Miklos Vajna
fe9fab9702
Open the bugdoc, start text edit on the only slide, in the only shape. Use the toolbar button to change from no numbering to bullet, some very small bullet with no spacing between the bullet and the text shows up. This happens since commit f60ee00edcc5b0fdee5227bb695448119cddb013 (tdf#89365 sd UI: fix transitioning from a numbered list to a bulleted list, 2025-11-04), previously the numbering to bullet transitioning was broken and you had to click on the "turn on bullets" button twice. A side effect of the old two-step transitioning was that no formatting from the old numbering was kept, so better defaults were used (but the numbering level was lost). Keep the old use-case fixed and fix the new use-case by looking at how this works on master pages: there TextObjectBar::ExecuteImpl()'s FN_NUM_BULLET_ON block calls SdStyleSheetPool::setDefaultOutlineNumberFormatBulletAndIndent() before setting the number format for a specific level of the numbering rule. Do the same for non-master pages in FuBulletAndPosition::SetCurrentBulletsNumbering(): if we transition to a bullet, then use the same defaults in the non-master-page case, too. Note that turning bullets on or off as direct formatting is not ideal: a better style is to assign bullets (or no bullets) to different outline levels in the master page, and then just change the list level of paragraphs in the outliner shape, which avoids this sort of problem in the first place. Change-Id: I4227988593baeaa91cc21525fb895c3acaf3afd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/195839 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
89 lines
2.0 KiB
Makefile
89 lines
2.0 KiB
Makefile
# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
|
|
#*************************************************************************
|
|
#
|
|
# This file is part of the LibreOffice project.
|
|
#
|
|
# This Source Code Form is subject to the terms of the Mozilla Public
|
|
# License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
# file, You can obtain one at http://mozilla.org/MPL/2.0/.
|
|
#
|
|
#*************************************************************************
|
|
|
|
$(eval $(call gb_CppunitTest_CppunitTest,sd_ui_func))
|
|
|
|
$(eval $(call gb_CppunitTest_use_externals,sd_ui_func,\
|
|
boost_headers \
|
|
libxml2 \
|
|
))
|
|
|
|
$(eval $(call gb_CppunitTest_use_common_precompiled_header,sd_ui_func))
|
|
|
|
$(eval $(call gb_CppunitTest_add_exception_objects,sd_ui_func, \
|
|
sd/qa/ui/func/func \
|
|
))
|
|
|
|
$(eval $(call gb_CppunitTest_use_libraries,sd_ui_func, \
|
|
basegfx \
|
|
canvastools \
|
|
comphelper \
|
|
cppcanvas \
|
|
cppu \
|
|
cppuhelper \
|
|
docmodel \
|
|
drawinglayer \
|
|
editeng \
|
|
for \
|
|
forui \
|
|
i18nlangtag \
|
|
i18nutil \
|
|
msfilter \
|
|
oox \
|
|
sal \
|
|
salhelper \
|
|
sax \
|
|
sb \
|
|
sd \
|
|
sfx \
|
|
sot \
|
|
subsequenttest \
|
|
svl \
|
|
svt \
|
|
svx \
|
|
svxcore \
|
|
test \
|
|
tl \
|
|
tk \
|
|
ucbhelper \
|
|
unotest \
|
|
utl \
|
|
vcl \
|
|
xo \
|
|
))
|
|
|
|
$(eval $(call gb_CppunitTest_set_include,sd_ui_func,\
|
|
-I$(SRCDIR)/sd/inc \
|
|
-I$(SRCDIR)/sd/source/ui/inc \
|
|
-I$(SRCDIR)/sd/source/ui/slidesorter/inc \
|
|
-I$(SRCDIR)/sd/qa/unit \
|
|
$$(INCLUDE) \
|
|
))
|
|
|
|
$(eval $(call gb_CppunitTest_use_sdk_api,sd_ui_func))
|
|
|
|
$(eval $(call gb_CppunitTest_use_ure,sd_ui_func))
|
|
$(eval $(call gb_CppunitTest_use_vcl,sd_ui_func))
|
|
|
|
$(eval $(call gb_CppunitTest_use_rdb,sd_ui_func,services))
|
|
|
|
$(eval $(call gb_CppunitTest_use_custom_headers,sd_ui_func,\
|
|
officecfg/registry \
|
|
))
|
|
|
|
$(eval $(call gb_CppunitTest_use_configuration,sd_ui_func))
|
|
|
|
$(eval $(call gb_CppunitTest_add_arguments,sd_ui_func, \
|
|
-env:arg-env=$(gb_Helper_LIBRARY_PATH_VAR)"$$$${$(gb_Helper_LIBRARY_PATH_VAR)+=$$$$$(gb_Helper_LIBRARY_PATH_VAR)}" \
|
|
))
|
|
|
|
# vim: set noet sw=4 ts=4:
|