I think I managed to disable this when I converted it to
use the shared plugin infrastructure.
So fix that, and then make it much smarter to avoid various
false positives.
Change-Id: I0a4657cff3b40a00434924bf764d024dbfd7d5b3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176646
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Don't delete range finder during arrow key navigation since cursor keys
don't count as modifications.
Change-Id: I53566a4a84ff4dc81fdf0d8b8f6468f956958925
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176689
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Jenkins
previously a comment `(for unprotected cells)` was added to the `Delete Rows` and `Delete Columns` menu entries as a solution of tdf#136003. The change has been reverted https://gerrit.libreoffice.org/c/core/+/176614
As tdf#136003 says "Can't delete rows, despite of allow to deletes", the source of confusion is these labels `[ ] Delete Rows` and `[ ] Delete Columns` in the protect sheet dialog. Changed these to `Delete rows with unprotected cells` to make it more clear what they are about.
Change-Id: I1009fca2a3cf56ffdc513fdb9b6192b3b965d050
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176616
Tested-by: Jenkins
Reviewed-by: Sahil Gautam <sahil@libreoffice.org>
While trying to load notebookbar.ui for sc I found that there are issues
with the .ui file itself:
* Duplicate IDs, created in 608e1452c5
* Typo in the attribute names, created with the manual edits in
04ed7cbe53
This patch fixes above problems.
Now, one can preview the notebookbar.ui for sc with:
$ export GLADE_CATALOG_SEARCH_PATH=$PWD/instdir/share/glade
$ glade-previewer -f sc/uiconfig/scalc/ui/notebookbar.ui
Change-Id: I83be23f4a2a24a04f4fa8b627c138bc42bdf6916
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176619
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
tdf#160404: Fix FILEOPEN XLSX Pivot table is not imported if sheet
protection has Pivot table editing enabled
- Import correctly the pivot tables, even if the tab protection is not
allowing to use them.
tdf#160535: Support sheet protection option: Use AutoFilter
- Add new option for tab protection to enable/disable to use autofilter
on the sheet. Import/export correctly to odf/ooxml.
Add new ext-odf attribute: XML_USE_AUTOFILTER
tdf#160536: Support sheet protection option: Use PivotTable&PivotChart
- Add new option for tab protection to enable/disable to use Pivot table
on the sheet. Import/export correctly to odf/ooxml.
Add new ext-odf attribute: XML_USE_PIVOT
Change-Id: I5d34e3608aed1a3d004ec553f6125b6428e9c05e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176274
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
This change extends layout for font-relative paragraph first-line
indentation into Edit Engine.
Change-Id: I5906f493b91fbcb87ded165709fb132b33ce1906
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176487
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
V1037 Two or more case-branches perform the same actions. Check lines: 921, 924
V1037 Two or more case-branches perform the same actions. Check lines: 1003, 1160
Change-Id: I42e78f2960b97a67625bfdb524b7f615833332ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175230
Reviewed-by: David Gilbert <freedesktop@treblig.org>
Tested-by: Jenkins
V656 Variables 'aOldSet', 'aNewSet' are initialized through the call to the same function. It's probably an error or un-optimized code. Consider inspecting the 'pOldAttrs->GetItemSet()' expression. Check lines: 1181, 1182.
Change-Id: I44b7be1bfb53872109b39323f909d5e1fcc1a809
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176405
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Orca commit [1]
commit 40a2d302eb52295433fd84e6c254a7dbe5108a24
Author: Joanmarie Diggs <jdiggs@igalia.com>
Date: Thu Nov 7 14:15:07 2024 +0100
Spellcheck: Check for accessible id in more places
Do the following case-insensitive checks:
* If the object's accessible id starts with "suggestions" treat it
as the suggestions list.
* If the object's accessible id starts with "replacement" treat it
as the object (likely entry) which contains the proposed replacement.
* If the label's/widget's accessible id starts with "error" treat
it as the container displaying the misspelled word.
Note that the first of the three is based on what LO 25.2 currently
exposes ("suggestionslb"). The other two are not in use yet, but adding
them facilitates implementation in, and getting feedback from, apps and
toolkits.
Also modify the existing check for the window. We were doing an exact
match on "SpellingDialog". Making that case insensitive and limiting to
starts with "spelling" works with the current LO implementation and
removes an implementation detail ("dialog").
introduced logic to identify more UI elements in the spelling
dialog by their accessible ID.
Adjust the GtkBuilder ID (which gets reported as accessible ID as well)
of the drawing area that holds the misspelt text to match the
expectations as mentioned in the commit message above.
[1] https://gitlab.gnome.org/GNOME/orca/-/commit/40a2d302eb52295433fd84e6c254a7dbe5108a24
Change-Id: I0658de40a47e46a6b2451dfb4ee30d1457b9f9e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176280
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
we can just take a "const &".
(found by running clang-tidy with the
performance-unnecessary-copy-initialization warning)
Change-Id: I20fd208c65303da78170b1ac06c638fdf3aa094b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176267
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Switch css::accessibility::AccessibleRelationType
from integer constants to an enum.
This provides more type safety and improves the debugging
experience, e.g. GDB now prints
com::sun::star::accessibility::AccessibleRelationType::AccessibleRelationType_CONTENT_FLOWS_TO
instead of just "2" when printing the value of a
corresponding variable, so it's no longer necessary
to manually look up what constant has that integer
value to know what relation this refers to.
offapi/com/sun/star/accessibility/AccessibleRelationType.idl
had this comment:
> <p>We are using constants instead of a more typesafe enum. The reason
> for this is that IDL enums may not be extended. Therefore, in order to
> include future extensions to the set of roles we have to use constants
> here.</p>
However, the a11y UNO API is internal (not published),
so that shouldn't be a concern.
Change-Id: I44a7d56cb085dc24effb24fcd34bb222b78ef4cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176153
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Before this, the non-ASCII Windows-1252 characters get exported to RTF
without Unicode markup, regardless of the font-defined charset; and on
import to Writer (and other compliant RTF readers), this 8-bit markup
was interpreted using the font data, producing different characters.
Change-Id: I2032930b6585287fde3eb3b5e6abed0298d29330
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176048
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
For VLOOKUP nSearchMode was 0. So static_cast<SearchMode>(nSearchMode)
casts to a value which does not exist in SearchMode enum. That gives an
"undefined behavior". Better to use the valid default forward search. (1)
Change-Id: I1757b43073e13638704b96c4a9d036cb9a21e470
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176043
Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
Tested-by: Jenkins
Noel Grandin