Commit Graph
216 Commits
Author SHA1 Message Date
Noel Grandin ed33d1d492 clean up some Java warnings
Change-Id: Id54e8fd6803c3a6c0d924338d1781679ed0b1bfd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115025
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-03 12:33:33 +02:00
Stephan Bergmann 6de0b1710a Get rid of apache-commons-logging
...using Java 1.4 java.util.logging.Logger instead also for the last remaining
uses in reportbuilder.

(The mention in swext/mediawiki/src/THIRDPARTYLICENSEREADME.html was presumably
a leftover from 4b6ceed4a4 "swext: Wiki Publisher
does not use those apache-commons libraries".)

Change-Id: Ia0bc598fe5844ced11cae497548ec7d09453a99d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113939
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-11 10:35:04 +02:00
Andrea Gelmini c26acd15a6 Fix typo in code
It passed "make check" on Linux

Change-Id: Ide85943961b6f5102294356ff623c6be8d7bc790
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101813
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-09-01 12:12:12 +02:00
Andrea Gelmini 0940229305 Fix '..'
To complete this:
https://gerrit.libreoffice.org/#/c/78312/

This is a massive replace for lines ending with
".." instead of "..."

It passed "make check" on Linux.

Change-Id: I07fa7b2e30ba9ea17a1f9a5e21c57216ba958efe
Reviewed-on: https://gerrit.libreoffice.org/78356
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
2019-09-01 11:15:11 +02:00
Andrea Gelmini 0650ffefe0 Fix typos
Change-Id: Ia8335622cb2e2b44f2b1ee36f7370b126d1ae642
Reviewed-on: https://gerrit.libreoffice.org/77610
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-16 22:19:01 +02:00
Andrea Gelmini 9aa90b50c8 Fix typos
Change-Id: I94d0e85c731801b8b0ec844ae2a8f268b2f1022e
Reviewed-on: https://gerrit.libreoffice.org/77256
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-12 10:03:23 +02:00
Andrea Gelmini caa6268094 Fix typos
Change-Id: I2b9361433df39f66ec8328262a3128cf7294b6e1
Reviewed-on: https://gerrit.libreoffice.org/76720
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-31 15:10:24 +02:00
Andrea Gelmini 5ccc8124a0 Fix typos
Change-Id: I59a0fd175fa5185c15d093d2d9bed9f95bb4cfd5
Reviewed-on: https://gerrit.libreoffice.org/76280
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-25 07:07:25 +02:00
Caolán McNamara 852d5b7b3b cid#1448272 RV: Bad use of return value
Change-Id: I716c4e617ae2493385391f96567e2fb4571cd440
Reviewed-on: https://gerrit.libreoffice.org/76253
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-24 21:32:49 +02:00
Caolán McNamara fbc038cc4f an uno -> a uno
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d
Reviewed-on: https://gerrit.libreoffice.org/72105
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-10 14:50:59 +02:00
Jens Carl 68dd147bd3 Fix typos
Change indefinite article "an" to "a" before
the word unique and some variants.

Change-Id: Ia14a6f3b9ec6b257ad8bed3b089faa9b6f07d44f
Reviewed-on: https://gerrit.libreoffice.org/70174
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-03 08:54:15 +02:00
Caolán McNamara 57bfb56972 Resolves: tdf#94446 if this is a SQLException in disguise, throw that instead
instead of the wrapper exception, so that dbaccess can apply its special
handling for SQLException::ErrorCode of dbtools::ParameterInteractionCancelled
in OLinkedDocumentsAccess::open if ParameterInteractionCancelled was the root
cause

Change-Id: I777893cf7355d8c4a9c48237284903176d81402d
Reviewed-on: https://gerrit.libreoffice.org/64123
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28 13:11:20 +01:00
Caolán McNamara 92c34111dd Related: tdf#94446 set parent for dialog
Change-Id: I174ec605f40e7cafbcb44e492941dfc36a4df3f2
Reviewed-on: https://gerrit.libreoffice.org/64120
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-27 21:09:13 +01:00
Andrea Gelmini 7653271950 Fix typo: s/an other/another/g
Change-Id: Iab3302d20fb9b0be4b97331709f83f818a46b2da
Reviewed-on: https://gerrit.libreoffice.org/59100
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-08-15 19:04:41 +02:00
Andrea Gelmini 7d071f35be Fix typos
Change-Id: Iebc31a53404da41f35eed7338662365d7efbd7a2
Reviewed-on: https://gerrit.libreoffice.org/57810
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-23 11:44:59 +02:00
Andrea Gelmini 5c0af52feb Fix typos
Change-Id: I8d5a8251a01af7cdf9832d98d8a6573b907f8532
Reviewed-on: https://gerrit.libreoffice.org/48683
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-27 08:49:38 +01:00
Fridrich Štrba 398eccd6e8 This really does not need to be utf-8 character
Change-Id: I75e3973ed3fe2489233cdce127a29ff19f604903
2017-09-12 13:37:58 +02:00
Eike Rathke 91287c7456 Enable the Formula Wizard to display 255 argument fields
Previously it was, for example for SUM,

1
2
3
...
28
29
30,31,32,33,...,253,254,255

ie. for more than 30 parameters the exceeding ones were crammed into the last
(30th) edit field. The expression still worked, but this was ugly, and
selecting the last field it was easy to overwrite all remaining arguments at
once.

Change-Id: I6b27a20e7f07d3a6b4752855f04d6239e6375418
2017-07-05 13:47:55 +02:00
Eike Rathke 3054a8c1c1 Prepare for change of VAR_ARGS value
Change-Id: I0b1955bb660b5e19587799de657c63634705b99c
2017-07-04 14:04:56 +02:00
Andrea Gelmini a940826162 Fix typos
To complete commit 0ef94e2b55
and f12096272e

Change-Id: Ie86bbfbd58dd728a013bef221e4d5c8fbcaf8e03
Reviewed-on: https://gerrit.libreoffice.org/37199
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-05 23:35:06 +02:00
Andrea Gelmini 2e9fe26014 Fix typos
Change-Id: I5fc62060e7d01c6b492a0e91323f753cc676bf71
Reviewed-on: https://gerrit.libreoffice.org/35639
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25 11:11:09 +00:00
Andrea Gelmini b068d9fb8d Fix typos
Change-Id: I35eeb71f4f698e39b7b0d98e3cb30657a64a611a
Reviewed-on: https://gerrit.libreoffice.org/34802
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-02 12:32:05 +00:00
Andrea Gelmini 534b2a4b58 Fix typos
Change-Id: Ice72f8d9971e15dd6ef365e64cd567b8581a92d3
Reviewed-on: https://gerrit.libreoffice.org/21797
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-02-05 06:48:38 +00:00
Caolán McNamara bf4ee8ee31 coverity#1326386 Dereference null return value
Change-Id: Ifd1cd2cfb6032e7a2d14d926d4de8be22160daee
2016-02-04 15:47:11 +00:00
Michael Stahl 969a760e2b reportbuilder: tdf#92720: add loext namespace
... to allow export of paragraphs in shapes.

(regression from 6acc6c011d)

Change-Id: I2c23e686a2cfcd997d3393b0f9fb4cdcab7252b7
2016-02-03 23:43:34 +01:00
Caolán McNamara 08680c58de coverity#1326438 Dereference null return value
and

coverity#1326439 Dereference null return value

Change-Id: Idf7e6f34accfb5d5b98a62f6ad221c325e24586a
2016-01-21 15:15:52 +00:00
Caolán McNamara 2043556e6c coverity#1326551 Dereference before null check
Change-Id: I11a65723909b7ed78a487ece7456c0e5a4d1aa8b
2016-01-21 15:15:52 +00:00
Caolán McNamara 5e89fc23a8 coverity#1327068 SIC: Inner class could be made static
Change-Id: I1fd9d122f2bde1db9101e937999d75ac19cc4dfb
2015-11-04 13:55:53 +00:00
Caolán McNamara 385e9afea2 coverity#1327210 UwF: Unwritten field
Change-Id: I6fb5b18b6a6e51727d7350039da97f06f65736ff
2015-11-04 13:55:53 +00:00
Noel Grandin a1624a8ecd cid#1327023 to cid#1327077 SIC: Inner class could be made static
Change-Id: I41f89c4feefe4e012d72c663ebb9bbcb4aa7f163
2015-10-15 09:23:16 +02:00
Caolán McNamara e75701ce9e coverity#1327210 UwF: Unwritten field
Change-Id: I1021bd43a93b9b7f1b4e0f73f75e7a7f7c52b857
2015-10-14 11:40:23 +01:00
Noel Grandin abd980d4ec cid#1326605, cid#1326604 BC: Bad casts of object references
Change-Id: I85fa5fd4671d749850af854a7d4ba934416d892b
2015-10-14 09:55:11 +02:00
Andrea Gelmini d721cc515b Fix typos
Change-Id: I8f4500fc7a901c5cc73634ba6da6b9541452e5ae
Reviewed-on: https://gerrit.libreoffice.org/18966
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2015-09-30 06:43:52 +00:00
Tor Lillqvist 395d922f58 chmod -x
Change-Id: I4a248b59e12587c3b2ce79676fdce29a348b6751
2015-07-29 14:17:05 +03:00
Andrea Gelmini e544f449ed Fix typos
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920
Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-08 12:21:19 +02:00
Andrea Gelmini 3dfdd18707 Fix typos
Change-Id: Iddcc22f62ea134ea797292daa02e47042d52d0d1
Reviewed-on: https://gerrit.libreoffice.org/16710
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2015-07-04 10:22:11 +00:00
Noel Grandin 0c18bedb73 java: 'final static' to 'static final'
this is the canonical order, and it makes the code easier to read

Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470
Reviewed-on: https://gerrit.libreoffice.org/16242
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-15 08:45:19 +00:00
Noel Grandin efd4bfa818 java:regulatize the order of 'final' and public/private
Make the order be 'public static' or 'private static'
Just makes the code nicer to read.

Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2
Reviewed-on: https://gerrit.libreoffice.org/16202
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11 09:34:00 +00:00
Julien Nabet 48f0a5ed35 Typos
Change-Id: I845a85e1aad4a0708f2b43f7d94606b4b5513ee4
2015-02-18 21:59:02 +01:00
Lionel Elie Mamane cc376d8785 set java throwable cause argument (erroneously removed by previous commit)
Change-Id: Ib4516eec5e47d95d53dbb5002f7258514c93f2c9
2015-01-22 13:18:55 +01:00
Lionel Elie Mamane f4a2cff16e Don't try to pass an arbitrary Java exception through UNO
also make other exceptions more verbose

Change-Id: Id6bf88b1ec228b20b19c89ccf6ee14d0c1ffb44d
2015-01-21 18:26:06 +01:00
Stephan Bergmann 01fb1701c8 Related fdo#85190: Don't dress arbitrary Java Throwables as UNO Any values
Regression introduced with 9341bf3dc3 "java: when
rethrowing, store the original exception," but these two appear to be the only
two cases related to com.sun.star.lang.WrappedTarget[Runtime]Exception in that
patch that would now create bad UNO Any values.  Happily reverted to the
original but oddly inconsistent setting of the WrappedTargetException's
TargetException member...

Change-Id: I9421da721d5a111d0d89ee0601238a2c01cfc12c
2015-01-21 17:31:41 +01:00
Noel Grandin 10039462df java: remove more dead code
found by looking for unused parameters (in Eclipse)

Change-Id: I03cf9bc8312e59747b2d0ac153ee2fc8d76be893
2015-01-05 09:59:03 +02:00
Noel Grandin 46540d08b1 java: these fields can become local variables
found by PMD

Change-Id: Id852cfec984a181b91aca1c00a41e342b720a4bf
2015-01-05 08:23:30 +02:00
Noel Grandin a49b2ba1a6 java: remove dead stylemapper code in reportbuilder
as far as I can tell, this has been dead since the original import
of this code

Change-Id: I4bd47e55eb0abc991ea1d58c16fba6fa6c7878d9
2015-01-05 08:23:30 +02:00
Noel Grandin 43cc8ad33e java: remove dead code
found by UCDetector

Change-Id: I6b0f49529379072da566e927b86815f173e7a90b
2015-01-05 08:23:29 +02:00
Noel Grandin 581d1e35f8 java: reduce visibility of some methods and fields
found by UCDetector

Change-Id: I0a0a00d1fae1fed2e6aef198b7a1482d7e7e29f0
2014-12-19 11:49:10 +02:00
Lionel Elie Mamane 9c346fbcf2 Revert "reportbuilder: re-add numerous bits of dead code needed by bug fix"
This reverts commit 458f22c338.

Since we reverted d6ce95ae22, this code
is again unused.
2014-12-17 11:01:17 +01:00
Lionel Elie Mamane 08715e24c1 Revert "fdo#87044: reportbuilder: Revert "fdo#67930 don't use variables ..."
This reverts commit d6ce95ae22.

Not necessary to fix fdo#87044, commit
1e10f6d229 is sufficient. Since the code
that is reintroduced leads to an overly complex and fragile document
structure, I'd rather not have it.
2014-12-17 11:01:17 +01:00
Lionel Elie Mamane 1e10f6d229 fdo#67930 work around fdo#68024
don't emit string-value attribute

Change-Id: I3668b88437451523f2b6bb3c2c82e1929f7ba3d8
Reviewed-on: https://gerrit.libreoffice.org/5371
Tested-by: Miklos Vajna <vmiklos@suse.cz>
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
(cherry picked from commit 76408b0f0d7e91cddb8b056069a2ee547109b156)
2014-12-12 18:04:40 +01:00