Caolán McNamara
326351e2b3
move UserData bodge into VCLXMenu
...
Change-Id: I20c303788e576a29574a696cb20c9e8a235233b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126804
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2022-01-08 15:32:56 +01:00
Noel Grandin
aaa42c6725
use comphelper::WeakComponentImplHelper in WindowContentFactoryManager
...
Change-Id: I0918d7d1ff84b4d5e41191b554d08474abce1f93
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127518
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-27 09:00:06 +01:00
Noel Grandin
5437632edf
use comphelper::WeakComponentImplHelper in UIElementFactoryManager
...
Change-Id: I048e5671df230c498a2425d60f64208089fd044b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127489
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-27 07:34:16 +01:00
Noel Grandin
cfd257873a
use comphelper::WeakComponentImplHelper in UIControllerFactory
...
Change-Id: I4b583d72a1ece5af86f43be2f2add3da2779502a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127488
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-27 07:34:00 +01:00
Noel Grandin
8566b3f8d2
use comphelper::WeakComponentImplHelper in StatusbarItem
...
Change-Id: I2c278547d16c5ad0530188f1e465cb784d345746
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127460
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-26 08:23:53 +01:00
Noel Grandin
a839a6afad
use comphelper::WeakComponentImplHelper in UICommandDescription
...
Change-Id: I042c9761c60d3b1c39950cfede80958edf2d84c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127461
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-26 08:23:14 +01:00
Noel Grandin
92c0775f2f
use comphelper::WeakComponentImplHelper in SubstitutePathVariables
...
Change-Id: I1b41ae57b65b42ef63d2d2c026cf78a00b5b937d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127462
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-26 08:22:42 +01:00
Noel Grandin
2d1ed93e46
use comphelper::WeakComponentImplHelper in TaskCreatorService
...
Change-Id: I2414ef01bc0990c68bb6fa02a897bfa19d7982a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127463
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-26 08:22:20 +01:00
Noel Grandin
058c64ad17
use comphelper::WeakComponentImplHelper in WindowStateConfiguration
...
Change-Id: Iada515ab1926aa1e0b7a3f39690d7c6eebf28aea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127465
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-26 08:21:59 +01:00
Noel Grandin
d4257daba1
use comphelper::WeakComponentImplHelper in MenuBarManager
...
Change-Id: I687f71c5af810618b3ab27b004bf765b53d7b8e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127466
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-25 19:34:05 +01:00
Noel Grandin
98dbe250d7
use comphelper::WeakComponentImplHelper in ContextChangeEventMultiplexer
...
Change-Id: I6f8c2be817695e44b25f209a5a56e021cd3e94d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127487
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-25 19:33:53 +01:00
Noel Grandin
a7a1d8647a
use comphelper::WeakComponentImplHelper in ModuleUIConfigurationManagerSupplier
...
Change-Id: I22164080dd87ab3c3a93b50d06cba8574e00c189
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127464
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-25 18:14:05 +01:00
Noel Grandin
a997f62242
cleanup AcceleratorCache
...
(1) reduce visibility of stuff nothing is using outside the class
(2) remove noise comments
Change-Id: Icea829ef92d6121b957ad47a992ef7ac04656af9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127324
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-22 17:17:48 +01:00
Andrea Gelmini
bddf28af4a
Fix typo
...
Change-Id: I0b441f47062a45395777b609d71ea0fa978bffc9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127279
Tested-by: Julien Nabet <serval2412@yahoo.fr >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2021-12-21 21:35:08 +01:00
Noel Grandin
489bce5986
loplugin:flatten in filter..framework
...
Change-Id: I15a577b3c6da03001bbbf2c2b43b29b41c4007c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127234
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-21 17:14:14 +01:00
Noel Grandin
a08f3b1055
osl::Mutex->std::mutex in GlobalImageList
...
Change-Id: I12b3074e77e67bfd0914f74d71ad2dace8d1ac21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127107
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-20 17:52:30 +01:00
Noel Grandin
dab35c152a
osl::Mutex->std::mutex in ModuleUIConfigurationManager
...
Change-Id: I012ba8ab049fd19832e9f1df643957e57c05b69c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127109
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-20 17:52:01 +01:00
Noel Grandin
516fa8464f
osl::Mutex->std::mutex in ImageManagerImpl
...
Change-Id: I2feae13f2d8fe90d1f3b072156f3e384fd71db82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127108
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-20 14:58:02 +01:00
Noel Grandin
d53b9c69e2
osl::Mutex->std::mutex in UndoManagerHelper_Impl
...
Change-Id: I4d279e2175f22422bec242ef8a15166cf67ef59f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127105
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-20 13:11:28 +01:00
Noel Grandin
599cb40c92
osl::Mutex->std::mutex in Oxt_Handler
...
Change-Id: Iaa7120a5373c09a1515dc76e5a5ba19b16cf1554
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127102
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-20 09:47:16 +01:00
Noel Grandin
95b7ecbbdb
osl::Mutex->std::mutex in WakeUpThread
...
Change-Id: I469fa855eb373829f23232875669f607dcb0c6a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127104
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-20 09:25:41 +01:00
Noel Grandin
82ceab070d
osl::Mutex->std::mutex in UIConfigurationManager
...
Change-Id: Idbad742b51c1ee8b8ba7104bc7520772ad947ed2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127110
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-20 08:36:05 +01:00
Noel Grandin
7e44d8d78a
osl::Mutex->std::mutex in HelpOnStartup
...
Change-Id: I3133ab5e0f0af40c7570856c216f3921576818af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127103
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-20 08:34:04 +01:00
Noel Grandin
7fe0a4cddf
osl::Mutex->std::mutex in StorageHolder
...
Change-Id: Ie0ababcea79b445ac73ffd4e69d260a7641af663
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127106
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-20 08:33:50 +01:00
Andrea Gelmini
9d65987055
Fix typos
...
Change-Id: I7f1636226c4fbe29d9d2ef850318a9d57f1b5450
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127009
Tested-by: Julien Nabet <serval2412@yahoo.fr >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2021-12-17 20:43:28 +01:00
Mike Kaganski
866b569b58
tdf#146219: don't try to detect if a recent file is a directory
...
This avoids accessing (possibly unavailable) remote URLs,
when we already know that MRU items are files.
Change-Id: I97e07f007d4129b93b4939311c67cf95de6ff836
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126943
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com >
2021-12-16 21:28:09 +01:00
Gabor Kelemen
b24064f2b7
Recheck include/[a-d]* with IWYU
...
See tdf#42949 for motivation
Change-Id: I42475b8e75951d5dcae2fe6b0ad0bca64441e7f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126837
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
2021-12-15 15:08:10 +01:00
Caolán McNamara
354849e0af
prefer css::awt::XPopupMenu api
...
Change-Id: I23310b8b5adbe7c84d0b9d30a227619c1e9a6960
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126803
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-12-14 12:11:24 +01:00
Caolán McNamara
984ad86e71
prefer css::awt::XPopupMenu api
...
Change-Id: I486e24b0b85357b43213443c1a9b71206b8f441a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126711
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-12-13 10:03:12 +01:00
Caolán McNamara
9f326792c1
only use css::awt::XPopupMenu methods
...
Change-Id: Icab3bc855e92c5f6389ee8129bcaaa1308619ca8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126710
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-12-13 10:02:59 +01:00
Caolán McNamara
74094ffd2a
prefer css::awt::XPopupMenu api
...
Change-Id: Ibb5984a588e21f9b761b6f56933394874c09dd88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126709
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-12-13 10:02:43 +01:00
Caolán McNamara
5ae0a6026c
prefer css::awt::XPopupMenu api
...
Change-Id: I81c892d946965f779d982194efd6b32d6493143e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126708
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-12-13 10:02:29 +01:00
Caolán McNamara
843f140289
prefer css::awt::XPopupMenu api
...
Change-Id: Ib52e4091d6a4e0d01aece3eb5f541cd29187a983
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126707
Tested-by: Caolán McNamara <caolanm@redhat.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-12-13 10:02:14 +01:00
Caolán McNamara
cf3bbe3a75
only use css::awt::XPopupMenu methods
...
Change-Id: Ib8e14af038fccd43e79f12b6a5f9371be6a29c43
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126706
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-12-13 10:01:45 +01:00
Caolán McNamara
604c3140d1
prefer css::awt::XPopupMenu api
...
Change-Id: Ibf34e33715a86a09ec49495b1049a60e1403a6af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126705
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-12-13 10:01:30 +01:00
Caolán McNamara
5cbddfc617
use XMenu::enableAutoMnemonics instead of Menu::SetMenuFlags
...
Change-Id: I4d3d8234bb2e643067bed68595a4b22198e38fb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126704
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-12-13 10:01:13 +01:00
Caolán McNamara
4304856bfb
these aSolarMutexGuard calls are redundant now
...
Change-Id: Ic167b8d40c1c93f5e6f4408d260c4e70b4017fd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126693
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-12-12 15:58:11 +01:00
Caolán McNamara
afa35742a4
prefer more css::awt::XPopupMenu api
...
Change-Id: Ib008281d63071ea79935af83cbe434be66155455
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126692
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-12-12 13:35:00 +01:00
Caolán McNamara
569de88e9c
prefer css::awt::XPopupMenu api
...
and using GetXGraphic will return a vcl unographic::XGraphic which
also supports XBitmap as well as XGraphic so we can check if
the XBitmap we're passing around supports XGraphic and use that
if it does and drop the imagewrapper in favor of doing that
Change-Id: I3bd7963b53c3f715fca4b5cfb2ddad650ca92e1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126691
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-12-12 13:33:27 +01:00
Andrea Gelmini
0040076af3
Fix typos
...
Change-Id: I8e6db5dfb5285e45f862fadf09ecb4142be6e075
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126659
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Jenkins
2021-12-11 16:05:03 +01:00
Stephan Bergmann
db3a61cd95
Generally determine Rdb content from gb_*_set_componentfile calls
...
...instead of by listing the content somewhat redundantly in the Rdb_*.mk
files, to avoid duplication of logic for components that are only built
conditionally (and thus should only be included conditionally in the
corresponding Rdb). To achieve that, add an "rdb" parameter to
gb_ComponentTarget_ComponentTarget (and to the gb_*_set_componentfile macros
that internally call gb_ComponentTarget_ComponentTarget), which is used to make
the appropriate gb_Rdb_add_component call internally from within
gb_ComponentTarget_ComponentTarget. (As a special case,
gb_CppunitTest_set_componentfile shall not call gb_Rdb_add_component, as that
has already been done by the corresponding gb_Library_set_componentfile call, so
allow the gb_ComponentTarget_ComponentTarget "rdb" parameter to be empty to
support that special case.)
Most Rdb_*.mk files are thus mostly empty now. One exception is
i18npool/Rdb_saxparser.mk, which duplicates some of the Rdb_services content as
needed during the build in CustomTarget_i18npool/localedata.
1c9a40299d1c9a40299dhttps://gerrit.libreoffice.org/c/core/+/126577
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2021-12-10 08:14:24 +01:00
Noel Grandin
3efde47ec9
loplugin:unusedfields
...
Change-Id: Id39c3f484a364fb5163444febe99aee79daf1a76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126418
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-07 07:06:12 +01:00
Noel Grandin
95266ea934
use OMultiTypeInterfaceContainerHelperVar3 in framework
...
Change-Id: Ia2f59322511ed85492708262f90de26b33275105
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126197
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2021-12-03 08:40:02 +01:00
Caolán McNamara
64ed0dcf6d
use more XPopupMenu methods over PopupMenu ones
...
Change-Id: Ib60ae5db7097cd92cc7971fd8227b8753391da26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126073
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-11-30 11:16:47 +01:00
Caolán McNamara
a12b14c180
drop unneeded include
...
Change-Id: Iea28a59086d23c4edd91d0c531bf3a1337b5da78
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126071
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-11-30 09:48:06 +01:00
Caolán McNamara
1fbbfc2419
remove out of date comments
...
Change-Id: If1fb6c86b04d559eabb5b35fa35f09408a90522f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126069
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-11-30 09:47:50 +01:00
Caolán McNamara
3bd7c79abe
drop unneeded include
...
Change-Id: I3eba0020edefcc92bc612eea1f388f17b9a45022
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126072
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-11-30 09:46:55 +01:00
Caolán McNamara
88b69059c3
use more XPopupMenu methods over PopupMenu ones
...
Change-Id: I54acdcb82b90d363e48543de99c75adea8fceb2a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126047
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-11-29 21:21:12 +01:00
Caolán McNamara
67df066460
nothing consumes this value set with SetUserValue
...
the GetUserValue was removed in...
commit b90296a32bhttps://gerrit.libreoffice.org/c/core/+/126046
Tested-by: Caolán McNamara <caolanm@redhat.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-11-29 21:20:58 +01:00
Caolán McNamara
99eb1ede7d
use css::awt::XPopupMenu::setItemImage instead of PopupMenu::SetItemImage
...
Change-Id: I414a98a2d8a9e9a2995811e95b2db1f66ac87d5e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126043
Tested-by: Caolán McNamara <caolanm@redhat.com >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
2021-11-29 21:20:32 +01:00
Caolán McNamara