ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
380,264 Commits 3 Branches 3 Tags
eaf2c278888ebca0ac99055ee34df6f011da3596
Commit Graph
501 Commits
Author SHA1 Message Date
Takeshi Abe 889d825879 xmlsecurity: tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants.

Change-Id: Ie8f972330f6bc88e205290dcbe666895b7bad43f
Reviewed-on: https://gerrit.libreoffice.org/18557
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-09-14 06:24:12 +00:00
Stephan Bergmann 1b70ed18bd loplugin:stringconstant: OUStringBuffer: appendAscii -> append 
Change-Id: I5c7318795d987b1b28a52de59cf4ebd2b74d9125
 2015-08-31 08:00:04 +02:00
Noel Grandin a4fd6c4f9e inline some use-once typedefs 
Change-Id: I02cbbba56a2ad83e0ac3d806265a7e0d6a29594d
Reviewed-on: https://gerrit.libreoffice.org/17495
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-03 12:16:33 +00:00
Noel Grandin e963a88912 formatting of public/private/protected section qualifiers 
make it consistent across the codebase, no space between keyword
and the colon

Change-Id: Idca61ddfc74ad2460fb05fe417499324b05e5de5
Reviewed-on: https://gerrit.libreoffice.org/17148
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-07-17 09:49:35 +00:00
Noel Grandin 64fe684368 loplugin:unusedmethods xmlsecurity 
Change-Id: I7b0a6521168dab13e87fc39920fdaef70943961e
 2015-07-17 10:56:06 +02:00
Andrea Gelmini e544f449ed Fix typos 
Change-Id: I020c7ce4d9aa93cb0292378a410cdb9f7788e920
Signed-off-by: Michael Stahl <mstahl@redhat.com>
 2015-07-08 12:21:19 +02:00
Andrea Gelmini 1c5f07e60c Fix typos 
Change-Id: I98b4dfb0f72f315065693335e2f882bb2eed3afe
Reviewed-on: https://gerrit.libreoffice.org/16713
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
 2015-07-03 09:14:23 +00:00
Andrea Gelmini 69c88a32aa Fix typos 
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff
Reviewed-on: https://gerrit.libreoffice.org/16522
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2015-06-28 12:28:31 +00:00
Andrea Gelmini aade27554d Fix typos 
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b
Reviewed-on: https://gerrit.libreoffice.org/16408
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-22 12:36:21 +00:00
Takeshi Abe 0980095619 Replace boost::scoped_array<T> with std::unique_ptr<T[]> 
This may reduce some degree of dependency on boost.
Done by running a script like:

git grep -l '#include  *.boost/scoped_array.hpp.' \
 | xargs sed -i -e 's@#include  *.boost/scoped_array.hpp.@#include <memory>@'
git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \
 | xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/'

... and then killing duplicate or unnecessary includes,
while changing manually
m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx,
extensions/source/ole/unoconversionutilities.hxx, and
extensions/source/ole/oleobjw.cxx.

Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
Reviewed-on: https://gerrit.libreoffice.org/16289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2015-06-17 15:50:45 +00:00
Andrea Gelmini 814af9f1e5 Fix typos 
Change-Id: Icfb885b72d51edc886851cf503c56fa12b8f559f
Reviewed-on: https://gerrit.libreoffice.org/16309
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-16 11:21:07 +00:00
Andrea Gelmini ca9de688c2 Fix typos 
Change-Id: I549635318f46718042e50c8f89ce3c620cade990
Reviewed-on: https://gerrit.libreoffice.org/16281
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-16 11:10:51 +00:00
Stephan Bergmann 642f4e574c loplugin:cstylecast: deal with remaining pointer casts 
Change-Id: Idcaafa47f1891858d2ac4cdc536065cbc127b7c4
 2015-06-08 16:30:07 +02:00
Julien Nabet 16f1477a2d Remove include stdio (part7) 
Change-Id: I7058ac53f4bbf96eff9a36a03279ab0753cc42ba
Reviewed-on: https://gerrit.libreoffice.org/16135
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2015-06-07 15:33:38 +00:00
Stephan Bergmann 3f846cb7a4 loplugin:cstylecast: deal with those that are (technically) const_cast 
Change-Id: I7128d99926bddf5ffd0a87099c7fa3ce3a1e08e0
 2015-06-02 11:29:00 +02:00
Caolán McNamara dcee23b7f8 cppcheck: noExplicitConstructor 
Change-Id: Idcf5460ec59cfb6f13055652c094d460c15da5ed
 2015-05-20 20:40:54 +01:00
Stephan Bergmann 7011bf7817 loplugin:cstylecast: nop between pointer types of exactly same spelling 
Change-Id: Idac7d377f3798a56d3fb32d8e3ec393bd2a53e9d
 2015-05-11 12:51:47 +02:00
Caolán McNamara 869e477484 cppcheck: noExplicitConstructor 
Change-Id: Iea5bb0504518b380c3fe7c238d376dc26be8a7ef
 2015-05-04 20:13:52 +01:00
Stephan Bergmann 6ef8f9de02 loplugin:simplifybool 
Change-Id: I54f9e6d879c973c8d47226bd87a4b38404ed8f45
 2015-04-24 12:36:32 +02:00
Stephan Bergmann 2240118177 Improved loplugin:literaltoboolconversion looking into cond. exprs. 
...automatic rewriter fixes

Change-Id: I6b04ca80f08f8a71ff94e309fd52f44d736751ee
 2015-04-23 18:39:07 +02:00
Stephan Bergmann 1a31dd5ec4 Clean up odd sal::static_int_cast<sal_Bool> uses 
Change-Id: Idbd1cdb06315b96dc9f45e34108a1af45229ed2f
Reviewed-on: https://gerrit.libreoffice.org/15484
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2015-04-22 20:50:54 +00:00
Noel Grandin 71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Noel Grandin 4cca0169aa loplugin:staticmethods 
Change-Id: I2177e424d54dc2b5e26b7bbfe073b524e9cc5bab
Reviewed-on: https://gerrit.libreoffice.org/15187
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-04-09 06:44:49 +00:00
Stephan Bergmann 698a6d4ab6 Reduce to static_cast any reinterpret_cast from void pointers 
Change-Id: I374bfba6ee7470044a677b7351cd59aac2e1b042
 2015-03-31 13:18:04 +02:00
Stephan Bergmann 51a705c439 Clean up C-style casts from pointers to void 
Change-Id: I112f4df678d9f3e70df7782443c860f930909e33
 2015-03-28 19:09:29 +01:00
Stephan Bergmann c5f1e8c3bb const_cast: convert some C-style casts and remove some redundant ones 
Change-Id: I42fdc042ed7317b5b6c337e7b38966e616f8e24b
 2015-03-26 15:33:41 +01:00
Noel Grandin 6618a6d7f2 loplugin:constantfunction: xmlsecurity 
Change-Id: Iabe2b4677b75cbd4b10a55fc4b2f13ba29645cd4
 2015-03-24 10:31:17 +02:00
Caolán McNamara 68495ab364 cppcheck: add some explicits 
Change-Id: I4e1fd50f1268f0820fae2bb41c69155ef5c28464
 2015-03-23 09:38:04 +00:00
Caolán McNamara 556373c41f V668 no sense in testing the result of new against null 
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
 2015-03-11 09:58:36 +00:00
Caolán McNamara 5a308b1239 V801: Decreased performance 
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
 2015-03-09 12:41:09 +00:00
Caolán McNamara 44e1eaea6a cppcheck: variableScope 
Change-Id: I2dbab9e972c7470e9bd30692e54c51ee11ffd45b
 2015-02-26 14:45:37 +00:00
Caolán McNamara 6e44e13a98 cppcheck: variableScope 
Change-Id: Ibdea832c607494d5d6b36b3655a0af7de540d0c7
 2015-02-10 21:46:37 +00:00
Caolán McNamara 309574394b callcatcher: large newly detected unused methods post de-virtualization 
i.e lots now able to be detected after...

commit b44cbb26ef
Author: Noel Grandin <noel@peralex.com>
Date:   Tue Jan 20 12:38:10 2015 +0200

    new loplugin: change virtual methods to non-virtual

    Where we can prove that the virtual method is never overriden.

    In the case of pure-virtual methods, we remove the method entirely.
    Sometimes this leads to entire methods and fields being
    eliminated.

Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
 2015-01-29 23:42:26 +00:00
Noel Grandin b44cbb26ef new loplugin: change virtual methods to non-virtual 
Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae
 2015-01-26 08:42:28 +02:00
Stephan Bergmann 2880dfe301 Some more loplugin:cstylecast: xmlsecurity 
Change-Id: Iceaeefc26fec2643d3fbb916ab7719a918beb496
 2015-01-20 09:06:54 +01:00
Michael Weghorn bfe79b50bc fdo#39440 reduce scope of local variables 
This addresses some cppcheck warnings.

Change-Id: If7ad3584b3124ed0b337836071af1a5bd0451d85
Reviewed-on: https://gerrit.libreoffice.org/13972
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-01-19 08:39:32 +00:00
Noel Grandin 45ec1d9b56 brute-force find-and-remove of unused #define constants. 
Change-Id: I7223530ae37297a76654cd00cc1fedb56dbe3adb
 2015-01-08 10:39:36 +02:00
Stephan Bergmann 8d487ceba1 xmlsecurity: Use appropriate OUString functions on string constants 
Change-Id: I18370f6203455cf7568e48e49b7093d114656619
 2014-12-18 14:12:39 +01:00
Stephan Bergmann 147ff66242 Typo "mehtod" -> "method" 
Change-Id: I49f3f59c76bd4dd078f7014b6a0450241214db7f
 2014-12-08 11:11:43 +01:00
Tor Lillqvist 71c58fce69 Bin noise comments 
Change-Id: I084040ff90ee30aa83ac5d3ad11365768272ec65
 2014-12-04 16:59:19 +02:00
Michael Stahl 6a0fe37dec sal: clean up public headers with include-what-you-use 
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
 2014-11-17 11:06:53 +01:00
Andrea Gelmini da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Andrea Gelmini 0c0e3e7539 Fixed typos. No automatic tools (sed, and so on). 
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f
Reviewed-on: https://gerrit.libreoffice.org/12150
Reviewed-by: Bryan Quigley <gquigs@gmail.com>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2014-10-30 17:16:02 +00:00
Caolán McNamara 0048a11521 coverity#982248 Unchecked return value 
Change-Id: Ice8c1b3eab28fc8ef27d802f64b7dd90a0614e42
 2014-10-20 10:57:17 +01:00
Noel Grandin fb7b1f45f9 loplugin: cstylecast 
Change-Id: I96a0d5d7ec3363076b0165f3c540c51ef01b58f3
 2014-10-15 13:57:08 +02:00
Noel Grandin addf55184a loplugin: cstylecast 
Change-Id: I37d7c3e59f1debbee8d92e76f4d08fff773000b3
 2014-10-06 07:52:55 +02:00
Noel Grandin fc04f76336 fdo#82577: Handle Time 
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-01 07:34:23 +00:00
Stephan Bergmann 7bac68d79e Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy 
Change-Id: Id03c16337cb637c7f63fb789697c8bceec905bda
 2014-08-28 16:17:35 +02:00
Tor Lillqvist 595e446aff Get rid of xmlsec_trace() and use SAL_INFO("xmlsecurity.xmlsec") 
Change-Id: I3e1db89de2019285ce313f9bae1375a5b82f6383
 2014-08-12 17:02:15 +03:00
Thomas Arnhold 5717de74f5 create OUString from literal 
Change-Id: I8198fbad20daa7262e42a452c8d81fcfa3331680
 2014-08-04 15:59:06 +02:00