The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.
(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to
OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager();
in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)
Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
because xdg-email is apparently the only route
that knows how to support adding an attachment
to thunderbird
Change-Id: Ife1b56ccfe2434eb31ad67bef00f55197e96151e
This reverts commit 8da1d7869a.
plus:
Revert "Revert "KDE: don't throw on TemplatePathVariable""
This reverts commit 72812a380c.
I had misread the code and thought that handling of those two properties in
shell/source/backends/desktopbe/desktopbackend.cxx would hide handling them in the
specific KDE backends, but that is not actually the case.
Change-Id: I32fae5ba34cc934ceca2f574d50fc327b506b001
...now that b5c05876f7 "Related: rhbz#1065807
recover using xdg templates and documents settings" handles WorkPathVariable in
the generic shell/source/backends/desktopbe/desktopbackend.cxx code.
Change-Id: I3920cdb3f54688462813d212569c9b33a1371333
This reverts commit e44a7eefb7, which is no longer
necessary now that b5c05876f7 "Related:
rhbz#1065807 recover using xdg templates and documents settings" handles
TemplatePathVariable in the generic
shell/source/backends/desktopbe/desktopbackend.cxx code.
...as had been done in the GConf-based backend prior to
3cf557c12d "drop gconf integration as per ESC
decision".
Change-Id: I56f256aaec542e0a62fc30a37d5c982e93e77812
since
commit 3cf557c12d
Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date: Fri Oct 16 12:15:55 2015 +0100
drop gconf integration as per ESC decision
Conflicts:
shell/source/backends/gconfbe/gconfbackend.cxx
Change-Id: If8e9b273e410250b45d3f645f6a31c1e80f02c6c
LibreOffice wants to open URLs by calling /usr/bin/xdg-open, which the flatpak
org.gnome.Platform runtime does not provide. However,
<https://github.com/flatpak/xdg-desktop-portal> will provide a Desktop portal
through which an application can make an OpenURI request. So the idea is to
include a fake xdg-open application in the LO flatpak, that will use gdbus to
call that portal. However, I see no way to make the LO flatpak provide that as
/usr/bin/xdg-open, so instead provide it as /app/bin/xdg-open and hack LO to
use that path when run under flatpak (where the LIBO_FLATPAK environment
variable is already used for the OfficeIPCThread).
Change-Id: I63bc0bfb937ef767958ba4d34b0c3653e38ec868
Searched source for using declarations.
Checked if those symbols reappear in the source file,
even in comments or dead code but not in #include statements.
If they don't reappear, remove the declaration.
Remove includes whose symbol got removed.
Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0
Reviewed-on: https://gerrit.libreoffice.org/24148
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Remove kde4/tde/open-url.sh and have LO just use xdg-open.
It's available on TDE builds as well as any recent KDE. We recently
did this just for gnome-open-url and have had no reported issues.
Change-Id: I4e1ee6caef368051af92023fa382b6fed9d9397e
Reviewed-on: https://gerrit.libreoffice.org/21173
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
stage 2 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro
In this stage we focus on replacing usage of the WIN macro
Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84
Reviewed-on: https://gerrit.libreoffice.org/22393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
stage 1 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro
Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f
Reviewed-on: https://gerrit.libreoffice.org/22390
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
A ridiculously fast way of doing this is:
for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
--exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
perl -0777 -i -pe 's/^
{3,}/
/gm' $i
done
Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
...when throwing an exception from implicitly noexcept ~GErrorWrapper. So make
~GErrorWrapper noexcept(false) and see that no code executed while a
GErrorWrapper instance is active on the stack would throw an exception. But the
design of GErrorWrapper, to throw an exception from a dtor, is very brittle and
should be fixed.
Change-Id: Ib04ff2b0497c160dc7ee44c3354fa9619285ec88
Use Qt submodule notation for Qt includes and also "correct"
some KDE headers AKA use <> notation for external headers.
Change-Id: I9457f75baae56514989800b016a11348a72a242b
time_t is long on some platforms but not on all.
This plagues a warning on FreeBSD.
Taken from: Jung-uk Kim
(cherry picked from commit 1c030e286ac7a82eaa5b87c0f950894ab6be5027)
"thumbviewer.cxx(168,9) : error: delete called on 'StreamOnZipBuffer' that has
virtual functions but non-virtual destructor"
Change-Id: I34510d54b9a99d8f1f9e8da0236625023c3fd94c
Jochen Nitschke