Noel Grandin
af65e892dc
clang-tidy modernize-pass-by-value in xmlreader
...
Change-Id: I448d3119129a864e79dbef336e46545f9aca8b25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137584
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2022-07-29 13:10:15 +02:00
Shobhit
c098d1a957
tdf#124176: Use pragma once instead of include guards
...
Change-Id: Iedaa6ac7b326fead2545943e3bbe605882c1337b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110204
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org >
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org >
2021-01-31 18:11:26 +01:00
Julien Nabet
25a3658f51
Revert "Optimize getNamespaceId (xmlreader)"
...
This reverts commit def0096124https://gerrit.libreoffice.org/80565
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2019-10-10 07:55:00 +02:00
Noel Grandin
266303e867
cleanups in xmlreader
...
(*) fix order of headers
(*) include the right headers in span.hxx
(*) use std::memcmp instead of memcmp
(*) clear entries from cache when the namespaces array is resized
Change-Id: I04319bbaa84369e5470799578fadcda66a591c9f
Reviewed-on: https://gerrit.libreoffice.org/80347
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-10-08 08:30:46 +02:00
Noel Grandin
4b28b77edd
we can use Span for the cache key here
...
Change-Id: I77894e3c5e3d68cb2a12abcc0b09f2c042664ba0
Reviewed-on: https://gerrit.libreoffice.org/80315
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-10-06 18:51:37 +02:00
Julien Nabet
def0096124
Optimize getNamespaceId (xmlreader)
...
Adding a map to cache values allows me
20s -> 13s to start LO
Change-Id: If343225def253e29696b96f223cdcb54d0d8525d
Reviewed-on: https://gerrit.libreoffice.org/80290
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2019-10-06 00:28:13 +02:00
Gabor Kelemen
690cbe7aa2
tdf#42949 Fix IWYU warnings in include/xmlreader/*
...
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: Ie96f3c739d4b3654d60888e01f3a8a70c18d25cf
Reviewed-on: https://gerrit.libreoffice.org/58824
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
2018-08-13 17:58:09 +02:00
Noel Grandin
0b7fe7b2ce
loplugin:unusedfields,can-be-const in xmlreader
...
Change-Id: I762a749b858063a1c063ee918bb6d33e06328876
Reviewed-on: https://gerrit.libreoffice.org/57852
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-07-24 08:32:46 +02:00
Noel Grandin
2559a2a056
loplugin:constmethod in cppu,cppuhelper,idlc
...
Change-Id: I9138b7e5d53c30488f99e9f9b9fe3f98c8d6858b
Reviewed-on: https://gerrit.libreoffice.org/43583
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-10-23 08:15:50 +02:00
Noel Grandin
2fffaf6f05
loplugin:unusedmethods
...
Change-Id: Ia874baf21257e5fe41e104211068a2bcc50446eb
Reviewed-on: https://gerrit.libreoffice.org/40391
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk >
2017-07-25 12:03:50 +02:00
Stephan Bergmann
6cb9e6dad7
Remove redundant 'inline' keyword
...
...from function definitions occurring within class definitions. Done with
a rewriting Clang plugin (to be pushed later).
Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8
Reviewed-on: https://gerrit.libreoffice.org/34874
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2017-03-03 20:55:50 +00:00
Stephan Bergmann
ac9c9de9af
loplugin:staticmethods: xmlreader
...
Change-Id: Ibb345883350019a6623dbeb9ab437482f2b2923a
2016-10-07 12:07:43 +02:00
Noel Grandin
4300656d9f
convert XmlReader::State to scoped enum
...
Change-Id: I8020843ad238ac3487f7f2781693ca619db5e1b3
2016-08-31 10:00:07 +02:00
Noel Grandin
4722192098
Convert XmlReader::Result to scoped enum
...
Change-Id: I6a0d1dcf5ae51d2ac08aacdfec50865f93e51c21
Reviewed-on: https://gerrit.libreoffice.org/25365
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-25 11:59:08 +00:00
Noel Grandin
6bda2bf6fe
Convert XmlReader::Text to scoped enum
...
Change-Id: I4741b13fcf887a95b85886cb41f8236e128e81a2
Reviewed-on: https://gerrit.libreoffice.org/25364
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-05-24 06:54:19 +00:00
Stephan Bergmann
bff4c13475
Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY code
...
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-10-12 17:52:26 +02:00
Caolán McNamara
a368823489
another dependency still required
...
Change-Id: I0f0ce96ee8209f711739952422d642a012252d1f
2015-02-16 13:26:09 +00:00
Noel Grandin
3e82897353
improve the inlinesimplememberfunctions clang plugin
...
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
Noel Grandin
0e507ae031
various: remove SAL_THROW macro
...
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
2014-06-05 08:17:52 +02:00
Caolán McNamara
5d4f20a09f
coverity#708726 Uninitialized scalar field
...
Change-Id: Idaa6cfffe33d4ab9451e322fcdbdbf5ad0e7629b
2014-03-06 16:35:48 +00:00
Matúš Kukan
c2f5e09900
Zip .ui translations per UIConfig target.
...
Fix installer / scp2 to not ignore directory prefix in 'Name'.
Change-Id: Ib319363c8be73a72029f1ba3833e518e15c55e29
Reviewed-on: https://gerrit.libreoffice.org/6915
Reviewed-by: David Tardon <dtardon@redhat.com >
Tested-by: David Tardon <dtardon@redhat.com >
2013-12-06 05:43:21 -06:00
Norbert Thiebaud
4ad3ed74ea
fdo#65108 inter-module includes <> include/xmlreader
...
Change-Id: I5c04e9169518212ec6a9cbb6d07216a87a2d9cdb
2013-11-09 18:48:44 -06:00
Bjoern Michaelsen
b9337e22ce
execute move of global headers
...
see https://gerrit.libreoffice.org/#/c/3367/
and Change-Id: I00c96fa77d04b33a6f8c8cd3490dfcd9bdc9e84a for details
Change-Id: I199a75bc4042af20817265d5ef85b1134a96ff5a
2013-04-23 22:20:31 +02:00
Noel Grandin