ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
461,186 Commits 3 Branches 3 Tags
e64dc07ca8300a997d6d3eebfc3e198ae55d290d
Commit Graph
7621 Commits
Author SHA1 Message Date
Henry Castro a06f8147fe lok: remove frame action listener when disposing 
In order to prevent that the frame action listener
holds the object reference count when removed,
ensure they are removed when disposing the object.

Change-Id: If83574e31230d9c683adaf36af36485650fd2c50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113389
Tested-by: Jenkins
Reviewed-by: Henry Castro <hcastro@collabora.com>
 2021-04-01 14:07:10 +02:00
Noel c7483d48df drop operator bool and operator! from Bitmap and BitmapEx 
IRC chat:
<quikee[m]> noelgrandin: doesn't adding operator bool to Bitmap
  has the same problem as Graphic and the reason why you dropped that
  commit 7334034ae9
  "drop Graphic::operator bool"
<noelgrandin> quikee[m], hmmm, good point
<noelgrandin> maybe I should just drop both operator bool and
  operator! in favor of IsEmpty
<quikee[m]> noelgrandin: I don't remember what the problem is I just
  remembered we dropped it Graphic :) sure, dropping everything for
  IsEmpty is probably the best

Change-Id: Ieae289cda64f0b8d8fdecd5ea9e6f2bb874ff4cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113163
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-28 10:26:06 +02:00
Noel b624b13b3d loplugin:flatten 
Change-Id: Ib7a895fba66f8dc9b6501e61631c02694053b7fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113157
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-26 18:02:19 +01:00
Mike Kaganski a0656ec6fc const OUString -> const OUStringLiteral 
Mostly automated rewrite

Change-Id: Ie020a083f898bc126b8fb039d4ecb2e687172da1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112965
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-03-25 10:06:26 +01:00
Hossein c16158772d Using .md extension/Markdown syntax for modules README 
Renaming all README files for all top level modules to README.md,
applying no content change at this stage to be able to track history
of the files. These files should be edited to use correct Markdown
syntax later.

Change-Id: I542fa3f3d32072156f16eaad2211a397cc212665
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112977
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
 2021-03-24 11:46:14 +01:00
Vincent LE GARREC 90c978f839 tdf#124176 Use pragma once in f* 
filter, forms, fpicker, framework

Change-Id: I55a25ad2dc3749e63465e638e8eeea3c322eabbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112047
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
 2021-03-23 13:07:09 +01:00
Noel Grandin a9493229bb use single-use attribute for ContextChangeEventMultiplexer 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: I13b36f1fe570f789036ef54ecfb7d0a85ce1450c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112842
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-23 09:33:43 +01:00
Noel Grandin dfc3f0b640 use single-use attribute for GlobalAcceleratorConfiguration 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: I13161282ebefb47923a34a71fd66d64106d00c78
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112853
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-22 16:05:21 +01:00
Noel Grandin cd596ebc8e use single-use attribute for PathSettings 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: I90f7e0af8ce67cdcef2df7b28c7e55b1c92aad3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112834
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-22 16:05:07 +01:00
Noel Grandin 1d7cc199fa use single-use attribute for JobExecutor 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: I33e8fa15eda12b326beaede61065a84d236b8154
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112852
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-22 11:58:00 +01:00
Noel Grandin bc22a790b9 use single-use attribute for AutoRecovery 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: I53c722e4126f5386b3cd43eee09ccfe4656ebd9e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112851
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-22 11:57:46 +01:00
Noel Grandin a95abea894 use single-use attribute for TaskCreatorService 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: I0ebf3a71c93015850eb34c8cbe9395b6d36ce3c6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112832
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-21 18:00:49 +01:00
Noel Grandin f86e20fa4a use single-use attribute for ModuleManager 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: I80ee080d4b62065dadc9c406485a81433a38ffaa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112841
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-21 17:30:16 +01:00
Noel Grandin b4ec5a94bd use single-use attribute for SubstitutePathVariables 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: I1b488ce343063b9f07d76d9dec2e12bd153c942a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112833
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-21 15:44:34 +01:00
Caolán McNamara e3e7bc65ed update pches 
Change-Id: I60e61133c305673bb305e41957f5414820c7c358
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112790
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-03-21 15:31:46 +01:00
Noel 918dc4c205 use single-use attribute for StatusBarControllerFactory 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: Ifec5f54633508aa66492599caf80ed2bf3d7cbe5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112683
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-20 16:50:15 +01:00
Noel b7d10f1381 use single-use attribute for UICommandDescription 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: Ia26871e1a2cf2cc6150d681f3a40b42269fb65c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112686
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-20 09:30:57 +01:00
Noel 8a6887717f use single-use attribute for UICategoryDescription 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: Ie6c8f76b88f1e059b81b28a40343a2207531b0d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112688
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-20 09:30:20 +01:00
Noel ea004488f6 use single-use attribute for ToolbarControllerFactory 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: Ie856c5954965fc640dc34d500664be924ddab69c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112684
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-20 07:52:33 +01:00
Noel 109312f422 use single-use attribute for PopupMenuControllerFactory 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: Ib7e51a5ba945ad151176d207d2d40f13d0fa6813
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112685
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-19 20:04:43 +01:00
Noel ccef00e160 use single-use attribute for WindowStateConfiguration 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: I2a6a3b1e989d48f4eebf19e9922df22124d25d2a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112687
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-19 20:04:25 +01:00
Noel 2167edad3b use single-use attribute for ModuleUIConfigurationManagerSupplier 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: I146c0da83e59557ec563ec33851d2418c15aa065
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112689
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-19 20:04:18 +01:00
Noel f5784794f4 use single-use attribute for UIElementFactoryManager 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: I52193861c4b2e07c3655773c8d185b2036336da2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112682
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-19 17:37:07 +01:00
Noel 22e4f7a348 use single-use attribute for WindowContentFactoryManager 
instead of rtl::Instance, which means it will get
cleaned up when UNO shuts down

Change-Id: I877c541c11d5c667b0d94cb3875f4263a9323dcb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112681
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-19 17:36:29 +01:00
Noel Grandin c880d3e304 check for quit when calling Yield in loop 
so we don't get stuck threads when the main application
quits

Change-Id: Id36e99267ceb4154873b6ef8ef494622fff6c19a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112409
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
 2021-03-14 08:20:53 +01:00
Luboš Luňák e1d0846e06 drop PNGReader and use only PngImageReader 
PNGReader is a home-made PNG reader that does not use libpng,
so it's more code, presumably less optimized and it apparently also
doesn't always map colors properly.
The only two features it has that PngImageReader doesn't are explicit
chunk reading (used only for reading Microsoft's GIF in PNG, I
implemented that for PngImageReader in a previous commit), and it
loads paletted images as BitmapEx with a palette instead of
converting to direct-color 24/32bpp or 8bpp-gray. The latter is even
questional if nowadays that's feature or a misfeature, as it saves
memory at the expense of speed. I can implement that if somebody
misses it.
I had to adjust some tests:
- CVE-2016-0952-1.png - invalid CRC of the PNG header, neither Gimp
  nor Gwenview can display that, it should fail
- afl-sample-Z_NEED_DICT.png - failure while decompressing data,
  but the loader considers that only a partially broken image since
  the header is correct, so it "passes" (like in Gimp or Gwenview)
- SdImportTest::testTdf134210() and
  testPictureWithSchemeColor::Load_Verify_Reload_Verify()
  need the colors tested changed, because apparently gamma correction
  or something is now applied correctly, and it wasn't before (again
  checked the loaded images with Gimp)

Change-Id: Id46f8d8a01256daf48ca64264b47c4e609183837
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112042
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
 2021-03-12 15:37:21 +01:00
Caolán McNamara ce83d1f448 use preferred variant when window arg is null 
Change-Id: I8fad194b6f147b40ecee6fff9fbbe947e7faa014
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112345
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-03-12 10:06:05 +01:00
Noel 1692998399 use strong_int for item ids in vcl::ToolBox 
(*) fix bug in SfxToolBoxControl::StateChanged where it was using the slot id
    instead of the toolbox item id
(*) I left the logic in SbaTableQueryBrowser alone, but it looks suspicious,
    casting slot ids to toolbox ids

Change-Id: Ied229164c27fb4456b0515c6fdcbd1682766a1a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112186
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-11 14:10:30 +01:00
Mike Kaganski 083900f88c Make sal/config.h the first in pch 
By convention, it should be the first include in C/CXX files;
so use of pch should not break that.

Change-Id: Ic329c5f39e8f48ad1778724368e262e48972342b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112123
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-03-09 06:51:51 +01:00
Noel c7b898df4d clean up some more dynamic/static casting 
using a hacked version of the staticdynamic plugin
and some judgement

Change-Id: I5e6668b19320025e419f84bebceade4239577729
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112137
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-08 07:40:01 +01:00
Caolán McNamara f34e8ab3e7 keep ImplDockingWindowWrapper DLL_PRIVATE and use DockingManager 
to get the FloatingWindow instead

Change-Id: Ifedfe3cc9b024069eef5ea9b7952f2dc2f58b645
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111819
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-03-03 10:02:25 +01:00
Jim Raykowski 098f4e84f0 tdf#116136 don't show status bar LangSelection control tool tip 
in print preview

Change-Id: I85bcb547a71b2a5666310e184d8ba1da16acc97c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111671
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
 2021-03-02 22:52:06 +01:00
Stephan Bergmann 9ccbf716ba Fix null-pointer-use 
Since df33714f0e "tdf#131000: sc: Add UItest"
introduced that test, UITest_calc_tests9
UITEST_TEST_NAME=forms.Forms.test_tdf131000 fails with

> /framework/source/services/frame.cxx:1451:34: runtime error: member call on null pointer of type 'vcl::Window'
>     #0 0x2b0f4825f68f in (anonymous namespace)::XFrameImpl::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) /framework/source/services/frame.cxx:1451:34
>     #1 0x2b0f59361178 in FmPropBrw::impl_ensurePropertyBrowser_nothrow(FmFormShell*) /svx/source/form/fmPropBrw.cxx:508:27
>     #2 0x2b0f5936236e in FmPropBrw::StateChanged(unsigned short, SfxItemState, SfxPoolItem const*) /svx/source/form/fmPropBrw.cxx:539:13
>     #3 0x2b0f4fb3a8f0 in SfxStateCache::SetState_Impl(SfxItemState, SfxPoolItem const*, bool) /sfx2/source/control/statcach.cxx:423:24
>     #4 0x2b0f4fb39a28 in SfxStateCache::SetState(SfxItemState, SfxPoolItem const*, bool) /sfx2/source/control/statcach.cxx:324:5
>     #5 0x2b0f4f868e30 in SfxBindings::UpdateControllers_Impl(SfxFoundCache_Impl const&, SfxPoolItem const*, SfxItemState) /sfx2/source/control/bindings.cxx:1218:16
>     #6 0x2b0f4f865d34 in SfxBindings::Update_Impl(SfxStateCache&) /sfx2/source/control/bindings.cxx:271:17
>     #7 0x2b0f4f86d30c in SfxBindings::Update(unsigned short) /sfx2/source/control/bindings.cxx:350:13
>     #8 0x2b0f4f900fc6 in SfxDispatcher::Call_Impl(SfxShell&, SfxSlot const&, SfxRequest&, bool) /sfx2/source/control/dispatch.cxx:279:24
>     #9 0x2b0f4f91693f in SfxDispatcher::Execute_(SfxShell&, SfxSlot const&, SfxRequest&, SfxCallMode) /sfx2/source/control/dispatch.cxx:753:9
>     #10 0x2b0f4f88e55f in SfxBindings::Execute_Impl(SfxRequest&, SfxSlot const*, SfxShell*) /sfx2/source/control/bindings.cxx:1060:22
>     #11 0x2b0f4fd7a482 in SfxDispatchController_Impl::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /sfx2/source/control/unoctitm.cxx:758:53
>     #12 0x2b0f4fd753c1 in SfxOfficeDispatch::dispatch(com::sun::star::util::URL const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) /sfx2/source/control/unoctitm.cxx:229:16
>     #13 0x2b0f3ff4de92 in comphelper::dispatchCommand(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /comphelper/source/misc/dispatchcommand.cxx:61:12
>     #14 0x2b0f3ff4e605 in comphelper::dispatchCommand(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::frame::XDispatchResultListener> const&) /comphelper/source/misc/dispatchcommand.cxx:76:12
>     #15 0x2b0f75905186 in UITest::executeCommand(rtl::OUString const&) /vcl/source/uitest/uitest.cxx:24:12
>     #16 0x2b0f75917a20 in (anonymous namespace)::UITestUnoObj::executeCommand(rtl::OUString const&) /vcl/source/uitest/uno/uitest_uno.cxx:69:12
>     #17 0x2b0fb07ea8db in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) /bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5
>     #18 0x2b0fb07e4bf2 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) /bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13
>     #19 0x2b0fb07e173d in unoInterfaceProxyDispatch /bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413:13
>     #20 0x2b0fb5c1835a in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const /binaryurp/source/incomingrequest.cxx:235:13
>     #21 0x2b0fb5c11f7a in binaryurp::IncomingRequest::execute() const /binaryurp/source/incomingrequest.cxx:78:26
>     #22 0x2b0fb5ceecc7 in request /binaryurp/source/reader.cxx:85:9
>     #23 0x2b0f4145fac4 in cppu_threadpool::JobQueue::enter(void const*, bool) /cppu/source/threadpool/jobqueue.cxx:100:17
>     #24 0x2b0f414838eb in cppu_threadpool::ORequestThread::run() /cppu/source/threadpool/thread.cxx:165:31
>     #25 0x2b0f4148f62f in threadFunc /include/osl/thread.hxx:189:15
>     #26 0x2b0f37f38da8 in osl_thread_start_Impl(void*) /sal/osl/unx/thread.cxx:264:9
>     #27 0x2b0f39ddaea4 in start_thread (/lib64/libpthread.so.0+0x7ea4)
>     #28 0x2b0f3a71096c in clone (/lib64/libc.so.6+0xfe96c)

(<https://ci.libreoffice.org/job/lo_ubsan/1933/>).

The code in XFrameImpl::setComponent is like that ever since
79d6899a2f "INTEGRATION: CWS inplaceobjects" did

> -    sal_Bool                                       bHadFocus           = m_eActiveState==E_FOCUS;
> +    Window*                                        pOwnWindow = VCLUnoHelper::GetWindow( xContainerWindow );
> +    sal_Bool                                       bHadFocus           = pOwnWindow->HasChildPathFocus();

Lets assume that pOwnWindow can legitimately be null here (i.e., it is not just
a consequence of an error that should be fixed elsewhere), and that bHadFocus
should be false in that case.

Change-Id: I73ce2c24e011d5b2ba95d09fd56bd59e47b4b991
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111841
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-03-02 21:42:46 +01:00
Noel 05d6dae5eb loplugin:refcounting in sfx2 
Change-Id: Iba7b1be688f1a7c1b0947c2423cc1965362386b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111682
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-03-01 19:34:08 +01:00
Caolán McNamara 15b86b9dc1 hide some FloatingWindow details 
Change-Id: I1dc8cb7adc9a26efb74634353b9d75286e31ebb7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111663
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-02-27 20:14:36 +01:00
Caolán McNamara 9ad76a23eb allow use of FloatWinPopupFlags without including complete floatwin.hxx 
Change-Id: Ica412938ead6f213668b3aa876bff81d8f512f1a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111526
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-02-25 21:12:33 +01:00
Caolán McNamara 27272097e6 dockwin.hxx doesn't need to include floatwin.hxx 
Change-Id: Ib0408f715c9a12f32ce2f8049d2c9c7272201d76
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111504
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-02-25 21:12:08 +01:00
Moaz a9a350c13d tdf#139734 Remove redundant asserts after MacrosTest::loadFromDesktop 
MacrosTest::loadFromDesktop itself asserts on its return value.
Thus, the additional checks in unit tests are redundant, and only create
noise unrelated to the tested functionality.

Change-Id: If616001b296afdde38f5a23ececee3d44b4a395d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111290
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-02-25 07:50:29 +01:00
Caolán McNamara a54ccd575c fill convert menu via the css::awt::XPopupMenu apis 
don't poke around at it via vcl

Change-Id: I3c7cdc76c9efd45084294cd6f001ded8e3ebe793
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111411
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-02-23 20:19:30 +01:00
Noel 897970cd0b loplugin:refcounting in framework 
Change-Id: I2d7d14fe0335689e4a338c70587bf33137ed1ddd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111279
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-02-21 16:11:48 +01:00
Caolán McNamara 860b2d0123 update pches 
Change-Id: Ic4586057346b6de700c1bb6ff4cd759a11bb3e4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111231
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-02-19 20:42:34 +01:00
Noel 7767ff7b52 loplugin:referencecasting in editeng..framework 
Change-Id: Ia3375011ecd0a65afed0f131f477fc1542603fde
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110948
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-02-16 07:52:37 +01:00
Caolán McNamara c950dedc9b update pches 
Change-Id: Icf55ddda055d11b649e7607c2cdd8b6d6ddfefbc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110483
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2021-02-08 12:11:17 +01:00
Noel 1250aecd71 loplugin:stringviewparam extend to new.. 
O[U]StringBuffer methods

Change-Id: I0ffbc33d54ae7c98b5652434f3370ee4f819f6f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110090
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-01-29 09:25:12 +01:00
Noel 9430608363 simplify code, use more subView() 
Change-Id: I569c7f34acbdf8451cd5c9acf1abd334637072d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110051
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-01-28 17:32:18 +01:00
Noel 1da6908173 add string_view variants of methods to O[U]StringBuffer 
and update the stringview loplugin to detect cases where we can
use these new methods.

Change-Id: I998efe02e35c8efcb3abfb4d7186165bbe6dfb2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110046
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-01-28 11:11:28 +01:00
Noel c83166ce71 loplugin:passstuffbyref 
Change-Id: I330e0ab6c9955939dad313f9d472f93e39dbd313
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109924
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-01-26 08:30:42 +01:00
Noel Grandin 1aa31294b2 avoid some ref-counting 
can just return a pointer here, instead of VclPtr.

Change-Id: I9ab8962cbbe84ed4dfcfd658a6d758112914cb89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109923
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-01-25 20:21:48 +01:00
Michael Meeks 27cec4edf1 lok: avoid expensive fetching of a property. 
--doc_setView
   SfxLokHelper::setView
   SfxViewFrame::MakeActive_Impl
   SfxApplication::SetViewFrame_Impl
   |
    --SfxDispatcher::Update_Impl
              |
               --SfxWorkWindow::UpdateObjectBars_Impl
	         SfxWorkWindow::UpdateObjectBars_Impl2
		 |
		  --framework::LayoutManager::requestElement
                    framework::LayoutManager::createElement
                    |
                    --11.97%--framework::implts_isPreviewModel

We re-calculate the calc print-area on every setView via this
code-path; pointlessly expensive.

Change-Id: I36dbdc60a789fac4e2a82825b145725a4a4d6439
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109805
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
 2021-01-24 03:01:40 +01:00
Maxim Monastirsky da2b2c9b3d tdf#139696 Use getToolboxId to set item id 
This code depends on ToolboxController::m_nToolBoxId being already set, which
is the case for toolbars, as passed by ToolBarManager::CreateControllers via
the "Identifier" property, but not for the notebookbar, as can be seen in
sfx2::sidebar::ControllerFactory::CreateToolBarController.

Avoid this problem by using getToolboxId, like in most other toolbar controls.

Change-Id: I5dfb1bda0886ce3542274a422f8c9111e7fdcf7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109722
Tested-by: Jenkins
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
 2021-01-21 11:31:18 +01:00