Commit Graph
264 Commits
Author SHA1 Message Date
Jens Carl 958e304490 Use in-class member initializers
Don't use a default ctor that only initializes data members, but rather
in-class member initializers. Follow CppCoreGuidelines rule C.45
(see https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-default).

Change-Id: I52d26fa0393f7e383beb95456dd016aa0e84b777
Reviewed-on: https://gerrit.libreoffice.org/74589
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-23 17:59:21 +02:00
Jens Carl 0e73f9eb41 tdf#45904 Move XShape Java tests to C++
Move XShape Java tests to C++ for ScShapeObj.

Change-Id: I349c4abb09c3e9e43285b63ee5f19f55d967b38f
Reviewed-on: https://gerrit.libreoffice.org/74331
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-19 08:10:10 +02:00
Jens Carl 8a453f96f0 tdf#45904 Move XGluePointsSupplier Java test to C++
Move XGluePointsSupplier Java test to C++ for ScShapeObj.

Change-Id: I75babf46b664cccbb4d1df2af1764c3fa296903a
Reviewed-on: https://gerrit.libreoffice.org/74140
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-18 06:52:14 +02:00
Jens Carl c77a1e1c03 tdf#45904 Move XShapeDescriptor Java test to C++
Move XShapeDescriptor Java test to C++ for ScShapeObj.

Change-Id: I2d530ea73c6f25e36665db0bd65f734e509d97a6
Reviewed-on: https://gerrit.libreoffice.org/74139
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-06-17 08:03:15 +02:00
Michael Meeks 03d33ba941 lok: re-factor getTextSelection.
Change-Id: I2c27c213ee980e19d6020e9599b2b72115e7f28e
Reviewed-on: https://gerrit.libreoffice.org/73626
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-06-07 15:42:05 +02:00
Jens Carl 35608a192d tdf#45904 Move XComponent Java tests to C++
Move XComponent Java tests to C++ for ScShapeObj.

Change-Id: Ib692827729dbe38eaceb76aa042d76e14d9614f8
Reviewed-on: https://gerrit.libreoffice.org/71787
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-04 17:37:47 +02:00
Jens Carl de529f3212 Enable testing of multiple service names
Enable testing of multiple service names of the object supports this, by
storing all possible names in a vector.

Change-Id: Iff2c974cc30a0729cb26b07002582e0786a4de44
Reviewed-on: https://gerrit.libreoffice.org/71713
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-03 03:32:45 +02:00
Jens Carl f07e91ac73 tdf#45904 Move XReplaceDescriptor Java tests to C++
Move XReplaceDescriptor Java tests to C++ for ScCellSearchObj.

Change-Id: Ica5042ce8b5eac3663a0fb5f66ae0a2830c89d93
Reviewed-on: https://gerrit.libreoffice.org/71645
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-02 02:53:26 +02:00
Jens Carl 6f763a3fcd tdf#45904 Move SearchDescriptor Java tests to C++
Move SearchDescriptor Java tests to C++ for ScCellSearchObj.

Change-Id: I3c9ffbfc80c7fdc39d0e67fe8aae12605a8d04f5
Reviewed-on: https://gerrit.libreoffice.org/71644
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-02 02:52:28 +02:00
Jens Carl 976bb31199 tdf#45904 Move XSearchDescriptor Java tests to C++
Move XSearchDescriptor Java tests to C++ for ScCellSearchObj.

Change-Id: I1ae50bb586fd742b7cc19f71bcae018ca42139e6
Reviewed-on: https://gerrit.libreoffice.org/71643
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-02 01:19:34 +02:00
Mike Kaganski d822953cbc Make getXPathPosition assert on requested child found
Previously, for an XML like this:

    <sharedItems>
        <d v="2017-07-10T09:11:02"/>
        <d v="2017-07-10T09:11:03"/>
        <m/>
    </sharedItems>

the call like

    int pos = getXPathPosition(pDoc, "/x:sharedItems", "absent");

gave 3. That could result in mistakes, when a test would assert
on position "3" for a child element which name is mistyped.

I made such a mistake when creating a unit test trying to assert on
a position of the last element, and writing its name as "x:m", like
in rXPath itself; the return was 3, and I initially wrongly assumed
that the return is 1-based (like in xpath bracketed expressions).

rChildName made const OString&, for consistency with rXPath, or with
rAttribute in getXPath: child name is just a part of a longer xpath.

Change-Id: I7ba9c4466c75b1b10fce1ccf26ef3b56b4e11e87
Reviewed-on: https://gerrit.libreoffice.org/71614
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-01 12:30:22 +02:00
Mike Kaganski 3fef9fa3f5 assertXPath: disallow passing rAttribute without rExpectedValue
Change-Id: I7fb59039429361dad04fb68507f40545f9c4dd6d
Reviewed-on: https://gerrit.libreoffice.org/71290
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-25 14:42:13 +02:00
Jens Carl 7c88700b74 tdf#45904 Move TableColumn Java tests to C++
Move TableColumn Java tests to C++ for ScTableColumnObj.

Change-Id: I3f17fa1f25c2676124b56c384364e36736fac849
Reviewed-on: https://gerrit.libreoffice.org/71261
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-25 01:21:49 +02:00
Jens Carl eb7a731bcf tdf#45904 Move XChartData Java tests to C++
Fix tdf#43309: Move XChartData Java tests to C++ for ScCellRangeObj.

Change-Id: I6b57db53fdddab2ff382354d32809404224a2e1e
Reviewed-on: https://gerrit.libreoffice.org/70956
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-19 05:00:46 +02:00
Jens Carl 5696272f90 tdf#45904 Move XTextField Java tests to C++
Move XTextField Java tests to C++ for ScEditFieldObj_Header (formerly
ScHeaderFieldObj).

Change-Id: I36b723945d9306720846b4a4e2d3eaddb1a1c063
Reviewed-on: https://gerrit.libreoffice.org/70841
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-17 01:11:58 +02:00
Jens Carl c498e548ee tdf#45904 Move TextContent Java tests to C++
Move TextContent Java tests to C++ for ScEditFieldObj_Cell and
ScEditFieldObj_Header (formerly ScCellFieldObj).

Change-Id: Ieed5cdbc128490e66d1797c817d998a932317dd4
Reviewed-on: https://gerrit.libreoffice.org/70615
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-12 06:12:19 +02:00
Jens Carl 6a7350f856 tdf#45904 Move XCellRange Java tests to C++
Move XCellRange Java tests to C++ for ScTableRowObj.

Change-Id: I2735779cae777c5af4e622bc1b538df2d8bf70df
Reviewed-on: https://gerrit.libreoffice.org/70163
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-03 03:47:56 +02:00
Jens Carl cc9a8c13da tdf#45904 Move TableRow Java tests to C++
Move TableRow Java tests to C++ for ScTableRowObj.

Change-Id: I72cd8006b8ad932bab56681de9aac66fb40542fe
Reviewed-on: https://gerrit.libreoffice.org/70159
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-03 00:39:08 +02:00
Samuel Mehrbrodt 8ecdaecfa8 Split large test method in two
Change-Id: If1b915f721a5768b682c63dc9c08b708ba37a705
Reviewed-on: https://gerrit.libreoffice.org/70116
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-04-02 15:03:53 +02:00
Jens Carl 2e0e7a15f6 tdf#45904 Move XFormLayerAccess Java tests to C++
Move XFormLayerAccess Java tests to C++ for ScViewPaneObj.

Change-Id: I7ed6ff51d435b6f3de85daec99a13583e50a450a
Reviewed-on: https://gerrit.libreoffice.org/69942
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-30 22:40:23 +01:00
Jens Carl 413bfc3442 Move UNO Api helper form to include/
Move UNO Api helper form to include/, so it can be used outside of
directory test/.

Change-Id: I9392f44df8a93d2b5ee092b0458aeef12f99fc7a
Reviewed-on: https://gerrit.libreoffice.org/69936
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-29 23:04:32 +01:00
Jens Carl d757b121e3 tdf#45904 Move XNamed Java tests to C++
Move XNamed Java tests to C++ for ScSheetLinkObj.

Change-Id: I64904ed6bae1b96767f8b0a65b0850a8694b10c2
Reviewed-on: https://gerrit.libreoffice.org/69907
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-29 02:47:05 +01:00
Jens Carl b99ea0ff33 tdf#45904 Move XShapes Java tests to C++
Move XShapes Java tests to C++ for ScDrawPageObj.

Change-Id: I1b65e8ad685c3d387a5023e8e8e9b9e06627af11
Reviewed-on: https://gerrit.libreoffice.org/69904
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-29 00:45:46 +01:00
Jens Carl ee92196179 Fix header guard and improve comments
Change-Id: I7ddef04a88381e3e58a6604de35694dea658c81d
Reviewed-on: https://gerrit.libreoffice.org/69900
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-28 22:18:48 +01:00
Jens Carl ee503c3619 tdf#45904 Move XShapeGrouper Java tests to C++
Move XShapeGrouper Java tests to C++ for ScDrawPageObj.

Change-Id: I4a1ed4f14f759fa4214141f0d552e35ccae28035
Reviewed-on: https://gerrit.libreoffice.org/69873
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-28 06:28:16 +01:00
Jens Carl 28eab5de35 Helper to create various drawing::XShape
This ports SOfficeFactory::createShape() from file
qadevOOo/runner/util/SOfficeFactory.

Change-Id: I2c7eb0304ac1d439211d3851b2debdb4843130e3
Reviewed-on: https://gerrit.libreoffice.org/69772
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-27 19:35:51 +01:00
Noel Grandin 705558aa45 condition always true in XSpreadsheets2::importSheetToCopy
leftover from
    commit ed45c87896
    Date:   Mon Oct 20 21:08:54 2014 +0200
    sc: fix temp file leak in ScTableSheetsObj

Change-Id: Ic108fb36cc0caccbe57f2b47f7fcbe80156842dc
Reviewed-on: https://gerrit.libreoffice.org/69749
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-27 07:40:12 +01:00
Bjoern Michaelsen 3428ca9c3b name apitest suites consistently while we still can
- writer test apitest suites are now called like the UNO implementation they
  are testing
- also mark them final for good measure
- move tests to module test and try to match its conventions
  * BaseIndex
  * TextDocumentIndex
  * TextDocumentSettings
  * TextPrinterSettings
  * TextSettings
  * XDocumentIndex
- also remove anonymous namespace in header, as that is a bad idea
- also remove now obsolete ApiBaseTest
- also remove dead code in TextPrinterSettings
- remove writer xtextcontent test as it duplicates the impl in module test

Change-Id: I71aa5f3755d5c90726f4ff4394117fa2391495d7
Reviewed-on: https://gerrit.libreoffice.org/69374
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-03-19 08:38:34 +01:00
Bjoern Michaelsen e4600ec933 Component test
Change-Id: I03785b3126671629011d5e62925a5658ab5ec2f7
Reviewed-on: https://gerrit.libreoffice.org/69067
Tested-by: Jenkins
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-03-16 23:36:10 +01:00
Jens Carl c7aed551ab Fix typo
Change-Id: I5e75f430090e6812d82146c88e7b687d6c6fcffa
Reviewed-on: https://gerrit.libreoffice.org/69344
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-16 21:03:11 +01:00
Jens Carl 4eff406181 tdf#45904 Move XTableColumns Java tests to C++
Move XTableColumns Java tests to C++ for ScTableColumnsObj.

Change-Id: Iead7ca3d7c07820086f75d86833b7bfc97978751
Reviewed-on: https://gerrit.libreoffice.org/69286
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-15 23:54:26 +01:00
Jens Carl 4ad3b5cdf4 tdf#45904 Move XNameReplace Java tests to C++
Move XNameReplace Java tests to C++ for ScStyleFamilyObj.
Fixes i#23594 by creating a new "com.sun.star.style.CellStyle"
rather then using an existing one.

Change-Id: Ie42e627020aff475173af5bc014bc28d7a11ec56
Reviewed-on: https://gerrit.libreoffice.org/69140
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-13 06:38:53 +01:00
Jens Carl 57ca3b3b2b tdf#45904 Move XTableCharts Java tests to C++
Move XTableCharts Java tests to C++ for ScChartsObj.

Change-Id: Ibd08cc60d38d8ca01af9168d862a9f391c48e90a
Reviewed-on: https://gerrit.libreoffice.org/68992
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-10 07:14:51 +01:00
Jens Carl fe632c86aa tdf#45904 Move XRefreshable Java tests to C++
Move XRefreshable Java tests to C++ for ScAreaLinkObj.
To make this test work, had to provide parameter aSourceArea (in this
case file sc/qa/extras/testdocuments/scarealinkobj.ods). All the other
depended tests of ScAreaLinkObj had to adjusted to the new test
environment.
Also fixes i84711, because the XRefreshable test runs independent from
the other tests, as mentioned in the bug description.

Change-Id: I8847813431e2fdd60ed95be0f7d115bcaeafe500
Reviewed-on: https://gerrit.libreoffice.org/68949
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-09 02:52:05 +01:00
Jens Carl 167c5f9aff tdf#45904 Move XTextRange Java tests to C++
Move XTextRange Java tests to C++ for ScAnnotationObj
(also fixes i109517).

Change-Id: Id7e45d9f1159b45fb267cb28dc875b62eae12e24
Reviewed-on: https://gerrit.libreoffice.org/68634
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-03 19:46:33 +01:00
Jens Carl 4b98337699 Add missing XNameContainer tests to ScDataPilotFieldGroupsObj
Change-Id: Ia59b2a6136e2e56bf6c43a84e3cb6268471278a5
Reviewed-on: https://gerrit.libreoffice.org/68410
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-02-27 09:39:42 +01:00
Tomaž Vajngerl 24f7dd6251 move and extend primitive2dxmldump to drawinglayer
Also needs extending the XmlWriter to output double numbers as
the attribute content.

Change-Id: Ie749ea990d856c8c90092ed8153c24efda99c444
Reviewed-on: https://gerrit.libreoffice.org/67573
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-09 11:58:06 +01:00
Jens Carl ce2b98580b Add XSheetFilterDescriptor2 and XSheetFilterDescriptor3 tests
Add XSheetFilterDescriptor2 and XSheetFilterDescriptor3 tests
to ScFilterDescriptorBase.

Change-Id: I932560c42d9c5f3077f47f116f6ae011f6aea79e
Reviewed-on: https://gerrit.libreoffice.org/67097
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-29 23:57:08 +01:00
Michael Stahl 3cacdf5b0f sc: fix CppunitTest_sc_ddelinkobj to copy its test document
XRefreshable::testRefreshListener() fails on read-only filesystem
because the ScDDELinksObj.ods cannot be loaded read-write.

It is loaded read-write since commit
5b2794e27a.

Change-Id: I27b954b216acd3d138ade0d3f1b21fedd2f74fb1
Reviewed-on: https://gerrit.libreoffice.org/67071
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-29 17:02:17 +01:00
Ajay Mahato ecc855aa1c tdf#45904 Move XSimpleText Java tests to C++
Change-Id: I6232615f15b52a1f004a13ed97fc0b8002a22269
Reviewed-on: https://gerrit.libreoffice.org/66694
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-29 01:02:34 +01:00
Jens Carl 8968e64811 Add XActionLockable tests to ScNamedRangesObj
Change-Id: Ibadda3535294fb58ea371e00357da8cd504d5f9a
Reviewed-on: https://gerrit.libreoffice.org/66953
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-26 07:01:00 +01:00
Jens Carl 412fbb6f01 tdf#45904 Move XEnumerationAccess Java test to C++
Move XEnumerationAccess Java test to C++ for ScNamedRangesObj.

Change-Id: Ia19281b8e481eda2535eb6f26c60dedc65f1beec
Reviewed-on: https://gerrit.libreoffice.org/66933
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-26 02:12:24 +01:00
Jens Carl 059a958a65 Add XMultiFormulaTokens tests to ScTableValidationObj
Change-Id: I6239cfba2b275c5f0b8794e30d57d1835ed569fa
Reviewed-on: https://gerrit.libreoffice.org/66892
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-25 14:55:18 +01:00
Jens Carl 3e36b6b1fc Fix typos
Change-Id: I57e99100d76d64bd9a7cf27016bbb02de9ed9d6a
Reviewed-on: https://gerrit.libreoffice.org/66893
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-25 14:24:06 +01:00
Jens Carl dd0155967e tdf#45904 Move XPropertySet Java tests to C++
Move XPropertySet Java tests to C++ for ScTableValidationObj.

Change-Id: If058f40ff73203d2705bf9841d0496d52ff93ed8
Reviewed-on: https://gerrit.libreoffice.org/66890
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-25 04:17:29 +01:00
Jens Carl b5d2ebb76e tdf#45904 Move XTableChart Java tests to C++
Move XTableChart Java tests to C++ for ScChartObj.

Change-Id: I007d484357b5743a4283e9aa41bc6d203d312379
Reviewed-on: https://gerrit.libreoffice.org/66842
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-24 22:02:07 +01:00
Jens Carl 9a2954f566 tdf#45904 Move XEmbeddedObjectSupplier Java test to C++
Move XEmbeddedObjectSupplier Java test to C++ for ScChartObj.

Change-Id: I125951e490719de225f1ac48d10b857c457fa529
Reviewed-on: https://gerrit.libreoffice.org/66839
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-24 18:42:23 +01:00
Jens Carl fd8a724d22 tdf#45904 Move XDrawPages Java tests to C++
Move XDrawPages Java tests to C++ for ScDrawPagesObj.

Change-Id: I0e48aae9caadf0d9834c4f973095ba9d10435fdc
Reviewed-on: https://gerrit.libreoffice.org/66712
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-22 07:18:17 +01:00
Jens Carl eee8c16a5c Add XDDELinks tests to ScDDELinksObj
Change-Id: I9e6efbd5a1cd9e4787e8143dd4f8adbe6ab2cae7
Reviewed-on: https://gerrit.libreoffice.org/66561
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-18 08:41:38 +01:00
Jens Carl 7b7cc20d83 Move XStyleLoader2 tests to ScStyleFamiliesObj
Change-Id: Ibba0464d17a9517eb48f3f33b46db2455093ac52
Reviewed-on: https://gerrit.libreoffice.org/66413
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-16 18:57:49 +01:00