Use it instead of classname::getImplementation from UNO3_GETIMPLEMENTATION_*
Change-Id: Ifcc8cfcd6369c576250008c76ce31ba79ea3a596
Reviewed-on: https://gerrit.libreoffice.org/74107
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Replace with UNO3_GETIMPLEMENTATION* macros.
Replace single usage of IMPL_XUNOTUNNEL_MINIMAL with it's body.
Change-Id: I7d4ad76399b999ebb2178ecf57edcf6bd2aa6c3e
Reviewed-on: https://gerrit.libreoffice.org/73424
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
f9905401d8 "tdf#125170 Deliver mouse events also
when clicking into document content" had disabled it because its
gerrit_linux_clang_dbgutil Jenkins build had failed it successively like
> LOG> Execute: Date
> LOG> try to set:
> LOG> old = com.sun.star.util.Date@271053e1{1, 1, 1800}
> LOG> new = com.sun.star.util.Date@589838eb{2, 0, 0}
> warn:tools.datetime:303:1063:tools/source/datetime/tdate.cxx:102: Date::setDateFromDMY - sure about 0 year? It's not in the calendar.
> LOG> Property Date is void
> LOG> Value for 'Date' hasn't changed as expected
> LOG> result = com.sun.star.util.Date@42dafa95{1, 1, 1800}
> Method Date finished with state FAILED
> LOG> Date: COMPLETED.FAILED
(<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/32715/>).
But it is unclear how that commit would have affected that test, and at least a
recent local build of mine succeeds with
> LOG> Execute: Date
> LOG> try to set:
> LOG> old = com.sun.star.util.Date@dc24521{0, 0, 0}
> LOG> new = com.sun.star.util.Date@10bdf5e5{1, 0, 0}
> warn:tools.datetime:10048:10220:tools/source/datetime/tdate.cxx:102: Date::setDateFromDMY - sure about 0 year? It's not in the calendar.
> LOG> Property Date is void
> LOG> Property 'Date' OK
> LOG> result = com.sun.star.util.Date@6e1ec318{1, 0, 0}
> Method Date finished with state OK
> LOG> Date: COMPLETED.OK
(note the difference of initial date, {1, 1, 1800} vs. {0, 0, 0}, whether or not
that is relevant), so lets re-enable the test for now and see...
Change-Id: I53b462954650e32de85c795c94f9b8038dc01918
Reviewed-on: https://gerrit.libreoffice.org/72863
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Event listeners are added once VCLXWindow::SetWindow is called.
This never happened for the document content window.
So we need to call Window::GetComponentInterface which will create an XWindowPeer
and then call UnoWrapper::SetWindowInterface which calls VCLXWindow::SetWindow.
After that, event listeners are registered so that we can deliver events.
Change-Id: I2ed01f1ab20d87fedc4803bdbd96f5ef14d40043
Reviewed-on: https://gerrit.libreoffice.org/71948
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
By creating deleted methods for the wrong calls.
Avoids the compiler needing to construct a temporary
Change-Id: I3b8c648d6bb22d22827bf74f21ea5a2a17fc0f6a
Reviewed-on: https://gerrit.libreoffice.org/72103
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
... which could help catch copy-paste errors when wrong guard is cleared
second time.
Also an assert added that when resetting, there's something to reset
(i.e., no descendant class had cleared protected pResetT, making reset
impossible, and thus actually unable to guard anything).
framework/source/layoutmanager/layoutmanager.cxx: made sure to not call
clear() second time
framework/source/layoutmanager/toolbarlayoutmanager.cxx: restored lock
lost in commit 777bc22ca6
forms/source/misc/InterfaceContainer.cxx: removed a leftover from commit
a19cd21e3c which reduced guarded scope
forms/source/component/DatabaseForm.cxx: fixed clear-reset sequence
broken from the initial commit bf4154eb53
Change-Id: Ibab6660c79561eee31faf3e6c1128ab141a7e8a3
Reviewed-on: https://gerrit.libreoffice.org/70381
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Also use scope where possible. This allows to limit guard scope at
language level; visualises the scope clearly; and helps avoiding
errors like fixed in commit 61e4437c85.
Change-Id: Ifeca96e2df8e8a0897770d9546b2536806275f41
Reviewed-on: https://gerrit.libreoffice.org/70376
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I6e97c7ed6c0211dfafee83b9bdbea672e415fc49
Reviewed-on: https://gerrit.libreoffice.org/69715
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
look for places we are doing code like:
Reference<XProperty>(model, css::uno::UNO_QUERY)->getAsProperty()
which might result in a SIGSEGV is the query fails
Change-Id: I5cbdbc9e64bd0bed588297c512bf60cbacb9442e
Reviewed-on: https://gerrit.libreoffice.org/69044
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I02f75be483529ba1f7a6e460e34c4752b4265221
Reviewed-on: https://gerrit.libreoffice.org/68893
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Caolán McNamara