Noel Grandin
bd2eed385f
write out empty state explicitly in writeRectangle
...
this is purely an internal XML format, so we can change it
Change-Id: I9e2a4350c6c3f51031742e94823ea052dd73c8df
Reviewed-on: https://gerrit.libreoffice.org/75639
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2019-07-16 08:09:56 +02:00
Stephan Bergmann
6ad13e0e5d
Demote from std::unique_lock to std::scoped_lock where applicable
...
Change-Id: I53a019f05978bab62ad0da3d0eb08f37f8ec1e18
Reviewed-on: https://gerrit.libreoffice.org/74414
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2019-06-20 10:19:33 +02:00
Gabor Kelemen
79e618c65f
tdf#42949 Fix remaining IWYU warnings in include/vcl/*
...
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Some new headers were added since I begun the cleanup here
Also blacklist the header from commit 403e3c0442
Change-Id: Ie2358d5e27297f873aeb4a4dfb2778e6fb95dfa5
Reviewed-on: https://gerrit.libreoffice.org/66255
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
2019-01-18 09:09:22 +01:00
Miklos Vajna
66b919c867
svm xml dumper: move this from test to vcl
...
This is very useful functionality, this way it can be invoked from the
debugger and/or nested into an outer xml dump (sw/sd doc model dump)
more easily.
Change-Id: If6c83b11d0f3e65fcce71e8d820c6bc354f64d68
Reviewed-on: https://gerrit.libreoffice.org/65834
Reviewed-by: Miklos Vajna <vmiklos@collabora.com >
Tested-by: Jenkins
2019-01-03 15:08:06 +01:00
Noel Grandin
6f50961e69
remove more rtl::OUString and OString prefixes
...
which seem to have snuck back in since the great rounds of removals.
Change-Id: I85f7f5f4801c0b48dae8b50f51f83595b286d6a1
Reviewed-on: https://gerrit.libreoffice.org/62229
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-10-24 14:43:34 +02:00
Noel Grandin
ef5b895afe
loplugin:staticvar in editeng..framework
...
Change-Id: I8e555a98f74f61e6e40122564b7ad19ca07a8a91
Reviewed-on: https://gerrit.libreoffice.org/61866
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk >
2018-10-17 12:07:46 +02:00
Gabor Kelemen
bdb0775a26
Add missing sal/log.hxx headers
...
rtl/string.hxx and rtl/ustring.hxx both unnecessarily #include <sal/log.hxx> (and don't make use of it themselves), but many other files happen to depend on it.
This is a continuation of commit 6ff2d84ade to be able to remove those unneeded includes.
This commit adds missing headers to every file found by:
grep -FwL sal/log.hxx $(git grep -Elw 'SAL_INFO|SAL_INFO_IF|SAL_WARN|SAL_WARN_IF|SAL_DETAIL_LOG_STREAM|SAL_WHERE|SAL_STREAM|SAL_DEBUG')
to directories from filter to jvmfwk
Change-Id: I2a73d63f2aaef5f26d7d08957daaa8a30b412ac5
Reviewed-on: https://gerrit.libreoffice.org/58204
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk >
2018-07-30 09:28:40 +02:00
Chris Sherlock
4d94541a7b
Make Color a forward declaration
...
Change-Id: Ib28833555661b119de8e967b05e3c8691fca826a
Reviewed-on: https://gerrit.libreoffice.org/43227
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com >
2017-10-08 04:48:46 +02:00
Noel Grandin
2c05d758b2
add << operator for css::uno::Exception
...
Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
Tested-by: Jenkins <ci@libreoffice.org >
2017-10-04 15:18:00 +02:00
Stephan Bergmann
cd8aeed156
Fix data races during CppunitTest_filter_xslt
...
Change-Id: I140ac8a24326959ba341adddbbf505ff16616283
2017-09-11 17:58:13 +02:00
Caolán McNamara
206ca28bed
add CVE-2017-10688 testcase
...
Change-Id: Icf24df4a3655775d9ce26ca1f72e130eead49c10
Reviewed-on: https://gerrit.libreoffice.org/39760
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-07-10 17:39:07 +02:00
Caolán McNamara
8038574923
add CVE-2017-9936 testcase
...
Change-Id: I0c791ef1f51c8af9f752742b8a3a3de6d626191b
Reviewed-on: https://gerrit.libreoffice.org/39759
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-07-10 17:38:45 +02:00
Caolán McNamara
de855a731c
add CVE-2017-9147 testcase
...
Change-Id: I82f5d4e75c888f4f988c8d6188b77550631fe258
Reviewed-on: https://gerrit.libreoffice.org/39758
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2017-07-10 16:41:02 +02:00
Caolán McNamara
bb3715b628
ofz#967 optimize tiff import if line is the same as previous line
...
Change-Id: Ided61679a579a73481320f85c05b03e3ce3d762a
2017-03-30 21:14:48 +01:00
Caolán McNamara
b018021d5a
ofz: timeout on clamping big double to 0..360
...
Change-Id: Ica2aedc5275e5f523302f5793e3f3816b3ff65b4
2017-02-28 20:47:57 +00:00
Stephan Bergmann
e57ca02849
Remove dynamic exception specifications
...
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html >
"Dynamic Exception Specifications" for details.
Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly). The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually). There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).
Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code. Missing @throws
documentation has not been applied in such manual clean-up.
Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2017-01-26 12:54:43 +00:00
Caolán McNamara
7420e35090
guard against self-recursive GetBoundingBox
...
Change-Id: If33f0e5e326604bf731d6ad50644e3a0b24ccf51
2017-01-13 15:13:37 +00:00
Caolán McNamara
57779b5f3a
avoid infinite loops in dxf rendering
...
Change-Id: Id2eb5540241f0792cde35c444fc2c0c5b7778353
2017-01-13 13:21:07 +00:00
Miklos Vajna
81ce0f3772
filter: fix loplugin:cppunitassertequals warnings
...
Change-Id: Ibb80377a581d70501dbd243307e883057508e67f
2016-09-16 10:55:36 +02:00
Stephan Bergmann
60b1c95cc4
Extract Directories from BootstrapFixtureBase
...
(as some tests derive from the latter only for the Directories part, not for the
setUp/tearDown overrides: those tests will be cleaned up next)
Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f
Reviewed-on: https://gerrit.libreoffice.org/23078
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Stephan Bergmann <sbergman@redhat.com >
2016-03-10 08:04:40 +00:00
Noel Grandin
70f87284c6
improve defaultparams loplugin
...
to catch calling params with defaults like "= OUSString()"
Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9
Reviewed-on: https://gerrit.libreoffice.org/22932
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2016-03-07 05:57:17 +00:00
Michael Stahl
18b0343010
RC4 encrypt some WMF and TIFF test files
...
Reportedly some virus scanners warn about some of these files.
Use a new "RC4" name prefix since the files don't come from external
sources.
http://permalink.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/69200
Change-Id: I6d4cff2fdd5c0134bf2c77558ea09b3196b39be9
2016-01-05 13:33:56 +01:00
Stephan Bergmann
3cdda9af2c
loplugin:nullptr (automatic rewrite)
...
Change-Id: I61e494952df8cc40fff3ccad0936adf06035dbeb
2015-11-10 10:31:25 +01:00
Oliver Specht
7f533e6cda
merged graphic import/export into a single library
...
instead of egi, eme, epb, epg, epp, eps, ept, era, eti, exp,
icd, idx, ime, ipb, ipd, ips, ipt, ipx, ira, itg, iti,
there is now one graphic import export lib (gie)
Change-Id: I20c0dd94e5857bb6e2e8cc8ac175ff500c6bbdfc
Reviewed-on: https://gerrit.libreoffice.org/19756
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Oliver Specht <oliver.specht@cib.de >
2015-11-06 11:42:36 +00:00
Stephan Bergmann
b36963c0a6
Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
...
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Caolán McNamara
b43e03353a
check stream status more often
...
Change-Id: I233c2fff9c06a81117f8114ccee83b53ea4026db
2015-09-11 15:38:39 +01:00
Caolán McNamara
b02f1c58e7
fix size check related hang
...
Change-Id: I3e8aa5c48ba802cd363688502b44e27bfdf67f01
2015-09-10 09:25:11 +01:00
Caolán McNamara
ad6d83defb
check for legal field sizes before reading
...
Change-Id: I3cdb647e1a057be5bb4b32d119ee5bcbbedf7473
2015-08-31 11:22:45 +01:00
Caolán McNamara
a8fe085f97
check stream status
...
Change-Id: I65ed5979d35d8739367294a71620782b832cfd71
2015-08-31 09:57:00 +01:00
Caolán McNamara
0a76c1fd68
in reality we are limited to max sal_Int32 here
...
so accept that and test if the values were accepted or limited
Change-Id: Iaed5ebc2f12b52055506147c71117a2ad88d28ac
2015-08-24 20:51:13 +01:00
Caolán McNamara
6b82437dca
detect and reject loop in tif
...
Change-Id: I77d315fa432a3eb1a65539489a2ba6da8508b283
2015-08-24 15:32:42 +01:00
Zolnai Tamás
3f339c5e77
Better to call this msfilter test
...
Change-Id: I2abd6aedb16303d8988c17e7204c9607bf8336a3
2015-08-23 19:10:41 +02:00
Takeshi Abe
678bb5135b
tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants, for filter.
Change-Id: I30dcd7cfb3e484034f6cceceb1ff7cd9d3f4b7a6
Reviewed-on: https://gerrit.libreoffice.org/17585
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
2015-08-11 07:06:51 +00:00
Caolán McNamara
34d062147c
reject invalid tiff dimensions
...
Change-Id: I64e77f12cb016a7f4a9d21c732aaeaae7959da76
2015-07-21 10:12:41 +01:00
Caolán McNamara
97a0e7558b
bail if offsets are past eof
...
Change-Id: I4a8e78231befff498894ec92a1f38af206e13129
2015-07-20 12:30:28 +01:00
Caolán McNamara
8eaef6b521
fail on short read
...
Change-Id: I7215cf8d8b1e4a4156c87507018de3c2b7ed08d8
2015-07-20 11:46:21 +01:00
Caolán McNamara
6964f67d0d
don't hang on a bad ReadCodeAndDecode
...
Change-Id: I999012d428fa84e21fe9e9f851a016eacc96a686
2015-07-20 11:24:42 +01:00
Caolán McNamara
c02e798749
ensure loop ends eventually
...
Change-Id: I318385286fcc27ffb2d938237d83e793564d2525
2015-07-20 10:28:30 +01:00
Caolán McNamara
dcbbe7741a
final check np bounds
...
Change-Id: I9213bb2cc059e05e286598edac03bd72c84db876
2015-07-20 09:25:36 +01:00
Caolán McNamara
33d43205c3
test that nNumStripByteCounts value is within bounds of file
...
Change-Id: If119628d7f510a7db30ed2180111063781cde887
2015-07-20 09:21:35 +01:00
Caolán McNamara
bca4d6f896
check np bounds yet again
...
Change-Id: Id3f6fdc0ebed9711acec5d71f404e7a6072b765c
2015-07-20 08:51:30 +01:00
Caolán McNamara
5d32a4ac5c
reduce scope, etc, don't loop endlessly
...
Change-Id: I86e4e94392527b5faf5d9cdb4251853f35813f4e
2015-07-20 08:38:12 +01:00
David Tardon
3f0677b86f
add a test image
...
Change-Id: Ibd30ddc9c4a0e1ca440d0b62635cfab3f3ab8235
2015-07-20 08:50:53 +02:00
Caolán McNamara
fcdddbd30a
check np bounds again
...
Change-Id: I0fb61954b2eaf0c015d7bdefe9f03bd459b31501
2015-07-19 21:33:37 +01:00
Caolán McNamara
be4e1141be
check np bounds
...
Change-Id: Id16ae9325f3c67792941b9c88d83435aa98282ca
2015-07-19 21:26:32 +01:00
Caolán McNamara
80c591ea9c
in reality we are limited to max sal_Int32 here
...
so accept that and test if the values were accepted or limited
Change-Id: I599cf8065a6f8786d380fdba03135857766770f3
2015-07-19 21:13:37 +01:00
Caolán McNamara
6a1f31898d
in remainingSize consider that its is possible to seek past the end
...
Change-Id: I1652244d5515629f1cd8f15f4c5b15f139dba0aa
2015-07-17 11:22:12 +01:00
Caolán McNamara
c9ba7a2a4d
don't loop forever if pcx has short read
...
Change-Id: I638792417924bcb8e48995f4e789f84a2cbf4757
2015-07-17 11:22:11 +01:00
Caolán McNamara
64cc2d775c
rename test case
...
Change-Id: I76d35955a1d024d05a94ffdfdcf8e4076de24975
2015-07-17 10:00:45 +01:00
Caolán McNamara
49bf2c6700
detect another loop in tif format
...
Change-Id: I950f751277d9080b4fc00c38f63453cce81bcc32
2015-07-17 10:00:45 +01:00