ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
438,884 Commits 3 Branches 3 Tags
e48e2bb90748bb2d63dfd70d05ab8b463fb9bcd2
Commit Graph
612 Commits
Author SHA1 Message Date
Caolán McNamara fbc038cc4f an uno -> a uno 
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d
Reviewed-on: https://gerrit.libreoffice.org/72105
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-05-10 14:50:59 +02:00
Gabor Kelemen 754c6af45a tdf#42949 Fix IWYU warnings in include/basic/* 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I9dd7984affc4343f148c66077feaac19176adf51
Reviewed-on: https://gerrit.libreoffice.org/68769
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2019-03-07 14:20:10 +01:00
Noel Grandin 38187ec15b loplugin:singlevalfields extend to all static vars 
Change-Id: Ic238bb5291539fd1b7e98cb4afc9b25f37e7d528
Reviewed-on: https://gerrit.libreoffice.org/64710
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-12-07 07:38:24 +01:00
Mike Kaganski cb9d192f18 tdf#120703 PVS: V547 Expression '!pRTLData' is always false 
Let SbiInstance::GetRTLData() return reference

Change-Id: Iafe7e64f6f296b478003ce66ea66936a65ba9edc
Reviewed-on: https://gerrit.libreoffice.org/62855
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2018-11-05 09:43:24 +01:00
Jan-Marek Glogowski 2226d69ae3 Make SbiProcDef::Match more readable 
This reverts commit 02caaef29d ("loplugin:useuniqueptr in
SbiProcDef") and is hopefully easier to follow.

Change-Id: I46be2b3c7a933743795d89fe17a2c499c6983382
Reviewed-on: https://gerrit.libreoffice.org/62548
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
 2018-10-30 21:40:26 +01:00
Noel Grandin c0cc59adca loplugin:singlevalfields improvement 
look for any kind of types, not just POD types, helps to find
smart pointer fields that are only assigned nullptr

Change-Id: I2d887e98db012f03b646e1023985bcc196285abc
Reviewed-on: https://gerrit.libreoffice.org/62382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-10-26 11:20:07 +02:00
Gabor Kelemen cc7280efdb tdf#42949 Fix IWYU warnings in include/cppuhelper/* 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: Ib420e9216b8313f5ed7634ec375e39ceb741fd45
Reviewed-on: https://gerrit.libreoffice.org/59297
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2018-09-10 09:58:12 +02:00
Andrea Gelmini 6732bebb87 Fix typo 
Change-Id: Ib2c183f5edb94e68f43f92edd83cb8d3ae5b40e1
Reviewed-on: https://gerrit.libreoffice.org/60103
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
 2018-09-07 02:32:35 +02:00
Noel Grandin 24eae7bd70 clang-tidy performance-unnecessary-value-param 
Change-Id: I69247498e13331f6ef84afeb242479f8fb1178a8
Reviewed-on: https://gerrit.libreoffice.org/60068
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-09-06 09:54:25 +02:00
Noel Grandin d02587d79d loplugin:useuniqueptr in SbiGlobals 
Change-Id: Icbf913058ada4714345d0251970e6420b315270c
Reviewed-on: https://gerrit.libreoffice.org/60001
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-09-05 09:31:29 +02:00
Noel Grandin a18a72ac1a loplugin:useuniqueptr in SbiExprNode 
Change-Id: I2025251e35a48f47a51f11d790c3a22e118f3c05
Reviewed-on: https://gerrit.libreoffice.org/59348
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-08-22 08:26:41 +02:00
Noel Grandin 02caaef29d loplugin:useuniqueptr in SbiProcDef 
Change-Id: I31c43f8fe40d90094d550b02c5d6213e59149bad
Reviewed-on: https://gerrit.libreoffice.org/58486
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-08-03 09:08:04 +02:00
Stephan Bergmann e6ab9174b0 basic: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9) 
...by removing explicitly user-provided functions that do the same as their
implicitly-defined counterparts, but may prevent implicitly declared copy
functions from being defined as non-deleted in the future.  (Even if a dtor was
declared non-inline in an include file, the apparently-used implicitly-defined
copy functions are already inline, so why bother with a non-inline dtor.)

Change-Id: I8a31ab0c806cb0f3c226d217f152a205aff6c07f
Reviewed-on: https://gerrit.libreoffice.org/58065
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-07-26 16:27:20 +02:00
Noel Grandin dbf8ad9bc3 loplugin:useuniqueptr in SbUnoStructRefObject 
now that we have upgraded to VS2017, we can use std::unique_ptr in
std::map

Change-Id: Id01af07ccae7447405b8f0bc44b08043f453e54b
Reviewed-on: https://gerrit.libreoffice.org/57384
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-07-13 11:58:10 +02:00
Mike Kaganski 0f7a7c8e71 tdf#118218: Implement FormatNumber VBA function 
The existing unit test (previously non-functional because of defunct
success condition) is fixed and extended.

Change-Id: I2544f865144b25f51a5f0941e5d961f246f41c4b
Reviewed-on: https://gerrit.libreoffice.org/56610
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2018-06-29 21:06:12 +02:00
Caolán McNamara 39e75712b2 valgrind: use OUString::operator to access into string 
address some out of bounds oddness seen with
rtl_ustr_getlength_heap_buffer_overflow.sample

Change-Id: I5a9772de9607644f43e74174f73053d292ca7cc0
Reviewed-on: https://gerrit.libreoffice.org/55722
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-06-13 15:28:21 +02:00
Johnny_M abe5a1a55f Translate German comments and debug strings 
And correct a few comments (translation and grammar)

Change-Id: Ifafa521c683e9ca65aeba8031cd4cbfc1fadc137
Reviewed-on: https://gerrit.libreoffice.org/54888
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
 2018-06-06 13:46:09 +02:00
Arkadiy Illarionov f62243c7bb tdf#96099 Remove some trivial typedef std::vector 
Change-Id: I41fff78c10d46bde50063536d8cf1a3942dbf6af
Reviewed-on: https://gerrit.libreoffice.org/54834
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
 2018-05-28 09:39:47 +02:00
Eike Rathke 40c9a129e5 Resolves: tdf#117612 truncate DateAdd("m",...) to last day of month 
... instead of resulting in error because of roll-over not being set.

Fallout from

    commit 6d424f0770
    CommitDate: Tue May 2 23:12:34 2017 +0200

        Replace mouth-painted "inaccurate around leap year" rollover algorithm

that does stricter checking but DateAdd() needs a lax checking
with truncate to last day of month.

Change-Id: I9d6f95ad3ac38257d492019bd621070491e98e76
 2018-05-16 11:38:53 +02:00
Noel Grandin 1cb646dc5f loplugin:useuniqueptr in SbiImage 
Change-Id: I24ee5de3628d6436dc045cb543d35b16074ef189
Reviewed-on: https://gerrit.libreoffice.org/53700
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-05-02 08:25:37 +02:00
Noel Grandin fcd589d4f3 loplugin:useuniqueptr pStringOff in SbiImage 
Change-Id: I05de3e910bf857e095c99cade6fec22ccb2dd99d
Reviewed-on: https://gerrit.libreoffice.org/53606
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-04-29 18:22:23 +02:00
Noel Grandin d254f8a926 loplugin:singlevalfields improve unaryoperator 
when we see a unaryoperator, unless it's one of a small set, we can
know (mostly) that the field will not be written.
there is still a small risk of false+ with code taking references
via conditional expressions.

Change-Id: I96fa808067576a50e5eaf425338e225b4e0bdd4e
Reviewed-on: https://gerrit.libreoffice.org/53263
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-04-23 08:16:18 +02:00
Noel Grandin 000fa4c495 loplugin:useuniqueptr in SbiStdObject 
Change-Id: Ic66d817746de423549c87f58068e47f9942d04fd
 2018-01-19 08:58:46 +02:00
Noel Grandin 24cbc7a1fc loplugin:useuniqueptr in SbUnoMethod 
Change-Id: Ibeae1754a18152c3a17379c95e3caa536a8822db
 2018-01-19 08:58:46 +02:00
Noel Grandin 5954878448 loplugin:useuniqueptr in SbiGlobals 
Change-Id: I0ebec3193b4369039f90be4223ebdf6d048b8478
 2018-01-19 08:58:46 +02:00
Stephan Bergmann 6070aaa47d More loplugin:cstylecast: basic 
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: I20b38196ee1b6a34384dc46d9de1b6e1b44947ae
 2018-01-12 20:29:14 +01:00
Noel Grandin 2a421b26c0 loplugin:passstuffbyref improved return in basic,framework 
Change-Id: Ib19836febb59f4e2bb07dc874cfc6baabc653237
Reviewed-on: https://gerrit.libreoffice.org/47065
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-26 19:56:02 +01:00
Noel Grandin c947a25b3a loplugin:countusersofdefaultparams in basctl..basegfx 
Change-Id: I515acfb9de1f6dff1de94a60055c5b600e5e5241
Reviewed-on: https://gerrit.libreoffice.org/45957
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-07 07:19:59 +01:00
Michael Stahl 9f9347c265 basic: SfxLibraryContainer: replace maMutex 
... with cppu::BaseMutex, because a member cannot ensure the life
cycle guarantees expected by WeakComponentImplHelper.

Change-Id: Iaa10c699abf69882d917487740db241ba1455e1c
 2017-12-06 10:03:24 +01:00
Noel Grandin c0ac78c971 loplugin:salcall handle virtual methods 
Change-Id: Iab95db31188ea2914a46d63a7ebef3d825e6ec42
Reviewed-on: https://gerrit.libreoffice.org/45851
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-06 07:42:50 +01:00
Noel Grandin 9a06b99d2f loplugin:salcall fix non-virtual methods 
first, since those are safer to change than virtual methods

Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe
Reviewed-on: https://gerrit.libreoffice.org/45798
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-05 07:32:46 +01:00
Noel Grandin a566fd1c1a loplugin:unusedmethods 
Change-Id: I2efb5c0e5735c179314c6c5de87821cee3b033e1
Reviewed-on: https://gerrit.libreoffice.org/45386
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-29 07:28:57 +01:00
Eike Rathke 4b98e352e5 Make the SbiInstance SvNumberFormatter shared_ptr 
In preparation to get rid of the per call locally created
SvNumberFormatter instances..

Change-Id: Ic7db3bbb655aa18e939f5722964655a20f2eadf2
Reviewed-on: https://gerrit.libreoffice.org/45227
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2017-11-24 21:30:02 +01:00
Caolán McNamara 462866cfdc various coverity warnings 
Change-Id: I27f20c51f86aeaed8e932f7ca45cce8770bc34ec
Reviewed-on: https://gerrit.libreoffice.org/45140
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-23 21:28:47 +01:00
Caolán McNamara 5280b3eaa6 silence some coverity warnings 
Change-Id: I5a530e37156b5cd36e8a07ac20851880a46f520d
Reviewed-on: https://gerrit.libreoffice.org/44875
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-18 21:59:23 +01:00
Noel Grandin 049e026755 loplugin:finalclasses in basic,basegfx 
Change-Id: Iff223782fa0ded0fe46b8b7af35bfd21f331015f
Reviewed-on: https://gerrit.libreoffice.org/44535
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-10 07:44:47 +01:00
Noel Grandin 3dde9d988f loplugin:constparams in various(1) 
Change-Id: Ic80ca59abc3e104c7adf0c1eff1d16addf48bc8b
Reviewed-on: https://gerrit.libreoffice.org/44261
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-04 07:50:01 +01:00
Noel Grandin 5d618d73ed loplugin:constantparam in basic,basctl 
Change-Id: If918c42d4b82d78c07786cfa47c74d0dfb7493d6
Reviewed-on: https://gerrit.libreoffice.org/44131
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-01 07:14:13 +01:00
Stephan Bergmann d4a25418b3 loplugin:includeform: basic 
Change-Id: I6fbba5c4619eec7ae03fed65a18974faa0f190af
 2017-10-23 22:46:13 +02:00
Noel Grandin 87a9979c89 overload std::hash for OUString and OString 
no need to explicitly specify it anymore

Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec
Reviewed-on: https://gerrit.libreoffice.org/43567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-23 08:15:35 +02:00
Mike Kaganski daf7c3e732 basic: consistently use "" and <> in include directives 
Change-Id: I147c0e9b9b1e09af593f54799e45e1348cd40716
Reviewed-on: https://gerrit.libreoffice.org/43298
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-10-10 07:43:46 +02:00
Noel Grandin c8ff3059a7 move all the basic errcodes to one file 
Change-Id: Ic3353c80ac9fdbd17f17503b1c973c9a7cef0c7f
Reviewed-on: https://gerrit.libreoffice.org/41617
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-29 11:50:43 +02:00
Jens Carl b1f6e6299c tdf#39468 Translate German comments/terms 
Change-Id: I3c8d8ba10de007429b1cdf26f5e8b207f7cc5eea
Reviewed-on: https://gerrit.libreoffice.org/41201
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-08-16 14:26:38 +02:00
Noel Grandin 6d829ae4f2 loplugin:constparams in basic 
Change-Id: Idf55f63f2d56be4997a8cdc6afc5690eacac9a60
Reviewed-on: https://gerrit.libreoffice.org/40214
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-20 12:01:08 +02:00
Noel Grandin b0e05f9ade loplugin:useuniqueptr in basic..cppcanvas 
Change-Id: Ib40241eb794607154ae52f8aa68fbf5ea5e944af
Reviewed-on: https://gerrit.libreoffice.org/39551
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-05 11:30:12 +02:00
Stephan Bergmann 56dcc7b65f loplugin:casttovoid in RTLFUNC 
Change-Id: I810278640936e9b3c73f56a37e8c4786fd2790e3
 2017-07-04 08:15:07 +02:00
Stephan Bergmann c8fd385d61 loplugin:casttovoid: basic 
Change-Id: I4e70accf67d4d812b8998b0baa07cd04c27216ad
 2017-07-02 22:35:38 +02:00
Noel Grandin 7b5fac67fd loplugin:unusedfields in accessibility..comphelper 
Change-Id: Ifb68d65fc3e48dd80e3ff2b7a4124468fdda1695
Reviewed-on: https://gerrit.libreoffice.org/39137
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-23 09:01:24 +02:00
Noel Grandin 3059ede409 drop SbError typedef 
in favour of ErrCode.
Part of a larger patch to convert ErrCode to strong_int

Change-Id: Ia846bfc93c58c85c6a6cec79e9d19b9ecbd1c05f
Reviewed-on: https://gerrit.libreoffice.org/38783
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-15 08:25:22 +02:00
Takeshi Abe 514fd7073c basic: Kill unnecessary ifdef stuff 
Change-Id: Id890eb2b7ff2f87005e114dd0fcea0fe3eb81eea
Reviewed-on: https://gerrit.libreoffice.org/37866
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2017-05-22 05:01:57 +02:00