Introduce new helper method MenuBarManager::SetAcceleratorKeys
and call that from both places that are setting accelerator
keys, to deduplicate code and simplify future maintenance.
The use in MenuBarManager::FillMenuManager was introduced in
commit 08fe2669a0
Author: Rüdiger Timm <rt@openoffice.org>
Date: Fri May 13 06:29:54 2005 +0000
INTEGRATION: CWS tbe22 (1.25.30); FILE MERGED
2005/05/04 14:21:00 tbe 1.25.30.1: #i48612# Opening a menu with GOK shows Tips instead of entries (fixed by CD)
and looks like it was primarily copy-pasted from the
other place.
Change-Id: I2097619740d45260e534ce06f9941337177f1bde
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175509
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Move variable/code from the beginning of
MenuBarManager::Activate to where they're actually used,
to increase readability.
Change-Id: I885c6039fd77a023204b60bfc8ef97089d98716a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175508
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
This is in preparation of deduplicating code in an upcoming
commit.
(Use `git show --ignore-space-change` to see the "actual
change" more clearly.)
Change-Id: Ibc9b8d8f77c2b2182c359a287eb604a92ed9c4e2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175507
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Since
commit 2f303d689e
Author: Kurt Zenker <kz@openoffice.org>
Date: Thu Jun 10 12:20:58 2004 +0000
INTEGRATION: CWS fwk02ea (1.6.38); FILE MERGED
V705 It is possible that 'else' block was forgotten or commented out, thus altering the program's operation logics.
Change-Id: Id5a331b0338a38740b5ecf3ad881d7ce4dd6033b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175289
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
If any of the modifier keys are held down while a menu item is selected,
dispatch the modifier keys along with the command.
There is not anything using this yet,
but (in an abandoned patch)
I wanted to let the "Quit" command know if KEY_SHIFT is pressed,
so I can imagine this ability could be very handy elsewhere.
The infrastructure is all there behind the scenes,
just this piece needed to be plugged in.
So instead of abandoning it completely,
let me put this piece in place so it is ready
for the next guy who could use it.
Change-Id: Iff45928872f8958bdb694771cae8dfb347c646ff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171843
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
This may make short lived progress bars somewhat more 'blocky' and less
smooth - but inevitably make loading faster, particularly for loaded
machines with ultra-beautiful, slow to render themed progress-bars.
Change-Id: I5a7e43690f5e7eff35c980cae4991376204eb5fb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171503
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Perhaps for desktop 40 updates per second can provide a nice smooth
status experience for a full screen-width progress bar in some cases;
but it seems likely that five per second over a remote protocol
might be better.
Change-Id: Ic77b3b76d680771cb766984bdbcd9c8af4af303d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171407
Tested-by: Jenkins
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Since commit 26c106a5ae "append '(Remote)'
in the titlebar when remote file is opened", 2015-08-14, the titlebar
shows "(remote)" for documents with non-empty URLs that are not file
scheme.
When recovering a non-existing document, the URL is a factory one like
"private:factory/swriter"; and INetURLObject::GetProtocol() call returns
PrivSoffice.
Indeed, recovery of a non-existing document doesn't make sense itself,
and is fixed by Justin elsewhere; but let's fix the general logic here.
Change-Id: Ibaf095981c37a2fd64f745ad0966465d98a4ed4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/171027
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Add new overloads to OUString methods that have a
"OUString* rest" style parameter.
Instead return a view, which does not require allocation.
To avoid overload ambiguity, split the methods into
different variants that do not use default parameters.
Change-Id: I1aa366115750f1f7ea4fe665804195f59f7c4b69
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167632
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
and
cid#1557287 Use of auto that causes a copy
cid#1558003 Use of auto that causes a copy
cid#1557568 Use of auto that causes a copy
cid#1556546 Use of auto that causes a copy
cid#1557377 Use of auto that causes a copy
cid#1608325 Use of auto that causes a copy
Change-Id: I84e59d2b14bb1e5856f9cac521ad6542b1784243
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170821
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Following
Change-Id: Id48f81deb05aee2026509037f7d14575735e5be0
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Wed Jul 10 14:49:03 2024 +0200
VCLUnoHelper: Align AWT <-> VCL helpers with convert.hxx impl
, port all uses of the helper functions defined in
`include/toolkit/helper/convert.hxx` to use the
`VCLUnoHelper` equivalents instead, to unify usage
and avoid duplication.
Drop `include/toolkit/helper/convert.hxx` now that
it's unused.
Change-Id: I22695a93e40e47bb2b14d191a2e0a4eb7c856895
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/170317
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
found by sed -i -f ref.sed */*.yaml
--------------------ref.sed --------------------
{
N;
N;
N;
s#\([^\n]*\n\)\([^\n]*\)\n\1\2#\1\2#g;
P;
D;
}
------------------------------------------------
meaning: by default it reads in one line from the file
then the 3 N; commands say "add a \n and read in the next line
which leaves a one-line pattern containing 4 lines separated by \n
then search for line1\nline2\n repeated \1\2
and replace with \1\2.
likely nothing has happened, so P; print up to the first \n (aka line1)
so that we don't lose that line
D; delete up to the first \n
so that it isn't in the pattern buffer any more,
and next search starts line2
and then repeat.
Note that the pattern gets rather huge
because while we only remove one line at a time,
we unnecessarily append 3 more lines (instead of just one).
But that doesn't seem to cause the search to fail...
Change-Id: I440bca873483dc7f1716881113807fe121fe6a4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169045
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Reviewed-by: Justin Luth <jluth@mail.com>
This reverts parts of the LO 24.2 patches commited for bug 57414.
There were lots more vocal people than I expected
that want the crash-recovery to restore their session state.
Since there is no working alternative to trigger a session save,
just revert the bits that made the RecoveryList clean
(as I and other users had requested)
and revert back to the original, historic behaviour.
This means that now the following files will again be recovered:
- saved documents (opened from file URL)
- read-only documents (opened from file URL)
- files that were opened, but never modified (opened from file URL)
- files from now-potentially-unavailable disks/servers/temp-dirs
- recovery will attempt to access those file URLs
At least one benefit remains:
- new, unmodified documents will not be in the RecoveryList
Maybe I'll look into a session save option for 25.2.
Change-Id: I2477f194bf94f14620d284728027846ec5b6119e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168650
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
Ports the checkDispatchOfXXX tests including the three database
dependent tests. The other tests in the file will be ported in
another commit, to be merged with this one.
Change-Id: I6bcbcbf91ad4d9cc52c817f4efef9779a17f2198
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168482
Tested-by: Jenkins
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
framework
- Remove CheckXTitle.java from makefiles
- Create new makefile for CheckXTitle
framework qa complex XTitle
- Remove JUnit test
framework qa cppunit
- Add new CppUnit test suit CheckXTitle.cxx
- checkDefaultTitle: tests if default title is the same after cycling through the default window and print preview
- checkTitleDefaultFileName: tests if a window title set with SuggestedSaveAs is in fact set with said name
- setTitleAndCheck: tests if after setting window title and cycling through default window and print preview, there is infinite recursion
Change-Id: If7794f0f853ef427bb735a22752cff3635f5ff63
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/168168
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
The WakeupThread is an attempt to avoid needing to call gettimeofday
and/or update a visual status bar very regularly, and to have a thread
marking the passing of time to emit progress updates infrequently.
Re-factor this to have a single time-keeping thread, so it will be
easier to shutdown and re-start for LOK; and also to simplify some
of the complexity lurking here.
Change-Id: Ia95890e5d6041a029484aa3f7df13b59a0397086
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167949
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins
Michael Weghorn