ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
412,229 Commits 3 Branches 3 Tags
dfaceb70ec2f6feda6a73b8be00a7f168dfe075b
Commit Graph
987 Commits
Author SHA1 Message Date
Noel Grandin 4e70d0b6bf rename SBX errorcodes to BASIC 
Change-Id: Ia6c2d2379a2f6e9b1109e2c04edd5cdd9dcf242f
Reviewed-on: https://gerrit.libreoffice.org/41706
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-29 19:50:11 +02:00
Noel Grandin ae8e1ad2e3 convert code-class in ErrCode to scoped enum 
Change-Id: I9aa8703921308d6fee8bae9ee2d7b29e19181cc7
Reviewed-on: https://gerrit.libreoffice.org/41601
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-27 21:24:16 +02:00
Noel Grandin 9881bea8d4 remove unnecessary use of OUString::getStr 
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4
Reviewed-on: https://gerrit.libreoffice.org/38114
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-17 11:55:13 +02:00
Noel Grandin d347c24036 convert std::map::insert to std::map::emplace 
which is considerably less verbose

Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b
Reviewed-on: https://gerrit.libreoffice.org/40978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-11 12:38:32 +02:00
Andrea Gelmini 35a2d88288 Fix typos 
Change-Id: Ib7f43bf17ab8b9fb9d961a908d7620b50826a975
Reviewed-on: https://gerrit.libreoffice.org/40688
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-08-05 00:32:50 +02:00
Caolán McNamara 13fac4894f normalize resource locale ctor construction mechanisms 
make them all the same and share std::locales more

various OModuleClient, etc, classes go away

Change-Id: I7e3ff01a69332eeacd22e3078f66a60318de62d5
Reviewed-on: https://gerrit.libreoffice.org/40634
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-08-02 10:36:07 +02:00
Caolán McNamara 00657aef09 migrate to boost::gettext 
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl
* all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string")
* ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching
  MODULE .mo files
* UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui
  goes from l10n target to normal one, so the res/lang.zips of UI files go away
* translation via Translation::get(hrc-define-key, imbued-std::locale)
* python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there
  to keep finding the .hrc file uniform) so magic numbers can go away there
* java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation
  mechanism
* en-US res files go away, their strings are now the .hrc keys in the source code
* remaining .res files are replaced by .mo files
* in .res/.ui-lang-zip files, the old scheme missing translations of strings
  results in inserting the english original so something can be found, now the
  standard fallback of using the english original from the source key is used, so
  partial translations shrink dramatically in size
* extract .hrc strings with hrcex which backs onto
   xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap
* extract .ui strings with uiex which backs onto
   xgettext --add-comments --no-wrap
* qtz for gettext translations is generated at runtime as ascii-ified crc32 of
   content + "|" + msgid
* [API CHANGE] remove deprecated binary .res resouce loader related uno apis
      com::sun::star::resource::OfficeResourceLoader
      com::sun::star::resource::XResourceBundleLoader
      com::sun::star::resource::XResourceBundle
    when translating strings via uno apis
      com.sun.star.resource.StringResourceWithLocation
    can continue to be used

Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
 2017-07-21 08:20:50 +01:00
Noel Grandin 6d829ae4f2 loplugin:constparams in basic 
Change-Id: Idf55f63f2d56be4997a8cdc6afc5690eacac9a60
Reviewed-on: https://gerrit.libreoffice.org/40214
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-20 12:01:08 +02:00
Stephan Bergmann 85d71244eb loplugin:oncevar: empty strings: basic 
Change-Id: I4edf130e526c4004aa8913e6aafdcd1e2f4ac1ef
 2017-07-13 11:47:27 +02:00
Noel Grandin 8a75aa52ef use more OUString::operator== in a*..chart2 
Change-Id: Ifb5608abebffd9687ed55e8c74f9be54a749111d
Reviewed-on: https://gerrit.libreoffice.org/39887
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-13 11:02:55 +02:00
Takeshi Abe d64b83b2b0 basic: Put local stuff into unnamed namespace 
Change-Id: Ic8515d04980ee627f964821547fb25d52240e933
Reviewed-on: https://gerrit.libreoffice.org/39681
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2017-07-07 12:15:45 +02:00
Noel Grandin 4b2262ab5b new loplugin unnecessaryparen 
Change-Id: Ic883a07b30069ca6342d7521c8ad890f4326f0ec
Reviewed-on: https://gerrit.libreoffice.org/39549
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-05 11:08:48 +02:00
Stephan Bergmann 56dcc7b65f loplugin:casttovoid in RTLFUNC 
Change-Id: I810278640936e9b3c73f56a37e8c4786fd2790e3
 2017-07-04 08:15:07 +02:00
Stephan Bergmann c8fd385d61 loplugin:casttovoid: basic 
Change-Id: I4e70accf67d4d812b8998b0baa07cd04c27216ad
 2017-07-02 22:35:38 +02:00
Stephan Bergmann b30ae238b4 No reason not to use RTLFUNC here 
Change-Id: I9f01d84b4c518c178220af5cc310a3ba06bdceaa
 2017-06-27 16:34:00 +02:00
Noel Grandin 7b5fac67fd loplugin:unusedfields in accessibility..comphelper 
Change-Id: Ifb68d65fc3e48dd80e3ff2b7a4124468fdda1695
Reviewed-on: https://gerrit.libreoffice.org/39137
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-23 09:01:24 +02:00
Noel Grandin 14c763e793 s/ERRCODE_SBX_OK/ERRCODE_NONE 
adds no value

Change-Id: Iedf7a6a7be28fed4059b576312890be8cbb980d7
Reviewed-on: https://gerrit.libreoffice.org/39056
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-21 20:58:36 +02:00
Noel Grandin 528632660b convert ErrCode to strong typedef 
would have preferred to re-use o3tl::strong_int, of which this
is a modified copy, but there are lots of convenience accessors
which are nice to define on the class.

Change-Id: I301b807aaf02fbced3bf75de1e1692cde6c0340a
Reviewed-on: https://gerrit.libreoffice.org/38497
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-21 08:42:30 +02:00
Noel Grandin 6ee9f2c188 loplugin:oncevar accessibility..basic 
Change-Id: I8fb41b658ef0f6ad1774ea897eace3dc9bb12de6
Reviewed-on: https://gerrit.libreoffice.org/38969
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-20 07:50:06 +02:00
Jochen Nitschke a5dba7dbec remove unused osl/mutex.hxx includes 
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-06-18 13:38:25 +02:00
Noel Grandin 7aee0ea7c5 replace SbxError typedef with ErrCode 
part of a larger patch to convert ErrCode to strong_int

Change-Id: Ia56e5d6d8c4217d6f258e2113d20ce737977892f
Reviewed-on: https://gerrit.libreoffice.org/38813
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-15 09:48:11 +02:00
Noel Grandin 3059ede409 drop SbError typedef 
in favour of ErrCode.
Part of a larger patch to convert ErrCode to strong_int

Change-Id: Ia846bfc93c58c85c6a6cec79e9d19b9ecbd1c05f
Reviewed-on: https://gerrit.libreoffice.org/38783
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-15 08:25:22 +02:00
Noel Grandin a6aa57ff59 use ERRCODE_NONE instead of 0 
peeling off a small chunk of my ErrCode strong_int conversion

Change-Id: Idc89e8496083beed7608cba705cd981139eb7111
Reviewed-on: https://gerrit.libreoffice.org/38777
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-14 15:42:31 +02:00
Jochen Nitschke febbad7263 cleanup unused css/frame/* includes 
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65
Reviewed-on: https://gerrit.libreoffice.org/38633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-12 13:05:38 +02:00
Stephan Bergmann b5594f06c4 Cater for UNO (signed) vs. BASIC (unsigned) byte mismatch 
See <https://listarchives.libreoffice.org/global/users/msg51243.html>
"[libreoffice-users] type byte in Basic", where

> Sub Main
>   dim oOutputStream as variant
>   oOutputStream = createUnoService("com.sun.star.io.SequenceOutputStream")
>   dim nA as byte
>   nA = 195
>   oOutputStream.writeBytes(array(nA))
>   oOutputStream.flush
>   dim back(0) as byte
>   back = oOutputStream.getWrittenBytes
>   MsgBox(back(0))
> End Sub

failed with "Inadmissible value or data type. Overflow." instead of showing
"-61".

Change-Id: I0445476c67510d5f8669a6e711e92332c01ec06c
 2017-06-08 14:48:25 +02:00
Noel Grandin de8caac6be replace SVSTREAM_OK with ERRCODE_NONE 
since the first is #define'd to the second, and offers no extra value

Change-Id: I2c67e09ea3aa5361b8e7dfe7a20858c6ae054450
Reviewed-on: https://gerrit.libreoffice.org/38406
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-06 08:15:57 +02:00
Noel Grandin 17a2c9e8e2 clang-tidy performance-unnecessary-value-param 
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192
Reviewed-on: https://gerrit.libreoffice.org/38400
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-05 09:22:51 +02:00
Jochen Nitschke cae3e20571 cleanup unused css/resource/ includes 
Change-Id: I1e2c795cef64799d5e28e5fafec6cd72f621abba
Reviewed-on: https://gerrit.libreoffice.org/37853
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-20 18:00:42 +02:00
Jochen Nitschke a0b93fe081 cleanup unused css/script/ includes 
but keep exception includes in headers for now

Change-Id: I826828675a2d14b906e57068cbced2e790e12bce
Reviewed-on: https://gerrit.libreoffice.org/37846
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-20 10:23:38 +02:00
Stephan Bergmann f0fddb1d2d loplugin:stringcopy: basic 
Change-Id: I39d8ae76be2794d5e7b5a9979d7211823c995c2c
 2017-05-19 17:19:14 +02:00
Noel Grandin 2e51afc77c loplugin:comparisonwithconstant in basic 
Change-Id: Ie34a17d2fb465ffbe675ba4e99917d23959f1fb5
Reviewed-on: https://gerrit.libreoffice.org/37809
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-19 12:53:34 +02:00
Johnny_M 2c3f58eff2 Translate German comments and debug strings (leftovers in dirs a... to c...) 
Translates all (leftovers) found using a custom regex, in directories not
shown by /bin/find-german-comments and beginning with "a" to "c".

Change-Id: I3b0152ee78ad80a29d714cbd98bf888f31be4763
Reviewed-on: https://gerrit.libreoffice.org/37573
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2017-05-15 15:27:52 +02:00
Noel Grandin 389da66dfc remove unused uno::Reference vars 
found by temporarily marking Reference as SAL_WARN_UNUSED.

Change-Id: I18809b62654467f890016adcc92576980ced393b
Reviewed-on: https://gerrit.libreoffice.org/37511
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-12 09:56:01 +02:00
Takeshi Abe e93cf20603 basic: Compare strings in a case-insensitive manner 
without creating temporary strings.

Change-Id: I8d0e8286089cb78fa9d8612bff6c51f6901637f1
Reviewed-on: https://gerrit.libreoffice.org/37249
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2017-05-10 05:54:25 +02:00
Noel Grandin 12191a4f30 make loplugin constantparam smarter about string params 
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294
Reviewed-on: https://gerrit.libreoffice.org/37426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-09 13:52:30 +02:00
Noel Grandin 4763091bbe loplugin:constantparam 
Change-Id: Ia9500b25602c14aadf49fe373682ae9d87a0a1a2
Reviewed-on: https://gerrit.libreoffice.org/37390
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-09 08:28:04 +02:00
Chris Sherlock 97eb00c75e revert OSL_ASSERT changes 
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
 2017-05-07 17:03:35 +10:00
Chris Sherlock 6b3b0b85f9 tdf#43157: convert basic module away from OSL_ASSERT to assert 
Change-Id: Idfd05d410ad3d76c3699492d98e1284a21f5f7d6
 2017-05-07 09:29:23 +10:00
Stephan Bergmann f06e696723 loplugin:salunicodeliteral: basic 
Change-Id: I479666b439f1d6324f07253d65181983b7c2c3ea
 2017-04-28 18:27:01 +02:00
Noel Grandin 2762ee5fe3 explicitly defining __RSC is no longer necessary 
since commit 6b448d3634
   "make __RSC a builtin define for the RSC compiler"

Change-Id: I99af239993c3217bf528f5595def0c2de337f01b
Reviewed-on: https://gerrit.libreoffice.org/37025
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-27 16:13:06 +02:00
Chris Sherlock f9f045e783 tools: move errcode.hxx to the vcl module 
Change-Id: I17e5a033de5f0aeb0a726744f7b464cdab6e2ee3
Reviewed-on: https://gerrit.libreoffice.org/36854
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2017-04-27 10:38:35 +02:00
Chris Sherlock 3b85b72d64 errinf.hxx moved out of tools and into vcl module 
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more
appropriate to have it reside in the VCL module.

Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650
Reviewed-on: https://gerrit.libreoffice.org/36839
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2017-04-25 10:55:17 +02:00
Noel Grandin 6b448d3634 make __RSC a builtin define for the RSC compiler 
instead of randomly defining it in only some of .src files

Change-Id: Ifec3920740723d248400f451d717b5288c421b8d
Reviewed-on: https://gerrit.libreoffice.org/36832
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-25 10:04:53 +02:00
Arnaud Versini f747797772 BASIC: Call OUString() instead of OUString(""); 
Change-Id: Ie68d48a5dd0fd3593054e853f179db9a4be03b24
Reviewed-on: https://gerrit.libreoffice.org/36831
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
 2017-04-24 15:01:32 +02:00
Noel Grandin 1c5cae479b loplugin:unusedmethods 
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672
Reviewed-on: https://gerrit.libreoffice.org/36718
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-20 10:07:10 +02:00
Noel Grandin 8fced917aa clang-tidy readability-simplify-boolean-expr in accessibility..cui 
Change-Id: Iae27da322c6ede592e6b268fb2210d3525ed22cc
Reviewed-on: https://gerrit.libreoffice.org/36677
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-19 14:38:35 +02:00
Noel Grandin 0514442730 no need to use OUStringToOString in SAL_INFO 
Change-Id: I707e0d72aba89b7e644def6f4c251e14f6599ad2
Reviewed-on: https://gerrit.libreoffice.org/36451
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-12 12:49:25 +02:00
Andrea Gelmini 7d4b68fa47 Fix typos 
Change-Id: I9e7f7fa6a8b89304883a843f9fb0b905f5e8a8a4
Reviewed-on: https://gerrit.libreoffice.org/36100
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-04-06 07:53:19 +00:00
Noel Grandin ff339c89b5 loplugin:constantparam part2 
Change-Id: I7ec4c946be52a6b56aee908426f95ecacc7b0746
Reviewed-on: https://gerrit.libreoffice.org/36072
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-05 06:42:40 +00:00
Jochen Nitschke da56de9ac4 remove type decorations on char literals 
they are only needed where type deduction fails.
left them in defines for now.

Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09
Reviewed-on: https://gerrit.libreoffice.org/35893
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-03-30 12:21:40 +00:00