Takeshi Abe
7640e244db
tdf#88206 replace cppu::WeakImplHelper* etc.
...
with the variadic variants, in basic.
Change-Id: I13c5644bd6b9e964e42a98bee9c3019d959efb36
Reviewed-on: https://gerrit.libreoffice.org/16719
Reviewed-by: Noel Grandin <noelgrandin@gmail.com >
Tested-by: Noel Grandin <noelgrandin@gmail.com >
2015-07-06 07:28:21 +00:00
Andrea Gelmini
ffa8892c5a
Fix typos
...
Change-Id: I75b4ad61785bf0ba1cb07735d938c0977356b8cc
Reviewed-on: https://gerrit.libreoffice.org/16705
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com >
2015-07-04 10:23:17 +00:00
Miklos Vajna
2e7fe50874
error: 'pGen' was not declared in this scope
...
Change-Id: I6ebf100be3a90b315491e2735da9c82e5901fc59
2015-07-02 10:24:59 +02:00
Arnaud Versini
fabe329412
BASIC : Remove SbCodeGen attribute from SbiExprNode and user std::unique_ptr.
...
Change-Id: I9f44f6a4b61987de960b77f54bac8cf2c981bd2a
Reviewed-on: https://gerrit.libreoffice.org/16551
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: David Tardon <dtardon@redhat.com >
2015-07-02 07:43:03 +00:00
Caolán McNamara
50bd0c8573
coverity#1308521 Uncaught exception
...
Change-Id: I6a189e0d1c4eb04e727fdf12585d46a1f4121f68
2015-06-28 17:55:52 +01:00
Andrea Gelmini
5d5dc059cb
Fix typos
...
Change-Id: I80995af6459af9f647e66d1c85da2eedad2647b9
Reviewed-on: https://gerrit.libreoffice.org/16523
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
2015-06-28 12:35:58 +00:00
Andrea Gelmini
69c88a32aa
Fix typos
...
Change-Id: Ifd126a535f18db79a18aaec61b76cdf26ab33dff
Reviewed-on: https://gerrit.libreoffice.org/16522
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2015-06-28 12:28:31 +00:00
Caolán McNamara
cfbbb3ca5d
coverity#1308445 Uncaught exception
...
Change-Id: I831637f7f2fb2c552de8c20dc9f5da4e8783b935
2015-06-27 18:24:57 +01:00
Caolán McNamara
232db3f79c
coverity#1308444 Uncaught exception
...
Change-Id: I103965dfb3e19964e58b3ca4ef34dcee2141d882
2015-06-27 18:24:57 +01:00
Caolán McNamara
25b665a2f3
coverity#1308435 Uncaught exception
...
Change-Id: I8d4ba326e94565bc1ae8b57e406883f737049aea
2015-06-27 14:42:20 +01:00
Stephan Bergmann
687ab37853
loplugin:stringconstant: Flag more inefficiencies
...
Change-Id: Ie6ca3065ee60fb2ad75f3bab53059046a981da8d
2015-06-25 12:38:33 +02:00
Stephan Bergmann
892455e72a
Simplify uses of comphelper::string::equals with constant argument
...
Change-Id: I7b12dd04f6811f71b776ee9168703434217b59c8
2015-06-24 15:27:28 +02:00
Noel Grandin
07d85c4499
remove SFX_NOTIFY macro
...
it has not served any purpose since we switched to using normal C++ RTTI
for the SfxHint objects
Change-Id: Ic81353bcb7863ce892eb75296248ca14d8fd6c86
2015-06-24 12:06:34 +02:00
Takeshi Abe
0980095619
Replace boost::scoped_array<T> with std::unique_ptr<T[]>
...
This may reduce some degree of dependency on boost.
Done by running a script like:
git grep -l '#include *.boost/scoped_array.hpp.' \
| xargs sed -i -e 's@#include *.boost/scoped_array.hpp.@#include <memory>@'
git grep -l '\(boost::\)\?scoped_array<\([^<>]*\)>' \
| xargs sed -i -e 's/\(boost::\)\?scoped_array<\([^<>]*\)>/std::unique_ptr<\2[]>/'
... and then killing duplicate or unnecessary includes,
while changing manually
m_xOutlineStylesCandidates in xmloff/source/text/txtimp.cxx,
extensions/source/ole/unoconversionutilities.hxx, and
extensions/source/ole/oleobjw.cxx.
Change-Id: I3955ed3ad99b94499a7bd0e6e3a09078771f9bfd
Reviewed-on: https://gerrit.libreoffice.org/16289
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-06-17 15:50:45 +00:00
Andrea Gelmini
f378e723d2
Fix typos
...
Change-Id: I528752dfabeb31d14c350f79819b521537ab9b56
Reviewed-on: https://gerrit.libreoffice.org/16300
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-06-16 11:14:55 +00:00
Andrea Gelmini
ca9de688c2
Fix typos
...
Change-Id: I549635318f46718042e50c8f89ce3c620cade990
Reviewed-on: https://gerrit.libreoffice.org/16281
Reviewed-by: Michael Stahl <mstahl@redhat.com >
Tested-by: Michael Stahl <mstahl@redhat.com >
2015-06-16 11:10:51 +00:00
Noel Grandin
4ea281a3cc
cppcheck:redundantAssignment
...
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
2015-06-15 13:34:14 +02:00
Noel Grandin
5a2e09989a
cppcheck:redundantCondition
...
Change-Id: Ib8b6342d1da526df6104125ded546b3f053c448b
2015-06-15 11:56:55 +02:00
Julien Nabet
b226928c6d
cppcheck: redundantCondition [part1]
...
Change-Id: I21c5340e7b5ec09248b08aa76f43acf883c56cd8
2015-06-14 12:17:55 +02:00
Arnaud Versini
0766db041e
BASIC: Don't use SbiStringPool to pass SbiParser.
...
Change-Id: I15949e604285d804de1554d36acf36e8a407ebd9
Reviewed-on: https://gerrit.libreoffice.org/16137
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org >
2015-06-13 11:53:03 +00:00
Julien Nabet
3754474cde
Typos
...
Change-Id: I21c352a63d668c174eef212dbfbe6346c678ce4d
2015-06-13 09:13:52 +02:00
Caolán McNamara
cc0e9a37de
cppcheck: variableScope
...
Change-Id: If0c56c89e2722d47a401363f3854331229856490
2015-06-09 10:33:59 +01:00
Stephan Bergmann
761e0ae0a7
loplugin:cstylecast: deal with remaining pointer casts
...
Change-Id: I8bce930283301130ec7a2b1eab2a2c8f65c8abf9
2015-06-08 16:23:17 +02:00
Noel Grandin
3f72218069
Apply new VclPtr clang plugin to catch potential problems.
...
Omit the plugin, and sw's FrameControlsManager for now.
Change-Id: Ifb98a2e6e03a9d099efc1668305b96bd9142ca5f
Reviewed-on: https://gerrit.libreoffice.org/16117
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
Tested-by: Michael Meeks <michael.meeks@collabora.com >
2015-06-06 20:26:54 +00:00
Noel Grandin
623445aa0e
convert PropertyMode to scoped enum
...
Change-Id: I9b0bbf6273aa18ae918d1d69af5dcc7652181f5c
2015-06-04 08:30:24 +02:00
Stephan Bergmann
b000faba86
loplugin:cstylecast: deal with those that are (technically) const_cast
...
Change-Id: I1788ad7d9f9dec892b31a0610d0f44ae1ccd2e64
2015-06-02 11:25:21 +02:00
Caolán McNamara
8e22cd40ec
cppcheck: noExplicitConstructor
...
Change-Id: I8ae8623252546ca94f65fc04b331dd9cafa4fc92
2015-06-02 08:57:56 +01:00
Michael Meeks
ba81e5c6bd
tdf#91702 - fix stack-based MessBox allocation.
...
Change-Id: I62dd164e281911d9db3de453789a5badc7cd5fd7
Reviewed-on: https://gerrit.libreoffice.org/15954
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
Tested-by: Michael Meeks <michael.meeks@collabora.com >
2015-05-29 12:16:28 +00:00
Noel Grandin
afcf1ecee1
loplugin:loopvartoosmall
...
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
2015-05-29 08:48:41 +02:00
Philippe Jung
1379e2feaa
Rewrite all calls like Dialog(params).Execute()
...
Replace all calls looking like
ADialog(some params).Execute()
by
ScopedVclPtrInstance<ADialog>::Create(some parms)->Execute()
Change-Id: I0b6f0a9ea5ef0a749ffa30ce131e9dc989604639
Reviewed-on: https://gerrit.libreoffice.org/15915
Tested-by: Jenkins <ci@libreoffice.org >
Tested-by: Michael Meeks <michael.meeks@collabora.com >
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
2015-05-28 08:44:31 +00:00
Arnaud Versini
563a3935b8
BASIC: Remove BasicCharClass::IsLetterTab
...
Change-Id: Ib6a13cb7a5725d451c0f8d64c2c543a8a9ec2ad0
Reviewed-on: https://gerrit.libreoffice.org/15876
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: David Tardon <dtardon@redhat.com >
2015-05-26 08:46:32 +00:00
Arnaud Versini
6a4a55d5f4
BASIC: User std::unique_ptr in basic runtime
...
Change-Id: Iac7efdad78cf2f827cbddbc671dd0d1b5ae1d467
Reviewed-on: https://gerrit.libreoffice.org/15874
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-05-26 08:13:35 +00:00
Julien Nabet
4d9595637c
Wrong comment since 642cfe8ac2
...
nEndPos is in fact sal_uInt32 type
Change-Id: I434564eebff2138709807676ae855a8f487f4c09
2015-05-23 16:53:57 +02:00
Michael Stahl
564fc48393
tdf#90110: basic: fix Randomize statement
...
- time() is used to seed the RNG but since it only has second resolution,
the same values will be generated if it's called multiple times like
in the bug report
- BASIC using the global rng would be fine except that BASIC Randomize
takes an optional parameter to set the seed, which should continue
to be supported, but should not affect the RNG state for non-BASIC
users of comphelper::random
(regression from df466d79cb ,
but the old implementation was even more delightfully absurd,
where Randomize was essentially srand((sal_uInt16)rand()) ...)
Change-Id: I0f30e509de08f933c02ac77c5d932b20e79586c5
2015-05-19 22:02:41 +02:00
Noel Grandin
ae451af87d
basic: used typed LINKs
...
Change-Id: I8770a782e7ff5529e30aee13558711bdd8a4070d
2015-05-19 11:10:54 +02:00
Caolán McNamara
36b06104f7
missing semi
...
Change-Id: I3253f09d10cbe733fdf6387d90ab04d65ba9328e
2015-05-18 17:21:13 +01:00
Caolán McNamara
4b5091cfd7
cppunit: noExplicitConstructor
...
Change-Id: Iaf1387ea236bf3a5db9b2165d5b827dbdcf95207
2015-05-18 17:14:15 +01:00
Julien Nabet
3aebc670e1
Remove include stdio (part2)
...
Change-Id: Iae58d107d8df1c543a165086fb2b7c288e7121dd
Reviewed-on: https://gerrit.libreoffice.org/15775
Reviewed-by: Julien Nabet <serval2412@yahoo.fr >
Tested-by: Julien Nabet <serval2412@yahoo.fr >
2015-05-18 05:33:52 +00:00
Noel Grandin
539ba642d7
remove unnecessary header file
...
Change-Id: I3b86a54a773341be7e7e69e88c59dc531ea49c5b
2015-05-17 10:08:59 +02:00
Andrea Gelmini
5b1337f7b2
tdf#62475: partial handmade fixes
...
Change-Id: Ib9af202c43b916b9af4b4e18db35d470a8692fe4
Reviewed-on: https://gerrit.libreoffice.org/15712
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com >
2015-05-15 17:55:15 +00:00
Philippe Jung
2bb4d6cad4
Missing disposeAndClear in MsgBox basic function
...
Change-Id: Ida3d792a6f3797a6173b31b86a49b72ad7353340
Reviewed-on: https://gerrit.libreoffice.org/15717
Reviewed-by: Michael Meeks <michael.meeks@collabora.com >
Tested-by: Michael Meeks <michael.meeks@collabora.com >
2015-05-12 14:03:35 +00:00
Michael Stahl
be88e305ee
tdf#90969: basic: add horrible hack to avoid crash due to ...
...
... the stupid global variable GaDocBasicItems.
Change-Id: Ib849e0e2b661e54005d00091f6d6fc474dc5549b
2015-05-12 14:15:24 +02:00
Arnaud Versini
7ff58e1a89
Basic: Doesn't allow non ASCII characters in numeric literals
...
Change-Id: I8b7755dbea56953a04cd7687181ec246fc680c43
Reviewed-on: https://gerrit.libreoffice.org/14691
Tested-by: Jenkins <ci@libreoffice.org >
Reviewed-by: Caolán McNamara <caolanm@redhat.com >
Tested-by: Caolán McNamara <caolanm@redhat.com >
2015-05-12 09:25:18 +00:00
Stephan Bergmann
ef6877c167
loplugin:cstylecast: nop between pointer types of exactly same spelling
...
Change-Id: I1e4363f917a978434fb11368918435da12531dc6
2015-05-11 12:49:03 +02:00
Stephan Bergmann
9bb254fc85
NOINSTANCE is implied now in IMPL_STATIC_LINK...
...
Change-Id: Ifb032457d6c1b279c4183282ef2b271c706dd71a
2015-05-10 11:25:47 +02:00
Stephan Bergmann
5eb6bd4db7
lopluign:staticmethods: Handle DECL_LINK
...
Change-Id: Ib27854a8470f3ff5b208cb949a7bd02f2a86c969
2015-05-08 19:15:32 +02:00
Stephan Bergmann
0241519f32
Unwind SotStorageStreamRef typedef
...
Change-Id: If7652a7c0251b741660365848a717c06954ca419
2015-05-07 11:05:04 +02:00
Stephan Bergmann
dc47b2e513
Unwind SotStorageRef typedef
...
Change-Id: I8d5363bb2ad813ef29b4078848914f4b0989b9f1
2015-05-07 11:05:04 +02:00
Julien Nabet
0f79a5ff07
tdf#84435: Mod operator does not deal with decimals as described in help
...
Change-Id: I8dbfdf4bb2eceac0b5afbddd3f35e1dcde2db68b
Reviewed-on: https://gerrit.libreoffice.org/14611
Reviewed-by: Eike Rathke <erack@redhat.com >
Tested-by: Eike Rathke <erack@redhat.com >
2015-04-30 14:27:06 +00:00
Stephan Bergmann
3ead3ad52f
Gradually typed Link
...
Turn the Link class into a template abstracting over the link's argument and
return types, but provide default template arguments that keep the generic,
unsafe "void* in, sal_IntPtr out" behvior. That way, individual uses of the
Link class can be updated over time.
All the related macros are duplicated with ..._TYPED counterparts, that
additionally take the RetType (except for LINK_TYPED, which manages to infer the
relevant types from the supplied Member).
(It would have been attractive to change the "untyped" LinkStubs from taking a
void* to a properly typed ArgType parameter, too, but that would cause
-fsanitize=function to flag uses of "untyped" Link::Call.)
Change-Id: I3b0140378bad99abbf240140ebb4a46a05d2d2f8
2015-04-30 10:20:00 +02:00