Commit Graph
235 Commits
Author SHA1 Message Date
Stephan Bergmann 59a63d8161 In Java, css.uno.RuntimeException doesn't derive from css.uno.Exception
Change-Id: I83850db6e3f3ac87d52e75f122ba2b6bba3905b9
2017-02-23 11:43:22 +01:00
nadith 71901bfedd tdf#98004 - Enhansment on Editor(Beanshell)
Add a toolbar A little enhasment for the editor has been done.
Added a toolbar for set of buttons that was previously in a JPanel
and now it is in Jtoolbar in the editor

Change-Id: Ie04232e7824c051f272d69cc109eec0e70ccf921
Reviewed-on: https://gerrit.libreoffice.org/29806
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-16 12:46:15 +00:00
Caolán McNamara cae57d2e58 ClassLoader->URLClassLoader
Change-Id: I1f46a99025ba33d08842da9b06611dcfa6b1b49c
Reviewed-on: https://gerrit.libreoffice.org/29474
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-10-03 12:09:23 +00:00
Caolán McNamara d02941ebdb Revert "coverity#1371372 Resource leak on an exceptional path"
seeing as it doesn't build universally, java 1.7 onwards
apparently

This reverts commit 6830d8c208.
2016-08-19 14:09:38 +01:00
Caolán McNamara 6830d8c208 coverity#1371372 Resource leak on an exceptional path
and

coverity#1371366 Resource leak on an exceptional path
coverity#1371376 Resource leak on an exceptional path

Change-Id: Ic0fd05f02b1d78a47d4ee924dee8f10811586d0d
2016-08-19 13:00:44 +01:00
Caolán McNamara 21b0cbfdc5 coverity#1371367 Resource leak on an exceptional path
Change-Id: I4da5f6d427e8132d62860b46cb4def88b8afb25d
2016-08-19 13:00:44 +01:00
Noel Grandin 5f42a268c3 remove unused imports in java code
Change-Id: I95041f49dd22ba9a15da3598b04a010eecf761a8
2016-06-06 14:28:41 +02:00
Caolán McNamara 49cdc1da76 coverity#1361587 Dereference null return value
and

coverity#1361588 Dereference null return value

Change-Id: Ia282c37e94d9d4131d18b3ccf6a8b7cb12c12344
2016-05-15 12:47:48 +01:00
Douglas Mencken 60286229fa scripting: JDK 1.5 compatibility: don't use java.awt.Font.MONOSPACED
MONOSPACED is defined in java/awt/Font.java as
/* @since 1.6 */ static final String  MONOSPACED = "Monospaced";

Change-Id: I31847c939387c139971ff55f786773c7ce51448c
Reviewed-on: https://gerrit.libreoffice.org/23164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-03-14 09:08:38 +00:00
Caolán McNamara 3029afd738 coverity#1354272 SS: Unread field should be static
Change-Id: Ie9480265be8053805cb48cefe189e65a47ce0908
2016-02-25 20:29:20 +00:00
Chirag Manwani 1b287f14b2 tdf#98004 Added toolbar to beanshell editor with undo/redo buttons
Change-Id: I1d553473f34622e1cb1dab3ffe74ec0c5fa05605
Reviewed-on: https://gerrit.libreoffice.org/22612
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-22 12:29:39 +00:00
Chirag Manwani 03a5995ab0 tdf#97636 Added Undo/Redo functionality to Beanshell Editor
Change-Id: Ie24f7bb5e59cd78ba2d06a4ed1b6a0bcaf1a3736
Reviewed-on: https://gerrit.libreoffice.org/22500
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-21 07:16:23 +00:00
Caolán McNamara 5750444aff coverity#1326437 Dereference null return value
Change-Id: I9fe5f799b7b47d8dc1fd34893c392fcecef5b5a4
2016-02-18 17:21:18 +00:00
Chirag Manwani bc9ff64c40 tdf#97637 Fixed Tab size of beanshell editor to 4
Change-Id: Ifeb73ab210d9d955e502fab3e3ec993081625945
Reviewed-on: https://gerrit.libreoffice.org/22473
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-18 16:18:04 +00:00
Chirag Manwani 9046ce5cb9 tdf#97642 Use native theming for swing controls in Beanshell Editor
Change-Id: Ifb2f3cfe5132e9b6f7d5d2df5868b09b39c5ec47
Reviewed-on: https://gerrit.libreoffice.org/22429
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-18 04:31:39 +00:00
Chirag Manwani 38969497cb tdf#97640 Fixed-Width Font for Beanshell Editor
Change-Id: I809253a4f0481c825368d9c608cac77e64376aa0
Reviewed-on: https://gerrit.libreoffice.org/22404
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-17 07:34:11 +00:00
Caolán McNamara e384e3851d coverity#1326200 Explicit null dereferenced
Change-Id: I39ed18b55657e375b1c22f97c49a0e43aedce4f5
2016-02-16 09:50:16 +00:00
Caolán McNamara 84d126c6b6 coverity#1326199 Explicit null dereferenced
extensionDb is always the same

Change-Id: I57b59f09b3f55757844a6aab6c6698857da2e15b
2016-02-16 09:50:16 +00:00
Caolán McNamara b3e0bd62f5 coverity#1326399 Dereference null return value
Change-Id: I7828cdfcda5d4065fc3dafee744757292753abb5
2016-02-04 15:47:11 +00:00
Caolán McNamara 9b6cc4f409 coverity#1326631 DE: Dropped or ignored exception
Change-Id: If1f4f46ba51360eff3537f6804286adfe16c4a0e
2016-02-04 10:46:08 +00:00
Caolán McNamara bd5bc033fd coverity#1326630 DE: Dropped or ignored exception
Change-Id: I495c1b5d9d0e03a92330fe6b9371183471aee7bb
2016-02-04 10:46:08 +00:00
Caolán McNamara a7cf2bc5fc coverity#1326629 DE: Dropped or ignored exception
Change-Id: Ifb82c92eb0eaa019a19deee3dce375204576e2ee
2016-02-04 10:46:08 +00:00
Andrea Gelmini 64d624b651 Fix typos
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10 14:17:20 +00:00
Noel Grandin b5df54c5bc java: add some @Override annotations
Change-Id: I291db1dff5ab3ce40fda6f822a0e3ff1e6ef36c1
Reviewed-on: https://gerrit.libreoffice.org/19855
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-09 11:14:56 +00:00
Caolán McNamara 2f9bd9ac4d cid#1326721 to cid#1326726 Dm: Dubious method used
Change-Id: I5578dc3885945c013064cecf2ca86e7ca734368f
2015-10-25 15:41:02 +00:00
Caolán McNamara e9fc41292b Revert "coverity#1327168 see if stock SuppressWarnings is sufficient to"
that didn't work

This reverts commit 04a7df738a.

Change-Id: I5e4dfc28c03668eebb0fe8056beede7ef0b05ee5
2015-10-20 21:18:31 +01:00
Noel Grandin a2fa0ded8a cid#1326721 to cid#1326726 Dm: Dubious method used
Change-Id: I98e5590f61434ed1b1081b5b592622f9bcf037ec
2015-10-16 12:50:49 +02:00
Caolán McNamara 04a7df738a coverity#1327168 see if stock SuppressWarnings is sufficient to
silence UrF: Unread field, some sources online suggest that it
might be the case

Change-Id: I2287da343e97bec93e0aaf7a82a408c18ab76d9b
Reviewed-on: https://gerrit.libreoffice.org/19396
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-10-15 15:59:27 +00:00
Noel Grandin a1624a8ecd cid#1327023 to cid#1327077 SIC: Inner class could be made static
Change-Id: I41f89c4feefe4e012d72c663ebb9bbcb4aa7f163
2015-10-15 09:23:16 +02:00
Noel Grandin 3cc4b81b76 java:using "this" with a static field makes no sense
Change-Id: I79a38ff2ec50d3a3687cac7ed7688bbbcaf2208c
2015-10-14 16:07:50 +02:00
Noel Grandin fb451a14c0 cid#1326674 DLS: Dead local store
Change-Id: I8168d3703022c9a1baed6e82c43a04ffa0ca52c0
2015-10-14 12:05:51 +02:00
Noel Grandin 0c18bedb73 java: 'final static' to 'static final'
this is the canonical order, and it makes the code easier to read

Change-Id: I272e7f1e140296e582702b6dbf77a03eefb65470
Reviewed-on: https://gerrit.libreoffice.org/16242
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-06-15 08:45:19 +00:00
Noel Grandin efd4bfa818 java:regulatize the order of 'final' and public/private
Make the order be 'public static' or 'private static'
Just makes the code nicer to read.

Change-Id: I182424bda45a2d68642e5d04c6091d268ace1fe2
Reviewed-on: https://gerrit.libreoffice.org/16202
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-11 09:34:00 +00:00
Stephan Bergmann 3099c70b11 Fix various XServiceInfo implementations
...to match what is recorded in the .component files

Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
Stephan Bergmann 3336a5071b rhbz#1192732: Revert "From the context of the code, this field should...
...not be static."  This reverts commit
6d4c1f0d4a.  Whatever made the author of that
commit think rhinoWindow shouldn't be static, it clearly needs to be, as in
edit()'s Runnable.run(), the usage of rhinoWindow at the end relies on
rhinoWindow being set via the

  new ScriptEditorForJavaScript(context, url)

call to initUI() (or else rhinoWindow already being set from a previous such
call if already editor != null).
2015-02-16 10:45:50 +01:00
Noel Grandin 3ab2d3a2c5 fdo#88256 fix crash when running javascript macro
caused by my commit 8583da1e93
"java: remove unused fields"

Change-Id: Ibcd6462e8229a0a6cb98ebfd16ce5d2ea45ca931
2015-01-13 10:38:48 +02:00
Noel Grandin 7d812b09b5 java: unused imports
Change-Id: I05824a6f19a5f3048a52101b96f6bf3d3099df08
Reviewed-on: https://gerrit.libreoffice.org/13403
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-10 08:03:50 +00:00
Noel Grandin c199b76d88 java: remove some unused local variables
Change-Id: Ia01528460e2f4b610d123e29cad66520abc6a965
2014-12-05 11:15:57 +02:00
Noel Grandin 0063cf2856 java: make fields final where possible
found by PMD

Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
2014-11-18 12:44:28 +02:00
Robert Antoni Buj i Gelonch 2a0569b53d scripting: redundant cast to String
Change-Id: I5e048964cc7885a32c59ff8a9eb1fc5b9523e843
Reviewed-on: https://gerrit.libreoffice.org/11859
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-19 10:12:55 +00:00
Noel Grandin 93056481e8 java: when rethrowing exceptions, store the original
Change-Id: I8a2a264597d0b1ae06b08136fea36003682380b5
2014-10-17 08:26:22 +02:00
Noel Grandin 03c7c26cbe java: final fields that can be static
Change-Id: I8c06be7bc0b8a38c662209f0de72a00550e25447
2014-10-17 08:26:21 +02:00
Noel Grandin 12b01b920f java: no need to call String.valueOf to append to a String
Change-Id: I5ef45b971d24dde814ab8cbb2e9503d9da4f0d73
2014-10-17 08:26:19 +02:00
Noel Grandin b2f69f6264 java: when rethrowing, store the original exception
Change-Id: I14666493e72da177fcfff1895ef3206f0e13cc01
2014-10-16 12:27:14 +02:00
Robert Antoni Buj i Gelonch 791ed2c654 scripting: use new exception constructors
Change-Id: I7eeece85d4e462bf2df010ee29c062941a677759
Reviewed-on: https://gerrit.libreoffice.org/11966
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-14 12:28:37 +00:00
Robert Antoni Buj i Gelonch b862f6e923 scripting: Null pointer dereference
Change-Id: I0d72ef34945065f68e9af8b0957dc440a74c14ce
Reviewed-on: https://gerrit.libreoffice.org/11923
Reviewed-by: Matthew Francis <mjay.francis@gmail.com>
Tested-by: Matthew Francis <mjay.francis@gmail.com>
2014-10-13 17:18:54 +00:00
Robert Antoni Buj i Gelonch e41597eade scripting: line break (code formatting)
Change-Id: Ib1a8d7e4bdaad2f4eae822d9af280fd5b6f9dd7b
Reviewed-on: https://gerrit.libreoffice.org/11794
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-10-06 14:10:27 +00:00
Robert Antoni Buj i Gelonch 4a0fc2fb02 scripting: organize imports
Change-Id: I26a1164d44f464a44ed7deb93ac39465feb0541c
Reviewed-on: https://gerrit.libreoffice.org/11768
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-03 05:25:06 +00:00
Robert Antoni Buj i Gelonch 6f42a71439 scripting: Format_java_code.sh initial run
Conflicts:
	scripting/java/com/sun/star/script/framework/io/UCBStreamHandler.java

Change-Id: I09b94d8c96dfbaf498bd93a0088feb80a9e4afb6
2014-10-02 15:25:29 +02:00
Stephan Bergmann 27d5b5c6dd BRAND_BIN_SUBDIR -> BRAND_INI_DIR, to cater for new Mac OS X layout
Change-Id: Ic367545895a25a4cf6e95fc1be2f5db9f36a221b
2014-09-17 11:45:14 +02:00