ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
493,216 Commits 3 Branches 3 Tags
ca1c8b447110321664a7a385dda5af6e303a91c8
Commit Graph
1665 Commits
Author SHA1 Message Date
Caolán McNamara ca1c8b4471 we don't need the reg or store libraries for fuzzing 
possibly other configations too, but just for fuzzing for the moment

from looking at:
https://oss-fuzz.com/coverage-report/job/libfuzzer_asan_libreoffice/latest
and see what is built but is 0% coverage and uninteresting to be non-0

Change-Id: Ia7afdfc033dd8a705d85c76b246dc5dfb259b063
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163311
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2024-02-13 17:27:34 +01:00
Mike Kaganski 0fa827dbb2 Drop std::as_const from css::uno::Sequence iterations 
Obsoleted by commit 2484de6728 (Remove
non-const Sequence::begin()/end() in internal code, 2021-10-15) and
commit fb3c04bd19 (Drop non-const
Sequence::operator[] in internal code, 2021-11-05).

Change-Id: Idbafef5d34c0d4771cbbf75b9db9712e504164cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162640
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2024-01-27 12:43:48 +01:00
Noel Grandin 5f9da6e0ee improve loplugin:cow_wrapper 
some stuff was hiding inside templates

Change-Id: I89fd1a926dd6bf96e35a74e5028165acae51c60c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162159
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2024-01-16 13:20:10 +01:00
Caolán McNamara 283aa103b9 cid#1545177 COPY_INSTEAD_OF_MOVE 
and

cid#1545179 COPY_INSTEAD_OF_MOVE
cid#1545187 COPY_INSTEAD_OF_MOVE
cid#1545188 COPY_INSTEAD_OF_MOVE
cid#1545189 COPY_INSTEAD_OF_MOVE
cid#1545196 COPY_INSTEAD_OF_MOVE
cid#1545197 COPY_INSTEAD_OF_MOVE
cid#1545204 COPY_INSTEAD_OF_MOVE
cid#1545223 COPY_INSTEAD_OF_MOVE
cid#1545236 COPY_INSTEAD_OF_MOVE
cid#1545239 COPY_INSTEAD_OF_MOVE
cid#1545253 COPY_INSTEAD_OF_MOVE
cid#1545274 COPY_INSTEAD_OF_MOVE
cid#1545286 COPY_INSTEAD_OF_MOVE
cid#1545309 COPY_INSTEAD_OF_MOVE
cid#1545311 COPY_INSTEAD_OF_MOVE
cid#1545345 COPY_INSTEAD_OF_MOVE
cid#1545358 COPY_INSTEAD_OF_MOVE
cid#1545361 COPY_INSTEAD_OF_MOVE
cid#1545365 COPY_INSTEAD_OF_MOVE
cid#1545367 COPY_INSTEAD_OF_MOVE
cid#1545372 COPY_INSTEAD_OF_MOVE
cid#1545373 COPY_INSTEAD_OF_MOVE
cid#1545377 COPY_INSTEAD_OF_MOVE
cid#1545392 COPY_INSTEAD_OF_MOVE
cid#1545399 COPY_INSTEAD_OF_MOVE
cid#1545404 COPY_INSTEAD_OF_MOVE
cid#1545408 COPY_INSTEAD_OF_MOVE
cid#1545430 COPY_INSTEAD_OF_MOVE
cid#1545439 COPY_INSTEAD_OF_MOVE
cid#1545449 COPY_INSTEAD_OF_MOVE

Change-Id: I3afe836a0bbc8bd70937035e60eb020435e413d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160539
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2023-12-10 17:41:18 +01:00
Stephan Bergmann 15b86648f0 Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: cppuhelper 
Change-Id: I4c221461c60c5e96b738bb902253984a9b0b312b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158170
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-10-19 14:41:21 +02:00
Stephan Bergmann e0c33ec15f loplugin:ostr: automatic rewrite 
Change-Id: I2d09b2b83e1b50493ec88d0b2c323a83c0c86395
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157647
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins
 2023-10-07 00:47:20 +02:00
Caolán McNamara d282d73792 cid#1537991 Unchecked return value 
Change-Id: I303817f007dd0035e64d15b3f9310a06aab18060
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157396
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
 2023-09-29 14:14:00 +02:00
Paris Oplopoios 81e815edbf tdf#153109 Use any_of instead of loop to check a range 
Change-Id: Icf65288a7e53257008129b71e8d716b0b0c7f5fa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152868
Tested-by: Paris Oplopoios <parisoplop@gmail.com>
Reviewed-by: Paris Oplopoios <parisoplop@gmail.com>
 2023-06-12 13:11:07 +02:00
Noel Grandin 89e0a3e05d use WeakComponentImplHelper2 in Bootstrap_MacroExpander 
Change-Id: I49f051d9c9da46ec877e4f611836c7a3548f9f10
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151581
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-05-10 08:01:47 +02:00
Noel Grandin 8809b57da9 use WeakComponentImplHelper2 in ServiceManager 
Change-Id: I0f141398effbd2673c02f9d1f4378fd4e67af655
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151580
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-05-10 08:01:25 +02:00
Noel Grandin 94aba9289a use WeakComponentImplHelper2 in TypeManager 
Change-Id: I2358006a069ea4e8cdeeeafb8384ad8d47fba50a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151579
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-05-09 18:15:20 +02:00
Noel Grandin 00f8f75f36 copy some comphelper code down into cppuhelper 
Since I want to use them in the cppuhelper too, but comphelper is
"above" cppuhelper in the dependency tree.

And sharing the code between cppuhelper and the rest of LO
across the URE boundary appears to be nigh impossible.

Change-Id: I2ebf37746928dc820df43347dc1a2c158f00ec50
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151445
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-05-09 14:50:31 +02:00
Noel Grandin 4c288a18e7 fix o3tl::equalsAsciiL 
after I got it wrong in both the original commit
    commit d15a6560bd
    use more string_view
and in the attempted fix
    commit dd41ea3ec1
    fix for o3tl::equalsAscii
thanks to sberg for spotting that

Change-Id: Iff12879de823553b2623db48979e9a720302f2d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150240
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-04-12 08:23:54 +02:00
Noel Grandin dd41ea3ec1 fix for o3tl::equalsAscii 
from
    commit d15a6560bd
    use more string_view
where the new method was named incorrectly

Change-Id: Ia4513fa67f5bda8b6cb56e3db22df48b5e3c7283
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150217
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-04-11 13:29:45 +02:00
Noel Grandin 637cceeefb loplugin:stringadd in c* 
after my patch to merge the bufferadd loplugin into stringadd

Change-Id: I66f4ce2fd87c1e12eefb14406e0e17212f68ceff
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149497
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-24 15:29:18 +00:00
Stephan Bergmann 27f9a9cfa7 OUString::match -> OUString::startsWith 
(which reads better in combination with the following
OUString::endsWithIgnoreAsciiCase)

Change-Id: Ia80e3d205e5e3b48f9df43757fb267258ba3f8ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149353
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-03-22 21:51:01 +00:00
Stephan Bergmann feb8b04a0e rhbz#2171265 Filter out all non *.rdb files 
In that rhbz issue ("Libreoffice cannot start"), it looks like some junk file
named /usr/lib64/libreoffice/program/services/services.rdb;63ddcd86 caused
soffice.bin to crash early, without any information (cf.
a1faf14f74 "rhbz#2171265 Report fatal
InitApplicationServiceManager failures more reliably").  So, following up on
b8c7548527 "ignore backup files in services/
directory to avoid debugging grief", extend the set of ignored files to anything
starting with "." or not ending in ".rdb" (in any case).

Change-Id: I154750465d2128b3ff6493f4ab606072dda61503
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149328
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-03-22 19:26:59 +00:00
Arnaud VERSINI 048d01ff0f cppuhelper : use BaseMutex instead of OFactoryComponentHelper_Mutex 
Change-Id: I49ed178310b6d8441d8cfdd208b26b8d13ef39ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149091
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-20 05:45:35 +00:00
Arnaud VERSINI d4822aa450 cppuhelper : use constexpr OUStringLiteral instead of a function 
Change-Id: Icc25698e4213edbeaae1a997dccbee0ff529ce3b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149092
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-20 05:45:07 +00:00
Stephan Bergmann 55b534660e OFactoryComponentHelper's XAggregation is apparently unused 
It had been using cppu::OComponentHelper (which derives from XAggregation) ever
since b525a3115f "initial import", bug e.g.
ORegistryFactoryHelper deriving from it implements queryInterface in a way that
is incompatible with XAggregation (it should only have forwarded to
OFactoryComponentHelper::queryInterface, and rather implemented its logic in an
ORegistryFactoryHelper::queryAggregation override).

Also, without this commit but instead with a local

> diff --git a/cppuhelper/source/factory.cxx b/cppuhelper/source/factory.cxx
> index c8efcab0e604..9011264b3f3a 100644
> --- a/cppuhelper/source/factory.cxx
> +++ b/cppuhelper/source/factory.cxx
> @@ -241,6 +241,7 @@ class OFactoryComponentHelper
>      , public OComponentHelper
>      , public OSingleFactoryHelper
>  {
> +    void SAL_CALL setDelegator(css::uno::Reference<css::uno::XInterface> const &) final { assert(false); }
>  public:
>      OFactoryComponentHelper(
>          const Reference<XMultiServiceFactory > & rServiceManager,

`make check` still succeeded for me on Linux, without hitting that injected
assert that should have fired if that XAggregation mechanism had been used after
all.

So switch from OComponentHelper to WeakComponentImplHelper here (which is the
simplest implementation helper to use, even if it still needs the non-standard
OFactoryComponentHelper::getTypes overriding the non-fitting
WeakComponentImplHelper default implementation).

Change-Id: I9fc2f4f2ef36bd016f9a943a8efd5e4ac5f3baaf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145428
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-01-13 09:37:49 +00:00
Stephan Bergmann e001703df4 Merge OSingleFactoryHelper into OFactoryComponentHelper 
Change-Id: I7faf7a3ad54c80bd3c53525c92c26c0f980110f9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145423
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-01-13 07:50:57 +00:00
Stephan Bergmann c945eafc99 Don't let OSingleFactoryHelper delegate to derived classes' virtual overrides 
...as it doesn't make sense that e.g. OFactoryComponentHelper::createInstance
checked for bOneInstance, called OSingleFactoryHelper::createInstance, which
called [OFactoryComponentHelper::]createInstanceWithContext, which checked for
bOneInstance again

Change-Id: I53f54079a2ac1af18a6e95f0cb9d7b75c1e46ceb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145418
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-01-12 22:19:36 +00:00
Stephan Bergmann ca3ba86fe1 Fix aggregating OFactoryComponentHelper::queryInterface 
4bfc00aca2 "#67468# factories support
XUnloadingPreference now" had added the check for XUnloadingPreference there,
but that's already covered by OFactoryComponentHelper::queryAggregation
delegating to OSingleFactoryHelper::queryInterface.  (And as
OFactoryComponentHelper is inheriting XAggregation via OComponentHelper, the
only thing that OFactoryComponentHelper::queryInterface shall do is delegate to
OComponentHelper::queryInterface.)

Change-Id: Iebe507e88791d1e2390d042a8a9c152512ce212a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145420
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-01-12 21:38:06 +00:00
Arnaud VERSINI 555f433318 use std::this_thread::sleep_for instead of osl equivalent 
Change-Id: I5b4edc5417e5bb5e082688df616e1d5735717d92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142357
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-01-09 08:37:35 +00:00
Mike Kaganski b15eb164a8 tdf#152380: add checks for names and values sequences length equality 
Change-Id: Ibeef551126874bcfffb4e7736588e2e1873f5768
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143681
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2022-12-06 05:32:37 +00:00
Stephan Bergmann 9c6fa5fc98 Replace some uses of static_type with UnoType 
(which is what that static_type scaffolding calls internally, anyway)

Change-Id: Ibd8097de0d6a9cd0040c34e5070dafa8db256b56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143566
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-12-02 10:11:38 +00:00
Stephan Bergmann 5687eba49f Drop obsolete preprocessor directives from UNOIDL files 
...which were used by ildc, which is gone since
a8485d558f "[API CHANGE] Remove deprecated idlc
and regmerge from the SDK", and have always been ignored as legacy by its
unoidl-write replacement.

This change has been carried out (making use of GNU sed extensions) with

> for i in $(git ls-files \*.idl); do sed -i -z -E -e 's/\n\n((#[^\n]*\n)+\n)*(#[^\n]*\n)+\n?/\n\n/g' -e 's/\n(#[^\n]*\n)+/\n/g' "$i"; done && git checkout extensions/source/activex/so_activex.idl odk/examples/OLE/activex/so_activex.idl

which apparently happened to do the work.  (The final two files are not UNOIDL
source files.)

Change-Id: Ic9369e05d46e8f7e8a304ab01740b171b92335cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135683
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-06-13 16:27:45 +02:00
Stephan Bergmann e3b48ed3b8 Fix type of cppuhelper::TypeManager::getInterfaceMember separator param 
...after a5343a89f8 "use more string_view in cppu"

Change-Id: I7cd577f50cd92586e00f347b2e05247b6b5b0331
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135326
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-06-02 22:07:35 +02:00
Noel Grandin d16122e3e9 clang-tidy modernize-pass-by-value in cppuhelper 
Change-Id: I231b84cd973d730fe301045cb7442af2d1ddc5d2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135311
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-06-02 17:43:43 +02:00
Pragat Pandya 6abc09926c tdf#147021 Use std::size() instead of SAL_N_ELEMENTS() macro 
Change-Id: I54257e87da0cd66da59d820c7960c3e4b020fda3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134027
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
Tested-by: Jenkins
 2022-05-09 20:42:03 +02:00
Noel Grandin 9277faf14a osl::Mutex->std::mutex in cppuhelper::ServiceManager 
Change-Id: I2d30fb3c81e791eb554780b5abf4923a33cc884e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134029
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-09 10:16:39 +02:00
Andrea Gelmini 11f0cb056f Remove duplicated includes 
Change-Id: I137707aaad44ffe42bb4b234a59ff69e4b2ecaa2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133884
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
 2022-05-06 07:07:10 +02:00
Noel Grandin 9f1701d01d use more o3tl::getToken 
found by inspecting call sites of OUString::getToken

Change-Id: I4269c7476c7aa46fac39528227e350568f0eb34a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132644
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-05 12:57:00 +02:00
Noel Grandin d15a6560bd use more string_view 
found by examining the call sites of OString::getToken

which means I needed to add a new o3tl::equalsAscii function

Change-Id: I7dc0ea1cf5ce8090a708d44f2cf7c938fa200c5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133826
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-05 08:39:23 +02:00
Stephan Bergmann 7ba88f7981 Just use Any ctor instead of makeAny in cppuhelper 
Change-Id: I296f297060f10e09639da837df44cc9d30cc594b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133832
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-05-04 19:28:58 +02:00
Stephan Bergmann bdff0bb77b Use o3tl::make_unsigned in some places 
...where a signed and an unsigned value are compared, and the signed value has
just been proven to be non-negative here

Change-Id: I9665e6c2c4c5557f2d4cf1bb646f9fffc7bd7d30
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133442
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-04-26 17:04:01 +02:00
Noel Grandin c0ec38fe54 revert unnecessary change 
from
    commit 25ada1e520
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Thu Apr 21 13:59:07 2022 +0200
    use more string_view in cppuhelper

Change-Id: Ie5bd9226dca0f222edd0798b8b478054eda5162c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133430
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-26 12:48:13 +02:00
Gabor Kelemen ffcd599c4f Drop obsolete workaround for LanguageTool 1.7 
Upstream patch for this issue was integrated for LT 1.8:
https://sourceforge.net/p/languagetool/bugs/105/
some 10 years ago.

It should be safe to drop this workaround now that LT 1.7
was dropped from core.

Change-Id: I4ffec2247bcb6445cfcdb1c19018bdddec712c83
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133357
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
 2022-04-26 10:10:01 +02:00
Noel Grandin c2092e4da4 fix master after string_view patches.. 
crossed paths

Change-Id: I066b357dc10e2109658194b3b3682b7083ebbbbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133322
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-22 14:44:06 +02:00
Noel Grandin 25ada1e520 use more string_view in cppuhelper 
Change-Id: I846a1201b1b4fb8ca694a0b78b7d4cc2973dfbd2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133258
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-22 13:28:35 +02:00
Noel Grandin 9820f11ad2 address review comments on "use more string in unoidl.." 
on
    commit 2d9291b943
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Thu Apr 21 12:53:15 2022 +0200
    use more string_view in unoidl,codemaker

Primarily reverting the findEntity call-chain to use OUString
instead of std::u16string_view.

Change-Id: Ib01b9473c859bba3791563df753823bbf0a87ce0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133302
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-22 13:27:56 +02:00
Michael Weghorn a03d7b1871 android: Use fake exceptions on all architectures 
This was previously only used for aarch64, and the
workaround does not seem to be necessary in current
Android versions on other architectures.

However, while it's e.g. not needed on an x86 AVD
with API level 21 (Android 5), at least my
x86 AVD with API level 16 (Android 4.1), which
is currently our `minSdkVersion`, fails otherwise
when trying to open any document with the below
in the ADB log.

With this (and all the previous fixes for low API/SDK levels)
in place, opening a document in Android Viewer finally
succeeds there.

> F/libc    ( 3288): Fatal signal 11 (SIGSEGV) at 0xdeadbaad (code=1), thread 3310 (Thread-122)
> I/stderr  ( 3288): terminating with uncaught exception of type com::sun::star::ucb::InteractiveAugmentedIOException
> I/stderr  ( 3288): assertion "terminating with uncaught exception of type com::sun::star::ucb::InteractiveAugmentedIOException" failed: file "/usr/local/google/buildbot/src/android/ndk-release-r20/external/libcxx/../../external/libcxxabi/src/abort_message.cpp", line 73, function "abort_message"
> I/DEBUG   ( 1173): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
> I/DEBUG   ( 1173): Build fingerprint: 'generic_x86/sdk_x86/generic_x86:4.1.2/MASTER/eng.wdu.20191218.182616:eng/test-keys'
> I/DEBUG   ( 1173): pid: 3288, tid: 3310, name: Thread-122  >>> org.libreoffice <<<
> I/DEBUG   ( 1173): signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr deadbaad
> I/DEBUG   ( 1173):     eax 00000000  ebx b76c9f4c  ecx 00000000  edx b76cbfd4
> I/DEBUG   ( 1173):     esi b65ed000  edi 788c7d6c
> I/DEBUG   ( 1173):     xcs 00000073  xds 0000007b  xes 0000007b  xfs 00000000  xss 0000007b
> I/DEBUG   ( 1173):     eip b7661c03  ebp 788c7d88  esp 788c7d40  flags 00210246
> I/DEBUG   ( 1173):
> I/DEBUG   ( 1173): backtrace:
> I/DEBUG   ( 1173):     #00  pc 00021c03  /system/lib/libc.so (abort+131)
> I/DEBUG   ( 1173):     #01  pc 00030ff1  /system/lib/libc.so
> I/DEBUG   ( 1173):     #02  pc 0e137175  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #03  pc 0e1372f5  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #04  pc 0e133d0a  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #05  pc 0e13323f  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #06  pc 0e133194  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #07  pc 0d369737  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #08  pc 0d3673b0  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #09  pc 0d366a7b  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #10  pc 0d377a25  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #11  pc 09a2b944  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #12  pc 098826da  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #13  pc 098cc47c  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #14  pc 098ded29  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #15  pc 098bb839  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #16  pc 098b7e23  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #17  pc 098bb8cf  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #18  pc 0987a677  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #19  pc 0987b7c7  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #20  pc 0987ab4b  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #21  pc 0987a9a7  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #22  pc 0987f90b  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #23  pc 0986d4ff  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #24  pc 09872298  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #25  pc 035625cf  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #26  pc 0355dff2  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #27  pc 035713f9  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #28  pc 03570d3b  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #29  pc 035714b8  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #30  pc 09a5fb66  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #31  pc 09a5f984  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):
> I/DEBUG   ( 1173): stack:
> I/DEBUG   ( 1173):          788c7d00  b76cca48
> I/DEBUG   ( 1173):          788c7d04  b76ca208  /system/lib/libc.so
> I/DEBUG   ( 1173):          788c7d08  b76699eb  /system/lib/libc.so (_fwalk+11)
> I/DEBUG   ( 1173):          788c7d0c  b76c9f4c  /system/lib/libc.so
> I/DEBUG   ( 1173):          788c7d10  00000000
> I/DEBUG   ( 1173):          788c7d14  00000000
> I/DEBUG   ( 1173):          788c7d18  00000000
> I/DEBUG   ( 1173):          788c7d1c  00000000
> I/DEBUG   ( 1173):          788c7d20  00000000
> I/DEBUG   ( 1173):          788c7d24  00000000
> I/DEBUG   ( 1173):          788c7d28  00000000
> I/DEBUG   ( 1173):          788c7d2c  00000000
> I/DEBUG   ( 1173):          788c7d30  00000000
> I/DEBUG   ( 1173):          788c7d34  00000000
> I/DEBUG   ( 1173):          788c7d38  00000000
> I/DEBUG   ( 1173):          788c7d3c  00000000
> I/DEBUG   ( 1173):     #00  788c7d40  00000002
> I/DEBUG   ( 1173):          788c7d44  788c7d6c  [stack:3310]
> I/DEBUG   ( 1173):          788c7d48  00000000
> I/DEBUG   ( 1173):          788c7d4c  00000115
> I/DEBUG   ( 1173):          788c7d50  0000007f
> I/DEBUG   ( 1173):          788c7d54  b76c9f4c  /system/lib/libc.so
> I/DEBUG   ( 1173):          788c7d58  788c7d98  [stack:3310]
> I/DEBUG   ( 1173):          788c7d5c  b76c9f4c  /system/lib/libc.so
> I/DEBUG   ( 1173):          788c7d60  b76ca208  /system/lib/libc.so
> I/DEBUG   ( 1173):          788c7d64  788c7e04  [stack:3310]
> I/DEBUG   ( 1173):          788c7d68  788c7d88  [stack:3310]
> I/DEBUG   ( 1173):          788c7d6c  fffffbdf
> I/DEBUG   ( 1173):          788c7d70  b76ca208  /system/lib/libc.so
> I/DEBUG   ( 1173):          788c7d74  b76b3b24  /system/lib/libc.so
> I/DEBUG   ( 1173):          788c7d78  b7661b8e  /system/lib/libc.so (abort+14)
> I/DEBUG   ( 1173):          788c7d7c  b76c9f4c  /system/lib/libc.so
> I/DEBUG   ( 1173):          ........  ........
> I/DEBUG   ( 1173):     #01  788c7d90  b76ca208  /system/lib/libc.so
> I/DEBUG   ( 1173):          788c7d94  b76b3b24  /system/lib/libc.so
> I/DEBUG   ( 1173):          788c7d98  b9b98fc0  [heap]
> I/DEBUG   ( 1173):          788c7d9c  8723cac3  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):          788c7da0  00000049
> I/DEBUG   ( 1173):          788c7da4  8723cb39  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):          788c7da8  b766b6fe  /system/lib/libc.so (vasprintf+14)
> I/DEBUG   ( 1173):          788c7dac  8d73b830  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):          788c7db0  b7670fa9  /system/lib/libc.so (__assert2+9)
> I/DEBUG   ( 1173):          788c7db4  8d73b830  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):          788c7db8  788c7df8  [stack:3310]
> I/DEBUG   ( 1173):          788c7dbc  86a0d175  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):     #02  788c7dc0  8723cac3  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):          788c7dc4  00000049
> I/DEBUG   ( 1173):          788c7dc8  8723cb39  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):          788c7dcc  b9b98fc0  [heap]
> I/DEBUG   ( 1173):          788c7dd0  b9b98fc0  [heap]
> I/DEBUG   ( 1173):          788c7dd4  788c7e04  [stack:3310]
> I/DEBUG   ( 1173):          788c7dd8  788c7e04  [stack:3310]
> I/DEBUG   ( 1173):          788c7ddc  86a09960  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):          788c7de0  00000014
> I/DEBUG   ( 1173):          788c7de4  86a09980  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):          788c7de8  788c7e38  [stack:3310]
> I/DEBUG   ( 1173):          788c7dec  788c7e1c  [stack:3310]
> I/DEBUG   ( 1173):          788c7df0  b9b1c480  [heap]
> I/DEBUG   ( 1173):          788c7df4  8d73b830  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):          788c7df8  788c8238  [stack:3310]
> I/DEBUG   ( 1173):          788c7dfc  86a0d2f5  /data/data/org.libreoffice/lib/liblo-native-code.so
> I/DEBUG   ( 1173):
> I/DEBUG   ( 1173): memory map around fault addr deadbaad:
> I/DEBUG   ( 1173):     bfa03000-bfa24000 [stack]
> I/DEBUG   ( 1173):     (no map for address)
> I/DEBUG   ( 1173):     (no map above)
> D/Zygote  ( 1176): Process 3288 terminated by signal (11)

Change-Id: I0bc6d13b1217959c5e447e7c6126006b561639a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133264
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
 2022-04-21 20:59:05 +02:00
Noel Grandin 2d9291b943 use more string_view in unoidl,codemaker 
Change-Id: Ibc0624a662c98ef1308a3bb0c7c082935a89a25c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133252
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-21 13:53:26 +02:00
Noel Grandin a5343a89f8 use more string_view in cppu 
Change-Id: Ifd2ee4827e0083ffaff9120fee239fb16553380e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132957
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-13 16:11:49 +02:00
Noel Grandin fdfd517a6f loplugin:stringviewparam whitelist some more functions 
for which we have o3tl:: equivalents

Change-Id: I4670fd8b703ac47214be213f41e88d1c6ede7032
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132913
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-04-13 08:38:53 +02:00
Stephan Bergmann de46531735 -Werror,-Wstrict-prototypes (clang-cl) 
Change-Id: I72e35f51eb607662608ccaf944bec64ed422cef4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132835
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-04-11 19:40:51 +02:00
Stephan Bergmann 72303710ab -Werror,-Wstrict-prototypes 
Change-Id: I7b3d6f5a19020191e7add5ed21666d84e54744a3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132760
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-04-10 10:24:51 +02:00
Mike Kaganski 21b17ba1e6 Simplify a static array iteration 
Change-Id: I7dc4fdcbbaef08c1bc3b23403cd13e2c23585f75
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131733
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2022-03-18 11:49:54 +01:00
Noel Grandin 9e8d887089 address review comments for "Add XWeak constructor..." 
for
    commit 27352b8163 (origin/master, origin/HEAD)
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Mon Feb 21 16:00:52 2022 +0200
    Add XWeak constructor and operator= to uno::WeakReference

I accidentally created a new gerrit change for this, and thus managed to
miss sorting out various review comments.

(*) Fix version number in gcc3.map
(*) Narrow the interface (i.e. assume non-null parameter) in
WeakReferenceHelper
(*) Remove cargo-cult catch and OSL_ASSERT in WeakReferenceHelper
(*) Remove accidental indentation

Change-Id: I8d1b22dd42216e9293959032d92df65405fb054c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130349
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-28 11:25:58 +01:00
Noel Grandin 27352b8163 Add XWeak constructor and operator= to uno::WeakReference 
which is faster since we can skip the UNO_QUERY.

Change-Id: Id95ad9f3568213e974bd13659d92d4ea94dbfbd6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130282
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-02-22 12:27:55 +01:00