Commit Graph
13 Commits
Author SHA1 Message Date
Muhammad Ammar 1a6bd7b23a tdf#163691 replace memcpy with std::copy_n in package and xmlscript
Restored #include<string.h> header in both files as follow:
- /package/source/zippackage/ZipPackageBuffer.cxx
- /xmlscript/source/xml_helper/xml_byteseq.cxx

Change-Id: I5615140028c9f29eaa87e7269135748790f19ed3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/204441
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2026-04-27 18:17:24 +02:00
Gabor Kelemen 663551c5c4 tdf#146619 Run IWYU again on include/test
Change-Id: Ia2fe7435e0fbd6185c40655cd6c5ae93d39c7963
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193916
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen@collabora.com>
2025-11-30 18:25:35 +01:00
Mike Kaganski a6a6921123 Use good old string literals in assertXPath and friends
These are only sent to an external API expecting char*-like strings,
or for comparison. Having every assertXPath having three of _[ou]str
is too much syntactic noise, making the unit tests almost unreadable.

Change-Id: Ic004a36ea75e7bfe0b96f405c40f926a957b51cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174416
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
2024-10-05 10:06:44 +02:00
Xisco Fauli 83a8d5a275 BootstrapFixture: get rid of mxComponentContext
Change-Id: I0318485c3c0159277e47096e0c7e0df8ed109ea4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/169865
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-07-02 15:35:00 +02:00
Noel Grandin 28c64afa68 loplugin:ostr in xmlscript
Change-Id: Iaa78cb8994fc1f1b40f02d26e4e1218882ac4b6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167706
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
2024-05-16 08:50:01 +02:00
Gabor Kelemen d7acb0fc22 tdf#146619 Drop unused 'using namespace' in: xmlscript/
Change-Id: Ic9874b77bdbb1d30fb587c5c8bbd62e4811c71e3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165528
Tested-by: Jenkins
Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
2024-04-01 10:03:25 +02:00
Stephan Bergmann 156e7eafd7 Extended loplugin:ostr: xmlscript
Change-Id: I1b476b6fb89ee04b4427ba1210eee9811a722f0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159661
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-11-19 17:28:56 +01:00
Noel Grandin 4b95451f85 split utl::TempFile into fast and named variants
which makes it easier to know what each variant requires
to stay on it's happy path

Change-Id: I3275a2543573367714bc78092e882f6535507285
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140469
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-09-29 09:11:18 +02:00
Noel Grandin f4ac99f717 loplugin:moveparam in xmlscript
Change-Id: I8c33291dae8a4f90c02f47d823b127ca4e383d61
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123338
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-10 19:45:48 +02:00
Noel Grandin 5c79032077 fix leaks in loading xmlscript
Change-Id: I18e663a6da34ef34630272819420ead6f3b8389d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116087
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-25 11:47:48 +02:00
Noel Grandin 3d36ff1a1d loplugin:unusedfields
Change-Id: Ib574403a7f7f8b11c6263c9c19ec6b65c8374ddd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115753
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-18 21:42:10 +02:00
Stephan Bergmann af16aa6256 Improve loplugin:stringview
Issue the "instead of O[U]String, pass [u16]string_view" diagnostic also for
operator call arguments.  (The "rather than copy, pass subView()" diagnostic is
already part of handleSubExprThatCouldBeView, so no need to repeat it explicitly
for operator call arguments.)

(And many call sites don't even require an explicit [u16]string_view, esp. with
the recent ad48b2b02f "Optimized OString operator
+= overloads".  Just some test code in sal/qa/ that explicitly tests the
O[U]String functionality had to be excluded.)

Change-Id: I8d55ba5a7fa16a563f5ffe43d245125c88c793bc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115589
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-14 13:11:50 +02:00
Vasily Melenchuk ce135ba8a6 tdf#137652 add xmlscript unittest & infrastructure
entire module was not covered by unittests and there was no way
to test some of the latest fixes done there, like f4a5893ece.

Now it is possible and a test for
https://gerrit.libreoffice.org/c/core/+/104619 was added

Removed remains of older unused tests.

Change-Id: Ide7bc3704efa1bb4bc62ed71bf4dd8b1ad4e800f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112569
Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-04-06 10:08:15 +02:00