Parse the style*.xml file in the OOXML package, and store the imported
styles in XChartDocument via a new XChartStyle. Some areas are yet to be
fleshed out, but the intent here is to get a review of the general approach
and architecture. This includes no work on the export side (or the UI and
application of styles to a chart, which is a separate but related project).
Change-Id: I9d5b9f5aa44fb7944b2d971edc26e04dc2256c7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189531
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Add new paragraph justification options "Minimum glyph scaling"
and "Maximum glyph scaling" to improve typography, like DTP software
do, allowing to typeset visually better paragraphs, especially narrow
columns without unacceptably big word spacing.
* Add spin boxes to Alignment in paragraph formatting dialog window;
* Store properties in paragraph model:
css::style::ParagraphProperties::ParaPropScaleWidthMinimum
css::style::ParagraphProperties::ParaPropScaleWidthMaximum
Note: desired glyph scaling is already supported by ODF/UNO,
see css::style::CharacterProperties::CharScaleWidth.
* Implement visual layout of minimum and maximum glyph scaling,
limited by the available extra word spacing and letter spacing,
too.
Note: last line can exceed the paragraph width, because minimum
glyph scaling, also minimum letter scaling of the last line
haven't been applied there, yet.
* Add ODF import/export (loext:text-scale-maximum and
loext:text-scale-minimum, where style:text-scale is for the
desired text scaling).
* Add ODF unit test.
Note: hyphenated lines, lines with multiple portions haven't
been using custom glyph scaling, yet.
Note: resolution of glyph scaling is 1 percent, which will
avoid of overgeneration of font types using variable fonts.
Change-Id: I9b4576dde4303437b64e37202c47f888f94c3f67
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190534
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Implement new paragraph justification option "Minimum letter spacing"
allowing to shrink text lines more, choosing better paragraph layout
instead of hyphenation or rivers of space.
* Implement visual layout of minimum letter spacing.
* Enable Minimum letter spacing spin box on Alignment pane of the
paragraph formatting dialog window
* Remove also desired letter spacing spin box from the alignment pane.
It will be better to visualize CharKerning with percentage value
instead of adding a new user interface to the same setting.
* Set minimum and maximum spin box ranges to [-100, 0] and [0, 500],
and remove unnecessary handlers.
* offapi: extend API description with ranges of letter spacing
[-100, 500] and word spacing ([0, 1000]).
* Add ODF unit test.
Note: hyphenated lines, lines with multiple portions haven't
been using custom letter spacing, yet.
Note: resolution of the custom letter spacing is only 1/20 point
(1 twip) yet.
Note: adjust testTdf163149 failing on a test machine, maybe
because the DOCX test document contains the not supported Arial
font, resulting small differences based on the font replacement.
Follow-up to commit f83a04c510
"tdf#167648 cui offapi xmloff sw: add DTP-feature maximum letter
spacing".
Change-Id: I0d686ccbdaa5324eaf6c4c7f6da0f37e76f60611
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190533
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
When sorting a database range the feature 'natural sort' can be used.
If source has the strings K3 K10 K104 K23 K2, then the result will be
K2 K3 K10 K23 K104. Alphanumerical sort results in K10 K104 K2 K23 K3.
ODF has the attribute table:embedded-number-behavior for this
(19.628 part3 ODF 1.4). Its values are 'alpha-numeric', 'double' and
'integer'. LO has the attribute bool bNaturalSort in struct ScSortParam.
The ODF method 'integer' is not implemented in LO.
Currently natural sort is not read/written with ODF and is not available
in the API. I plan three steps:
1. Make natural sort available in the API (this patch)
2. Read and write table:embedded-number-behavior attribute
3. Implement 'integer' method.
To be later able to have three values, not a boolean property is used for
the API, but a group of constant values, although currently only two
values are needed.
Change-Id: I0418d5f23400fb0479034589fc90868a1e97ce44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190133
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
Tested-by: Jenkins
.../master/instdir/sdk/bin/unoidl-read --published \
.../libreoffice-25.8.0.4/instdir/program/types.rdb \
>.../master/udkapi/type_reference/udkapi.idl
* css.lang.XSingleServiceFactory has been un-deprecated with
4f03d1c238 "css.lang.XSingleServiceFactory must
not be @deprecated"
.../master/instdir/sdk/bin/unoidl-read --published \
.../libreoffice-25.8.0.4/instdir/program/types.rdb \
.../libreoffice-25.8.0.4/instdir/program/types/offapi.rdb \
>.../master/offapi/type_reference/offapi.idl
* css.i18n.GROUP_SEPARATOR_IN_NUMBER_3 is marked as "@since LibreOffice 25.2"
but was only brought into libreoffice-25-2 with
055b637ed9bdd02cd857664813a66afde51dfd0a "tdf#158867 offapi,i18npool,starmath:
fix ',' in Math again" after libreoffice-25.2.0.3, for which point the
previous type reference had been generated with
aabf7c44ec "Update the reference rdbs to
libreoffice-25.2.0.3"
Change-Id: I387e20b3bc5955b60b8365f6a64604481f2e0de2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190155
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
shown as the "prompt" text in the final slides
What should works
- New sd specific uno api shape property: CustomPromptText
- With this property, the corresponding master slide SdrObj's
and their final slide SdrObj's placeholder text can be set.
- If we have CustomPromptText value it will be used for the
PresetObj and will be created (CreatePresObj) with those texts
as a default prompt text. If we do not have the usual default
ones will be used.
- OOXML import and export (partly since we have many other problems
around export) are works
- Enable to OOXML import of com.sun.star.presentation.SubtitleShape
(partly, since in the core we handle them as Text objects) to handle them
a bit better. OOXML export is still not good for different reasons:
see tdf#112557
- Unit tests for custom "prompt" text
TODO
- odf import/export
- we cannot set in runtime new custom placeholder texts, so the new
placeholders/presobj will be created with the usual default texts.
Change-Id: Ic2b06a10f7a19f0cfdb2b705645b08a24b3e433b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189185
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
Follow-up patch to 6eff24aec6.
Removed empty line after @endparblock in
com::sun::star::i18n::XBreakIterator.
Put multiple paragraphs to parblocks in
affected files in com::sun::star::sheet.
Change-Id: Ie36edb9ff8ba8f59ea53214ffcc08b348c92c834
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188363
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Previously, we silently discarded fonts which rights disallowed editing
of documents. This change introduces a choice, where user can opt to
either discard the restricted fonts, or switch to read-only mode.
1. When user opens a document with restricted embedded fonts, which are
already installed on the system, those fonts are not considered as
restricted.
2. Trying to switch to edit mode will show the dialog again, allowing
to discard those fonts to allow editing.
3. Saving the document will discard restricted fonts not installed on
the system in any case.
4. Even though saving discards those fonts from file, it doesn't switch
to edit mode, because it doesn't reload the document, that is needed
to reload embedded font data (and release respective font files).
5. Opening a document initially in read-only mode skips the dialog.
TODO: avoid showing those fonts in the font lists.
Change-Id: Ia7c9b6c3f727720e64e4df8d1c4a8e3641b067bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189366
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
...to enable "the UNO parts (types and servie implementation) of the embindtest
framework (which can also be used independently of the Emscripten build)." And
which e.g. both last year's Lua GSoC project and this year's Rust GSoC project
(<https://gerrit.libreoffice.org/c/core/+/186425> "Add core UNO types for Rust
language binding") enabled locally in their respective dev builds.
Change-Id: I8cf917fbcdaf73e244bd84689a1f29f3aa95f923
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189363
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
Add new paragraph justification option "Maximum letter spacing"
to distribute letters on (part of) the available blank area of the
justified line instead of overstretching word spacing, like DTP
software do.
This improves typography a lot, allowing typesetting visually better
i.e. more readable paragraphs, minimizing or removing rivers and
too big word spacing (which was common in columns or text without
hyphenation).
* Add spin box to Alignment in paragraph formatting dialog window,
(also add spin boxes for future Minimum and the alternative
percent-based Desired letter spacing, see CharKerning);
For example (only ASCII visualization!), 100% maximum letter
spacing adds a space character-width blank space between the
characters, including the original space:
0%:
Lorem ipsum
pellentesque dolores
vitae.
100%:
L o r e m i p s u m
pellentesque dolores
vitae.
Normal value: 3%-5% (or more for very narrow columns), which means
e.g. 1-2 twips (twip = 1/20 pt) letter spacing in a ~12 pt text.
Note: resolution of the custom letter spacing is only 1 twip yet.
* Store properties in paragraph model:
css::style::ParagraphProperties::ParaPropLetterSpacingMaximum
css::style::ParagraphProperties::ParaPropLetterSpacingMinimum
Note: desired letter spacing is already supported by ODF/UNO,
see css::style::CharacterProperties::CharKerning.
* Implement visual layout of maximum letter spacing.
Note: after the last character of the line, there is an
unwanted letter-spacing, yet (which is visible only with
big letter-spacing values).
* Add ODF import/export (loext:letter-spacing-maximum and
loext:letter-spacing-minimum)
* Add ODF unit test.
Note: hyphenated lines and lines with multiple portions do not
yet use custom letter spacing, yet.
Change-Id: Ieac9f21631b90ae46bed4501f12da0d15ed84d63
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188653
Tested-by: László Németh <nemeth@numbertext.org>
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
Put multiple paragraphs into paragraph in
XBreakIterator::previousWord().
Additionally added missing punctuation in XBreakIterator.idl.
I also checked the rest of offapi/com/sun/star/i18n
and this was the only instance of multiple paragraphs
in a param block.
Change-Id: I5ef56673694ce5decb473129daa59e6080284a23
Change-Id: I9011867fd5444e90d4c0d22a095f43d8ce92e162
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188300
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Drop the unpublished service
"com.sun.star.awt.AccessibleTreeListBoxEntry"
because it's effectively unused. (The IDL file only documents some
internal implementation details of the a11y class
implementing the service, and that doc is also outdated/inaccurate.)
A search in Google and on Ask [1] didn't give
any results that would suggest this unpublished service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)
[1] https://ask.libreoffice.org/
Change-Id: I4a4291b1147c6c01f0bfe1b939ff378fbd39d46d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188146
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Drop the unpublished service
com::sun::star::drawing::AccessibleSlideView.
It's not implemented or used anywhere.
A search in Google and on Ask [1] didn't give
any results that would suggest this unpublished service
would be relevant for third party code.
[1] https://ask.libreoffice.org/
Change-Id: I6071ebdc51cbdcdf85b9d89bb495f893b995ca92
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186913
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished service
com::sun::star::drawing::AccessibleSlideViewObject.
It's not implemented or used anywhere.
A search in Google and on Ask [1] didn't give
any results that would suggest this unpublished service
would be relevant for third party code.
[1] https://ask.libreoffice.org/
Change-Id: I6656d4bcdb40a33a3119aa1fd6a2a5cacdc94764
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186912
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished service
com::sun::star::sheet::AccessibleCsvCell.
It's not implemented or used anywhere.
ScAccessibleCsvCell looks like the class implementing
the functionality mentioned ("The accessible object of the data
table in the CSV import dialog") but it doesn't actually
implement that service.
A search in Google and on Ask [1] didn't give
any results that would suggest this unpublished service
would be relevant for third party code.
[1] https://ask.libreoffice.org/
Change-Id: I0abd0bf627ff71ccce148fec1bdfd5c23ba453d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186911
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished service
com::sun::star::sheet::AccessibleCsvTable.
It's not implemented or used anywhere.
A search in Google and on Ask [1] didn't give
any results that would suggest this unpublished service
would be relevant for third party code.
[1] https://ask.libreoffice.org/
Change-Id: I40adefd81086284fec63d5343963000506469810
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186910
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished service
com::sun::star::sheet::AccessibleCsvRuler.
It's not implemented or used anywhere.
ScAccessibleCsvRuler is the class that implements
the functionality mentioned in the IDL file
("The accessible object of the ruler in the CSV import
dialog.") but it doesn't actually implement that service.
A search in Google and on Ask [1] didn't give
any results that would suggest this unpublished service
would be relevant for third party code.
[1] https://ask.libreoffice.org/
Change-Id: I80da59a92ce2e5a38db5230d2af0f6fb4e69d5a4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186909
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished service
"com.sun.star.accessibility.Accessible"
because it's unused internally.
As the doc in the IDL file says:
> <p>Service <code>Accessible</code> is just a wrapper for the interface
> <code>XAccessible</code>. See the interface's documentation for more
> information.</p>
That wrapper isn't needed.
This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] gave one result that looks
relevant/where this service is used: [4]
It was originally added in commit [5]
commit 3f227e8755954e30abf9eb2cde6e4613514e4958
Author: Zev Spitz <shivisi@hotmail.com>
Date: Sun Sep 10 09:20:55 2017 +0200
Type definitions for LibreOffice, via Automation
, which doesn't explain whether/why the particular use of
the Accessible service was chosen there, i.e. whether this
is actually of relevance.
I've created an issue/discussion to make developers of
that project aware: [6]
Stopping to implement XServiceInfo in SwAccessibleContext
and subclasses will be done in a separate upcoming commit,
now that the only service implemented by them has been
dropped.
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
[4] https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/activex-libreoffice/activex-libreoffice-tests.ts
[5] https://github.com/DefinitelyTyped/DefinitelyTyped/commit/3f227e8755954e30abf9eb2cde6e4613514e4958
[6] https://github.com/DefinitelyTyped/DefinitelyTyped/discussions/73096
Change-Id: I7432d4a524ceaf404b1a2673d8bb6cdb142baf25
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186881
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished service
"com.sun.star.text.AccessibleTextGraphicObject"
because it's unused. (The IDL file only documents some
internal implementation details of the a11y class
implementing the service.)
This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest this unpublished service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
Change-Id: I8446acfda2bb7a51c464c2bedf7bab2628cdbadc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186877
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished service
"com.sun.star.text.AccessibleParagraphView"
because it's unused. (The IDL file only documents some
internal implementation details of the a11y classes
implementing the service. It also isn't fully up to
date, e.g. the description of the accessible name.)
For AccessibleEditableTextPara, also no longer implement
the XServiceInfo interface, as the now dropped service was the
only one that was supported.
This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest this unpublished service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
Change-Id: Iee961e76ff7af1dab46d26cd844763970adc98c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186876
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished service
"com.sun.star.text.AccessibleTextEmbeddedObject"
because it's unused. (The IDL file only documents some
internal implementation details of the a11y class
implementing the service.)
This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest this unpublished service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
Change-Id: I5e7ef3b2f8ca911b3c83ec0980bbfa85072ca11d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186875
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished service
"com.sun.star.table.AccessibleCellView"
because it's unused. (The IDL file only documents some
internal implementation details of the a11y classes
implementing the service.)
This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest this unpublished service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
Change-Id: Iedce6bbf31ca0eb64e86de7239d44bd407d0dc7b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186874
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Drop the unpublished service
"com.sun.star.table.AccessibleTableView"
because it's unused. (The IDL file only documents some
internal implementation details of the a11y classes
implementing the service.)
This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest this unpublished service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
Change-Id: I36b4b4089c98a1b1969a33cdb857ba8aea934f64
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186873
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished service
"com.sun.star.sheet.AccessibleSpreadsheet"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).
The service name returned in
ScAccessibleSpreadsheet::getSupportedServiceNames
didn't even match because it was missing
".sheet" in the name.
This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
Change-Id: I9de5834c92d42150614bac21b570b909b7ec6eb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186851
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished service
"com.sun.star.text.AccessibleHeaderFooterView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).
This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
Change-Id: Ib335de951fbd9e91e9f0c303c2fa40bd8e0408d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186849
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished service
"com.sun.star.text.AccessibleTextFrameView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).
This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
Change-Id: I6359a528fb1956718b2cd79cec5374675e4e4b9c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186848
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished service
"com.sun.star.text.AccessibleEndnoteView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).
This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
Change-Id: Ib993cc958ebf87412d8f7d0c1e629856a983c03b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186847
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Drop the unpublished service
"com.sun.star.text.AccessibleFootnoteView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).
This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
Change-Id: I3455622b26072f3ece5b336f6204d3948b648db8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186846
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Drop the unpublished service
"com.sun.star.sheet.AccessiblePageHeaderFooterAreasView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).
This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
Change-Id: I18b7c0611cfcd5e507abfd8cbd6eac1ebfbf11ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186845
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Drop the unpublished service
"com.sun.star.text.AccessibleTextDocumentView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).
This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
Change-Id: If3fcc03720b5dfb62530c5efdaa954689f8efaf9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186844
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished service
"com.sun.star.sheet.AccessibleSpreadsheetDocumentView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it).
This is one step towards dropping the XServiceInfo
implementation from sc a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
Change-Id: Ia5f1009060c48015da91dee2a27496a8d24a27a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186843
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished service
"com.sun.star.sheet.AccessibleSpreadsheetPageView"
because it's unused (apart from providing some
documentation about internal implementation details of
the a11y class implementing it, but that's not fully
up to date, e.g. mentions a different accessible
name than the logic in
ScAccessibleDocumentPagePreview::getAccessibleName
actually implements).
This is one step towards dropping the XServiceInfo
implementation from sc a11y classes, which will also help
avoid linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest this unpublisheded service
could be relevant for third party code.
(Instances of the service couldn't be created by external
code anyway.)
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
Change-Id: I93b64a04a580c3f51b3923181e1538616e14347f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186842
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Drop the unpublished services
"com.sun.star.text.AccessiblePageView" and
"com.sun.star.text.AccessibleTextDocumentPageView"
because they're unused (apart from providing some
documentation about internal implementation details of
the a11y classes implementing them).
This is one step towards dropping the XServiceInfo
implementation from a11y classes, which will also help avoid
linker issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest these unpublisheded services
could be relevant for third party code. (Instances.
couldn't be created by external code anyway.)
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
Change-Id: Ia9688f094ef508a0aae07d81ee2d59386272e1a5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186827
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Stop overriding the XServiceInfo interface methods
in ScAccessibleCell as the info provided by that interface
isn't needed anywhere, see also
commit 6af782556d
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Fri Jun 20 11:14:19 2025 +0200
svtools ruler a11y: No longer implement XServiceInfo
for more background.
Related to that, drop the unpublished
"com.sun.star.sheet.AccessibleCell" service.
This is one step towards dropping the XServiceInfo
implementation from the ScAccessibleContextBase
base class, which will also help avoid linker
issues seen on Windows related to multiple
classes subclassing
cppu::ImplInheritanceHelper<class comphelper::OAccessibleComponentHelper,class com::sun::star::lang::XServiceInfo>
seen with upcoming commit
Change-Id: Ib56a9ddb1c36356943c2dfd7a5705351ee43e9d9
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Mon May 26 12:24:52 2025 +0200
vcl a11y: Let OAccessibleComponentHelper implement XAccessible
(Gerrit change [1], Windows CI log: [2]).
A search in Google and on Ask [3] didn't give
any results that would suggest this unpublished service
could be relevant for third party code. (Instances.
couldn't be created by external code anyway.)
The thread at [4] mentions it in the initial question,
but then doesn't actually make use of it in the usage
example.
[1] https://gerrit.libreoffice.org/c/core/+/185849/6
[2] https://ci.libreoffice.org/job/gerrit_windows/200107/console
[3] https://ask.libreoffice.org/
[4] https://ask.libreoffice.org/t/how-to-create-and-use-accessiblespreadsheet-and-accessiblecell-interfaces/67497
Change-Id: I6365b51644555025e33d76e99908c16e7b8d224e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186824
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Stop implementing the XServiceInfo interface in chart2
a11y implementations as the info provided by that interface
isn't needed anywhere, see also
Change-Id: Id306320710a1718ff10536127427f3a5daf68559
Author: Michael Weghorn <m.weghorn@posteo.de>
Date: Fri Jun 20 11:14:19 2025 +0200
svtools ruler a11y: No longer implement XServiceInfo
for more background.
Related to that, drop the unpublished AccessibleChartElement
service.
A search in Google and on Ask [1] didn't give
any results that would suggest this unpublished service
could be relevant for third party code. (Instances.
couldn't be created by external code anyway.)
[1] https://ask.libreoffice.org/
Change-Id: I97056996bc433940c262e9b1060eb37a24a0b00e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186758
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
The service is not implemented or used anywhere.
A search in Google and on Ask [1] also didn't give
any results that would suggest this could be relevant
for third party code.
[1] https://ask.libreoffice.org/
Change-Id: I888f891704c2ba9087d91be391f89efbae997e3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186757
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Kurt Nordback