Called with a (stray value read from file?) sometimes absurdly high value
treated as an int64 negative value which the algorithm couldn't cope with,
resulting in weird DateTime ctor arguments that now assert.
Changed to uint64 and replaced calculation with Date::operator+=(long)
Change-Id: Ia8dbc10c4c633208730fce583e43afd828e7546f
This is unbelievably slow, Impress is basically unusable in a
non-optimized build; every time you enter or leave text edit mode,
some svx::sidebar::AreaPropertyPanel is created, which loads the color
palette standard.soc, and there are lots of resource lookups for the
strings in there; the std::tie and std::tuple::operator< make those
10x slower.
(regression from d26f7537a5)
Change-Id: I073b0187f6c173487e781a42c49631cb9ff2e625
* Empty date (initialized with Date::EMPTY == all 0) stays empty.
* Day 0 is normalized to the last day of the previous month.
* Day 0 AND month 0 is also normalized to the last day of the previous month
(and not the last day of the previous-1 month).
* Before,
* all day 0 cases weren't handled at all and day 0 stayed day 0, which
doesn't make sense in a Normalize() context
* empty date wasn't detected and resulted in nonsense date -0001-12-00
Change-Id: Ib12ff7694e1adb17724af038a266f6f284285f36
'ParameterList::find' was used to detect duplicate sections and
sort the parameters by attribute and section.
Checking for duplicates is done by 'std::any_of' and
the predicate 'Parameter::IsSameSection' now.
The parameters are inserted as they are parsed and sorted later
with 'std::sort' algorithm and 'Parameter::operator<'
Adapt loops to use iterators. Change a weird 'for' loop in
'parseParameters' to a 'do .. while ..' loop to match style of a
preceding loop.
Extend unit test with a case of duplicate sections.
Change-Id: If2789c0cee8f64deae84bc720807d2d26d81dc9f
Reviewed-on: https://gerrit.libreoffice.org/37075
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Though only in case localtime() couldn't be obtained, which is about ~never.
Fallout from
commit a3de32acc0
Date: Wed Oct 28 11:23:36 2015 +0100
Rename (private) Date::init and reuse it
Change-Id: Idbbac69f3d90e7556cd83bbf442ef8ccaecec86e
This reverts parts of commit 631b679529
and commit abc6071b7a.
some of the removed fields are usefull,
m_bConverted should be checked by callers
fixed 2 bugs and added test cases:
* extended attributes with more than 2 sections were not parsed
* extended attributes with more than 1 section were not parsed
if there was an other attribute
Change-Id: I61ab2af7c5151ef1bcd80cc159fa2b99559374a8
Reviewed-on: https://gerrit.libreoffice.org/36913
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Change of an internal struct's name in errinf.cxx - renaming EDcrData to
DynamicErrorRegistry as EDcr makes very little sense to me. EDcrData is
an internally used struct consisting of collections of error data, error
handlers and error contexts, and uses only DynamicErrorInfo instances.
Change-Id: I79d7f7db5d9550dffca6adcb2a286a2d6e1fa2e7
Reviewed-on: https://gerrit.libreoffice.org/36836
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Mostly generated using
make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle"
Except some modules have their own foo::tools namespace, so there have
to use ::tools::Rectangle. This commit just moves the class from the
global namespace, it does not update pre/postwin.h yet.
Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2
Reviewed-on: https://gerrit.libreoffice.org/35923
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
gcc >= 5 and clang have builtins for this
msvc has safeint.h and functions in the msl::utilties namespace
otherwise fall back to certs demo implementations
Change-Id: I6001a278c24b0be4b381d933d256f01f91ead55d
Reviewed-on: https://gerrit.libreoffice.org/35505
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
...that would implicitly be sign extended (for plain char only if it is signed),
so non-ASCII char values would trigger the isUnicodeCodePoint assert.
Change-Id: Iaf8024ad509e64525558e882fe3fd078cfb4ea91
Reviewed-on: https://gerrit.libreoffice.org/35523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Jochen Nitschke