...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.
Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly). The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually). There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).
Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code. Missing @throws
documentation has not been applied in such manual clean-up.
Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.
(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to
OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager();
in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)
Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
This reverts commit 8da1d7869a.
plus:
Revert "Revert "KDE: don't throw on TemplatePathVariable""
This reverts commit 72812a380c.
I had misread the code and thought that handling of those two properties in
shell/source/backends/desktopbe/desktopbackend.cxx would hide handling them in the
specific KDE backends, but that is not actually the case.
Change-Id: I32fae5ba34cc934ceca2f574d50fc327b506b001
...now that b5c05876f7 "Related: rhbz#1065807
recover using xdg templates and documents settings" handles WorkPathVariable in
the generic shell/source/backends/desktopbe/desktopbackend.cxx code.
Change-Id: I3920cdb3f54688462813d212569c9b33a1371333
This reverts commit e44a7eefb7, which is no longer
necessary now that b5c05876f7 "Related:
rhbz#1065807 recover using xdg templates and documents settings" handles
TemplatePathVariable in the generic
shell/source/backends/desktopbe/desktopbackend.cxx code.
...as had been done in the GConf-based backend prior to
3cf557c12d "drop gconf integration as per ESC
decision".
Change-Id: I56f256aaec542e0a62fc30a37d5c982e93e77812
since
commit 3cf557c12d
Author: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date: Fri Oct 16 12:15:55 2015 +0100
drop gconf integration as per ESC decision
Conflicts:
shell/source/backends/gconfbe/gconfbackend.cxx
Change-Id: If8e9b273e410250b45d3f645f6a31c1e80f02c6c
stage 2 of replacing usage of various checks for the windows platform
with the compiler-defined '_WIN32' macro
In this stage we focus on replacing usage of the WIN macro
Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84
Reviewed-on: https://gerrit.libreoffice.org/22393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
A ridiculously fast way of doing this is:
for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
--exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
perl -0777 -i -pe 's/^
{3,}/
/gm' $i
done
Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Use Qt submodule notation for Qt includes and also "correct"
some KDE headers AKA use <> notation for external headers.
Change-Id: I9457f75baae56514989800b016a11348a72a242b
Stephan Bergmann