ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
407,799 Commits 3 Branches 3 Tags
b769152dcafe2b12bd820587036cced0ec49ec4f
Commit Graph
1360 Commits
Author SHA1 Message Date
Stephan Bergmann 99c99e3c75 cid#1403658: Try harder to make Coverity Scan happy 
Change-Id: I109f95a55875b7795fc366825b3a6bb2e897d676
 2017-05-11 17:07:32 +02:00
Jochen Nitschke 959496794c cleanup osl/diagnose.h includes 
with command
> git grep -l osl/diagnose.h *.cxx |
  xargs grep -L -w 'OSL_\w*' |
  xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d'

headers need more work

Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab
Reviewed-on: https://gerrit.libreoffice.org/37350
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-05-09 15:41:46 +02:00
Stephan Bergmann a53c3cc450 loplugin:nullptr (clang-cl) 
Change-Id: I6462f3e7667951ff9306ae1f8882de747148a741
 2017-05-09 14:07:01 +02:00
Stephan Bergmann 693528ffd4 Don't use uninitialized ProxyEntry::Port values 
...and get rid of the useless ProxyEntry struct altogether

Change-Id: I846f126c96343da17518686e666a7d44c6b1bef1
 2017-05-09 10:21:19 +02:00
Thomas Beck ad711bc6e2 tdf#107587 Opening Hyperlink opens Browser in Background. 
Added neccessary WinAPI calls to bring called window into the
Foreground.

Change-Id: I080968f655e2230d1a514b3ef91bf916d904d844
Reviewed-on: https://gerrit.libreoffice.org/37196
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2017-05-04 23:52:13 +02:00
Noel Grandin 68e213319f remove empty comments 
found with:
   git ls-files | xargs grep -Pzl '/\*\*
(\*|\s|
)*\*/'

Change-Id: I1f47bcb94d5a7b290a6c622c6941195fbb578597
Reviewed-on: https://gerrit.libreoffice.org/37159
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-03 09:07:36 +02:00
Stephan Bergmann 99637fb4c6 loplugin:useuniqueptr (clang-cl) 
Change-Id: Ie541ecc3ec8d7032666b09aaec7d216a43ae44f1
 2017-04-26 17:37:13 +02:00
Stephan Bergmann 3427e613c6 loplugin:redundantcast (clang-cl) 
Change-Id: I4370a16ae9652d4f1e5aa3ed472cd88ad6d210c7
 2017-04-26 17:37:13 +02:00
Noel Grandin c70d49c7c8 use strong_int for LanguageType 
Change-Id: If99a944f7032180355da291ad283b4cfcea4f448
Reviewed-on: https://gerrit.libreoffice.org/36629
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-26 08:50:54 +02:00
Chris Sherlock da64d198ec tools: svstream.hxx needs only errcode.hxx & not errinf.hxx 
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca
Reviewed-on: https://gerrit.libreoffice.org/36896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2017-04-25 09:31:31 +02:00
Mike Kaganski aa4e06c67d tdf#103058: use RegQueryValueEx instead of RegGetValue 
because the latter is unsupported on WinXP

Change-Id: Ie922271ab837637d77f3d76c5144d10a7f5a5f0d
Reviewed-on: https://gerrit.libreoffice.org/36416
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-04-11 20:24:24 +02:00
Mike Kaganski 88829fd914 tdf#103058: allow optional registration for MS ProgIDs 
To allow in-place replacement of OWSSUPP.dll, we need to be able
to handle the same ProgIDs that it handles, namely:
SharePoint.OpenDocuments and its versions. This allows to use
the SharePoint integration capabilities of LO without the need to
reconfigure SharePoint server's DOCICON.xml (the system would
start the component with same name as MS Office uses).

But this cannot be the default mode, since if MS Office is installed
on the same system, we would hijack the registration, that could be
undesirable.

So, this commit adds an option to use
regsvr32 [/u] /i:Substitute_OWSSUPP path\to\spsupp.dll
to also [un]register SharePoint.OpenDocuments in addition to normal
LOSPSupport.OpenDocuments.

Change-Id: Icc284f9aa8f97ecf04594dd55b99bc1e3d20740d
Reviewed-on: https://gerrit.libreoffice.org/36389
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2017-04-11 09:46:58 +02:00
Stephan Bergmann 071dcb5f6a loplugin:redundantinline (clang-cl) 
Change-Id: I03a19b599005f6ef25040889a1e1802445ebf430
Reviewed-on: https://gerrit.libreoffice.org/36063
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-04-04 12:06:18 +00:00
Stephan Bergmann 9a4b0beaa5 cid#1403658: Let ImplGetLocale return empty Optional for bad input 
...like non-ASCII or too-long env var content on Linux

Change-Id: Ic2c536fa92b88108e96a0fc1a657180bc1906f01
Reviewed-on: https://gerrit.libreoffice.org/36067
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-04-04 12:05:21 +00:00
Jochen Nitschke da56de9ac4 remove type decorations on char literals 
they are only needed where type deduction fails.
left them in defines for now.

Change-Id: I7f002dd6bc7acc083c73b6c64076de6dd28d0b09
Reviewed-on: https://gerrit.libreoffice.org/35893
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-03-30 12:21:40 +00:00
Andrea Gelmini 2eae33e82e Fix typos 
Change-Id: I5518e764fd8349c476e79bb888e93a1dab01ed1d
Reviewed-on: https://gerrit.libreoffice.org/35644
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-03-26 14:02:41 +00:00
Stephan Bergmann 6d7ed03dd3 Use rtl::toAsciiLowerCase 
Change-Id: I44e9f9382de2a7235b02ad94ff51b7f21295f2ae
 2017-03-23 15:28:11 +01:00
Stephan Bergmann 77c2b0a33e In Unix ImplGetLocale, read env vars instead of calling setlocale 
...to avoid the general problems with the latter (MT issues; changing global
state)

Change-Id: I21eb129b7e1422089b3449763f64f461371ffff1
 2017-03-23 10:48:54 +01:00
Stephan Bergmann 065a124407 Use rtl::isAscii* instead of ctype.h is* with wchar_t arg 
Change-Id: I48bee0474fc4fe8be454c1e8819d8f192c9f9216
 2017-03-22 21:35:59 +01:00
Andrea Gelmini 47a9523f3f Fix typos + some German translations 
Change-Id: I1c5bb725ffdf72363279436ad9bbb88064228253
Reviewed-on: https://gerrit.libreoffice.org/35406
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-03-19 10:05:45 +00:00
Andrea Gelmini d948d66509 Fix typos 
Change-Id: I5c89a47e658ae4ad2b0cdfcdb4988c4b79353085
Reviewed-on: https://gerrit.libreoffice.org/35413
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-19 05:49:15 +00:00
dennisroczek 7e24cedb9e fix typo/grammar: "the the" --> the 
* also removing pointless ASCII art (tdf#62475)
* truncate ending whitespace in Doxyfile

Change-Id: I59b012f41ac0d170216229da85a49aa41689dee5
Reviewed-on: https://gerrit.libreoffice.org/35151
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-19 05:43:51 +00:00
Stephan Bergmann 34604446fc Various clang-cl/loplugin warnings 
Change-Id: Ib18e04e5024d15f8bbbf4921932b07465fb1f32f
 2017-03-14 14:46:49 +01:00
Andrea Gelmini 127b2e5999 Fix typos 
Change-Id: I63da858b3f264cd099e60192633b44d362b6fad7
Reviewed-on: https://gerrit.libreoffice.org/35055
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-03-12 20:02:11 +00:00
Mike Kaganski 3de2e8a32b tdf#103058: Implement OpenDocuments ActiveX control 
Change-Id: I97489090476cd884a122a4b36d3ac62ca86fd886
Reviewed-on: https://gerrit.libreoffice.org/29608
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-03-10 11:05:54 +00:00
Noel Grandin 198c41c4fe new loplugin unoany 
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89
Reviewed-on: https://gerrit.libreoffice.org/34714
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-28 10:17:47 +00:00
Stephan Bergmann 1b8807c3ca loplugin:subtlezeroinit: shell 
Change-Id: Ie8bb360a92f11e7bbf57633c702c2c496f6ff9cc
 2017-02-21 07:35:00 +01:00
Tor Lillqvist 20c43a23d1 "Unicode" is a proper noun and should not be used in plural 
The 16-bit things that make up the UTF-16 encoding are called "code
units".

Change-Id: Iab2b83323783e518198c1a0553f7b053fc415985
 2017-02-12 12:43:12 +02:00
Stephan Bergmann 8646ab97dc Remove MinGW support 
In OOo times, there'd originally been efforts to allow building on Windows with
MinGW.  Later, in LO times, this has been shifted to an attempt of cross-
compiling for Windows on Linux.  That attempt can be considered abandoned, and
the relevant code rotting.

Due to this heritage, there are now three kinds of MinGW-specific code in LO:

* Code from the original OOo native Windows effort that is no longer relevant
  for the LO cross-compilation effort, but has never been removed properly.

* Code from the original OOo native Windows effort that is re-purposed for the
  LO cross-compilation effort.

* Code that has been added specifially for the LO cross-compilation effort.

All three kinds of code are removed.

(An unrelated, remaining use of MinGW is for --enable-build-unowinreg, utilizing
--with-mingw-cross-compiler, MINGWCXX, and MINGWSTRIP.)

Change-Id: I49daad8669b4cbe49fa923050c4a4a6ff7dda568
Reviewed-on: https://gerrit.libreoffice.org/34127
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-02-10 18:01:27 +00:00
Caolán McNamara 27a673ac52 coverity#1371289 Missing move assignment operator 
Change-Id: Idc26faf904f0c89cfd66f53bb311d8ce9b41eaab
 2017-02-08 10:41:06 +00:00
Stephan Bergmann 7c62784314 loplugin:useuniqueptr (clang-cl) 
Change-Id: I9b9a6af2a7ff2dd64c474ec7f2dd084d4feb76f0
 2017-02-08 08:41:17 +01:00
Stephan Bergmann fed3783e77 Add missing #includes 
...like 6dce9c6757, for Windows-only code

Change-Id: I35f37aae2e6f55ff8ed82afc710a9b59a43b028c
 2017-02-08 08:40:06 +01:00
Stephan Bergmann 6dce9c6757 Add missing #includes 
...and remove some unncessary using directives/declarations, in preparation of
removing now-unnecessary #includes from cppumaker-generated files, post
e57ca02849 "Remove dynamic exception
specifications".

Change-Id: Iaf1f268871e2ee1d1c76cf90f03557527ebc9067
 2017-02-06 17:21:16 +01:00
Stephan Bergmann 538c042d9a loplugin:unnecessaryoverride 
Change-Id: I7a45ef38380d62ddb847bab87a2ee15ca67621fc
 2017-02-02 15:18:31 +01:00
Stephan Bergmann 5595ee701e loplugin:useuniqueptr 
Change-Id: I3a246a22baaac8195dc1b94c42994de7d80e8336
 2017-02-02 15:17:52 +01:00
Stephan Bergmann 87087bab94 loplugin:stringconstant 
Change-Id: I8b7611d6fdc55fc8cd9551e129a2e03e58682229
 2017-02-01 16:00:41 +01:00
Stephan Bergmann 5a3722b230 loplugin:stringconstant 
Change-Id: Ic22b9c0c245cca23770a05518534a666e00f9f3e
 2017-02-01 08:27:50 +01:00
Jochen Nitschke 681c329b7f loplugin:stringconstant 
Change-Id: I7e90f4fecf7243c7551ec7ecbb29adfa92a86447
Reviewed-on: https://gerrit.libreoffice.org/33648
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-01-28 14:38:25 +00:00
Noel Grandin f1d83ac45f loplugin:stringconstant check for unnecessary OUString constructor.. 
..calls when creating exceptions

Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe
Reviewed-on: https://gerrit.libreoffice.org/33617
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-28 09:22:55 +00:00
Stephan Bergmann df60fbc361 Remove dynamic exception specifications from some TDE-only code 
Change-Id: Ic5fa5648d0d52bf5a16b5d3c32c549d5fffb2f4f
 2017-01-27 12:07:10 +01:00
Noel Grandin 4511431fb6 improve "unnecessary user-declared destructor" check 
to look for inline&empty destructors, where we can just let
the compiler do it's thing

Change-Id: Ibde8800bdfed6b77649c30ebc19921167c33dec3
Reviewed-on: https://gerrit.libreoffice.org/32999
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-27 09:49:04 +00:00
Stephan Bergmann e57ca02849 Remove dynamic exception specifications 
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-01-26 12:54:43 +00:00
Caolán McNamara b29069d163 can use truncate instead of a new OUStringBuffer 
Change-Id: I6efd48af1e00c21675ef0697b38185008a794d7a
 2017-01-20 10:11:56 +00:00
Stephan Bergmann 556f1eab63 loplugin:externvar (clang-cl) 
Change-Id: I9efdd5136fdf793e0075b91fcfae4fed42050109
 2017-01-11 13:42:42 +01:00
Stephan Bergmann 1722570628 New loplugin:conststringvar: shell 
Change-Id: Ie375164d9c461c25d256f321e4efd0aedc73a263
 2017-01-10 08:10:26 +01:00
Stephan Bergmann 9b37930e8a New loplugin:externvar: shell 
Change-Id: I280df3f20a45763d6d615ee9104a19c58ff4a046
 2017-01-09 15:40:47 +01:00
Stephan Bergmann 9c7647b3b0 Dead code 
Change-Id: I70078bf77786772795bc569407a9e6ac372df758
 2016-12-14 10:28:14 +01:00
Noel Grandin 4ef9ccea6c OSL_TRACE -> SAL in sfx2..svx 
Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e
Reviewed-on: https://gerrit.libreoffice.org/31799
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-11 18:56:16 +00:00
Jochen Nitschke 8826771e83 style fixes for cppcheck noExplicitConstructor 
Change-Id: I2a690caea7656f2a18beb6d09f53154178a30f34
Reviewed-on: https://gerrit.libreoffice.org/30460
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2016-11-01 18:44:20 +00:00
Noel Grandin 9bdec0831a loplugin:oncevar in sd..svgio 
Change-Id: I58565460fcc3279c9771c6e1272d0af540b2c87c
Reviewed-on: https://gerrit.libreoffice.org/30459
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-01 13:25:08 +00:00