Commit Graph
26 Commits
Author SHA1 Message Date
Stephan Bergmann 6cb9e6dad7 Remove redundant 'inline' keyword
...from function definitions occurring within class definitions.  Done with
a rewriting Clang plugin (to be pushed later).

Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8
Reviewed-on: https://gerrit.libreoffice.org/34874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-03-03 20:55:50 +00:00
Noel Grandin 2670ca3fc5 a whole bunch of SAL_WARN_UNUSED
Change-Id: Iea28debc7d3abc58cca21bd3856cb65b321dc1e6
Reviewed-on: https://gerrit.libreoffice.org/33693
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-31 05:32:03 +00:00
Muhammet Kara 136f5a209e Prefer prefix ++/-- operators for non-primitive types.
Change-Id: I9be657cd0b5ed964db8db2ca28fd2874ae5406aa
cppcheck: performance
Reviewed-on: https://gerrit.libreoffice.org/32431
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-01-02 10:36:33 +00:00
Stephan Bergmann 6f8d047519 loplugin:salbool: Better heuristic to determine code shared between C and C++
Change-Id: I09c9c57d5adeb665cc2508fad9727085a3289bfb
2016-07-11 16:32:28 +02:00
Noel Grandin 80c874dc87 remove "object is disposed" warning in OBroadcastHelperVar::removeListener
doesn't add anything of value.

Change-Id: Ie2dea7c43570640284771c992d0072ab61de425e
Reviewed-on: https://gerrit.libreoffice.org/25871
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-08 06:40:25 +00:00
Andrea Gelmini 64d624b651 Fix typos
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-01-10 14:17:20 +00:00
Stephan Bergmann 0813839682 Missing includes (for NULL)
Change-Id: Id2359f6ff4bddb2afbc0b346e17cd858f00179e3
2015-11-10 13:14:21 +01:00
Stephan Bergmann bf3f840302 loplugin:nullptr (automatic rewrite)
Change-Id: I62a63915dfc0bced2cd8ffe3999cbde5c4d97b0b
2015-11-10 10:31:21 +01:00
Noel Grandin 08233bd258 com::sun::star->css in include/cppuhelper
Change-Id: I3d9dcd4cd756a3f0d9cedd894377a117c9dbeecc
Reviewed-on: https://gerrit.libreoffice.org/19486
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-21 06:36:39 +00:00
Andrea Gelmini b3ebda451f Fix typos
Change-Id: Ia8b2176a439742769e61fb6a981000f316033071
Reviewed-on: https://gerrit.libreoffice.org/18954
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-09-30 12:36:37 +00:00
Noel Grandin b55166d266 Revert "return and use std::vector from OInterfaceContainerHelper"
This reverts commit e57314f61f.
2015-06-29 10:11:53 +02:00
Noel Grandin e57314f61f return and use std::vector from OInterfaceContainerHelper
since most of the time we don’t need a heavyweight uno::Sequence.
Adds a new method getElementsAsVector().

Change-Id: I9e72bef0c0c723ffd0dd7d4152db5baec6784a7a
Reviewed-on: https://gerrit.libreoffice.org/15747
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-29 07:25:22 +00:00
Noel Grandin 592ba8776b comment the element_alias union
Change-Id: I0467b2e3d124e71da7df150da31e3936615e098b
Reviewed-on: https://gerrit.libreoffice.org/15746
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-05-16 18:02:03 +00:00
Stephan Bergmann edbb1b6be7 loplugin:deletedspecial
Change-Id: I0b91d813d0ec432f15aaf2d31a11dd4c505e2e54
2015-02-07 12:35:57 +01:00
Michael Stahl 40d4f917e3 sal, cppuhelper headers a little more complete and self-contained
All of them now build as-is (doing that is actually a pain because some
are named the same as C library headers and clang looks first in the
directory where the source file is in...).

Change-Id: Ief6e245c8f49fcee678aebd46394c19e4cb47f51
2014-11-19 11:55:11 +01:00
Michael Stahl 6a0fe37dec sal: clean up public headers with include-what-you-use
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
Noel Grandin 8416a65af1 fix spelling structur -> structure
Change-Id: I7aa4a9bf72732db95a67cee368f3a83a0d71bb9c
2014-07-17 14:49:41 +02:00
Noel Grandin da906ab937 cppuhelper: remove SAL_THROW macro
Change-Id: I54141071396d04e7bead56da14a665b8556ba6d2
2014-06-05 08:17:46 +02:00
Stephan Bergmann fa0ffdbeb5 cppu::OMultiTypeInterfaceContainerHelperVar hashImpl param is unused
...since f059134fab "INTEGRATION: CWS
cppuhelpshrink: #i72766# save memory in cppuhelper, using a vector instead of a
hash_map" (but a dummy "void" default is left in place for backwards
compatibility).

Change-Id: I3bb0af8158f34737d41c344464f3cf944e2891ed
2014-04-15 07:46:43 +02:00
Alexander Wilms 8792ec7b21 Remove visual noise from include
Conflicts:
	include/framework/preventduplicateinteraction.hxx
	include/sfx2/sfxbasecontroller.hxx
	include/sfx2/sfxbasemodel.hxx
	include/toolkit/awt/vclxtabpagemodel.hxx
	include/vcl/field.hxx
	include/vcl/settings.hxx

Change-Id: Ibccf9f88c68267a3d7e656012b51eaf644c418c2
Reviewed-on: https://gerrit.libreoffice.org/8272
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-03-01 09:51:32 -06:00
Stephan Bergmann 9038a3ef7c cppuhelper: Let C++ inline functions return bool instead of sal_Bool
...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx).  This change should be
transparent to client code.

Change-Id: Ibed63566266328f84432ad2019e58265d9d30fc3
2014-01-29 11:08:32 +01:00
Stephan Bergmann 0fa31bed9a Default OMultiTypeInferfaceContainerHelperVar equalImpl parameter
...and assorted OUStringHash clean up

Change-Id: I779904e1275e8df88f567beb388d1d11af9e9671
2013-12-06 12:03:59 +01:00
Norbert Thiebaud 2f3305e939 fdo#65108 inter-module includes <> include/cppuhelper
Change-Id: Ife81bf3dacb574b664982f3b4d2c7af9eb78a66a
2013-11-09 18:48:40 -06:00
Thomas Arnhold 0bd7f12d41 fixincludeguards.sh: include/c*
Change-Id: Icba422d99836518a1b662b15144bc9334bed1473
2013-10-23 23:22:30 +02:00
Stephan Bergmann c38592527a EXCEPTIONS_OFF is never defined
...since gb_LinkTarget_NOEXCEPTIONFLAGS became unused with
e81b1f23c4 "remove
gb_LinkTarget_add_noexception_object."

Change-Id: I4a7275b5b26a9d4b6ded66efb52e6866e6e09cc3
2013-08-14 13:29:39 +02:00
David Tardon 6c7659b584 move URE headers to include/
Change-Id: Ib48a12e902f2311c295b2007f08f44dee28f431d
Reviewed-on: https://gerrit.libreoffice.org/3499
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2013-04-24 05:17:10 +00:00