ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
407,799 Commits 3 Branches 3 Tags
b769152dcafe2b12bd820587036cced0ec49ec4f
Commit Graph
10884 Commits
Author SHA1 Message Date
Jochen Nitschke 05d3a1899e tdf#75280 replace uses of sal_uLong 
those vars get their type from SvStream which uses sal_uInt64

Change-Id: Ia356699bb0f5e9787ae6f02e52e0b00cc2f817b1
Reviewed-on: https://gerrit.libreoffice.org/37547
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-12 19:34:14 +02:00
Eike Rathke 534746c99e Introduce and check FormulaTokenArray::mbFinalized to not add further tokens 
Obviously after FormulaTokenArray::Assign() or the copy-ctor for that matter,
new tokens can not be added anymore to the shrunk code array. We don't do it,
but ensure that it isn't done in future..

Change-Id: Ibc0115f9f38e9745028a7459c61408c188783d03
 2017-05-12 17:54:36 +02:00
Noel Grandin dd6d7992d6 loplugin:constantparam 
Change-Id: I67d74072c776c32a1f91df94c621efe180baf5dc
Reviewed-on: https://gerrit.libreoffice.org/37481
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-12 12:30:53 +02:00
Noel Grandin a651dbcfca convert SdrLayerId to strong_int 
Also
- rename SetOfByte to SdrLayerIDSet
- add asserts in SdrLayerAdmin::GetUniqueLayerID so that we don't
  allocate overlapping SdrLayerID values
- add a new constant SDRLAYERPOS_NOTFOUND to be returned from
  SdrLayerAdmin::GetLayerPos

Change-Id: I3bb3489f9338e3d02c4040bcbd811744699941c8
Reviewed-on: https://gerrit.libreoffice.org/37467
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-12 09:54:23 +02:00
Chris Sherlock 9b5ce4023d osl: document oslFileError enumeration 
Change-Id: I870ea69135ae293b00b9ae52f254d3f7f205a109
Reviewed-on: https://gerrit.libreoffice.org/37524
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2017-05-12 09:46:35 +02:00
Chris Sherlock 81f92bc061 osl: file header comment clarification 
Change-Id: I07aa1d2452dcdd891782707ae6928027e03f00e8
Reviewed-on: https://gerrit.libreoffice.org/37523
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2017-05-12 06:55:19 +02:00
Marco Cecchetti 9cc9300bc2 lok: sc: notify cell cursor position to address control in client 
A new callback has been introduced for notifying the client:
LOK_CALLBACK_CELL_ADDRESS

Change-Id: I40b38a3cb8fb658c3f00332d56cfcbaf98e13771
Reviewed-on: https://gerrit.libreoffice.org/37357
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
 2017-05-11 17:56:09 +02:00
Gulsah Kose 198f5a16fd tdf#107258 Create show/hide all comments toggle button. 
Created new show/hide all comments button for calc by
ShowAnnotations command. Unifyied writer, calc and impress's
ShowAnnotations slot.

Change-Id: I27149d09ee1763b84258c5e0c890a9628c8874c0
Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/36697
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
 2017-05-11 16:12:11 +02:00
Stephan Bergmann 39f023f054 No need for copyable VclSimpleEvent 
fixes Windows --disable-pch build after 5aa54f1744
"break circular include"

Change-Id: I6e69dcf58d2f3b29ff1a7bbab1208ebdf1ed9f99
 2017-05-10 12:54:48 +02:00
Eike Rathke 1cf4494716 Hold ParamClass at FormulaByteToken instead of bool, tdf#107724 prep 
* change IsInForceArray() to GetInForceArray()
* add IsInForceArray() to keep previous functionality

Change-Id: I64c891486e548a66539646846a4691a213c783ac
 2017-05-10 00:39:58 +02:00
Eike Rathke f39e1b1079 Change IsForceArrayParameter() to GetForceArrayParameter(), tdf#107724 prep 
Change-Id: Icd3400e4ee1c69860908a2ad0ca6e52879f2f725
 2017-05-10 00:39:58 +02:00
Eike Rathke 8ba4679c96 Move ScParameterClassification::Type to formula::ParamClass, tdf#107724 prep 
To be able to later differentiate specific types in the compiler.

Change-Id: If97485c0cb8e8e2e129c61cd3f01d9d420c92c8d
Reviewed-on: https://gerrit.libreoffice.org/37439
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>
 2017-05-09 22:34:18 +02:00
Andrea Gelmini bd6a8ab3b8 Fix typos 
Change-Id: Ie0f67456e5c7d9b7b26b27b4d633881236ceeadb
Reviewed-on: https://gerrit.libreoffice.org/37361
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-05-09 15:22:11 +02:00
Noel Grandin 12191a4f30 make loplugin constantparam smarter about string params 
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294
Reviewed-on: https://gerrit.libreoffice.org/37426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-09 13:52:30 +02:00
Miklos Vajna 3a9854a929 tdf#107620 RTF export: handle DocumentSettingId::PARA_SPACE_MAX compat setting 
As it turns out it has a dedicated RTF control word.  With this, the
bugdoc is again kept as a one-page document during DOCX -> RTF
conversion.

If we are at it, also write the automatic before/after paragraph spacing
markup.

Change-Id: I78de644f0631e59ef507dfaa07c5a812d4ef10cd
 2017-05-09 13:51:29 +02:00
Caolán McNamara 899ffa4c4c gnome-documents: hold solarmutex on dtor patch as well 
Change-Id: I75fe71612116d435606c37185bf55b450425fc25
Reviewed-on: https://gerrit.libreoffice.org/37396
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-05-09 09:31:20 +02:00
Stephan Bergmann 10b03e6ea8 -Werror,-Wunused-private-field 
Change-Id: Id42e8699f5cfb420d49f7223ee288090539f2492
 2017-05-09 08:55:45 +02:00
Noel Grandin 719a2adfbd remove unnecessary empty OUString fields and vars 
Change-Id: I940120087a0bc6b1b0abc30a3e7727ce22b7d9a7
Reviewed-on: https://gerrit.libreoffice.org/37394
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-09 08:28:56 +02:00
Noel Grandin 4763091bbe loplugin:constantparam 
Change-Id: Ia9500b25602c14aadf49fe373682ae9d87a0a1a2
Reviewed-on: https://gerrit.libreoffice.org/37390
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-09 08:28:04 +02:00
Miklos Vajna e8a05109d9 vcl: split jpeg import into two parts 
Split the import into two:

1) Just create the bitmap, this part is not thread-safe (e.g.
OpenGLContext::makeCurrent() is called when OpenGL is enabled).

2) Import the image into an existing bitmap.

The point is that the second part takes much more time than the first,
and in the future that part may be executed on a thread, while without
such a split the whole ImportJPEG() can't do that. For now
GraphicFilter::ImportGraphic() simply invokes the two parts after each
other, so no real functional changes yet.

Change-Id: Iee742a2cd3c581aeaf1a1ed9f55cd543955a85e0
Reviewed-on: https://gerrit.libreoffice.org/37397
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-05-08 19:20:40 +02:00
Noel Grandin 034e9de08e loplugin:checkunusedparams in xmloff 
Change-Id: I59d2cb1f69882b62e6fe732e9d9214feec8a79a2
Reviewed-on: https://gerrit.libreoffice.org/37283
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-08 08:29:26 +02:00
Noel Grandin 185ed3ddb8 teach loplugin:constantparam about simple constructor calls 
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9
Reviewed-on: https://gerrit.libreoffice.org/37280
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-08 08:29:03 +02:00
Jochen Nitschke 7cc8555e0a convert EESelectionMode to scoped enum 
Change-Id: I4da22d40d5b14878b5efac1f3e4a5c76adec37b3
Reviewed-on: https://gerrit.libreoffice.org/37341
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-05-07 21:30:36 +02:00
Caolán McNamara 0e99a36c69 split clear and set graphic 
Change-Id: I3e98e872574e9edbe97099e93d787cbbcced60dd
 2017-05-07 17:24:18 +01:00
Jochen Nitschke 5aa54f1744 break circular include 
of include/vcl/window.hxx and include/vcl/vclevent.hxx

Change-Id: Iacb3cc942693a732de5899af26e08e0977a83102
Reviewed-on: https://gerrit.libreoffice.org/37338
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-05-07 14:37:42 +02:00
Andrea Gelmini fbd4147411 Fix typos 
To complete commit 076758857a

Change-Id: I6424109e3aee8a3236e40168bdd98c725a7afafb
Reviewed-on: https://gerrit.libreoffice.org/37306
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-05-07 12:45:36 +02:00
Chris Sherlock 97eb00c75e revert OSL_ASSERT changes 
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
 2017-05-07 17:03:35 +10:00
Chris Sherlock b8fc5aee3c tdf#43157: convert most of canvas codebase away from OSL_ASSERT to assert 
Change-Id: Ie6a5942dcac62a0bc3b589ff0b82922b313f88a8
 2017-05-07 09:37:20 +10:00
Chris Sherlock 85c7782eb8 tdf#43157: convert salhelper from OSL_ASSERT to assert 
Change-Id: Ibbb8cf124b79626e89938a79f40f8ee714af8e86
 2017-05-07 07:55:23 +10:00
Chris Sherlock 6d49392c4b osl: small fixes to file.h initial comment 
Change-Id: I51eeed1a9afc392c33e60d5cad784136adf28384
 2017-05-07 05:45:03 +10:00
Caolán McNamara adf0f0f103 coverity#1403665 Unrecoverable parse warning 
Change-Id: Ia4e6f856dc37a2398c5bba58e77261e5e12d3c9c
Reviewed-on: https://gerrit.libreoffice.org/37317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-05-06 20:33:34 +02:00
Andrea Gelmini a940826162 Fix typos 
To complete commit 0ef94e2b55
and f12096272e

Change-Id: Ie86bbfbd58dd728a013bef221e4d5c8fbcaf8e03
Reviewed-on: https://gerrit.libreoffice.org/37199
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-05-05 23:35:06 +02:00
Michael Stahl 156095d6b4 connectivity: convert the other OSL_ENSURE to SAL_WARN_IF 
Change-Id: Ie3d84129b73792e1f129d65350bf0e1455b08566
 2017-05-05 16:27:35 +02:00
Noel Grandin 076758857a fix spelling, methode -> method 
Change-Id: I1c7a4e657601e28d9d50d86e24c4e0ba7579b9d4
Reviewed-on: https://gerrit.libreoffice.org/37289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-05 15:39:08 +02:00
Eike Rathke cf2c51307a Introduce Date::IsEmpty() 
Change-Id: I4199b1da723c93b369c84bf664ef2d6e6e6dabb7
 2017-05-05 15:36:34 +02:00
Eike Rathke d50fc27e76 Comment that day and month must be <100 and year != 0 
Change-Id: Ibfb003f4ce108b401e3102fecd0843dc75fcb41e
 2017-05-05 15:36:34 +02:00
Maxim Monastirsky fe0451259d tdf#103158 ctrl+shift should work on key up 
Under gtk/gtk3 we send CommandEventId::ModKeyChange on
key down, to support the auto-accelerator feature. But
at least the handler in SwEditWin::Command must get it
on key up, in order to not interfere with other
ctrl+shift+X shortcuts, which work on key down.

To achieve that, we need:

- On key up pass the key that was just released, instead
  of the current state of nothing being pressed.

- Have a flag of whether it's a key down or up event, so
  it can be checked by the application code.

Change-Id: If188d6ccdc3b214a2c3ed20aad291d74d46b358f
Reviewed-on: https://gerrit.libreoffice.org/37275
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
 2017-05-05 11:27:33 +02:00
Noel Grandin e3a44cbb1d loplugin:checkunusedparams in toolkit..vbahelper 
the extra argument on the runtimeexception method was only ever passed
an "OUString()"

Change-Id: I0ea19ae9328760918f1267f27ba103432fff0b47
Reviewed-on: https://gerrit.libreoffice.org/37274
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-05 11:11:41 +02:00
Noel Grandin 93a9b70c7f loplugin:checkunusedparams in svtools 
Change-Id: Iea68d7c0683740acaf4f85c14efe2a33e0cf13e7
Reviewed-on: https://gerrit.libreoffice.org/37201
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-05 08:53:47 +02:00
Noel Grandin ac11e45bad loplugin:checkunusedparams in svx(part4) 
Change-Id: I032b49f4e1228ef275d7ff8d87ba969dcef687ab
Reviewed-on: https://gerrit.libreoffice.org/37248
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-05 08:50:46 +02:00
Noel Grandin ec38966951 loplugin:checkunusedparams in svx(part3) 
Change-Id: I4b9b749565750acc7f674957fd619870b0e29237
Reviewed-on: https://gerrit.libreoffice.org/37240
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-05 08:50:27 +02:00
Noel Grandin 44bc7fc560 loplugin:checkunusedparams in svx(part2) 
Change-Id: I608d504b64336e1cb2fc32a46908bef0cffed3bd
Reviewed-on: https://gerrit.libreoffice.org/37229
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-05 08:41:46 +02:00
Noel Grandin 57f1934bda convert HTML_TOKEN_IDS to scoped enum 
Change-Id: I525506e0103e4f17e5b8b95f15c1285d65b93de9
Reviewed-on: https://gerrit.libreoffice.org/37220
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-05 08:38:36 +02:00
Jochen Nitschke fadf6427a9 convert EVAnchorMode enum to scoped enum 
change values to match position in definition to their meaning

Change-Id: Ia96e0c7e0c70c847dea518ef871608516542d3cb
Reviewed-on: https://gerrit.libreoffice.org/37186
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-04 20:32:30 +02:00
Noel Grandin 97f391d4e5 loplugin:checkunusedparams in svx(part1) 
Change-Id: Ie98ec3be5ece2579feca050563c5ab7776ad6a7e
Reviewed-on: https://gerrit.libreoffice.org/37227
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-04 12:14:56 +02:00
Noel Grandin 214e0847f5 drop default param in SdrPaintView::VisAreaChanged 
to make it easier to remove some unused params

Change-Id: If36f5b69d8a45261ed23ea382b145ac2286ea794
Reviewed-on: https://gerrit.libreoffice.org/37225
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-04 12:05:57 +02:00
Noel Grandin d4e9fe5a73 loplugin:checkunusedparams in sfx2 
Change-Id: Iea88ddd619f10a2a2586ee24edbf07e246dcbb49
Reviewed-on: https://gerrit.libreoffice.org/37191
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-04 12:05:29 +02:00
Arnaud Versini 1fdb0e1897 Replace all OUString("") with OUString() 
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0
Reviewed-on: https://gerrit.libreoffice.org/37146
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-04 08:39:18 +02:00
Eike Rathke fd4c9d0b01 Make SvNumberformat::ImpIsIso8601() const 
Change-Id: Ied2440046ab01bc0f18629ddb885e7555b8af137
 2017-05-04 00:46:18 +02:00
Jochen Nitschke d93f33c8c9 remove unused includes 
from <com/sun/star/frame/XFrame.hpp> we only use <.../XComponent.hpp>

Change-Id: I5e3daf848e52cff62e10f9b5e91106894e16a175
Reviewed-on: https://gerrit.libreoffice.org/37160
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-03 09:10:37 +02:00