ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
473,865 Commits 3 Branches 3 Tags
b07e36ee14c8dae4331fa6c9044fa18760728275
Commit Graph
467 Commits
Author SHA1 Message Date
Gabor Kelemen e3206e6740 Recheck modules [e-f]* with IWYU 
See tdf#42949 for motivation

Change-Id: I49a3ce10dee4b03f99156f5b641f69448e1d5617
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128479
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
 2022-01-17 01:33:35 +01:00
Noel Grandin 599cb40c92 osl::Mutex->std::mutex in Oxt_Handler 
Change-Id: Iaa7120a5373c09a1515dc76e5a5ba19b16cf1554
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127102
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-12-20 09:47:16 +01:00
Noel Grandin c36a21e4a3 osl::Mutex->std::mutex in WindowCommandDispatch 
Change-Id: Ia89f4a7b1f444a031e8f58f644ba9129f8c48942
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125622
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-11-22 07:55:42 +01:00
Noel Grandin 2ab40e9ecc use more OUStringLiteral in MediaDescriptor 
Change-Id: I0567d103db8db401c737fed98483912a39352929
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124835
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-11-08 11:31:36 +01:00
Noel Grandin 9ffbbd9dba flatten PopupMenuDispatcher::queryDispatch 
Change-Id: I8dce031913a4ed40faa8d7994b1da8990d684091
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124732
Tested-by: Jenkins
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-11-05 10:41:03 +01:00
Noel Grandin 03b476c0da [-Werror=nonnull] ‘this’ pointer is null 
gcc (Ubuntu 11.2.0-7ubuntu2) 11.2.0
is now complaining about a double-unlock

Which has been there ever since
    commit fb6c93aed8
    Date:   Wed Dec 13 14:05:51 2006 +0000
    INTEGRATION: CWS fwk54 (1.1.2); FILE ADDED
    2006/11/10 12:54:27 cd 1.1.2.1: #i65187# Protocol handler for
vnd.sun.star.popup URLs to support dispatch by popup menu controller

Change-Id: I87206bb7313b69babb16859808868ffa00707faa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124731
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-11-05 10:40:43 +01:00
Mike Kaganski f662ba9536 Prepare for removal of non-const operator[] from Sequence in framework 
Change-Id: Ied2683a0b8a1bab1a7594da1e9bdbd3cb753552c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124370
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2021-10-30 10:31:26 +02:00
Noel Grandin 8a54339fc8 loplugin:referencecasting look through more clang Types 
Note that because of where the fix resides, loplugin:redundantcast
also notices a few more things.

Change-Id: I0b66047fadfff2c5ceafcbd3eab085de00d861a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120865
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-08-23 15:25:26 +02:00
Noel Grandin ae29e471ca convert #defines to OUStringLiteral 
mostly by doing

$ git grep -l '#define.*\"' -- *.cxx
    | xargs perl -pi -e
's/^#define\s+(\w+)\s+(\".*\")/constexpr OUStringLiteral \1 =
u\2;/g'

Change-Id: I63a4b050f220f0a61749892cd47fb91813f7d088
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119844
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-08-02 12:57:28 +02:00
Miklos Vajna 58aac6e941 framework, sfx2: catch more exceptions when the object is already disposed 
This can happen when an out of process Java object is registered as a
callback, then that Java process exits without notifying us.

Handle this failure by just ignoring that object, so we don't crash on
soffice process shutdown.

Change-Id: I5d61e76494c62148ef0c3db24789a5ea6e5843eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118823
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
 2021-07-13 15:47:46 +02:00
Noel Grandin 46ce0d28b4 loplugin:stringliteralvar look for assignments 
to O[U]String from char array literals, we can convert the char literals
to O[U]StringLiteral and avoid a runtime allocation

Change-Id: I15d8dddb2cd428b90740e39f20daf98e0941aa6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114125
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-04-15 13:54:53 +02:00
Vincent LE GARREC 90c978f839 tdf#124176 Use pragma once in f* 
filter, forms, fpicker, framework

Change-Id: I55a25ad2dc3749e63465e638e8eeea3c322eabbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112047
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
 2021-03-23 13:07:09 +01:00
Noel 897970cd0b loplugin:refcounting in framework 
Change-Id: I2d7d14fe0335689e4a338c70587bf33137ed1ddd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111279
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2021-02-21 16:11:48 +01:00
Philipp Hofer 49494bb703 tdf#123936 Formatting files in module framework with clang-format 
Change-Id: I8210a1d4bb51519f59265f370f5e8bab8a3c4179
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105674
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
 2020-11-13 15:18:12 +01:00
Gabor Kelemen a5389cb5dd tdf#42949 Fix new IWYU warnings in directories [e-f]* 
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I963aa5fb892a0be36212fd0587b69f217f017947
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105469
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
 2020-11-12 10:53:07 +01:00
Noel 93c64a61f2 loplugin:stringview 
Add new methods "subView" to O(U)String to return substring views
of the underlying data.

Add a clang plugin to warn when replacing existing calls to copy()
would be better to use subView().

Change-Id: I03a5732431ce60808946f2ce2c923b22845689ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105420
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-11-11 11:58:37 +01:00
Noel 700a833520 long->tools::Long in forms..framework 
Change-Id: I4cb29aade5ad1d3c3588b9437197e8493292872e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104625
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-10-22 08:06:43 +02:00
Noel eac4526f07 loplugin:reducevarscope in framework 
Change-Id: I79237d68d815f9b46277a496a05b596f58b4028b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103813
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-10-02 11:21:44 +02:00
Andrea Gelmini 765d57f755 Fix typo in code 
It passed "make check" on Linux

Change-Id: I8be2457de5018e1e764e378e609c3a41c3cb9d11
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101802
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2020-09-01 09:52:12 +02:00
Noel Grandin 6653107b83 clean up macro usage 
Change-Id: I06669718f692cc5e9e209b4e490365f4f016afdb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98389
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-07-09 08:27:53 +02:00
Noel Grandin 1a90b1aa64 framework: create instances with uno constructors 
See tdf#74608 for motivation

Change-Id: I6237016000dc05eacb14e59815b53cd44fbfce0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98384
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-07-08 21:12:50 +02:00
Noel Grandin 71227e2306 framework: create instances with uno constructors 
See tdf#74608 for motivation

Change-Id: I8679b50395d11cb2d807d52526d803df9b0606b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98294
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-07-07 22:13:02 +02:00
Fatih f62f200f31 tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctor 
Change-Id: I4f87f1735fbb61125f4c3bdd0239b28c6df400de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94471
Tested-by: Jenkins
Reviewed-by: Fatih Budak <budakf@itu.edu.tr>
Reviewed-by: Michael Stahl <michael.stahl@cib.de>
 2020-06-11 16:15:39 +02:00
Stephan Bergmann 8331ecac51 Upcoming loplugin:elidestringvar: framework 
Change-Id: I5a786316e9fa6dab0166c435c6a1ac9e5d8014a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95466
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2020-06-04 11:31:03 +02:00
Noel Grandin 89340fcb65 use for-range on Sequence in f* 
Change-Id: I820255001c1b96d1f4b76a203f3c0f76fa09fe66
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94567
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-05-21 08:48:26 +02:00
Noel Grandin ff25a4a6f4 loplugin:flatten in framework 
Change-Id: I2a74a7543b5edd853396efa31a3e2568e6607778
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91848
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-04-08 11:01:31 +02:00
Noel Grandin facc94bb0a loplugin:unusedfields 
Change-Id: Ifb9c91b3e8d6c2dd3a639a239fa41e7d5c7a4ee6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87735
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-01-30 16:17:45 +01:00
Noel Grandin e579e49983 m_aListenerContainer is effectively unused here 
ever since initial commit

Change-Id: Ia4cde1696edd26b8ddac3d093e043064d1cf87d0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86976
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2020-01-17 18:39:46 +01:00
Andrea Gelmini 22d656a45c Fix typo/grammar 
Change-Id: I8e7320224a9cb4ff9317b842a2c1c0b1a3ddcd17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86390
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2020-01-08 13:18:43 +01:00
Gabor Kelemen 0f25e181c1 tdf#42949 Fix IWYU warnings in framework/*/*cxx 
Also drop the now unused framework/inc/general.h

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I8e19036a507dbdcd178835b6ac4182719d27a654
Reviewed-on: https://gerrit.libreoffice.org/82744
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2019-11-20 10:47:20 +01:00
Gabor Kelemen e4bf92ae34 tdf#42949 Fix IWYU warnings in framework/*/*hxx 
Also drop unused framework/inc/fwkdllapi.h

Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.

Change-Id: I9e79266f273b778f4a8bd3330b1b0353a2e01a61
Reviewed-on: https://gerrit.libreoffice.org/81927
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
 2019-11-11 09:48:23 +01:00
Stephan Bergmann 3b16dfd80f Combine LoadEnv's initializeLoading and startLoading 
...as they are only ever called directly one after the other.  Rename the
original initializeLoading to startLoading, and rename the original startLoading
to private start (called at the end of the original initializeLoading).

Change-Id: I5271387450324cc26743195329c4f401cf3aa0f9
Reviewed-on: https://gerrit.libreoffice.org/82308
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-11-08 17:26:46 +01:00
Andrea Gelmini b9b8ca7739 Fix typos 
Change-Id: I5e7cbd49e8bd7d9d6957508f8c8534653854cb3c
Reviewed-on: https://gerrit.libreoffice.org/77679
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-08-19 09:39:05 +02:00
Andrea Gelmini 902f09e49f Fix typos 
Change-Id: I3f7feca68e10e53ac1a6bce2b3920fa0a142a5ef
Reviewed-on: https://gerrit.libreoffice.org/77628
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2019-08-17 17:05:34 +02:00
Andrea Gelmini a179305c35 Fix typos 
Information is always singular

Change-Id: I55275d7c2fd76c3ec0ae4a98aa952777feb90460
Reviewed-on: https://gerrit.libreoffice.org/75645
Tested-by: Jenkins
Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
 2019-08-10 07:39:52 +02:00
Stephan Bergmann 1c09998952 Improved loplugin:stringconstant (now that GCC 7 supports it): framework 
Change-Id: Ia6eef000a712c9f23f81eaf6d27f5a236da9b24d
Reviewed-on: https://gerrit.libreoffice.org/76673
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2019-07-31 12:58:15 +02:00
Noel Grandin 952b806c22 loplugin:referencecasting in framework 
Change-Id: I49aee4023fdb3173d842c19a53f9170ca1e725e4
Reviewed-on: https://gerrit.libreoffice.org/75972
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-07-20 07:55:40 +02:00
Noel Grandin 7508c1d1e7 loplugin:logexceptionnicely in filter..framework 
Change-Id: I8cf70ee278c641767e3fcfcfd151d99d791b3468
Reviewed-on: https://gerrit.libreoffice.org/74098
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-06-16 08:55:07 +02:00
Andrea Gelmini bef53853a5 Fix typo 
Change-Id: I168842ab68c8d4c3066786d9bd1beba935b9aa01
Reviewed-on: https://gerrit.libreoffice.org/74009
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2019-06-14 07:12:53 +02:00
Arkadiy Illarionov 966f40eecf Use hasElements to check Sequence emptiness in [e-i]* 
Similar to clang-tidy readability-container-size-empty

Change-Id: I79e31919db8f4132216f09a7868d18835eeb154b
Reviewed-on: https://gerrit.libreoffice.org/71795
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-05-31 16:10:17 +02:00
Caolán McNamara fbc038cc4f an uno -> a uno 
Change-Id: I538db88f8477dd2d2ad25c372928fec6c11d979d
Reviewed-on: https://gerrit.libreoffice.org/72105
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-05-10 14:50:59 +02:00
Caolán McNamara 1156f981ac an is used before a vowel sound 
not before vowels with a consonant sound so its a url not an url

Change-Id: Ic27ff3bee67469284d460c31ced6f63cb3633db2
Reviewed-on: https://gerrit.libreoffice.org/72062
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2019-05-10 10:01:13 +02:00
Noel Grandin 3fce6ae224 fix usage of successful/successfully in comments 
Change-Id: If280e1e944c877462cb84b579e19d4fd2ad1900b
Reviewed-on: https://gerrit.libreoffice.org/70813
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-04-16 12:46:55 +02:00
Noel Grandin bf9f0b2973 loplugin:sequentialassign in framework 
Change-Id: I98da731a0f6b72ea0cb890dae2f25992c75a0984
Reviewed-on: https://gerrit.libreoffice.org/70701
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-04-13 14:47:12 +02:00
Mike Kaganski 5a824268df Don't use resettable/clearable guard where plain guard is enough 
Also use scope where possible. This allows to limit guard scope at
language level; visualises the scope clearly; and helps avoiding
errors like fixed in commit 61e4437c85.

Change-Id: Ifeca96e2df8e8a0897770d9546b2536806275f41
Reviewed-on: https://gerrit.libreoffice.org/70376
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2019-04-07 17:53:04 +02:00
Arkadiy Illarionov 44841a6778 Simplify containers iterations in [f-l]* 
Use range-based loop or replace with STL functions

Change-Id: Ib3fab47318d1bfbb4df8f886a8cd9596525a420f
Reviewed-on: https://gerrit.libreoffice.org/67914
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-02-18 07:41:05 +01:00
Noel Grandin cfadf87cf5 loplugin:indentation in framework 
Change-Id: I9d0ef502eb812499b0372436083f673bb19ff578
Reviewed-on: https://gerrit.libreoffice.org/67557
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2019-02-09 17:07:24 +01:00
Noel Grandin 21de55596c remove unnecessary "if (!empty()" checks before loops 
found with
   git grep -n -A4 'if.*!.*empty' | grep -B3 -P
'(\bfor)|(\bwhile)|(\bdo)'

Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334
Reviewed-on: https://gerrit.libreoffice.org/64169
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-29 07:17:37 +01:00
Noel Grandin 2e2d736ccb loplugin:collapseif in framework..sal 
Change-Id: I3068b18f5cff024a48a8f8c68d69cadad30fe4d5
Reviewed-on: https://gerrit.libreoffice.org/62953
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-11-07 07:56:39 +01:00
Noel Grandin 2c1b7e8d6a clang-tidy readability-container-size-empty 
Change-Id: I1df70b7dff5ebb6048f7fc618789faa15ca5d422
Reviewed-on: https://gerrit.libreoffice.org/61967
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-10-19 10:02:39 +02:00