Commit Graph
458 Commits
Author SHA1 Message Date
Caolán McNamara 0048a11521 coverity#982248 Unchecked return value
Change-Id: Ice8c1b3eab28fc8ef27d802f64b7dd90a0614e42
2014-10-20 10:57:17 +01:00
Noel Grandin fb7b1f45f9 loplugin: cstylecast
Change-Id: I96a0d5d7ec3363076b0165f3c540c51ef01b58f3
2014-10-15 13:57:08 +02:00
Noel Grandin addf55184a loplugin: cstylecast
Change-Id: I37d7c3e59f1debbee8d92e76f4d08fff773000b3
2014-10-06 07:52:55 +02:00
Noel Grandin fc04f76336 fdo#82577: Handle Time
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01 07:34:23 +00:00
Stephan Bergmann 7bac68d79e Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: Id03c16337cb637c7f63fb789697c8bceec905bda
2014-08-28 16:17:35 +02:00
Tor Lillqvist 595e446aff Get rid of xmlsec_trace() and use SAL_INFO("xmlsecurity.xmlsec")
Change-Id: I3e1db89de2019285ce313f9bae1375a5b82f6383
2014-08-12 17:02:15 +03:00
Thomas Arnhold 5717de74f5 create OUString from literal
Change-Id: I8198fbad20daa7262e42a452c8d81fcfa3331680
2014-08-04 15:59:06 +02:00
Noel Grandin 3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
Noel Grandin 184a00b962 loplugin: inlinesimplememberfunctions
Change-Id: I42119f656ca528286fb25d2d36c0af54b7d04a6b
2014-06-09 10:10:13 +02:00
Thomas Arnhold b312a38797 update_pch: add a bunch of pch files
desktop:    1m51s ->   54s
 framework:  1m55s -> 1m04s
 package:      32s ->   16s
 sdext:      1m31s ->   47s
 svgio:        32s ->   15s
 uui:          49s ->   20s
 vbahelper:  1m44s ->   27s
 xmlscript:    15s ->   10s
 xmlsecurity:  45s ->   23s

Change-Id: Ia437969c091bf877983ababc5ea2d044bbc0bee0
2014-06-04 21:18:37 +02:00
Julien Nabet 2ed32f7afa cppcheck: Prefer prefix ++/-- operators
Change-Id: I290ccba1487e59ea6f86bfb0382671ca4ed50831
2014-05-24 11:32:43 +02:00
Noel Grandin e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
Thomas Arnhold 4671e7b8a4 fix-includes.pl: xmlsecurity
Change-Id: Ie3dd8674e1fa927d15eeb6a64a0cad24b8825262
2014-05-19 20:04:27 +02:00
Noel Grandin 248145f99e Find places where uno::Sequence is passed by value.
Implement a clang plugin to find them, and clean up existing code
to pass them by reference.

Change-Id: If642d87407c73346d9c0164b9fc77c5c3c4354b8
Reviewed-on: https://gerrit.libreoffice.org/9351
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-05-14 08:10:22 +00:00
Caolán McNamara f3e519d424 coverity#982735 Negative loop bound
xmlSecBase64Decode returns int

Change-Id: I5bfb273141e62f1355033c669c49af5c645da900
2014-05-11 21:05:54 +01:00
Caolán McNamara a089a4e27a coverity#707488 Uncaught exception
Change-Id: I568de20d26cff7742529a93f5a86b10ee2ac630c
2014-04-24 10:37:11 +01:00
Caolán McNamara f4a760025b coverity#707489 Uncaught exception
Change-Id: Ia15d9c6761b1b7990586b766a4f8c385c04edc0a
2014-04-24 10:37:11 +01:00
Caolán McNamara 8821c0698c coverity#707490 Uncaught exception
Change-Id: I8aeff7a5e3513d316202d40b953435238c1bf714
2014-04-24 10:37:11 +01:00
Noel Grandin e4e654e405 xmlsecurity: sal_Bool->bool
Change-Id: I4f32fe3b5133e13dab88ca1c9acd021d84dc59a9
2014-04-24 10:53:16 +02:00
Tor Lillqvist c9e2ce548b WaE: Unreferenced function definition [loplugin:unreffun]
Change-Id: Ibac16b109d9024a75fc6045d5d55fb5d21eee70a
2014-04-19 22:24:04 +03:00
Thomas Arnhold 55c70634b8 fixincludeguards.sh: xmlsecurity 2014-04-19 11:10:08 +02:00
Stephan Bergmann bfed8b9c9b Clean up function declarations
Change-Id: I448e0cf2abeeafb0f6266baeb95705b3a11705a4
2014-04-14 16:00:03 +02:00
Stephan Bergmann fb1b0c1f7b Use valid UNOIDL identifiers in XCompressedDocumentHandler
...which is new in LO 4.3 and still unpublished.

Change-Id: I2d6b553c27906d7855c62f33fdf0060b58d3ec62
2014-04-11 08:41:09 +02:00
Noel Grandin 5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00
Stephan Bergmann 70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
Noel Grandin 4386863e1a xmlsecurity: prefer passing OUString by reference
Change-Id: I44b96a8adc2f6309088d99ff3bce438f660d302d
2014-03-17 13:30:53 +02:00
Marcos Paulo de Souza 4d6560f506 fdo#54938: Convert some places to use cppu::supportsService
The last cases are non obvious, so it's pratically done

Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547
Reviewed-on: https://gerrit.libreoffice.org/8445
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-03-04 07:30:02 -06:00
Stephan Bergmann 5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Alexandre Vicenzi 92f162eb0b Convert xmlsecurity to cppu::supportsService
Change-Id: Ifcec9e067e54cc8a3d1254d41d09ea251820849d
2014-01-17 12:24:57 +01:00
Tor Lillqvist be053c9a80 Spelling correction: s/retrive/retrieve/
Change-Id: I96845d358765e2d2507763a9b15a30388b32bc6b
2013-12-20 23:26:58 +02:00
Noel Grandin 610b2b94b3 remove unnecessary use of OUString constructor when assigning
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-19 10:29:31 +02:00
Noel Grandin 2c35fff7ec remove most use of RTL_CONSTASCII_USTRINGPARAM macro
This is largely unnecessary when working with OUString

Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-19 10:29:30 +02:00
Noel Grandin 0121f632ef remove unnecessary use of OUString constructor in XMLSECURITY module
Change-Id: I95b0eda83c60456f3db267183030fe5f6cd70bc4
2013-11-07 11:28:38 +02:00
Tor Lillqvist a7724966ab Bin comments that claim to say why some header is included
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22 16:56:28 +03:00
Caolán McNamara 094f00651a CID#708741 uninitialized members
Change-Id: I15475d560e889b0f0fc91d96cfa6ae97e81a41b5
2013-10-03 13:30:13 +01:00
Andras Timar 6ea6a422fb s/wiki.services.openoffice.org/wiki.openoffice.org/g
Change-Id: I059fbee385a109069c70f3869021c8e2ee48fee1
2013-09-07 14:21:22 +02:00
Jelle van der Waa b5e5ce956b fdo#57950: Remove some chained appends in xmlsecurity
Change-Id: I35ac622abb995a9259f0774f463ec2816b3668b6
Reviewed-on: https://gerrit.libreoffice.org/5477
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
2013-08-18 13:53:54 +00:00
Andrzej J.R. Hunt 182bf2a63a Revert "fdo#57950: Remove some chained appends in xmlsecurity"
This reverts commit 4f20c9f6f9

Change-Id: I4d8cef801d570b0c20e580144e79a5940b100271
Reviewed-on: https://gerrit.libreoffice.org/5476
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
2013-08-17 15:28:01 +00:00
Jelle van der Waa 4f20c9f6f9 fdo#57950: Remove some chained appends in xmlsecurity
Change-Id: If70fa38ad4836b6dacdd0c5577c66b78be6826a6
Reviewed-on: https://gerrit.libreoffice.org/5465
Reviewed-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
Tested-by: Andrzej J.R. Hunt <andrzej@ahunt.org>
2013-08-17 07:48:21 +00:00
Tor Lillqvist 9499df9f8c Ifdef out code which had been accidentally un-commented-out
The code snippet had been commented out since its introduction in
2004. In 1452e56597 it was accidentally
un-commented-out, but it causes compilation errors. So ifdef it out
instead, with a comment. Note that I have no idea what the code does
and whether it actually is useful to keep for future reference or not.

Change-Id: Ie60ca065b2c65f86a7b382e246c1b650424daa1d
2013-08-12 09:28:57 +03:00
Jelle van der Waa 1452e56597 fdo#62475 removed pointless comments
Change-Id: I02b264a9661bcefaea96d6c5743352914154427d
Reviewed-on: https://gerrit.libreoffice.org/5345
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-08-11 19:37:59 +00:00
Jelle van der Waa ec52a20edb fdo#63690 - replace RTL_CONTEXT_ macros with SAL_INFO
Change-Id: Ie959aa5a6874aae3c60273355a959c344e82699e
Reviewed-on: https://gerrit.libreoffice.org/5083
Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org>
Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-07-24 20:18:36 +00:00
Takeshi Abe bddd4d4598 Mark as const
Change-Id: I2746b92b1360c3c181879a81f653c44ef609f351
2013-07-22 21:03:55 +09:00
Thomas Arnhold ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
Noel Grandin 670e2329df fdo#46808, Convert xml::crypto services to new style
Also remove the unnecessary XInitialization implementations.

Change-Id: I81f32b2cdcf69b84fe4b15382f9294073a7f2f20
2013-06-10 10:20:44 +02:00
Fridrich Štrba 9eb4e4dc51 Some more modules at least building with mingw64
Change-Id: I3ea039655aecb7885bb310b1f2c29d66f9f7bb4f
2013-06-06 19:49:56 +02:00
Jian Fang Zhang 3d8a7a435c Resolves: #i120675# the certificate store handles need to be closed
after closing the document

Found by: zhangjf
Patch by: zhangjf
(cherry picked from commit 33d9584bb6d285de1d935bf23adbb2c7666656f4)

Change-Id: I131a17276f33059eb944fc34272c50f838b6973f
2013-05-16 16:26:34 +01:00
Luboš Luňák e2e2cc6114 remove usage of RTL_CONSTASCII_USTRINGPARAM
Mechanical removal of usage together with OUString ctor, done
by compiler plugin.

Change-Id: I554227f76df0dac620b1b46fca32516f78b462c5
2013-05-06 16:51:45 +02:00
Miklos Vajna 3155a8e60f xmlsecurity: drop no longer needed RTL_ASCII_USTRINGPARAM macro
Change-Id: Ia08688ef3c262ba4379213231032c73404ae748b
2013-05-06 09:24:01 +02:00
Lionel Elie Mamane 9830fd36db date/time IDL datatypes incompatible change
- nanosecond precision
 - signed (allowed negative) year

Also: assorted improvements / bugfixes in date/time handling code.
Some factorisation of copy/pasted code.

Change-Id: I761a1b0b8731c82f19a0c37acbcf43d3c06d6cd6
2013-04-18 21:34:46 +02:00