ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
381,234 Commits 3 Branches 3 Tags
9983c58c3f07be3c94de35d3edc85f900241e426
Commit Graph
314 Commits
Author SHA1 Message Date
Noel Grandin 6a93b970c5 com::sun::star->css in embedserv/ 
Change-Id: Iaf1e30ae7dc9710a16a031ea623d531e9e65a6a5
Reviewed-on: https://gerrit.libreoffice.org/19025
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-01 08:01:49 +00:00
Caolán McNamara 35fd0cf311 cppcheck: noExplicitConstructor 
Change-Id: I39194062ba68c4cb1ccc9b93c629f005ccd02497
 2015-09-13 22:42:35 +01:00
Julien Nabet f0208db49d cppcheck: fix some redundantCondition warnings 
Change-Id: If53d33fb4d9ca9dc1babb9043bd07c5d29fe74c2
Reviewed-on: https://gerrit.libreoffice.org/18353
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2015-09-05 13:42:02 +00:00
Takeshi Abe aecdaa7186 tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants in embedserv and eventattacher.

Change-Id: I556ad208a7ffcf85c484e298cdbb1324b8a6a659
Reviewed-on: https://gerrit.libreoffice.org/17499
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-05 07:00:14 +00:00
Noel Grandin b55166d266 Revert "return and use std::vector from OInterfaceContainerHelper" 
This reverts commit e57314f61f.
 2015-06-29 10:11:53 +02:00
Noel Grandin e57314f61f return and use std::vector from OInterfaceContainerHelper 
since most of the time we don’t need a heavyweight uno::Sequence.
Adds a new method getElementsAsVector().

Change-Id: I9e72bef0c0c723ffd0dd7d4152db5baec6784a7a
Reviewed-on: https://gerrit.libreoffice.org/15747
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-06-29 07:25:22 +00:00
Noel Grandin 4729774b24 remove unnecessary check for null when calling delete 
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'

Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
 2015-06-15 14:46:41 +02:00
Stephan Bergmann fccf76ee8c css::uno::Reference can automatically up-cast now 
follow-up to 8568c7226c "tdf#66232: Cannot open
files by COM2"

Change-Id: I5a0858dd6f48136f9f07b0d04c5634a6173dd154
 2015-05-04 13:11:13 +02:00
Mike Kaganski 8568c7226c tdf#66232: Cannot open files by COM2 
As suggested by comment 13 of the bug, the problem is caused
by commit b248624126 by Noel Grandin.

1. DocumentHolder::DocumentFrame(): XDesktop2 cannot be directly
queried for XFrame2. And in this case, simple XFrame is enough.

2. DocumentHolder::CloseFrame(): m_xFrame->dispose() violates an
assert because of NULL reference. Reverted to previous code.

3. Following commit debde4fdc4 by
Andras Timar (supposed to fix the bug), found two places where
previously used to be UNO_QUERY, but now UNO_QUERY_THROW is used.
These places are reverted to use UNO_QUERY.

Change-Id: Ifb9e74367d5dd99ba12166abdd443b29a8018aeb
Reviewed-on: https://gerrit.libreoffice.org/15607
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
 2015-05-03 16:14:03 +00:00
Noel Grandin 71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Stephan Bergmann c6dcd7b7f3 Fix various Windows-only XServiceInfo implementations 
...to match what is recorded in the .component files

Change-Id: Ibc5bb0575f3869317e4d14614cf1dad0af728ddc
 2015-03-24 18:08:39 +01:00
Julien Nabet b98ac70724 Typo: trough->through 
Change-Id: I5af784709df88492695d1ac9c9a5b020e909f362
 2015-02-21 14:45:36 +01:00
Caolán McNamara ca8787a981 boost::unordered_map->std::unordered_map 
Change-Id: I5d458f43616edc395faa8c27edaddc7d515166db
 2015-01-04 12:51:09 +00:00
Michael Stahl 15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use 
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
 2014-11-18 18:51:49 +01:00
Michael Stahl 6a0fe37dec sal: clean up public headers with include-what-you-use 
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
 2014-11-17 11:06:53 +01:00
Andrea Gelmini da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Jens Carl 3ddb928061 fdo#68849: Add header guards to all include files 
Added header guards to files in directories desktop/*, and embedserv/*

Change-Id: Idaffcc0539b84962ed7c132cb20078512799d433
Reviewed-on: https://gerrit.libreoffice.org/9556
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-05-30 01:44:03 -05:00
Julien Nabet b09b5f8f7c Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part19 
Change-Id: Iab50c52a132c90389992ef68c2d31df95a193ab9
 2014-05-22 23:21:18 +02:00
Thomas Arnhold 2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left 
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-05-15 12:50:46 +00:00
Thomas Arnhold c327acab9e remove globally disabled warnings from source files 
Change-Id: Ic7b092a24b4d1e48ca11e53b507da5c2bfdeabe8
 2014-05-10 13:03:20 +02:00
Stephan Bergmann fa0ffdbeb5 cppu::OMultiTypeInterfaceContainerHelperVar hashImpl param is unused 
...since f059134fab "INTEGRATION: CWS
cppuhelpshrink: #i72766# save memory in cppuhelper, using a vector instead of a
hash_map" (but a dummy "void" default is left in place for backwards
compatibility).

Change-Id: I3bb0af8158f34737d41c344464f3cf944e2891ed
 2014-04-15 07:46:43 +02:00
Stephan Bergmann c63ba20f2a embedserv: simplify deprecated XTypeProvider.getImplementationId 
Change-Id: I383eea6c556005e1547df364b4cf34042b5e3a18
 2014-03-10 17:39:54 +01:00
Alexander Wilms eb8b76211e Remove visual noise from embedserv 
Change-Id: I4914fd2f3e067fcc10fc110f172d3e33daa0977b
Reviewed-on: https://gerrit.libreoffice.org/8257
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 15:00:58 -06:00
Alexander Wilms 0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Stephan Bergmann 612dac063a bool improvements 
Change-Id: I0dc09b7a6ee2849bd0c2ffc31be45f81cd2c15ee
 2014-01-29 11:08:32 +01:00
Andras Timar b55259eeb5 typo fixes 
Change-Id: Ia5f104bfd707bcf4e159c78ca2764c861fb0b6d9
 2013-12-20 15:55:00 +01:00
Stephan Bergmann 0fa31bed9a Default OMultiTypeInferfaceContainerHelperVar equalImpl parameter 
...and assorted OUStringHash clean up

Change-Id: I779904e1275e8df88f567beb388d1d11af9e9671
 2013-12-06 12:03:59 +01:00
Michael Stahl b24957e812 clean up some COM initialization 
CoInitialize{Ex] always exist in all supported Win32 versions, so just
call them.

Change-Id: I45f227319aae811b6c94a3ac475467a06146b8e9
 2013-11-28 00:59:48 +01:00
Tor Lillqvist 72365491e3 Use <windows.h> with a lower-case 'w' for cross-compilation goodness 
Change-Id: Ia7ec6c4e9808a379e955a013264e1f92a7f6a358
 2013-11-20 18:40:49 +02:00
Thomas Arnhold f01580ce9c Windows: Require at least Windows XP SP2 
* Windows XP SP2 is 0x0502, see
  http://msdn.microsoft.com/en-us/library/aa383745.aspx
* If a module changes the Windows SDK version setting,
  this is done module wide now. So the overall behavior
  is as before. This seems to be the best compromise for
  now.
* We need at least SP2 because of the bluetooth stuff
  used in sd/source/ui/remotecontrol.
* Now, we require at least Internet Explorer 7.0. IE6
  has been outdated for a long time.
* Leave StdAfx.h file definitions, as those are Microsoft
  project specific precompiled header files.
* All local definitions of WINVER are removed, because
  the global WINVER setting makes them obsolete now.

To the relation of the three macros:

Setting _WIN32_WINNT sets WINVER and NTDDI_VERSION
automatically to the same value as _WIN32_WINNT.

WINVER and NTDDI_VERSION can be set idenpendently each
for itself.

Change-Id: Ibcc12493aae4fcaf7bcfda88be99c1b61bc326cb
Reviewed-on: https://gerrit.libreoffice.org/6496
Reviewed-by: Thorsten Behrens <thb@documentfoundation.org>
Tested-by: Thorsten Behrens <thb@documentfoundation.org>
 2013-11-20 07:15:16 -06:00
Andras Timar debde4fdc4 fdo#66232 fix opening files via COM server 
Thanks to Noel Grandin & Stephan Bergmann for the hint on IRC.

Change-Id: I2b407a53b02a7ecdbff553ad47674c1e00455180
 2013-11-19 12:45:14 +01:00
Noel Grandin 610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Noel Grandin 2c35fff7ec remove most use of RTL_CONSTASCII_USTRINGPARAM macro 
This is largely unnecessary when working with OUString

Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
 2013-11-19 10:29:30 +02:00
Andras Timar d360febd39 embedserv: unused code 
Change-Id: I6343cf1f274de407b6de18304612b69e2516f621
 2013-11-14 05:08:24 -08:00
Noel Grandin e52779d2f8 remove unnecessary use of OUString constructor 
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
 2013-11-11 11:21:26 +02:00
Thomas Arnhold f852bda5ec clean up some include guards 
Conflicts:
	sw/source/ui/inc/content.hxx

Change-Id: I58d81881271fc6e3320bf3b5f1321594b28614a6
Reviewed-on: https://gerrit.libreoffice.org/6388
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2013-10-23 10:28:07 +00:00
Tor Lillqvist a463f74ebf WaE: C4723: potential divide by 0 
Fix crack that formats an int into eight hex digits. Why the simple
sprintf() that originally was used here was not good enough, but had
to be replaced (in 2009) by broken and hard to understand code I have
no idea.

Found during link-time code generation (!).

Change-Id: I05b33ca0fcb6a47a846ec2ff294243c5639a5b49
 2013-09-04 00:40:46 +03:00
Michael Meeks d32b179c3f more liblibreoffice pieces. 
Change-Id: I21d67de281847321d784cddc652d4a51a437fadf
 2013-07-26 18:22:19 +01:00
Thomas Arnhold ba0a57702c remove OUString wrap for string literals 
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-06-29 21:52:54 +00:00
Marcos Paulo de Souza c914d7d5cc fdo#63154: Remove all usages of the macro EXTERN_C 
Change-Id: I25b7f509ba5d1007a16c84ad05870a8174c094ec
Reviewed-on: https://gerrit.libreoffice.org/3621
Reviewed-by: Tor Lillqvist <tml@iki.fi>
Tested-by: Tor Lillqvist <tml@iki.fi>
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
 2013-04-26 11:52:36 +00:00
Noel Grandin d95fb607c2 fix windows build 2013-04-08 15:24:40 +02:00
Noel Grandin 84373a71d6 fix windows build 2013-04-08 14:56:59 +02:00
Noel Grandin b248624126 fdo#46808, Convert frame::Frame to new style 
Change-Id: I74427d1e0059808f04960c648b93245b06c20f7f
 2013-04-08 13:53:04 +02:00
Luboš Luňák 1946794ae0 mass removal of rtl:: prefixes for O(U)String* 
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
 2013-04-07 14:23:11 +02:00
Thomas Arnhold 488e6875e9 remove external include guards 
Change-Id: If5758e02baa8e019923355b6c97043b306223fdd
 2013-03-25 19:58:16 +01:00
Thomas Arnhold 39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations 
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-03-19 10:48:30 +00:00
Thomas Arnhold 8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings 
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-03-19 09:00:26 +00:00
Julien Nabet 1443a9f7ab [Uu]sefull -> [Uu]seful 
Change-Id: I5dad83789ff9b6815561208679a5e19821041e1f
 2013-02-22 11:12:33 +01:00
Stephan Bergmann a6f978e1c3 Logic (only update ret if it does not indicate an error yet) 
Change-Id: I717ff4de7cf406b01383f8f181b81695242a2ca8
 2013-01-08 16:42:23 +01:00
Julien Nabet 1f5ae5e8c1 test on the return of pOleObject->Close 
Change-Id: Iee64f6f369e2312d479fa81e7a59fb962ed8d90e
Reviewed-on: https://gerrit.libreoffice.org/1567
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
 2013-01-08 09:40:34 +00:00