ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
485,243 Commits 3 Branches 3 Tags
94de79e7d3c980b576192d2f264bee658716163a
Commit Graph
3675 Commits
Author SHA1 Message Date
Adolfo Jayme Barrientos 7a229155aa Related: tdf#154684 Make this string more specific 
Change-Id: Id28083f1549c752555068dc715131c38f09adb23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150180
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2023-04-10 13:22:27 +02:00
Julien Nabet 26012007e4 tdf#154658: XML Form Document: Fields doesnt calculate any more 
Regression from 73334560b2
author	Julien Nabet <serval2412@yahoo.fr>	2021-11-07 15:40:37 +0100
committer	Julien Nabet <serval2412@yahoo.fr>	2021-11-07 21:58:53 +0100
commit	73334560b2 (patch)
tree	b5bc4f69dd
parent	6be03ac71e (diff)
Replace some macros in forms part 16

A big thank you to Raal for having spotted this!

Change-Id: Ib6f1878897b16b43df287702f82835824c1f766d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150174
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
 2023-04-10 12:01:57 +02:00
Noel Grandin 3a0c5b7820 loplugin:stringadd in editeng..framework 
after my patch to merge the bufferadd loplugin into stringadd

Change-Id: Ieac16a01fde6467a2f6fe47864069304a3c44e47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149552
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-25 07:27:34 +00:00
Noel Grandin f5bfc127dd elide some temporary OUStrings 
where we are calling
  append(OUString::createFromAscii(
and we can rather call
  appendAscii

Change-Id: I2366b518fe6d8d2484b00bb831cb79fb49bc0293
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149043
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-17 09:41:13 +00:00
Noel Grandin 13d3ae64db make more use of OUStringBuffer::append(OUStringConcat) 
where we can avoid constructing temporary OUStrings

Change-Id: I0eacd68a8d1b450894c2ea769055f16886b78ad0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148780
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-13 16:47:32 +00:00
Noel Grandin bb92647934 no need to allocate these separately 
they are all one or two words in size

Change-Id: Idc76cb87d1dae7ef245f327dc4afebaf71190f6b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148342
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-03-06 19:58:02 +00:00
Noel Grandin 0292570e63 osl::Mutex->std::mutex in CProgressHandlerHelper 
Change-Id: I86ddf381e0d52fe50739d5378ea36059a4d1e521
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147863
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-02-27 14:11:02 +00:00
Noel Grandin 1ce02008ae osl::Mutex->std::mutex in frm::OComponentEventThread 
Change-Id: I419a96fce0d5dbdd438dda32217ced39ba598446
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147864
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-02-27 14:10:03 +00:00
Noel Grandin 1f49d8ad7a BaseMutex->std::mutex in ListenerMultiplexerBase 
Change-Id: Icd565c83ca3b4afb1a846a637b7943b0498487e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147457
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-02-22 11:47:11 +00:00
Caolán McNamara c6668bf7f8 cid#1520418 Unchecked dynamic_cast 
and

cid#1520419 Unchecked dynamic_cast
cid#1520420 Unchecked dynamic_cast

Change-Id: Ia5ef238677bd5eadcdb7fc3fcf982d8a1507133c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145768
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2023-01-19 10:33:16 +00:00
Noel Grandin 7195e2740e cleanup commit for Submission 
The following commit missed some stuff:
    commit fc41f4d58c
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Sat Jan 14 12:41:58 2023 +0200
    XUnoTunnel->dynamic_cast in Submission

Change-Id: Ic27a813e360ae39227cd68213d2899ab64f0dee5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145688
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-01-18 05:01:26 +00:00
Noel Grandin fc41f4d58c XUnoTunnel->dynamic_cast in Submission 
Change-Id: I2bafbecdd1b3f16375880e49708fe932db060812
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145626
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-01-17 16:10:02 +00:00
Noel Grandin 68a8d0e750 XUnoTunnel->dynamic_cast in forms::Model 
Change-Id: I60525e6c4f2d2400cdc47538e9d704b10b7c87ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145627
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-01-17 06:43:02 +00:00
Noel Grandin 27d76f145a tdf#153039 submitting XML from XForms document 
regression from
    commit 5fd2f0b93b
    Author: Noel Grandin <noel.grandin@collabora.co.uk>
    Date:   Thu Jan 12 09:19:03 2023 +0200
    use concrete class in Submission

Change-Id: I99bc069b5243e994da71287960e29be6ab3338ac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145567
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-01-16 15:33:24 +00:00
Andrea Gelmini 32911b8fe9 Fix typo 
Change-Id: I4d6b70095259b179f8ac3fc210899ffa84b87fa0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145492
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2023-01-13 20:26:24 +00:00
Noel Grandin 172aedbc51 XUnoTunnel->dynamic_cast in VCLXDevice 
Change-Id: I9fa06600d3b9a2172a1818f89a3b9c06d65c8c54
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145467
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-01-13 12:53:27 +00:00
Tomaž Vajngerl 197e5f8121 introduce {Char,Fill}ColorThemeReference which uses XThemeColor 
Adds a unified UNO property for theme colors *ColorTheme
(CharColorTheme and FillColorTheme) which uses XThemeColor, that
replaces the properties *Theme, *TintOrShade, *LumOff, *LumMod.
The properties are still present for backwards compatibility and
to keep ODF support working in tests as that needs a bigger change.

Reactor the code and tests to accomodate for this change.

Change-Id: If7983decb4ba528b49fe7b5968aa9efc696a9efc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144783
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2023-01-13 00:49:24 +00:00
Noel Grandin 5fd2f0b93b use concrete class in Submission 
the code already relies on the underlying type of mxModel being Model
rather than XModel

Change-Id: I5b78482d37024a5bc274b0208fa56e4328f3f5f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145390
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-01-12 14:46:19 +00:00
Noel Grandin 21734247d5 drop internal support for 1-bit images 
on modern hardware, these are less efficient than regular alpha
channels.

Also, this greatly simplies the range of stuff that vcl needs to deal
with, which will make the upcoming transparency->alpha patch easier to
deal with.

Enhance vcl::CreateFromData to convert incoming 1-bit data to 8-bit
image.

Change-Id: I35829da750029fe373d0d2911a669d10bab6ad23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145321
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-01-12 06:52:42 +00:00
Noel Grandin cfb2a587bc rename BitmapEx::GetAlpha to GetAlphaMask 
to ease the reading of code related to an upcoming patch to convert
transparency to alpha, since there is already a GetAlpha in Color.

Change-Id: I1af0f8f6dd94acfe4673c8556c7aff6c20da3f7a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145209
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2023-01-11 08:57:13 +00:00
Stephan Bergmann 19691c3b68 Revert all the recent loplugin:unocast changes 
...as obsoleted by ef53355355 "Rudimentary support
for dynamic_cast on UNO proxy objects".

This reverts all of:
4cfcc9ac37 "loplugin:unocast (framework::Desktop)"
03efbf72f4 "loplugin:unocast
 (vclcanvas::TextLayout)"
80099fdd51 "loplugin:unocast (SalGtkXWindow)"
cc147f576d "loplugin:unocast
 (sdext::presenter::CachablePresenterView)"
40db42be1d "loplugin:unocast
 (vclcanvas::CanvasFont)"
2d1e7995ea "loplugin:unocast (CairoColorSpace)"
4c0bbe4bd9 "loplugin:unocast
 (canvas::ParametricPolyPolygon)"
8980366662 "loplugin:unocast
 (vclcanas::CanvasBitmap)"
d5e0c2c8db "loplugin:unocast
 (sfx2::DigitalSignatures)"
c0c4519e0d "loplugin:unocast
 (VCLXAccessibleComponent)"
feb8b833a6 "loplugin:unocast (VCLXDialog)"
1fa58cc6cc "loplugin:unocast (VCLXMultiPage)"
f481f036de "loplugin:unocast
 (DocumentSettingsSerializer)"
73df933f5f "loplugin:unocast
 (css::embed::EmbeddedUpdate)"
420165ab0e "loplugin:unocast
 (canvas::tools' StandardColorSpace, StandardNoAlphaColorSpace)"
9abe8ee067 "loplugin:unocast (MutableTreeNode)"
9f3022ceb0 "loplugin:unocast (VCLXTabPage)"
1be70dda02 "loplugin:unocast
 (vcl::unotools::VclCanvasBitmap)"
d6a70bb641 "loplugin:unocast
 (basegfx::unotools::UnoPolyPolygon)"
5a14f009e6 "loplugin:unocast
 (xmlsecurity::Certificate)"
99009c9535 "loplugin:unocast (sd::Annotation)"
0c7585c5fa "loplugin:unocast (sd::TextApiObject)"
24e14afd1b "loplugin:unocast
 (SignatureVerifierImpl)"
1a7ad0c10d "loplugin:unocast
 (pcr::PropertyEventTranslation)"
a97e2d2702 "loplugin:unocast (RangePageBreaks)"
19dfdf86ad "iloplugin:unocast
 (pcr::OFormattedNumericControl)"
f9785ea595 "loplugin:unocast
 (frm::OInterfaceContainer)"
5e5f40a4a9 "loplugin:unocast (ScVbaShapes)"
27b35b2c21 "loplugin:unocast (ScVbaShapeRange)"
cb3108f860 "cid#1517812 Dereference null return
 value"
feba0ddb15 "loplugin:unocast
 (weld::TransportAsXWindow)"
4d6c232165 "loplugin:unocast
 (oox::ForumlaImExportBase)"
4844c096a8 "loplugin:unocast
 (cairocanvas::SurfaceProvider)"
9a0b523e0a "loplugin:unocast
 (cairocanvas::CanvasBitmap)"
8a5648d8e5 "loplugin:unocast
 (cairocanvas::TextLayout)"
28c27a0623 "loplugin:unocast
 (cairocanvas::CanvasFont)"
53bc223cb3 "loplugin:unocast
 (cairocanvas::RepaintTarget)"
5f70b0b9f6 "loplugin:unocast (SvXMLImport)"
068187a898 "loplugin:unocast (VCLXWindow)"
88b4f96620 "loplugin:unocast
 (sfx2::sidebar::SidebarController)"
f1b7a69b28 "loplugin:unocast
 (SvxLineStyleToolBoxControl)"
ba76f0ba7e "loplugin:unocast
 (i18npool::Calendar_gregorian)"
840154daf9 "loplugin:unocast
 (framework::AddonsToolBarWrapper)"
b0e9c4c5f0 "loplugin:unocast
 (GrammarCheckingIterator)"
8ee6cfc965 "loplugin:unocast
 (ucb::ucp::ext::Content)"
5b8cd77c11 "loplugin:unocast
 (basic::SfxScriptLibraryContainer)"
9e73ff9fce "loplugin:unocast
 (sdext::presenter::PresenterNotesView)"
a98acca8fb "loplugin:unocast
 (SelectionChangeHandler)"
c0b59ad6e3 "Consistently use
 comphelper::getSomethingImpl<I>(aIdentifier, this)"
276e3ccbdd "loplugin:unocast
 (vclcanvas::RepaintTarget)"

Change-Id: I37c73e3422a5154bf6cb647640d2d3f23db8bc34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145063
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2023-01-05 11:45:51 +00:00
Stephan Bergmann f9785ea595 loplugin:unocast (frm::OInterfaceContainer) 
(See the upcoming commit introducing that loplugin:unocast on why such
dynamic_casts from UNO types are dangerous.)

Change-Id: Ie8f6fbe25dfffc082033a4bc967d738143746506
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/144635
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-12-21 06:43:15 +00:00
Nalini Prasad Dash 855bf4d688 tdf#114441 - Convert use of sal_uLong to better integer types 
The variable type of nHeight was changed as the return type of
pFontHeightItem->GetHeight() is sal_uInt32.Also nBit was assigned
the underlying datatype of LB(int) as it was checked against
LB::LAST(Value converted to underlying datatype of LB) in the for loop .

Change-Id: I657d545ac7af1786edd61569ba43b42e55d1f47b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143145
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-12-08 22:44:38 +00:00
Mike Kaganski b15eb164a8 tdf#152380: add checks for names and values sequences length equality 
Change-Id: Ibeef551126874bcfffb4e7736588e2e1873f5768
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143681
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2022-12-06 05:32:37 +00:00
Noel Grandin 9c2e77152c loplugin:unusedfields make some fields private 
this is one of the secondary analyses this plugin performs

Change-Id: Iaa4424c2396470c6f1df85b0290fbffdda35fa08
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143177
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-11-23 20:49:03 +01:00
Noel Grandin 767092fe2c loplugin:referencecasting look for a new pattern 
Change-Id: Ib7ded8db2c513909159f0876389f63b60082a529
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141618
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-10-21 15:50:35 +02:00
Noel Grandin 425255567e use more string_view 
Change-Id: Ie826234aa9064b08b8f0647738b57c47ac0ed91a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141369
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-10-17 10:39:11 +02:00
Andreas Heinisch 7c1a815288 tdf#122319 - Don't allow nullable form components if input is required 
Change-Id: I676aab37df7a98192680b87f0143a27d2a5fd3ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140713
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
 2022-10-05 15:31:51 +02:00
Caolán McNamara ca46afebb7 default to 'flat' instead of '3D Look' for form controls 
better matches what the pdf/print output will be.

Change-Id: I86869024768877f8345c4a0c320eb24d48b35f13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140947
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-10-04 21:18:15 +02:00
Caolán McNamara ea36e0502c tdf#150786 use a 'standard' theme for form controls 
i.e. ignore system theme so we get the same results on export to pdf
regardless of the theme (esp dark) and don't follow the system theme
when hosted with a writer/calc/impress document (do continue to use
system theme for StarBasic dialogs as seen in BasicIDE)

Didn't reuse 'NativeWidgetLook' for this because is currently defaults
off, while we currently do use the colors derived from the system theme
even when this is off, its really the NWF flag to render using the
platform theming engine

Change-Id: I816d7ebaf793e5eac7bd937d44c1db0371145199
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140942
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-10-04 21:17:46 +02:00
Ilhan Yesil ba164651bb tdf#149797 Change highlight background color in some controls 
The highlight and highlighttext colors can be set for some
controls. So as example a selected item in a listbox can now
be paint with anothers colors then the standard blue. Controls
are: listbox, combobox, edit field and some special edit
fields like date, currency and others.

Change-Id: Iace2dd9a1a61abb7819b6c81eb0b8030912db32b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136691
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
 2022-09-19 13:30:15 +02:00
Samuel Mehrbrodt 467085bfb0 Rename MouseNotifyEvent to NotifyEventType 
Also contains keyboard and focus events, not only mouse events

Change-Id: Iec1d6c341b01a489ba80fe9634ea3579afb02ea9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139970
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
 2022-09-19 11:42:59 +02:00
Noel Grandin fd3888c69a move ErrCode to comphelper and improve debug output string 
need to move it, because modules "below" vcl want
to use the debug output method

Change-Id: Ibcaf4089a1e0b3fcc0b5189c7ebf1aae90f50b48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139791
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-09-14 08:34:38 +02:00
Noel Grandin 16987d2aae unique_ptr->optional for Graphic 
Graphic is just a wrapper around shared_ptr, so no need to
allocate this separately

Change-Id: Ie657dea1c021e66a6876e814090a44cb6f995b91
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139739
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-09-10 12:19:13 +02:00
Juan C. Sanz 5d40ced9e8 Revert "tdf#150569 Modify hardcoded dates to extend the range of accepted dates" 
This reverts commit b20594f2fc.

Reason for revert: Further testing has shown some errors in other ways of displaying the data

Change-Id: Ic4909f8571c8730ab3ba622c7fad99f2646616ca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139566
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-09-08 10:24:01 +02:00
jucasaca b20594f2fc tdf#150569 Modify hardcoded dates to extend the range of accepted dates 
Replaces date range limits to allow entry of dates between 1/1/0001 and
31/12/9999, which is the normal date range in most database manager

May need some discussion

Change-Id: Ide8dfc64663d2ef2a66d8b7e1af3ef8ed3bb0af5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138845
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-09-07 12:48:16 +02:00
Caolán McNamara 310a524907 cid#1500688 silence Dereference after null check 
Change-Id: I53ffb3537b2ac5618a9776c946eebf866f725cb1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138929
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-08-27 15:30:03 +02:00
Stephan Bergmann 91ba9654ba Move tools/diagnose_ex.h to comphelper/diagnose_ex.hxx 
...so that its TOOLS_WARN_EXCEPTION can be used in
comphelper/source/misc/logging.cxx in a follow-up commit.  (And while at it,
rename from diangose_ex.h to the more appropriate diagnose_ex.hxx.  The
comphelper module is sufficiently low-level for this immediate use case, so use
that at least for now; o3tl might be even more suitable but doesn't have a
Library until now.  Also, for the immediate use case it would have sufficed to
only break DbgGetCaughtException, exceptionToString, TOOLS_WARN_EXCEPTION,
TOOLS_WARN_EXCEPTION_IF, and TOOLS_INFO_EXCEPTION out of
include/tools/diagnose_ex.h into an additional new
include/comphelper/diagnose_ex.hxx, but its probably easier overall to just move
the complete include file as is.)

Change-Id: I9f3222d4ccf1a9ac29d7eb9ba1530d53e2affaee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138451
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-08-18 17:10:19 +02:00
Maxim Monastirsky c76857fe4e Make ToolBox::InsertItem take the command name 
For the next patch for tdf#149956 I need the command to be
already set when the VclEventId::ToolboxItemAdded event is emitted.

Change-Id: I3d8ce44b426a3ed5704d4520d6e62bc4efbf8e44
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138038
Tested-by: Jenkins
Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
 2022-08-10 08:28:18 +02:00
Caolán McNamara 479cf04cee drop unwanted scroll corner 
Change-Id: I82143de336df91c5ca69693f6255b0d729e8381b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137978
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-08-08 20:26:28 +02:00
Caolán McNamara cdf5b6a2a6 tdf#117388 use native scrollbar under gtk in richedit control 
you get one of these by starting with a normal text box form control
and changing its "text type" property to multi-line with formatting

Change-Id: If922b6b9fdc49b78fa379dbb3e5974a73f6095ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137933
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2022-08-08 09:54:31 +02:00
Noel Grandin 0351bec874 use more o3tl::span 
which means we can reserve precisely the right number of entries when
building maps

Change-Id: I580414699289369de4730caae09829bbd8759e82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137292
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-07-25 10:00:23 +02:00
Noel Grandin faa40c022c elide some makeStringAndClear() calls 
Change-Id: I8636102554a76f2ba3f6297219b40761473a4489
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137285
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-07-21 11:01:22 +02:00
Chris Sherlock 845393b9aa move wintypes.hxx from tools to vcl 
Change-Id: Ief9949fd4252de9e33df172af07aa7ed097b5520
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136560
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2022-07-20 12:20:59 +02:00
Noel Grandin 7778a1a573 clang-tidy modernize-pass-by-value in forms 
Change-Id: I9b4b8db9872ccc8aeb461e34ceed203af7ea35b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136204
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-06-21 12:59:54 +02:00
Noel Grandin f71606c920 new loplugin:moveit 
look for local variables that can be std::move'd to parameters

off by default, since it doesn't do proper data flow analysis

Change-Id: I3403a0fcffd165bdea6a772528bc53995c5fdb40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135527
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-06-10 13:13:15 +02:00
Stephan Bergmann 5060c50158 Use o3tl::make_unsigned in some places 
...where a signed and an unsigned value are compared, and the signed value has
just been proven to be non-negative here

Change-Id: I20600d61a5d59d739bc1bee838c0038e4611aec2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134875
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-05-24 16:50:03 +02:00
Stephan Bergmann efdf328a71 Just use Any ctor instead of makeAny in forms 
Change-Id: I25183cc06728c81e45b28fd41071c15abf05bbc1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133809
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2022-05-04 12:11:29 +02:00
Noel Grandin ddef1e2c01 add o3tl::equalsAscii 
Change-Id: I042b8dcadbf7581de325c161763fe35aecde5ca2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133694
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-03 09:12:32 +02:00
Noel Grandin 5200a73627 use more string_view in various 
found by examining uses of OUString::copy() for likely places

Change-Id: I6ff20e7b273ad6005410b82719183c1122f8c018
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133617
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2022-05-01 08:30:18 +02:00