Commit Graph
57 Commits
Author SHA1 Message Date
Miklos Vajna f3e8d0fb31 xmlsecurity: create XMLDocumentWrapper instances with a constructor
Change-Id: I23bca00fb0fbcae92e73c4a106b08edd5caf5cf9
Reviewed-on: https://gerrit.libreoffice.org/51720
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-22 09:05:41 +01:00
Miklos Vajna 4bb67227c1 xmlsecurity: create XMLElementWrapper instances with a constructor
Change-Id: I0fe7d0a21b0ea35b537466316a637a0a46c52fe5
Reviewed-on: https://gerrit.libreoffice.org/50601
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2018-03-02 08:07:52 +01:00
Stephan Bergmann e5262ed74d More loplugin:cstylecast: xmlsecurity
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: Ica6e96072435aa4df4e74accdfe06f798a640bbe
2018-01-12 20:08:53 +01:00
Andrea Gelmini 677d606021 Fix typos
Change-Id: Ifcbf431291cc77ffc33cc1cbcc493181ffc9943d
Reviewed-on: https://gerrit.libreoffice.org/46634
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-17 10:18:40 +01:00
Noel Grandin 3af500580b loplugin:salcall fix functions
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11 12:13:46 +01:00
Stephan Bergmann 35a2b55a13 loplugin:includeform: xmlsecurity
Change-Id: I9c3eca51fec52a255fcf280fe4e5ecc2ebbee5f3
2017-10-23 22:45:46 +02:00
Thorsten Behrens cae5f2a543 gpg4libre: initial GPG signature generation
* takes XML-Sec signature template
* calculates digest for all added reference streams
* produces signature value over canonicalized signature template
* writes same as detached signature into template, streams that out

Change-Id: I303e080dc25c440175fe1ae897f03cf356d5d0f2
Reviewed-on: https://gerrit.libreoffice.org/36106
Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-05-18 09:18:47 +02:00
Chris Sherlock 97eb00c75e revert OSL_ASSERT changes
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07 17:03:35 +10:00
Chris Sherlock a85694c4c7 tdf#43157: convert xmlsecurity module away from OSL_ASSERT to assert
Change-Id: Ib5297ceb307e8f8d475b7ff0523e6a57f72434a5
2017-05-07 13:03:03 +10:00
Andrea Gelmini 74117f9597 Fix typos
Change-Id: I901ff35ad2e0aa43a421f0996865130514a819bc
Reviewed-on: https://gerrit.libreoffice.org/35663
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-25 13:10:53 +00:00
Stephan Bergmann 8ca2d453e3 Some simplifications, using UNO_QUERY_THROW
Change-Id: I6e7555472da6b23af4c64b299182339a5b324ee9
Reviewed-on: https://gerrit.libreoffice.org/34250
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-15 14:16:26 +00:00
Stephan Bergmann e57ca02849 Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26 12:54:43 +00:00
Miklos Vajna a7c35729e0 xmlsecurity: hold XMLDocumentWrapper by rtl::Reference in XSecController
Going via UNO for a class in the same module is an overkill.

Change-Id: Idf706782e5844fd2e553c44966e1dd1104dce8e7
Reviewed-on: https://gerrit.libreoffice.org/32030
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-12-15 09:15:38 +00:00
Miklos Vajna 9bd471cb76 xmlsecurity: clean up not needed C2U macro in xmldocumentwrapper
Also remove some auto-generated documentation that adds no useful
information.

Change-Id: I5e5c5dd6aaa3fb6953c38d6e82fa13737217c25c
Reviewed-on: https://gerrit.libreoffice.org/31748
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-12-08 09:17:53 +00:00
Otto Kekäläinen 428e23f4f7 Fix some spelling errors in comments and strings
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e
Reviewed-on: https://gerrit.libreoffice.org/26883
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-07-04 06:11:36 +00:00
Noel Grandin 789055bc2a clang-tidy performance-unnecessary-copy-initialization
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.

Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-18 07:37:31 +00:00
Noel Grandin 43d57d105d com::sun::star->css in xmlsecurity/
Change-Id: I4b89f97671ab526e5731d2f1f99802e23f3fd4b5
2016-03-14 13:28:04 +02:00
Miklos Vajna eb63915f0a xmlsecurity: clean up no longer relevant email addresses
Change-Id: I224a0914bd3506b4e2ce057c53838ec78187b060
2016-03-11 09:11:38 +01:00
Noel Grandin 96c26b0d9d use initialiser for Sequence<OUString>
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"

Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 12:20:39 +00:00
Stephan Bergmann 3a2037b11c loplugin:nullptr (automatic rewrite)
Change-Id: I2093e93e07ff19a1a1d2c8b6f221dac2bf2a2613
2015-11-10 10:32:02 +01:00
Noel Grandin 9e8ff13eb2 use uno::Reference::set method instead of assignment
Change-Id: I60e52ef2abc3107ba77e81811dfe1bffbfd77218
2015-11-05 13:32:17 +02:00
Andrea Gelmini aade27554d Fix typos
Change-Id: I60ed5eb658d50cbc7dc572facb5463b7527b4d9b
Reviewed-on: https://gerrit.libreoffice.org/16408
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2015-06-22 12:36:21 +00:00
Stephan Bergmann 642f4e574c loplugin:cstylecast: deal with remaining pointer casts
Change-Id: Idcaafa47f1891858d2ac4cdc536065cbc127b7c4
2015-06-08 16:30:07 +02:00
Julien Nabet 16f1477a2d Remove include stdio (part7)
Change-Id: I7058ac53f4bbf96eff9a36a03279ab0753cc42ba
Reviewed-on: https://gerrit.libreoffice.org/16135
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2015-06-07 15:33:38 +00:00
Noel Grandin 4cca0169aa loplugin:staticmethods
Change-Id: I2177e424d54dc2b5e26b7bbfe073b524e9cc5bab
Reviewed-on: https://gerrit.libreoffice.org/15187
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-04-09 06:44:49 +00:00
Stephan Bergmann c5f1e8c3bb const_cast: convert some C-style casts and remove some redundant ones
Change-Id: I42fdc042ed7317b5b6c337e7b38966e616f8e24b
2015-03-26 15:33:41 +01:00
Noel Grandin 6618a6d7f2 loplugin:constantfunction: xmlsecurity
Change-Id: Iabe2b4677b75cbd4b10a55fc4b2f13ba29645cd4
2015-03-24 10:31:17 +02:00
Stephan Bergmann 2880dfe301 Some more loplugin:cstylecast: xmlsecurity
Change-Id: Iceaeefc26fec2643d3fbb916ab7719a918beb496
2015-01-20 09:06:54 +01:00
Stephan Bergmann 8d487ceba1 xmlsecurity: Use appropriate OUString functions on string constants
Change-Id: I18370f6203455cf7568e48e49b7093d114656619
2014-12-18 14:12:39 +01:00
Michael Stahl 6a0fe37dec sal: clean up public headers with include-what-you-use
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
Andrea Gelmini da40cac540 Fix common typos. No automatic tools. Handmade…
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-12 11:04:11 +00:00
Noel Grandin addf55184a loplugin: cstylecast
Change-Id: I37d7c3e59f1debbee8d92e76f4d08fff773000b3
2014-10-06 07:52:55 +02:00
Stephan Bergmann 7bac68d79e Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: Id03c16337cb637c7f63fb789697c8bceec905bda
2014-08-28 16:17:35 +02:00
Thomas Arnhold 5717de74f5 create OUString from literal
Change-Id: I8198fbad20daa7262e42a452c8d81fcfa3331680
2014-08-04 15:59:06 +02:00
Noel Grandin e4e654e405 xmlsecurity: sal_Bool->bool
Change-Id: I4f32fe3b5133e13dab88ca1c9acd021d84dc59a9
2014-04-24 10:53:16 +02:00
Stephan Bergmann fb1b0c1f7b Use valid UNOIDL identifiers in XCompressedDocumentHandler
...which is new in LO 4.3 and still unpublished.

Change-Id: I2d6b553c27906d7855c62f33fdf0060b58d3ec62
2014-04-11 08:41:09 +02:00
Marcos Paulo de Souza 4d6560f506 fdo#54938: Convert some places to use cppu::supportsService
The last cases are non obvious, so it's pratically done

Change-Id: Icae1da8e238f516eaed0f7fbdf96fff778eac547
Reviewed-on: https://gerrit.libreoffice.org/8445
Reviewed-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Tested-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
2014-03-04 07:30:02 -06:00
Stephan Bergmann 5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Tor Lillqvist be053c9a80 Spelling correction: s/retrive/retrieve/
Change-Id: I96845d358765e2d2507763a9b15a30388b32bc6b
2013-12-20 23:26:58 +02:00
Caolán McNamara 094f00651a CID#708741 uninitialized members
Change-Id: I15475d560e889b0f0fc91d96cfa6ae97e81a41b5
2013-10-03 13:30:13 +01:00
Miklos Vajna 3155a8e60f xmlsecurity: drop no longer needed RTL_ASCII_USTRINGPARAM macro
Change-Id: Ia08688ef3c262ba4379213231032c73404ae748b
2013-05-06 09:24:01 +02:00
Luboš Luňák 1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Stephan Bergmann 973a16f9e6 Adapt to XComponentContext
Change-Id: I2f2c745245722f90b8101995367c55878d568703
2012-12-07 07:55:50 +01:00
Michael Meeks 6eeb0942c3 re-base on ALv2 code. Includes:
retain presence of MPL licensed nssrenam.h symbol renamer.
2012-07-17 11:51:17 +01:00
Thomas Arnhold 4c4d748767 Remove some more include guards
Change-Id: I7c62d086cb593744785abecae7a107686a4d65ce
2012-06-29 09:25:10 +02:00
Szabolcs Dezsi f770c5d6bc Replaced equalsAsciiL(RTL_CONSTASCII_STRINGPARAM(...)) with == operator
Pattern used:

find . -name "*.cxx" -exec sed -i 's/\( *\)return \([^()]*\)\.equalsAsciiL( *RTL_CONSTASCII_STRINGPARAM *( *\([^)]*\) ) *);/\1return \2 == \3;/' \{\} \;
2012-04-06 12:48:32 +02:00
Norbert Thiebaud b33971cb12 remove include of pch header from xmlsecurity 2011-11-27 13:28:28 -06:00
Guillaume Poussel 842bfb16f7 Remove useless comments in components. 2011-02-08 19:06:48 +01:00
Sebastian Spaeth ead7290449 Add vim/emacs modelines to all source files
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-13 10:57:23 +02:00
J. Graeme Lingard 15aaf45ef9 Remove redundant #include directives & comments 2010-10-04 23:25:47 -04:00