ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
413 Commits
Author SHA1 Message Date
Noel Grandin ddd43218e9 drop sax::tools::*base64 methods 
and use the underlying comphelper methods rather. This is so that I can
break the dependency that tools has on sax, and can add methods that
make sax depend on tools.

Change-Id: I8a2d6ce2ffc3529a0020710ade6a1748ee5af7d5
Reviewed-on: https://gerrit.libreoffice.org/50767
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-05 14:25:02 +01:00
Noel Grandin be8c414567 loplugin:unusedmethods also check for functions returning bool 
we were previously excluding them

Change-Id: I48a68799b0de60b4995fae541eb363e043d4dd11
Reviewed-on: https://gerrit.libreoffice.org/48167
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-19 13:26:27 +01:00
Miklos Vajna 67e1e2ee40 tdf#42949 Fix some more Include What You Use warnings 
Change-Id: I2040315707674dc99a37aedb96ac61dca274c13a
Reviewed-on: https://gerrit.libreoffice.org/47348
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-01-04 15:51:39 +01:00
Miklos Vajna d8efc393bf Turn on clang-format for these files 
I (tried to) keep these files consistent locally with astyle in the past,
switching to clang-format makes sure that the recent problem with introducing
inconsistencies with automatic loplugin rewrites doesn't happen again.

Change-Id: If49c96b6e9e6ed50beb69c70e37125dff5607f76
Reviewed-on: https://gerrit.libreoffice.org/47332
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-01-03 22:12:15 +01:00
Noel Grandin 4855257e52 loplugin:passstuffbyref improved return in sw 
Change-Id: I4484ac461761e4c46364b4f473c7e62f8ec72103
Reviewed-on: https://gerrit.libreoffice.org/47243
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-02 12:19:10 +01:00
Thorsten Behrens 1e71870034 gpg4libre: rename GPGME_HAVE_GPGME to HAVE_FEATURE_GPGME 
Change-Id: I6f085b67c3477f427bd1efd96db93cbb89e20647
Reviewed-on: https://gerrit.libreoffice.org/46050
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2017-12-08 09:13:51 +01:00
Miklos Vajna ccd2888110 EPUB export: implement character properties of links from named styles 
ODF allows text properties on hyperlinks directly, librevenge wants an
inner span instead.

Change-Id: I903045a688bf318e7ac7f8cac83bb4d537259969
Reviewed-on: https://gerrit.libreoffice.org/45161
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-11-24 09:03:39 +01:00
Thorsten Behrens 43ac50dccc gpg4libre: conditional-compile gpgme code 
Change-Id: I1d139a7b6df271d61bedd107c6b3a0535d233606
Reviewed-on: https://gerrit.libreoffice.org/45124
Reviewed-by: Siegmund Gorr <siegmund.gorr@cib.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2017-11-23 12:13:43 +01:00
Samuel Mehrbrodt 08434e96ef Missing initialization of m_bInSignatureLineId 
Change-Id: I563f7324129828d13c4549d330d58d6ab972472c
Reviewed-on: https://gerrit.libreoffice.org/44268
Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de>
Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de>
 2017-11-03 15:46:50 +01:00
Samuel Mehrbrodt bd3c5c4c23 [API CHANGE] tdf#65393 Import signature line images from ooxml 
showing whether the signature behind the signature line is valid or not.

Change-Id: Ia6cca62812019f26d55d234cac767a9b4b7c8175
Reviewed-on: https://gerrit.libreoffice.org/40980
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2017-11-03 13:57:00 +01:00
Miklos Vajna 6cf3ef823a xmlsecurity: can hold UriBindingHelper by rtl::Reference 
... in XMLSignatureHelper and XSecController

Change-Id: Ie3817684c9ed9ed8a222e3ba56c8fbc389a68071
Reviewed-on: https://gerrit.libreoffice.org/44193
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-11-03 09:26:12 +01:00
Miklos Vajna 4216d6f590 xmlsecurity: remove unused chainOn() argument 
Change-Id: Id4d4ae41eb6d667a96ce5d294dd5bf3fcf4cb686
Reviewed-on: https://gerrit.libreoffice.org/43801
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-25 11:44:04 +02:00
Stephan Bergmann 35a2b55a13 loplugin:includeform: xmlsecurity 
Change-Id: I9c3eca51fec52a255fcf280fe4e5ecc2ebbee5f3
 2017-10-23 22:45:46 +02:00
Miklos Vajna 73ade0b029 xmlsecurity: remove unused m_xElementStackKeeper 
Change-Id: Ibd7d39e288a4121428e83408ce67205eab3340c6
Reviewed-on: https://gerrit.libreoffice.org/43479
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-18 10:25:20 +02:00
Miklos Vajna d0211e091e xmlsecurity: remove unused XSecController::m_xNextNodeOnSAXChain 
Change-Id: Ic5fd625afe2ef53968b87d1382b257e3d44ce08b
Reviewed-on: https://gerrit.libreoffice.org/43354
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-13 08:20:35 +02:00
Miklos Vajna f1ad49892d xmlsecurity: last 2 params of setSAXChainConnector() is always nullptr 
So remove them.

Change-Id: Iec2430af6634608bdc8c4beff6078ccceb7a2391
Reviewed-on: https://gerrit.libreoffice.org/43182
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-06 11:00:05 +02:00
Noel Grandin 2c05d758b2 add << operator for css::uno::Exception 
Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-04 15:18:00 +02:00
Miklos Vajna 1cfcbf3573 xmlsecurity: hold SignatureCreatorImpl by rtl::Reference 
Not going via UNO means explicit interface casting can be avoided.

Change-Id: I4fa2db810cade787913bca222530405d8d2eb6a9
Reviewed-on: https://gerrit.libreoffice.org/42573
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2017-09-21 11:43:52 +02:00
Noel Grandin b0de7bc428 clang-tidy modernize-use-emplace in various 
Change-Id: Id1bbd3f380c17beeaab11f7140d4df1304c3d0d8
Reviewed-on: https://gerrit.libreoffice.org/41750
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-14 11:51:44 +02:00
Thorsten Behrens fdc85f759c gpg4libre: use SHA512 digests for GPG signing unconditionally 
Change-Id: I2ee6b0ba440a50b4627b3732c52afe08ba02d664
Reviewed-on: https://gerrit.libreoffice.org/42087
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2017-09-10 01:43:53 +02:00
Thorsten Behrens ca6ab632a8 gpg4libre: add sha512 support 
Change-Id: Ia5ef54e47e8528a33aba83ae2e317fac5cffb428
Reviewed-on: https://gerrit.libreoffice.org/42086
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2017-09-10 01:42:55 +02:00
Miklos Vajna c210019f36 xmlsecurity: no need to have pdfio/pdfdocument.hxx as a global header 
Which means xmlsecurity can be again a module that has no public
headers.

Change-Id: I3d0b03680398f80196fac187263e770fd44ed0ed
Reviewed-on: https://gerrit.libreoffice.org/41966
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-09-06 09:06:19 +02:00
Gautam Prajapati 511ae02c64 Android: Enable HAVE_FEATURE_NSS and package the NSS libraries with apk 
This commit enables HAVE_FEATURE_NSS for Android and fixes the svl/ vcl/
and xmlsecurity/ module to use NSS.

xmlsecurity/ wasn't built for Android previously, this commit enables
building xmlsecurity/ for Android and disables the support of gpgme
in the same module(Only for Android).

It also enables the linking of NSS shared libraries with
liblo-native-code.so and adds a rule to package them along with the apk.

Change-Id: I7d0341688ac979ae92e9145c37dd107670417fe1
Reviewed-on: https://gerrit.libreoffice.org/41308
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2017-08-23 17:50:55 +02:00
Samuel Mehrbrodt c3f8727fe8 xmlsecurity: Log unknown xml elements for ooxml 
Change-Id: I0daf81ac91da1d6206282e486298d059b937bb21
Reviewed-on: https://gerrit.libreoffice.org/40819
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2017-08-10 17:38:44 +02:00
Noel Grandin 3dcf6dfcee remove unnecessary use of 'this->' 
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4
Reviewed-on: https://gerrit.libreoffice.org/40671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-02 13:45:36 +02:00
Noel Grandin b064a22f71 loplugin:constparams in xmlsecurity 
Change-Id: I41f153af55262d201c0fb024460de0e9f1c14670
Reviewed-on: https://gerrit.libreoffice.org/40472
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-27 10:58:32 +02:00
Noel Grandin 2fffaf6f05 loplugin:unusedmethods 
Change-Id: Ia874baf21257e5fe41e104211068a2bcc50446eb
Reviewed-on: https://gerrit.libreoffice.org/40391
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-25 12:03:50 +02:00
Samuel Mehrbrodt 610254209a Move namespace declaration to header file 
Change-Id: I5388d649ff3c8da0ff055f4aed6036647a123939
Reviewed-on: https://gerrit.libreoffice.org/40130
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-07-20 16:01:50 +02:00
Caolán McNamara f3d9887d7a coverity#1415512 silence Unchecked return value 
Change-Id: I50601be72a5f496c1d1e8135af57db649e29110a
 2017-07-18 16:41:46 +01:00
Samuel Mehrbrodt a83888e775 Fix warning for loext namespace 
Define the namespace near the element that's using it

Change-Id: If0a135a331d4f67ef2dfe4981e93110e7a1a787a
Reviewed-on: https://gerrit.libreoffice.org/40084
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2017-07-17 22:33:39 +02:00
Samuel Mehrbrodt fab7288516 This should be a namespace, not an attribute "namespace" 
Change-Id: I159db32662679a3194edf942fa6672370e2b8587
Reviewed-on: https://gerrit.libreoffice.org/40072
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2017-07-17 20:29:29 +02:00
Samuel Mehrbrodt 9127706ab3 gpg4libre: Wrap PGPOwner in own namespace 
as recommended by W3C: https://www.w3.org/TR/xmldsig-core/#sec-PGPData

Change-Id: I2cc0ae24eefc9137d2e3432da1d65e44245c7616
Reviewed-on: https://gerrit.libreoffice.org/40058
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2017-07-17 16:22:34 +02:00
Ashod Nakashian 4f17445c12 svl: move byte-array verification from vcl 
Also use comphelper::Base64 and
DateTime::CreateFromUnixTime to avoid depending on sax.

Change-Id: If1853f8d9481c9caa0625a111707531bbc495f75
Reviewed-on: https://gerrit.libreoffice.org/39993
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-07-17 00:12:10 +02:00
Noel Grandin daf177f703 use more OUString::operator== in test..xmlsecurity 
Change-Id: If5bdd1532be44a47ff7cc3b769be3ea585aea562
Reviewed-on: https://gerrit.libreoffice.org/39685
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-14 12:39:20 +02:00
Samuel Mehrbrodt 820bd4b3b6 tdf#108977 Show signature info also for keys we don't have locally 
gpg4libre

Change-Id: I89593224590007e61bce95c14922c08551282067
Reviewed-on: https://gerrit.libreoffice.org/39742
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2017-07-10 15:41:44 +02:00
Stephan Bergmann 83634c9d11 loplugin:staticmethods 
Change-Id: I68d02b89a2c55e41ad0d86392ed3994fa5410fac
 2017-06-30 10:18:07 +02:00
Noel Grandin 71112060e0 loplugin:oncevar various 
Change-Id: I8b82d46d4688b1a59d6fe1b05da7d5c8dfc13ca6
Reviewed-on: https://gerrit.libreoffice.org/38766
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-29 08:18:35 +02:00
Samuel Mehrbrodt 84dfff475c tdf#108798 Make CanSignWithGPG work with PDF docs 
Change-Id: I09aa030bed3d6ce51ef71d8bab905b01fab5b699
Reviewed-on: https://gerrit.libreoffice.org/39309
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2017-06-28 08:08:46 +02:00
Samuel Mehrbrodt e2378bbf45 tdf#108711 GPG key selection should only be possible for ODF >= 1.2 documents 
gpg4libre

Change-Id: I6dbdaefddacf55c9381d156ada20cb3f25d4b3cb
Reviewed-on: https://gerrit.libreoffice.org/39263
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2017-06-27 09:25:32 +02:00
Samuel Mehrbrodt b0351f6d57 Cleanup comment 
Change-Id: I218675bcb832c158171f87bb7c52a658ceaa7a67
Reviewed-on: https://gerrit.libreoffice.org/39278
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2017-06-26 21:47:47 +02:00
Miklos Vajna 6115b10932 xmlsecurity: remove newly introduced redundant namespace alias, used only once 
Change-Id: Ia93ec62863d16d3cc60878968b79ed0ccc5fba9b
 2017-06-22 09:07:37 +02:00
Miklos Vajna 686dfc5ed5 xmlsecurity: fix loplugin:passstuffbyref warnings 
Change-Id: I627abfe33e9c2fc4243276706c1624ce19943678
 2017-06-22 09:06:31 +02:00
Thorsten Behrens f9a14f3d02 gpg4libre: fix build for windows and mac 
Change-Id: I3e36b22cefba4c6195bcf8b85b3f7a2cc101b845
 2017-06-21 22:16:56 +02:00
Thorsten Behrens ba53bd4e72 gpg4libre: make signature impl swappable in-situ during validation 
Sadly we only know whether its a OpenPGP or X509 signature during
parsing, so we need to switch the implementation mid-way

Change-Id: Ib48a9da0105de62cfecda095df8c154b59ba8c40
 2017-06-21 22:16:56 +02:00
Thorsten Behrens 4ddb2f716f gpg4libre: some code improvements, add metadata for OpenPGP keys 
Change-Id: I1beb692b9a9a34b5f0cf743ba9e4a145ac582184
 2017-06-21 22:16:56 +02:00
Thorsten Behrens 891d4b5d91 gpg4libre: write PGPData info, get more metadata out for gpg key 
Change-Id: Ia560869ec02fca7fe4219136e1fe939e13f1e4c2
 2017-06-21 22:16:55 +02:00
Samuel Mehrbrodt ed92db7a50 gpg4libre: Init xmlsec in one place before creating the gpg/x509 services 
Change-Id: I0308d586344b5e52ad327f6650b62ac0eac7ecb9
 2017-06-21 22:16:55 +02:00
Samuel Mehrbrodt 9b8197ab0d gpg4libre: Make signature dialog work with two signing services 
Change-Id: I0b47e6dba38222bb6b4f778c4206d3b37bc93089
 2017-06-21 22:16:55 +02:00
Thorsten Behrens 06d7dbb356 gpg4libre: share static xmlsec lib between nss and gpg 
In the end, the gpgme implementation uses enough of xmlsec
functionality that splitting those (and ending up with two copies)
was just not worth it.

Change-Id: Ida87c848e4e6a770e3c697add9ceb589a9ec3930
 2017-06-21 22:16:55 +02:00
Stephan Bergmann d31dc15550 loplugin:stringcopy: xmlsecurity 
Change-Id: Ib5b6e2b2a03eec14a81e1f8ba8833611047c83f0
 2017-05-19 17:15:43 +02:00