ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
175 Commits
Author SHA1 Message Date
Noel Grandin 0b413caadf loplugin:constantparam in sal,sax 
Change-Id: I7ca2fd05d1cf61f9038c529a853e72fedb1c9ed0
Reviewed-on: https://gerrit.libreoffice.org/44087
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-31 08:43:18 +01:00
Stephan Bergmann 3ff3a05371 loplugin:includeform: xmloff 
Change-Id: I9e55142a7904c426fce49f68f1790365ea490fab
 2017-10-23 22:45:46 +02:00
Noel Grandin 692d35b89a loplugin:finalclasses in xmloff 
Change-Id: I10ffefd29b858548472a459314c7d5632324bca2
Reviewed-on: https://gerrit.libreoffice.org/43069
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-03 13:22:00 +02:00
Caolán McNamara 442df6cf83 ofz: don't leak in face of exceptions 
Change-Id: Ic15590a13bd3770ee5dd7db76b21c830a4fe73e2
Reviewed-on: https://gerrit.libreoffice.org/42587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-09-22 11:01:53 +02:00
Noel Grandin 977a676a71 loplugin:constparams in xmloff 
Change-Id: I136ee42523a40c576d7cf0b66abbf50ad9be052f
Reviewed-on: https://gerrit.libreoffice.org/40517
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-28 20:12:29 +02:00
Takeshi Abe f30530229b Mark SvXMLTokenMapEntry arrays as constant 
Change-Id: I37565540ec5dc3bfddf6cdeb20447f837e3014b6
Reviewed-on: https://gerrit.libreoffice.org/40374
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-07-26 20:44:20 +02:00
Noel Grandin 8bedbc3f56 loplugin:constparams in xmloff 
Change-Id: Iec9535b106c85e47ddb14eec4ef3db5b1c8d8fd7
Reviewed-on: https://gerrit.libreoffice.org/40219
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-20 13:03:29 +02:00
Noel Grandin ab9b38a406 use more begin()/end() for Sequence 
Change-Id: I399be6b6ef7a6ce01e883569a177c0969bc29c69
 2017-07-06 08:35:23 +02:00
Stephan Bergmann de93c6260c loplugin:casttovoid: xmloff 
Change-Id: I4f9ffd686e8e5a10bdd3f5ad4282dc4776923b62
 2017-07-02 22:27:05 +02:00
Michael Stahl 6e427e0bd1 xmloff: remove duplicate XML_NAMESPACE_##prefix##_IDX macros 
Why do we need 2 identical constants?

Change-Id: Ib969f9b9583261f26fe65e04f183bdfabcb9eefe
 2017-06-27 16:22:38 +02:00
Jochen Nitschke b3eb843766 cleanup tools/debug.hxx includes 
with command
> git grep -l tools/debug.hxx |
  xargs grep -L DBG_ |
  xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d'

don't change files in includes/ and */pch

Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08
Reviewed-on: https://gerrit.libreoffice.org/37349
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-08 08:33:01 +02:00
Michael Stahl 974d48b9b8 xmloff: fix --enable-mergedlibs build 
multiple definition of `toBool(rtl::OUString const&)' since
commit 836c9bbb64

Change-Id: I6a3e6a4e8a2af3c37f925cbdd684b8a99c088b1c
 2017-04-28 21:51:59 +02:00
Stephan Bergmann b7f688f7ab loplugin:salunicodeliteral: xmloff 
Change-Id: I751006fd054882a9ceab424675ac0505a9ddfd8b
 2017-04-28 18:26:53 +02:00
Andrea Gelmini 74117f9597 Fix typos 
Change-Id: I901ff35ad2e0aa43a421f0996865130514a819bc
Reviewed-on: https://gerrit.libreoffice.org/35663
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-03-25 13:10:53 +00:00
Noel Grandin 1461ebbbb5 expand out ::sax::Converter::convertNumber to OUString::number 
which results in much simpler code overall, there is no need to go via
an OUStringBuffer all the time

Change-Id: I69eba92c93f471fa9a45f97c29c56dcf3cd1ebf8
Reviewed-on: https://gerrit.libreoffice.org/33773
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-02 08:00:10 +00:00
Caolán McNamara aac6bb5bb3 ditch some empty dtors which match the default dtor 
Change-Id: Id2450b03e6c8c5461e92d995ea8c33d5dfd55a45
 2017-01-23 10:11:59 +00:00
Stephan Bergmann 76f894f248 New loplugin:externvar: xmloff 
Change-Id: I3fe731a535fe67b4cf260f9c6a36e32732695a7c
 2017-01-09 15:39:25 +01:00
Noel Grandin 0ea50b5b43 loplugin:countusersofdefaultparams in xmloff 
Change-Id: Ia92a878ac97b3cc668594946e77a718f27a3e3ed
Reviewed-on: https://gerrit.libreoffice.org/28890
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-09-14 08:47:48 +00:00
Stephan Bergmann 91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Stephan Bergmann 8c81f307ee loplugin:passstuffbyref also for {css::uno,rtl}::Reference 
Change-Id: Ide1102f4dcc5f31de0f896b570fe453b8074454d
 2016-07-07 18:59:55 +02:00
Otto Kekäläinen 428e23f4f7 Fix some spelling errors in comments and strings 
Change-Id: Iecd6b5e13d6be14651f77d8e37f01117ba15a11e
Reviewed-on: https://gerrit.libreoffice.org/26883
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
 2016-07-04 06:11:36 +00:00
Noel Grandin e6c004dd9f convert DBG_ASSERT in xmloff 
Change-Id: I2f4bbbef451026fc34638e17fa29b6db2c14d850
Reviewed-on: https://gerrit.libreoffice.org/26191
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-06-17 06:39:30 +00:00
Noel Grandin 5abc669599 new plugin stylepolice 
check for local variables which follow our member field naming
convention, which is highly confusing

Change-Id: Idacedf7145d09843e96a584237b385f7662eea10
 2016-04-21 08:32:47 +02:00
Jochen Nitschke 150ac9cf05 clean-up: unused using declarations and includes 
Searched source for using declarations.
Checked if those symbols reappear in the source file,
even in comments or dead code but not in #include statements.
If they don't reappear, remove the declaration.
Remove includes whose symbol got removed.

Change-Id: Ibb77163f63c1120070e9518e3dc0a78c6c59fab0
Reviewed-on: https://gerrit.libreoffice.org/24148
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-18 07:25:24 +00:00
Noel Grandin 868444c803 loplugin:passstuffbyref in xmloff 
Change-Id: I5995510c5c0686e5e69e8853d81dcba83ae96211
 2016-04-14 09:21:39 +02:00
Jochen Nitschke 4c7ec9f112 cleanup: remove unused com/sun/star/uno includes 
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.

Add a few missing includes provided by them.

Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-04-12 06:38:26 +00:00
Jochen Nitschke f7a75a66fa cleanup: remove unused Reference.h(xx) includes 
and unused using-declarations from Reference.h

Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19
Reviewed-on: https://gerrit.libreoffice.org/23735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
 2016-04-02 19:01:24 +00:00
Chris Sherlock a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Andrea Gelmini 64d624b651 Fix typos 
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-01-10 14:17:20 +00:00
Noel Grandin 80735fcbb0 com::sun::star->css in xmloff/ 
Change-Id: Iee6e21e093fb1383f19a0716dbc1c341f446b8c2
Reviewed-on: https://gerrit.libreoffice.org/20192
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-26 10:47:02 +00:00
Noel Grandin e0bf7914b4 loplugin:unusedfields in xmloff/ 
Change-Id: I1fb9cb1bc04fb0886d6080f62899a04e8fd4429e
 2015-11-24 10:09:26 +02:00
Stephan Bergmann 51b45df6bb loplugin:nullptr (automatic rewrite) 
Change-Id: I8690de2cb68dcfedc9f2239ce66cea06fd94bc16
 2015-11-10 10:32:01 +01:00
Stephan Bergmann b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code 
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
 2015-10-12 17:52:29 +02:00
Stephan Bergmann cbce40e965 Make content of OSL_ASSERT, DBG_ASSERT, etc. visiblie in non-debug builds 
...to avoid lots of loplugin:staticmethods warnings.  Also enables DBG_ASSERT
etc. also for --enable-debug builds in addition to --enable-dbgutil builds.

Change-Id: Ib89ecd9ab8ce7abb2c64790ace248b31f9d2b64d
 2015-07-13 18:14:11 +02:00
Takeshi Abe c675a2d669 xmloff: simplify code by using std::all_of/std::any_of/std::none_of 
Change-Id: I87311d8989c23538983d45ad9b12a64080441d78
Reviewed-on: https://gerrit.libreoffice.org/15569
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2015-04-30 11:51:17 +00:00
Tor Lillqvist d1ca0f4ed0 Bin some pointless comments and reduce some vertical whitespace 
Bin pointless '// predeclarations' or '// forward declarations' comments.  If
a programmer doesn't know what a forward declaration is, well, why read C++
source code?

Also bin some pointless '// end of namespace foo' comments after namespace
blocks just a handful of lines long, and some superfluous vertical whitespace.

Change-Id: I2a31c5d73d9b4de8825fb8eb9e7559dbd7303ef9
 2015-04-30 06:14:12 +03:00
Caolán McNamara 5a308b1239 V801: Decreased performance 
Change-Id: Iba139ede7bd72e23c0b7a28a8a4ff38ea816725a
 2015-03-09 12:41:09 +00:00
Stephan Bergmann 420fc7d1ad Missing include 
Change-Id: I067a83ef97e55afc27673c59b0bdae974d7f3232
 2015-02-18 09:59:08 +01:00
Michael Stahl 2f69e16c72 override the overloading of "overload" to decrease cognitive (over-)load 
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
 2015-01-09 00:00:47 +01:00
Michael Stahl 6a0fe37dec sal: clean up public headers with include-what-you-use 
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
 2014-11-17 11:06:53 +01:00
Noel Grandin 3e82897353 improve the inlinesimplememberfunctions clang plugin 
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
 2014-06-17 10:55:17 +02:00
Noel Grandin 4f9b21248f simplify ternary conditions "xxx ? yyy : false" 
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
 2014-05-05 12:47:48 +02:00
Noel Grandin 6ac6fb820f xmloff: sal_Bool->bool 
Change-Id: I64c33ae4c157e270acac9a1f820d3e6272ba0bea
 2014-03-31 12:39:02 +02:00
Stephan Bergmann 70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations 
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
 2014-03-26 16:39:26 +01:00
Alexander Wilms e23ea87cb3 Remove visual noise from xmloff 
Change-Id: I205d4e555f5b88654a90007eb7ac05bc7b00a904
Reviewed-on: https://gerrit.libreoffice.org/8346
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 04:32:34 -06:00
Noel Grandin 610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Noel Grandin 39c8da8c86 remove unnecessary sal_Unicode casts in XMLOFF module 
Change-Id: I836c7a28d5ec9039c0b185e8db2aa6d01ac62566
Reviewed-on: https://gerrit.libreoffice.org/6665
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2013-11-14 06:16:12 +00:00
Norbert Thiebaud 21123da759 xmloff: include <> for external includes 
Change-Id: Ic92d0121e928041bcff00b12706f794a4d8e25c8
 2013-11-11 22:37:28 -06:00
Noel Grandin 0e6a2601b3 Convert code that calls OUString::getStr()[] to use the [] operator 
This also means that this code now gets bounds checked in debug builds.

Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
 2013-11-04 08:06:10 +02:00
Thomas Arnhold a45953ed7c fixincludeguards.sh: xmloff 
Change-Id: I0e7d9daac1ad88fad8d240373e91ef323966bb47
 2013-10-23 23:22:32 +02:00