Commit Graph
97 Commits
Author SHA1 Message Date
Michael Stahl 88fe1bb839 xmloff: add a comment too
Change-Id: Ic23c36250938009b17f4b916f0d13a097d018a0c
2018-01-29 10:41:37 +01:00
Abhishek Shrivastava e3e2f6911d tdf#106780 Fix for invalid attribute in impress ODF
This patch fixes the invalid ODF generated in impress.
In tables now the attribute is shown as table:name="default"
instead of "text:style-name".

For strict XML version we only set table:name="default"

For Extended/Compatibility XML we set both text:style-name
and table:name

Change-Id: I894fd31f5f0eed3f77b216b3114b5da53acf1f9f
Reviewed-on: https://gerrit.libreoffice.org/48373
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-29 10:13:47 +01:00
Stephan Bergmann 3ff3a05371 loplugin:includeform: xmloff
Change-Id: I9e55142a7904c426fce49f68f1790365ea490fab
2017-10-23 22:45:46 +02:00
Caolán McNamara 442df6cf83 ofz: don't leak in face of exceptions
Change-Id: Ic15590a13bd3770ee5dd7db76b21c830a4fe73e2
Reviewed-on: https://gerrit.libreoffice.org/42587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-22 11:01:53 +02:00
Noel Grandin 977a676a71 loplugin:constparams in xmloff
Change-Id: I136ee42523a40c576d7cf0b66abbf50ad9be052f
Reviewed-on: https://gerrit.libreoffice.org/40517
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-28 20:12:29 +02:00
Stephan Bergmann de93c6260c loplugin:casttovoid: xmloff
Change-Id: I4f9ffd686e8e5a10bdd3f5ad4282dc4776923b62
2017-07-02 22:27:05 +02:00
Noel Grandin 83f9325f0d loplugin:unusedfields xmlhelp..xmlsecurity
Change-Id: I7e680e1913c787ce0adad5be1f84668d57ad00b3
Reviewed-on: https://gerrit.libreoffice.org/38821
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-16 08:24:49 +02:00
Noel Grandin 12191a4f30 make loplugin constantparam smarter about string params
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294
Reviewed-on: https://gerrit.libreoffice.org/37426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09 13:52:30 +02:00
Jochen Nitschke b3eb843766 cleanup tools/debug.hxx includes
with command
> git grep -l tools/debug.hxx |
  xargs grep -L DBG_ |
  xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d'

don't change files in includes/ and */pch

Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08
Reviewed-on: https://gerrit.libreoffice.org/37349
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08 08:33:01 +02:00
Noel Grandin 034e9de08e loplugin:checkunusedparams in xmloff
Change-Id: I59d2cb1f69882b62e6fe732e9d9214feec8a79a2
Reviewed-on: https://gerrit.libreoffice.org/37283
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08 08:29:26 +02:00
Tamás Zolnai bcb371b1a8 ODF import / export of rotated text in Impress table
Change-Id: I57136e32ed2db5e405a45e8e4bad1b8d459b7ae8
2017-04-15 15:40:56 +02:00
Stephan Bergmann c6f21f90e1 loplugin:subtlezeroinit: xmloff
Change-Id: I1308f4ad4584ac7c657ab9fc2b747c4e3715337d
2017-02-21 07:34:55 +01:00
Noel Grandin 06eb947c16 inline some constant strings in xmloff (part1)
Change-Id: I7971f210ffb30bdd80a1adde2c286b4d092bd053
Reviewed-on: https://gerrit.libreoffice.org/31433
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-02 06:34:36 +00:00
Stephan Bergmann 182dfdd00e loplugin:unnecessaryoverride (dtors) in xmloff
Change-Id: I351ff5955d766118e3a6b2234181774af0d1f522
2016-12-01 08:53:50 +01:00
Andrea Gelmini a31378fa04 Fix typos
Change-Id: Iad27d1f87568890180c142774c238a14d022946d
Reviewed-on: https://gerrit.libreoffice.org/29441
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-03 11:27:00 +00:00
Caolán McNamara 1f6af12705 Resolves: tdf#101708 only export loext table attributes in 'extended' variant
Change-Id: I35f297e94e1eb6ed56020cf69102fad4c4d1e7f4
2016-09-21 21:07:50 +01:00
Stephan Bergmann 91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
David Tardon 32ccb4ea86 resolve the snafu with 2 separate refcounted bases
Change-Id: Ia275596d54ea27436f03d01297fb78b6ca09e8a6
2016-09-09 07:30:30 +02:00
Jakub Trzebiatowski 40fba0f441 GSoC Writer Table Styles Import
This patch is implementing import of table styles (table-template).

Modified shared code: Added "background" to the cell styles export.

To make cell export properties map accessible by both export and import code,
moved from xmloff/source/table/XMLTableExport.cxx to xmloff/txtprmap.hxx.

To avoid export of default valued properties implemented XPropertyState for
SwXTextCellStyle

Change-Id: I8b4f12e4b51f478f8ce8fde1203cd4611d7ae852
Reviewed-on: https://gerrit.libreoffice.org/26721
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-07-07 09:02:15 +00:00
Jakub Trzebiatowski 309bc35559 GSoC Table Styles, Export Cell Styles
Exporting cell-styles
Exporting table-template
To be able to map SwTableAutoFormat to table-template 1:1
extended table-template by the following elements:
	loext:first-row-even-column
	loext:last-row-even-column
	loext:first-row-end-column
	loext:first-row-start-column
	loext:last-row-end-column
	loext:last-row-start-column

Added attributes describing box format to SwXTextCellStyle

Change-Id: I2967ba461dfc6f030c1e5cdbba62e2673d3b232b
Reviewed-on: https://gerrit.libreoffice.org/26185
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-06-20 12:08:01 +00:00
Noel Grandin e6c004dd9f convert DBG_ASSERT in xmloff
Change-Id: I2f4bbbef451026fc34638e17fa29b6db2c14d850
Reviewed-on: https://gerrit.libreoffice.org/26191
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-06-17 06:39:30 +00:00
Noel Grandin d96c114171 clang-tidy modernize-make-shared
Change-Id: I3fa866bfb3093fc876474a9d9db29fe05dc2af3a
Reviewed-on: https://gerrit.libreoffice.org/25056
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-18 06:58:44 +00:00
Noel Grandin 43b4903db3 teach stylepolice plugin about ref-counted-pointer naming
Change-Id: I6e91d22fc1826038c05ddb6fc065563c6a250752
Reviewed-on: https://gerrit.libreoffice.org/24459
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-28 09:31:16 +00:00
Stephan Bergmann 5ef76efb40 loplugin:salbool: Automatic rewrite of sal_False/True
Change-Id: I5896c6b8bf2aa9c7c66ca5f7c50cee1b0738ea0a
2016-04-20 17:27:32 +02:00
Stephan Bergmann cb9d95bd42 Avoid reserved identifiers
Change-Id: Idaa3059658fa0e8942b7b9b7be3198aeda8205e4
2016-04-12 20:03:50 +02:00
Noel Grandin 4c7ce41582 loplugin:unusedfields in xmlhelp,xmloff
Change-Id: I4d2f0ff95da5abaa3d0a0a5223616e09e0c476fc
2015-12-21 12:45:49 +02:00
Noel Grandin 80735fcbb0 com::sun::star->css in xmloff/
Change-Id: Iee6e21e093fb1383f19a0716dbc1c341f446b8c2
Reviewed-on: https://gerrit.libreoffice.org/20192
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-26 10:47:02 +00:00
Stephan Bergmann 51b45df6bb loplugin:nullptr (automatic rewrite)
Change-Id: I8690de2cb68dcfedc9f2239ce66cea06fd94bc16
2015-11-10 10:32:01 +01:00
Stephan Bergmann b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Noel Grandin 9c1f700aff improve refcounting loplugin to check SvRef-based classes
Change-Id: I2b3c8eedabeaecd8dcae9fe69c951353a5686883
Reviewed-on: https://gerrit.libreoffice.org/17521
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-05 11:26:04 +00:00
Caolán McNamara 3744d8506e boost->std
Change-Id: I8371b942d915f777a29ca01cd0aed674db0ca853
2015-02-17 16:24:05 +00:00
Michael Stahl 15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
Michael Stahl 6a0fe37dec sal: clean up public headers with include-what-you-use
Sadly cannot forward declare "struct {...} TimeValue;".

rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h
was painful enough for now...

Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-17 11:06:53 +01:00
Stephan Bergmann 4d3c88805d Avoid ODR-violating name clash
Change-Id: I69c3b11b01d520a485b07c8e5397a7f971210af2
2014-09-11 13:13:24 +02:00
Takeshi Abe 248437e4fd fdo#75757: remove inheritance to std::map
Change-Id: I2fd0b43c62c331d866d697c94dd57d17f903111b
Reviewed-on: https://gerrit.libreoffice.org/10810
Reviewed-by: David Tardon <dtardon@redhat.com>
Tested-by: David Tardon <dtardon@redhat.com>
2014-08-07 14:28:18 +00:00
Kohei Yoshida 8a690c88a9 Apply pimpl to XMLPropertySetMapper.
Let's hide its implementation for real this time.

Change-Id: I18c82f4969f2e3560536a68e9bbd86b9282e2ace
2014-07-25 11:50:02 -04:00
Noel Grandin 4ff115b3e7 drop UniReference in favour of rtl::Reference
since they're doing the same thing.

Change-Id: I76134b6b848db8628f315fe5bd9eb972a6bf0cb6
2014-07-02 15:23:52 +02:00
Matteo Casalin 982babed5c Fix typo: cought => caught
Change-Id: I4fcede18c4b36a2b35f7fafae997f14acef84394
2014-04-27 14:00:42 +02:00
Noel Grandin 8a81f542a6 xmloff: sal_Bool->bool
Change-Id: I873c80baec8e70e3e8f642644563b92137571a30
2014-04-15 09:02:31 +02:00
Noel Grandin 0f912872b6 xmloff: sal_Bool->bool
Change-Id: Id3d8f4f4ef32280a131907ffa32eb2ad5d6ea2e1
2014-03-31 12:39:03 +02:00
Noel Grandin 6ac6fb820f xmloff: sal_Bool->bool
Change-Id: I64c33ae4c157e270acac9a1f820d3e6272ba0bea
2014-03-31 12:39:02 +02:00
Noel Grandin ba6cfaaa6b xmloff: sal_Bool->bool
Change-Id: Idc7b0ef2591e65e82903d55af68434acbeca0e55
2014-03-31 12:37:25 +02:00
Stephan Bergmann 70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
Eike Rathke ebc1b2fe50 added bool bForExport parameter to XMLPropertySetMapper ctor
Set to true for export, false for import. If export true, an
XMLPropertyMapEntry with mbImportOnly==true is not added to the
mappings. This to be able to have more than one mappings for import
(for example a current extension namespace and the future namespace
proposed to the ODF-TC, or corrected typos in element or attribute
names), but map only to one entry on export, of course.

Change-Id: Ia01ea949c88eda2f8a6c10f51c59e35e7abdcaf3
2013-12-20 03:26:57 +01:00
Eike Rathke 9dd7ee88bd prepared XMLPropertyMapEntry with mbImportOnly flag
Change-Id: Id5a54a591a42c836884af1fd09dc055f2fce6db5
2013-12-20 03:26:56 +01:00
Norbert Thiebaud 21123da759 xmloff: include <> for external includes
Change-Id: Ic92d0121e928041bcff00b12706f794a4d8e25c8
2013-11-11 22:37:28 -06:00
Thomas Arnhold a45953ed7c fixincludeguards.sh: xmloff
Change-Id: I0e7d9daac1ad88fad8d240373e91ef323966bb47
2013-10-23 23:22:32 +02:00
Luboš Luňák 64b993e046 finish deprecation of O(U)String::valueOf()
Compiler plugin to replace with matching number(), boolean() or OUString ctor,
ran it, few manual tweaks, mark as really deprecated.

Change-Id: I4a79bdbcf4c460d21e73b635d2bd3725c22876b2
2013-08-21 15:10:35 +02:00
Jelle van der Waa 4f360266cd fdo#62475 removed pointless comments
Change-Id: I176886fbc9f3d9e2b8ad2308ac2b127d9c68d9a6
Reviewed-on: https://gerrit.libreoffice.org/5331
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2013-08-10 14:55:06 +00:00
Takeshi Abe a2e599f16b Mark as static and/or const
Change-Id: I45a890bb793a6d92546c05bd75738d4dd753a01e
2013-07-18 22:18:25 +09:00