ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
1787 Commits
Author SHA1 Message Date
Andrea Gelmini 4defe28e5f Fix typos 
Change-Id: Icb2d5f8bb9eb781d6a59384e1aac75abf6145774
Reviewed-on: https://gerrit.libreoffice.org/51337
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-03-15 20:09:53 +01:00
Noel Grandin dcd95c6fff tdf#115432 footnote separator position wrong (3rd attempt) 
My second attempt in

   commit dedf5e4f9000e271683dea9a0488e1b45b91176c
   "tdf#115432 footnote separator position wrong (2nd attempt)"

managed to lose part of the change because of incorrect rebasing.

Change-Id: I7b18f3e1602c617d1cb414ef0eb2ee456aeb58ee
Reviewed-on: https://gerrit.libreoffice.org/50901
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-03-07 19:23:57 +01:00
Noel Grandin 1163bcd5da tdf#115432 footnote separator position wrong (2nd attempt) 
the first attempt (d4a8d91abd)
incorrectly changed the type of a UNO property defined in a
published IDL file.

Change-Id: I75bc75dead0954d1faa6dfb6adab9f4c42c67cfc
Reviewed-on: https://gerrit.libreoffice.org/50827
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-07 08:05:32 +01:00
Noel Grandin 2407c18309 Revert "tdf#115432 footnote separator position remain in the left side" 
This reverts commit d4a8d91abd.

because it changes the type of an UNO property defined in a published IDL file

Change-Id: I4d3db3532b27552a30f34fcd4201856565eb0a3b
Reviewed-on: https://gerrit.libreoffice.org/50825
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-07 07:07:02 +01:00
Tomaž Vajngerl d72145f930 Move BackGraphicURL property & friends to BackGraphic + fixes 
This moves BackGraphicURL, HeaderGraphicURL, FooterGraphicURL and
ParaBackGraphicURL properties to BackGraphic, HeaderBackGraphic,
FooterBackGraphic and ParaBackGraphic. With this the property type
changes from String to XGraphic.

This change also fixes a bunch of test failures, changes the tests
to use the new properties and the correct type, changes the import
and export filters like xmloff and oox, to make the tests happy.

Change-Id: Ie66097514203c6dc36ab27420faf265322e9279e
Reviewed-on: https://gerrit.libreoffice.org/50760
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2018-03-07 02:37:36 +01:00
Noel Grandin f02b1ba18d use more Color in xmloff 
Change-Id: Iec12d2e9f3e254dc6525dc285259321b13f75c4a
Reviewed-on: https://gerrit.libreoffice.org/50794
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-06 11:50:16 +01:00
Noel Grandin ffee771f8d add some color conversion methods to sax::Converter 
to make the call-sites less verbose

Change-Id: Ifddcbb03a454a241bef93f31a8025801b84a66fc
Reviewed-on: https://gerrit.libreoffice.org/50578
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-06 06:51:00 +01:00
Noel Grandin d4a8d91abd tdf#115432 footnote separator position remain in the left side 
regression from
    commit 7e9857c293
    "templatize SvXMLEnumMapEntry"

Change-Id: Id29e7c07be637adcdc7fe624a1673beca9829d4d
Reviewed-on: https://gerrit.libreoffice.org/50420
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-27 16:03:01 +01:00
Tomaž Vajngerl 3400424877 xmloff: remove unused code when loading/saving the bitmap table 
Change-Id: I6bffe243e813079538a4cb57111266b41d7c03f1
Reviewed-on: https://gerrit.libreoffice.org/50333
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2018-02-26 06:04:43 +01:00
Tomaž Vajngerl 4256ffa959 fix import of graphic bullets 
When changing to use "GraphicBitmap" property instead of
"ImageURL", the import wasn't adapted and there was no test which
would warn of such an situation. This also changes the difference
between writer and impress where impress used "Graphic" and not
"GraphicBitmap" property.

Also adds missing tests for both writer and impress

Change-Id: Ieed629d2d37f7806d63e729b6ef23cd848593071
Reviewed-on: https://gerrit.libreoffice.org/50140
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2018-02-25 08:09:56 +01:00
Tomaž Vajngerl e48b4275ce report the saved mimetype when saving graphic + mime from stream 
When saving we need to determine which mime type to use for the
graphic. Return this information back to the caller so the
metadata can be written into the file if necessary.

Also add function to determine the mime type from the XGraphic
by converting it to a stream first (only then we can determine the
format that will actually be used and written to the storage file.

Change-Id: I796da715e47f29d77dea605a2769a2217ecd6ba5
Reviewed-on: https://gerrit.libreoffice.org/49992
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2018-02-21 21:32:56 +01:00
Noel Grandin 7ca8a6c8b1 create uno::Any overrides for Color 
And use less ColorData in writerfilter and xmloff.

part of removing ColorData.

Change-Id: Ia1c57bf837ae814e7642cf1c7de2eb7ada7a1500
Reviewed-on: https://gerrit.libreoffice.org/50028
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-20 12:55:47 +01:00
Noel Grandin 19a906f096 drop Color::SetColor(ColorData) in favour of operator= 
first stage of getting rid of ColorData

Change-Id: I5e4e95eb958722814c43c8d1ebfef17ad18c29ec
Reviewed-on: https://gerrit.libreoffice.org/49997
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-20 07:19:16 +01:00
Tomaž Vajngerl e02efb621f Change bitmap table to store XBitmap instead of GraphicObject URL 
As we want to get rid of GraphicObject URLs for the more robust
image life-cycle handling, it was necessary to change the way
bitmap table stores and handles images, so that they always
store a Graphic object (wrapped in UNO object that provides the
XGraphic and XBitmap interface).

In addition this changes loading and saving from ODF (xmloff) and
OOXML (oox) filters so they don't depend on GraphicObject URL
anymore, but load or save directly to / from  XGraphic or XBitmap.

Change-Id: I2b88e10056e7d6c920249d59188f86b1a5a32d21
Reviewed-on: https://gerrit.libreoffice.org/49074
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
 2018-02-01 11:54:22 +01:00
Caolán McNamara fd5c9c7bcd reuse limit 
Change-Id: I5942b6581c02ac55d7eb6acf535214daa5b34865
Reviewed-on: https://gerrit.libreoffice.org/48507
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-01-25 09:54:15 +01:00
Caolán McNamara 4f9d4b9b52 ofz: out-of-memory 
Change-Id: If1c9ade3268f4ebadfdad771fe3b35641dca210d
Reviewed-on: https://gerrit.libreoffice.org/48506
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-01-25 09:53:47 +01:00
Noel Grandin fe4de616a4 loplugin:useuniqueptr in SvXMLNumFmtExport 
Change-Id: I720450a4bee17673907fba2e9a34879d2a98bcae
Reviewed-on: https://gerrit.libreoffice.org/48481
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-25 07:23:56 +01:00
Noel Grandin e725836ec1 loplugin:unused-returns in filter,tools,xmloff 
Change-Id: I7a57be7e241883adac4417baa699a97d6304a631
Reviewed-on: https://gerrit.libreoffice.org/48188
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-20 07:41:29 +01:00
Stephan Bergmann 9dab60931e More loplugin:cstylecast: xmloff 
Change-Id: I870bc9fd1c7361913b073411065ec723f6b080da
 2018-01-15 09:00:57 +01:00
Tomaž Vajngerl 640a7c791b xmloff: XmlImageStyle class is pointless as the methods are static 
When used, we instantiate the XmlImageStyle class but all its
methods are static, so instantioation is completely pointless.
So change XmlImageStyle to a namespace and static method to
functions.

Change-Id: I6385bd7eeb08c627cb8e48b79a6820372cf94a65
Reviewed-on: https://gerrit.libreoffice.org/47851
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2018-01-14 14:45:01 +01:00
Stephan Bergmann dec5264878 More loplugin:cstylecast: xmloff 
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: Ic872cef7bb9982305528ec3ce12a1871f055b752
 2018-01-12 20:09:29 +01:00
Noel Grandin 00bc5a0973 wrap scoped enum around css::util::NumberFormat 
Change-Id: Icab5ded8bccdb95f79b3fa35ea164f47919c68fa
Reviewed-on: https://gerrit.libreoffice.org/46339
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
 2017-12-19 22:08:26 +01:00
Noel Grandin be359b156b loplugin:unusedenumconstants 
Change-Id: I9dc4b369872a7c6c076ae9be1dcdf2f8385af8a7
Reviewed-on: https://gerrit.libreoffice.org/46684
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-19 07:49:33 +01:00
Tor Lillqvist 2b26d15222 Bin a typedef used just once 
Change-Id: I8591b1d872a729402ea6045d2a17dc691fa66788
Reviewed-on: https://gerrit.libreoffice.org/45841
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
 2017-12-05 11:55:00 +01:00
Julien Nabet a46a5b653b Use for-range loops in xmlexppr (xmloff) 
Change-Id: I65b20b98082db6cd2bda17f527f7ade7a1123a97
Reviewed-on: https://gerrit.libreoffice.org/45743
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-12-03 19:33:05 +01:00
Miklos Vajna 9914ca04ac ODF export: expose font style and weight of embedded fonts 
We don't need this info ourselves, but when converting the flat ODF
output to other formats, this information is hard to find out, so state
them explicitly. Names correspond to existing CSS ones, where it's
necessary to state these explicitly. The EPUB export will make use of
these attributes.

(It is unclear why the test fails on the windows_msc_dbgutil_32 slave,
it works for me locally.)

Change-Id: I05030b6a14aca842e5a740786f3743e9ae838293
Reviewed-on: https://gerrit.libreoffice.org/45384
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
 2017-11-28 19:32:46 +01:00
Noel Grandin 665d085511 loplugin:countusersofdefaultparams in sw (1) 
Change-Id: I0d14f9c375f93079aef21ca4f1132adc4e1fe06c
Reviewed-on: https://gerrit.libreoffice.org/45207
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-24 12:31:35 +01:00
Noel Grandin 7a1c21e53f loplugin:simplifybool for negation of comparison operator 
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791
Reviewed-on: https://gerrit.libreoffice.org/45068
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-23 06:59:31 +01:00
Takeshi Abe 02393281b6 xmloff: These arrays are constant 
Change-Id: I834e23610facb8b4b35f0a377e33b744e7725d1f
Reviewed-on: https://gerrit.libreoffice.org/45066
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-22 07:46:29 +01:00
Noel Grandin 5f4938d89d loplugin:flatten in xmloff 
Change-Id: I782278b8a633094b96788f81ae7066a45d45b5fe
Reviewed-on: https://gerrit.libreoffice.org/44750
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-15 13:06:13 +01:00
Andrea Gelmini d71bcc4dc5 Fix typos 
Change-Id: Ia544298334364ece3b3963a4adc00c5e01189b91
Reviewed-on: https://gerrit.libreoffice.org/44654
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mark Page <aptitude@btconnect.com>
 2017-11-13 08:43:17 +01:00
Caolán McNamara b97d210bce ofz#4057 Integer-overflow 
Change-Id: I6a7ef3ca4c26ce4965deeea27ae47a03169bcf12
Reviewed-on: https://gerrit.libreoffice.org/44320
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-05 17:55:21 +01:00
Caolán McNamara d30522e46c ofz#3895 Integer-overflow 
Change-Id: Ibc90bdad5edf2d382e358dde4a0bfce6e4276584
Reviewed-on: https://gerrit.libreoffice.org/44026
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-10-30 00:15:37 +01:00
Stephan Bergmann 3ff3a05371 loplugin:includeform: xmloff 
Change-Id: I9e55142a7904c426fce49f68f1790365ea490fab
 2017-10-23 22:45:46 +02:00
Michael Stahl 99772908d7 xmloff: this should be an assert() 
Change-Id: Ib81fd7f72964d7152c62d1f9b90dc0cf95e952cc
 2017-10-17 21:03:52 +02:00
Eike Rathke 5be8c9cc1b Resolves: tdf#102075 support system [$-F400] time and [$-F800] long date 
By substituting a (valid matching the type) format using these
special LCID modifier values with the current system locale's
format.

See ECMA-376-1:2016 18.8.31 numFmts (Number Formats) and
https://msdn.microsoft.com/en-us/library/documentformat.openxml.spreadsheet.numberingformats.aspx
which seems to be the only documentation available.

Change-Id: Ieca048a77d4ef473ae475e202557d1353ff5387d
Reviewed-on: https://gerrit.libreoffice.org/43148
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-05 09:26:30 +02:00
Noel Grandin 2c05d758b2 add << operator for css::uno::Exception 
Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-04 15:18:00 +02:00
Noel Grandin 692d35b89a loplugin:finalclasses in xmloff 
Change-Id: I10ffefd29b858548472a459314c7d5632324bca2
Reviewed-on: https://gerrit.libreoffice.org/43069
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-03 13:22:00 +02:00
Julien Nabet 22e748e68a Prefer prefix operator 
Change-Id: I82f3f66bfc675dbc4a5d5b57d8715c3de01d9620
Reviewed-on: https://gerrit.libreoffice.org/42994
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-10-01 14:53:10 +02:00
Tor Lillqvist 8e7897588d Rename the basegfx::tools namespace to basegfx::utils 
Reduce potential confusion with the global tools namespace. Will
hopefully make it possible to remove the annoying initial :: when
referring to the global tools namespace. Unless we have even more
tools subnamespaces somewhere.

Thorsten said it was OK.

Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996
Reviewed-on: https://gerrit.libreoffice.org/42644
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-09-26 14:18:41 +02:00
Caolán McNamara 442df6cf83 ofz: don't leak in face of exceptions 
Change-Id: Ic15590a13bd3770ee5dd7db76b21c830a4fe73e2
Reviewed-on: https://gerrit.libreoffice.org/42587
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-09-22 11:01:53 +02:00
Michael Stahl 0ae13c77b6 xmloff,sw: some stylistic cleanup to conditional styles 
Change-Id: I1722a0b3d67a7c8740daa5a131d7800319ee2373
 2017-09-20 15:17:53 +02:00
Noel Grandin 5d5ac2fd9e clang-tidy modernize-use-emplace in xmloff 
Change-Id: I55bf75b5505d01cb33f26fac4603afdb3b4f1780
Reviewed-on: https://gerrit.libreoffice.org/42262
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-14 10:25:27 +02:00
Michael Stahl 9fe857b7bd tdf#111934 xmloff: ODF import: self-referential conditional style crash 
It's invalid input and also causes stack overflow.

Change-Id: Ie0b9dcaefcfcf254326151f345f4802ed66b994d
 2017-08-24 15:07:56 +02:00
Noel Grandin 2e8acde112 remove UL/L suffixes from integer constants on the RHS of expressions 
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5
Reviewed-on: https://gerrit.libreoffice.org/41237
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-17 11:25:21 +02:00
Noel Grandin db17a874af convert std::map::insert to std::map::emplace II 
Change-Id: Ief8bd59c903625ba65b75114b7b52c3b7ecbd331
Reviewed-on: https://gerrit.libreoffice.org/41019
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-11 13:51:29 +02:00
Noel Grandin d347c24036 convert std::map::insert to std::map::emplace 
which is considerably less verbose

Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b
Reviewed-on: https://gerrit.libreoffice.org/40978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-11 12:38:32 +02:00
Noel Grandin 977a676a71 loplugin:constparams in xmloff 
Change-Id: I136ee42523a40c576d7cf0b66abbf50ad9be052f
Reviewed-on: https://gerrit.libreoffice.org/40517
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-28 20:12:29 +02:00
Takeshi Abe f30530229b Mark SvXMLTokenMapEntry arrays as constant 
Change-Id: I37565540ec5dc3bfddf6cdeb20447f837e3014b6
Reviewed-on: https://gerrit.libreoffice.org/40374
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-07-26 20:44:20 +02:00
Noel Grandin 2fffaf6f05 loplugin:unusedmethods 
Change-Id: Ia874baf21257e5fe41e104211068a2bcc50446eb
Reviewed-on: https://gerrit.libreoffice.org/40391
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-25 12:03:50 +02:00