Commit Graph
105 Commits
Author SHA1 Message Date
Noel Grandin 3af500580b loplugin:salcall fix functions
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11 12:13:46 +01:00
Takeshi Abe 14f351529e cosmetics: Drop duplicate semicolon
Change-Id: I96d2ffb903f9ed15070572552c9564b5089df12f
Reviewed-on: https://gerrit.libreoffice.org/44914
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-20 14:01:44 +01:00
Stephan Bergmann bf49fc49ad loplugin:includeform: unotest
Change-Id: I2c545951eba154ac34db32f97e37c03edb790fd4
2017-10-23 22:45:48 +02:00
Stephan Bergmann 66604baf08 Consistently use OUString in test::Directories
Change-Id: Ia5fd8af34ee9d2f37e4450ab241f6bb9a06445b2
Reviewed-on: https://gerrit.libreoffice.org/41466
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-08-24 09:28:32 +02:00
Michael Stahl d8bd81fff8 unotest: really run every CppunitTest with its own user profile
Apparently a sw unit test randomly read a partially written autotbl.fmt
that was written by another unit test, in particular the file
workdir/unittest/user/config/autotbl.fmt.

The tests are actually started with
-env:UserInstallation=$(call gb_Helper_make_url,$(call gb_CppunitTest_get_target,$*).user)
to prevent exactly this problem, but unfortunately it's then
overridden by a call to rtl::Bootstrap::set(), which overrides
even command line arguments, from test::BootstrapFixtureBase::setUp().

Change-Id: I618574e94755ea38caf9583f3dcf7715396bca48
Reviewed-on: https://gerrit.libreoffice.org/41432
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-08-22 22:42:11 +02:00
Chris Sherlock 97eb00c75e revert OSL_ASSERT changes
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07 17:03:35 +10:00
Chris Sherlock 4833bcba21 tdf#43157: convert unotest from OSL_ASSERT to assert
Change-Id: I4fa580adfe9cc9a49824c5a4ef0f37c46b71a98d
2017-05-07 07:43:20 +10:00
Stephan Bergmann 36638dac7d loplugin:cppunitassertequals: unotest
Change-Id: If2ebd9ffcab036ecb7b07038346c8a8f8e059cbe
2017-04-28 14:22:47 +02:00
Tamás Zolnai 49d7bdea17 ChartDumpTest: A new chart test suite for a more sistematic testing
A hibrid of dumper tests (xmlDump) and simple CppUnit tests.
Advantages:
* Easy to add a new test case
** Add a new test file and generate the reference
** Similar to dumper tests
* Easy to find out the root of the problem when test fails
** Assertion is not coming somewhere from an XML file
** Assertion are placed in the code, so if you read and
understand that code, you can find out easier why the test fails.
** Similar to simple CppUnit tests.
* One test checks only one smaller part of the whole document
** e.g. legend, chart data, grid

Change-Id: I7bba5a37efcc62d6358c84acece91963243a914f
Reviewed-on: https://gerrit.libreoffice.org/34154
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-02-12 16:43:06 +00:00
Stephan Bergmann 06ce64bdc4 loplugin:unnecessaryoverride (dtors) in unotest
Change-Id: Ib9114cafb3732d11017b98405d1ca60052801675
2016-12-01 08:54:05 +01:00
Christian Lohmaier bc13c1c2ba screenshots: builddir is not neccessarily same as srcdir
Change-Id: Ic7d3d7854eeb5511d5e94e7329fcffa8a3ccba34
Reviewed-on: https://gerrit.libreoffice.org/31160
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-11-26 15:40:20 +00:00
David Tardon c87ecb0e18 remove dep on unotest from osl_Pipe test
Change-Id: I5f5862a684e52bd3d1336fa9f8cffa77cdebbe4c
2016-11-21 09:44:39 +01:00
Stephan Bergmann 91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
Jochen Nitschke 97abbec956 tdf#94306 replace boost::noncopyable in stoc to xmlsec..
Replace with C++11 delete copy-constructur
and copy-assignment.
Remove boost/noncopyable.hpp includes.
Add missing default ctors.

With this commit there should be no users
of boost::noncopyable left.

Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975
Reviewed-on: https://gerrit.libreoffice.org/24051
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13 11:19:04 +00:00
Jochen Nitschke 4c7ec9f112 cleanup: remove unused com/sun/star/uno includes
Sequence.h(xx), Any.h(xx) and Type.h(xx)
and remove unused using-declarations from these files.

Add a few missing includes provided by them.

Change-Id: I6b91b6d1fdf9d0496dd546c0aab9bdcc6831a5d4
Reviewed-on: https://gerrit.libreoffice.org/23805
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-04-12 06:38:26 +00:00
Jochen Nitschke f7a75a66fa cleanup: remove unused Reference.h(xx) includes
and unused using-declarations from Reference.h

Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19
Reviewed-on: https://gerrit.libreoffice.org/23735
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-04-02 19:01:24 +00:00
Stephan Bergmann 00b57f59a1 Special case for ANDROID is supposed to no longer be needed
...see Miklos' comment at <https://gerrit.libreoffice.org/#/c/23078/1> "Extract
Directories from BootstrapFixtureBase."

Change-Id: Ib8bd52a9960e4631802e5649c97147c074adddc6
2016-03-10 09:12:31 +01:00
Stephan Bergmann 60b1c95cc4 Extract Directories from BootstrapFixtureBase
(as some tests derive from the latter only for the Directories part, not for the
setUp/tearDown overrides: those tests will be cleaned up next)

Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f
Reviewed-on: https://gerrit.libreoffice.org/23078
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-10 08:04:40 +00:00
Michael Stahl 18b0343010 RC4 encrypt some WMF and TIFF test files
Reportedly some virus scanners warn about some of these files.

Use a new "RC4" name prefix since the files don't come from external
sources.

http://permalink.gmane.org/gmane.comp.documentfoundation.libreoffice.devel/69200

Change-Id: I6d4cff2fdd5c0134bf2c77558ea09b3196b39be9
2016-01-05 13:33:56 +01:00
Stephan Bergmann 34a66ff58a loplugin:nullptr (automatic rewrite)
Change-Id: Ie7e4b028ee0cd6e0254dda8dfe3c70973865bc03
2015-11-10 10:31:57 +01:00
Stephan Bergmann 7d4dcb08bc loplugin:stringconstant: elide explicit ctor usage (manually due to macros)
Change-Id: I888a2487201d6f6e9923de156bc616897b828624
2015-11-06 12:33:25 +01:00
Stephan Bergmann ebaa338df5 loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)
Change-Id: I909557f7ca803de8dc8604e95cc66430abb13f53
2015-11-06 09:38:26 +01:00
Noel Grandin 94268513ee use uno::Reference::set method instead of assignment
Change-Id: Id57ccff7ea6cf5c7053b51268b1190f5459bb357
2015-11-05 12:42:42 +02:00
Noel Grandin 59b072e22b yyyyy
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-04 14:10:44 +02:00
Stephan Bergmann b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Stephan Bergmann 23a0d1ff82 Use CPPUNIT_ASSERT_EQUAL
Change-Id: Id4305098e3139bb21711fefb350fa2574e3638cd
2015-09-15 13:22:23 +02:00
Stephan Bergmann a4ef3f4eb1 Clean up output
Change-Id: I4fbcd03e4af82ba8e3697651ddce92ba0ba450a6
2015-08-24 17:03:06 +02:00
Stephan Bergmann 82fb80ec22 Make test order deterministic
Change-Id: I9980034f0cb948acd6bb20aaf0fc27928ac68913
2015-08-24 16:56:29 +02:00
Noel Grandin a45827b230 loplugin:unusedmethods
Change-Id: Ib4d77ee01e7362f5951f81fceeca3c489872d971
Reviewed-on: https://gerrit.libreoffice.org/17378
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-07-30 06:23:00 +00:00
Stephan Bergmann 29bb3a68ea simplify
Change-Id: Ib88ccd6ea430791f18571ad7d6a34d7432477050
2015-04-01 16:48:28 +02:00
Miklos Vajna 0986fe7755 MacrosTest::loadFromDesktop: use comphelper::containerToSequence()
Change-Id: I91e385a6a7fe88251ec11ed90b61a3f61768ff5a
2015-03-31 09:15:02 +02:00
Tor Lillqvist 32423f6f87 WaE: passing [...] by value, rather pass by reference
Change-Id: Ic733f9b5dcb55bb8120c3652a60300914fab04ea
2015-03-30 16:51:24 +03:00
László Németh 6ec9e87ced Unit tests for SkipImages
SkipImages filter option skips image loading during DOC and DOCX
imports, but it keeps the text of textboxes and custom shapes.

Change-Id: Ia0ab3b350b9da22d9375787883678cc357a704b3
2015-03-30 12:32:33 +02:00
Tor Lillqvist 00ab36a16d The --nofirststartwizard option is a no-op
Change-Id: Id481af38ebb51224f4f8493cccfb4eb4fd1e268f
2015-03-29 23:51:03 +03:00
Noel Grandin 48bb2913a7 convert SFX_FILTER_ constants to enum class
Change-Id: I7e53cfc90cefd9da7d6ecd795b09214bd44b1613
2015-03-19 08:25:03 +02:00
Noel Grandin fb14be5f8f create new 'enum class' SotClipboardFormatId to unify types
of which there are several.

There are some issues here I am unsure of
- the SW and SC and CHART2 modules essentially ignore the enum values and assign their own ids
  Perhaps I should change them to use the common values and create new enum values where necessary?
- the sc/qa/ and sq/qa/ and starmath/qa/ code was doing some dodgy stuff. I translated the code to pass down the stuff
   numeric values to the underlying code, but perhaps further fixing is necessary?

Change-Id: Ic06d723e404481e3f1bca67c43b70321b764d923
2015-03-18 14:23:50 +02:00
Caolán McNamara 4d6a509efe convert all remaining BOOST_STATIC_ASSERT to static_assert
and we can include a few less headers

Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
2015-02-05 22:21:49 +00:00
Stephan Bergmann 484401bb5e unotest: Use appropriate OUString functions on string constants
Change-Id: I449587dd8e6e625e886e4ffc6419c612adffcfde
2014-12-18 14:12:36 +01:00
Caolán McNamara 36feeb1eab tweak the assert message so its readable when an errors happens
Change-Id: Ib4f262f4c8cffc9790001618ce8050eda75ae559
2014-11-19 11:06:23 +00:00
Caolán McNamara 12bcfec04f markup with event type not checker type
Change-Id: I14c0c5d90b67000cb4fe9e6be647854abfe784da
2014-11-05 14:58:00 +00:00
Caolán McNamara cb0e009a9e document array_vs_singleton dismissals
Change-Id: I8d7eb4c01197e885abca717c7814c61a7641ac9d
2014-10-30 10:10:09 +00:00
Noel Grandin fc04f76336 fdo#82577: Handle Time
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11
Time typedef.

Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866
Reviewed-on: https://gerrit.libreoffice.org/11684
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-01 07:34:23 +00:00
Noel Grandin 3e82897353 improve the inlinesimplememberfunctions clang plugin
Change-Id: I6d5a952901648e01904ef5c37f953c517304d31e
2014-06-17 10:55:17 +02:00
Stephan Bergmann 4ef5dfad79 loplugin:staticcall
Change-Id: Ib04cadafab0f3d0cd9e6bb550d846a3a1ca8ea76
2014-06-13 17:54:36 +02:00
Kohei Yoshida a916b6ff7f Detach all DocBasicItem objects upon process termination.
To prevent rogue DocBasicItem objects (which are global objects) from
attempting to stop listening after the main app is dead.

Change-Id: I68a667137ca4e0eff18278f4d2d5dd67466eaf34
2014-05-29 21:59:48 -04:00
Noel Grandin e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
Tomaž Vajngerl 5830799d5b macros_test: use "css" short form
Change-Id: I2e8d8773703df67d090059be8bd9f3c7c7335f78
2014-04-12 12:58:50 +02:00
Stephan Bergmann 70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
Alexander Wilms f993a8930a Remove visual noise from unotest
Change-Id: I34d98f086d1a041516174a26cbf37fc3d75da155
Reviewed-on: https://gerrit.libreoffice.org/8333
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 03:34:13 -06:00
Stephan Bergmann c622bc0696 bool improvements
Change-Id: Ic113564f9d30e59b0292d97318f15e9b04813ce3
2014-01-28 20:26:20 +01:00