ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
220 Commits
Author SHA1 Message Date
Andrea Gelmini 4defe28e5f Fix typos 
Change-Id: Icb2d5f8bb9eb781d6a59384e1aac75abf6145774
Reviewed-on: https://gerrit.libreoffice.org/51337
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-03-15 20:09:53 +01:00
Stephan Bergmann a2656563f1 loplugin:unnecessaryparen: Warn about parentheses around literals 
...that are not composed of multiple tokens, like ("foo" "bar").  Also don't yet
warn about Boolean literals, which are sometimes wrapped in parentheses to
silence unreachable-code warnings.

To avoid multiple warnings about code like

  f((0))

switch to generally using a set of ParenExpr to keep track of which occurrences
have already been handled.

Change-Id: I036a25a92836ec6ab6c56ea848f71bc6d63822bc
Reviewed-on: https://gerrit.libreoffice.org/45317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-11-27 14:04:40 +01:00
Stephan Bergmann 7c02ef0275 loplugin:includeform: unodevtools 
Change-Id: Iac0a22dd68a39cf5f71907c8f1e289fbd0c95249
 2017-10-23 22:45:48 +02:00
Julien Nabet 22e748e68a Prefer prefix operator 
Change-Id: I82f3f66bfc675dbc4a5d5b57d8715c3de01d9620
Reviewed-on: https://gerrit.libreoffice.org/42994
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-10-01 14:53:10 +02:00
Noel Grandin 1ffba0e356 loplugin:flatten check for throw in then clause 
also make the plugin ignore the case where we have var decl's in the
clause we want to flatten, which could lead to problematic extension of
variable lifetime

Change-Id: I3061f7104e8c6a460bf74f5eac325a516ec50c59
Reviewed-on: https://gerrit.libreoffice.org/42889
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-29 08:51:48 +02:00
Noel Grandin 9881bea8d4 remove unnecessary use of OUString::getStr 
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4
Reviewed-on: https://gerrit.libreoffice.org/38114
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-17 11:55:13 +02:00
Noel Grandin d347c24036 convert std::map::insert to std::map::emplace 
which is considerably less verbose

Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b
Reviewed-on: https://gerrit.libreoffice.org/40978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-11 12:38:32 +02:00
Noel Grandin daf177f703 use more OUString::operator== in test..xmlsecurity 
Change-Id: If5bdd1532be44a47ff7cc3b769be3ea585aea562
Reviewed-on: https://gerrit.libreoffice.org/39685
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-14 12:39:20 +02:00
Noel Grandin 4250b25c6a teach unnecessaryparen loplugin about identifiers 
Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b
Reviewed-on: https://gerrit.libreoffice.org/39737
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-10 09:57:24 +02:00
Noel Grandin 8c77b5670e use OString::operator== in preference to ::equals 
Change-Id: Ib291521963a791a9c6175964571e9d9895072acf
Reviewed-on: https://gerrit.libreoffice.org/39646
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-06 20:23:09 +02:00
Noel Grandin 3ab6732629 fix bug in skeletonmaker 
how this got missed for so long I don't know

Change-Id: I5c4bbb880f364fdbb8c88e80c6329184c0bd48a5
Reviewed-on: https://gerrit.libreoffice.org/38725
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-13 11:56:01 +02:00
Noel Grandin ef513fd4b0 remove unnecessary use of OString::getStr 
Change-Id: I0490efedf459190521f4339854b3394d57765fdb
Reviewed-on: https://gerrit.libreoffice.org/38058
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-28 19:44:08 +02:00
Noel Grandin 3a36cf434f loplugin:checkunusedparams in configmgr and vcl 
Change-Id: I7226d01f38e6edaf3868d7267d9b02dbdbc9e5ba
Reviewed-on: https://gerrit.libreoffice.org/36975
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-28 08:32:56 +02:00
Stephan Bergmann c4de235ad3 New loplugin:conststringvar: unodevtools 
Change-Id: I7bbe7f78b8e62962f907a598e8405be7d4be03c9
 2017-01-10 08:09:58 +01:00
Takeshi Abe cb90f0976d Omit the default comparator 
Change-Id: Idea8ea8dab6a86d7be6394aef1cf7f25b75009e0
Reviewed-on: https://gerrit.libreoffice.org/30319
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
 2016-11-01 04:11:44 +00:00
Noel Grandin b796b24793 loplugin:countusersofdefaultparams in svl..unodevtools 
Change-Id: Ie3d2cf29e99b8a51b80246aafa23a92e6c3404b2
Reviewed-on: https://gerrit.libreoffice.org/28017
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-11 06:04:52 +00:00
Tor Lillqvist e0849330bc Get rid of unnecessary directory levels $D/inc/$D 
Change-Id: Ibf313b8948a493043006ebf3a8281487c1f67b48
Reviewed-on: https://gerrit.libreoffice.org/25532
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Tor Lillqvist <tml@collabora.com>
 2016-05-27 17:10:45 +00:00
Stephan Bergmann b14c3a5e33 Remove unused pbOpt parameter 
Change-Id: I4c566a122d600d41d7d8049779628a08e68ca277
 2016-05-02 16:59:51 +02:00
Stephan Bergmann db67f6f408 loplugin:salbool: Automatic rewrite of sal_False/True 
Change-Id: Ife577280d5176d9f48bff719c7b52fc829ae49f1
 2016-04-20 17:27:29 +02:00
Stephan Bergmann f9ddda3538 Remove ornamental noise 
Change-Id: Ic8d33142b6bd7d271e94ec93661f0260bb2ea6e2
 2016-03-08 16:12:01 +01:00
Rohan Kumar 26b69a9d0f tdf#91794 Remove OSL_DEBUG_LEVEL > 1 conditionals 
I removed the fprintf statements and replaced them with
SAL_WARN statements.

Change-Id: Id75e310e3a95b249fdf92a4dd5a9bcf1b7fb9be6
Reviewed-on: https://gerrit.libreoffice.org/22984
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
 2016-03-08 13:29:14 +00:00
Noel Grandin cd1bbdf0a4 convert codemaker::UnoType::Sort to scoped enum 
Change-Id: I70a84f777e714bcc20c2d7b06b918e3be0f3ce4a
 2016-02-24 11:48:38 +02:00
Stephan Bergmann f1e5db3e5c Use emplace_back 
Change-Id: I006e3c8f411b480917d9cfb9c4f3d082b79c833d
 2015-12-14 20:44:21 +01:00
Stephan Bergmann 9690dcc42e loplugin:nullptr (automatic rewrite) 
Change-Id: Ic89c5fb56e1f11fa17f6014a8c9722592b144337
 2015-11-10 10:31:56 +01:00
Noel Grandin 6c80a8fe89 new loplugin: oncevar 
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f
Reviewed-on: https://gerrit.libreoffice.org/19815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-09 08:34:40 +00:00
Caolán McNamara 9aa7c8375c coverity#1338260 Uncaught exception 
Change-Id: Ib969223cb5c8acdad0e97ff9b944703d3ee43825
 2015-11-06 12:15:59 +00:00
Noel Grandin 94268513ee use uno::Reference::set method instead of assignment 
Change-Id: Id57ccff7ea6cf5c7053b51268b1190f5459bb357
 2015-11-05 12:42:42 +02:00
Noel Grandin 286dfc2a72 loplugin: defaultparams 
Change-Id: I50ba6a836473961d952ed88e56532501469c5368
 2015-08-11 09:48:18 +02:00
Caolán McNamara 52be3fcbd9 cppcheck: badBitmaskCheck 
Change-Id: I0a6787379317e5077c5a4520e5144fe091a01538
 2015-08-10 12:13:30 +01:00
Andrea Gelmini 9b7e1bf43d Fix typos 
Change-Id: Ieaf67cf597e05dbae5affa153af907fda4462a41
Reviewed-on: https://gerrit.libreoffice.org/16295
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2015-06-16 10:59:53 +00:00
Noel Grandin 4ea281a3cc cppcheck:redundantAssignment 
Change-Id: I1167d0ce6b6f6e48309d0551c1d2a283d79546a7
 2015-06-15 13:34:14 +02:00
Michael Stahl 2f69e16c72 override the overloading of "overload" to decrease cognitive (over-)load 
Change-Id: I4d0e1de89d0bbdbea23bc5a46bf75ae0ce4e2796
 2015-01-09 00:00:47 +01:00
Stephan Bergmann 102ae9f11a unodevtools: Use appropriate OUString functions on string constants 
Change-Id: I70a86543c0269cbaeefc9cbe1da30c2ad7e48333
 2014-12-16 17:31:18 +01:00
Stephan Bergmann 7d4a694650 unodevtools: loplugin:cstylecast 
Change-Id: Id4bd8bb8361204ae281a090840b08c502e5b4a7a
 2014-12-04 08:22:55 +01:00
Brij Mohan Lal Srivastava d32be3ace8 fdo#86023 - O[U]String needs a 'clear' method 
Added clear() method to OString and OUString class, Updated appropriate call-sites.

Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac
Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
 2014-11-14 09:20:38 +01:00
Andrea Gelmini da40cac540 Fix common typos. No automatic tools. Handmade… 
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959
Reviewed-on: https://gerrit.libreoffice.org/12164
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-11-12 11:04:11 +00:00
Noel Grandin 0371a63365 remove unnecessary 'using namespace rtl' declarations 
It turns out that almost none of them were necessary.

Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-29 11:28:54 +00:00
Stephan Bergmann e50ef195bc New loplugin:stringconcat 
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
 2014-07-01 15:45:52 +02:00
Julien Nabet f8cd68bad6 cppcheck: Redundant checking of STL container 
Change-Id: I83a8671e90431bbc4f41392f062d37c452b018ff
 2014-06-21 14:26:58 +02:00
Noel Grandin 0e507ae031 various: remove SAL_THROW macro 
Change-Id: I9464179a736b91f5bc32eb5e5e89b3b4e3da3494
 2014-06-05 08:17:52 +02:00
Noel Grandin cc25f70ef1 compareTo -> equals 
convert OUString::compareTo usage to equals to startsWith where it
is more appropriate

Change-Id: I6f5b5b7942429c0099ad082ba4984fd18e422121
 2014-06-04 11:52:34 +02:00
Noel Grandin 4f9b21248f simplify ternary conditions "xxx ? yyy : false" 
Look for code like:
   xxx ? yyy : false;
Which can be simplified to:
   xxx && yyy

Change-Id: Ia33c0e452aa28af3f0658a5382895aaad0246b4d
 2014-05-05 12:47:48 +02:00
Stephan Bergmann 80ce877249 Clean up function declarations 
Change-Id: I18125ac6c58c89f76c3a6cfb3a7ee77b1059aeb1
 2014-04-08 10:22:01 +02:00
Noel Grandin 5babf1b903 remove unnecessary scope qualifier from sal_Bool uses 
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
 2014-04-03 13:54:02 +02:00
Andrzej Hunt d69346b170 Make parameters const too. 
(Following on from loplugin:passstringbyref)

Change-Id: I9100f51aa7420b237c84de7d36d2374ac6612d00
 2014-03-18 19:49:59 +00:00
Andrzej Hunt 887ab6d083 loplugin:passstringbyref 
Change-Id: Ic88d78418fb9380dece316544e0afb4d8660f8e6
 2014-03-18 18:37:33 +00:00
Tor Lillqvist c15913b273 Spelling fix: suported 
Change-Id: I3b67edd5ba4541a65cb0916abea6db1362c32afd
 2014-03-12 15:56:04 +02:00
Michael Stahl b3ccc23604 unodevtools: rename makefile like the Executable 
Change-Id: Icf8df0829aecf838d0037a3393f27e90c23b9548
 2014-03-03 23:44:12 +01:00
Alexander Wilms 3dd72c19eb Remove visual noise from unodevtools 
Change-Id: Ib8047c4606874d5bc6ce024bf34ee518cc51581b
Reviewed-on: https://gerrit.libreoffice.org/8332
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 07:21:41 -06:00
Alexander Wilms 0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00