Commit Graph
50 Commits
Author SHA1 Message Date
Noel Grandin 8ec0f90a28 loplugin:changetoolsgen in tools..toolkit
Change-Id: I3d87ee59258567b5a82cb459248539faea1b3ca9
Reviewed-on: https://gerrit.libreoffice.org/50101
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-22 07:22:33 +01:00
Noel Grandin 3af500580b loplugin:salcall fix functions
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11 12:13:46 +01:00
Johnny_M 75a96e22fd Translate German comments/debug strings (leftovers in dirs test to uui)
Translates leftovers found using a custom regex.

Additionally:
- A few spelling fixes

Change-Id: I3772e1b914acc487d80ab14efb815cb178ca3dcb
Reviewed-on: https://gerrit.libreoffice.org/41831
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
2017-09-04 11:04:46 +02:00
Noel Grandin 7aa7f4d9e4 loplugin:unnecessaryparen include c++ casts
Change-Id: I132d3c66f0562e2c37a02eaf4c168d06c2b473eb
Reviewed-on: https://gerrit.libreoffice.org/41874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-04 10:52:41 +02:00
Jens Carl 6b4a149a65 tdf#39468 Translate German comments
Translate German comments and terms in UnoControls/, editeng/, filter/,
odk/, reportdesign/, sd/, sfx2/, starmath/, svl/, svtools/, toolkit/,
tools/, writerfilter/, and xmloff/.

Change-Id: Ibc401a425ddfdf41e4e4a78600f3fbce8cfaa2b1
Reviewed-on: https://gerrit.libreoffice.org/35992
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-04-03 19:25:49 +00:00
Stephan Bergmann 5885bc4879 loplugin:loopvartoosmall
Change-Id: I14ada64d094d7ef147402e37baf4d6881075e914
2017-02-26 21:54:36 +01:00
Stephan Bergmann e57ca02849 Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26 12:54:43 +00:00
Noel Grandin e61521f6cf OSL_TRACE -> SAL in sw..ucb
Change-Id: I18f5511f70232d91095ac8527a6c5883c36294f5
Reviewed-on: https://gerrit.libreoffice.org/31762
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08 17:27:26 +00:00
Stephan Bergmann 175e2adfd1 loplugin:nullptr (automatic rewrite)
Change-Id: Ied9204441c07f1f6a6026c8c1a2fa21b93b98e1a
2015-11-10 10:31:54 +01:00
Noel Grandin b37b7b5cd5 use uno::Reference::set method instead of assignment
Change-Id: Id036f867e75d03d8347cc32a1011c5cdda1dcc73
2015-11-05 11:18:41 +02:00
Stephan Bergmann 64b33886ef loplugin:cstylecast: deal with those that are (technically) const_cast
Change-Id: Ie7129c66f236b93f505dad9ea672ab777cb380d1
2015-06-02 11:28:38 +02:00
Noel Grandin edc189dbfa loplugin:staticfunction
Change-Id: I89f5984d73e7d42269189dc1d1bc2d59e5ab193f
2015-04-01 10:37:02 +02:00
Stephan Bergmann 3099c70b11 Fix various XServiceInfo implementations
...to match what is recorded in the .component files

Change-Id: Ie548cd37872d3b8540222201afaac73040e65c8f
2015-03-17 12:25:11 +01:00
Michael Stahl 15b4ab8d19 cppuhelper: clean up public headers with include-what-you-use
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-18 18:51:49 +01:00
Noel Grandin 705c48d32e fdo#38835 strip out OUString globals
they are largely unnecessary these days, since our OUString infrastructure
gained optimised handling for static char constants.

Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-11-05 08:44:19 +02:00
Stephan Bergmann 1579d8ed79 Avoid incomplete type in fn sig to keep ubsan's RTTI-based checks happy
Change-Id: I536353b86ee023eb630ea89786d2205a628d95e3
2014-08-07 18:42:35 +02:00
Stephan Bergmann d656138b12 loplugin:staticcall
Change-Id: I9e643bd43e6e0f027a7e17b2d5d867c0cb452052
2014-06-13 17:54:35 +02:00
Julien Nabet ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
2014-05-23 22:11:52 +02:00
Stephan Bergmann 5e21a413c7 cppuhelper: retrofit std::exception into overriding exception specs
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26 18:22:20 +01:00
Alexander Wilms e90c27f5e1 Remove visual noise from toolkit
Change-Id: I1704d6ac497f2e47a813813640ead14c5fa480d9
Reviewed-on: https://gerrit.libreoffice.org/8326
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26 05:51:48 -06:00
Stephan Bergmann 146c7c5c89 toolkit: sal_Bool -> bool
Change-Id: I5153c4413004d1b50cc503b3e70657bc831a5793
2014-02-24 11:13:42 +01:00
Matúš Kukan 68694f360f tk: Ctor feature for StdTabController(Model).
Change-Id: I3792b8b4d240c212d332c676d53eaa1f5dca3902
2014-01-24 12:21:22 +01:00
Stephan Bergmann 2c5b0bb345 Avoid code mixing bool with other integral types
Change-Id: Idf75d03a302df977a41f688eb48e40de31ff2816
2014-01-10 17:11:43 +01:00
Luboš Luňák 1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Stephan Bergmann 9e2034c033 Missing solar mutex
...as witnessed by the triggered assert

MSVCR90!wassert+0x641
vcllo!ImplDbgTestSolarMutex+0x72 [c:\lo\core\vcl\source\app\dbggui.cxx @ 1750]
tllo!DbgFunc+0x47a [c:\lo\core\tools\source\debug\debug.cxx @ 1120]
vcllo!DbgTestSolarMutex+0xd [c:\lo\core\solver\wntmsci12\inc\tools\debug.hxx @ 295]
vcllo!OutputDevice::ImplInitClipRegion+0x2d [c:\lo\core\vcl\source\gdi\outdev.cxx @ 913]
vcllo!Window::Invert+0xef [c:\lo\core\vcl\source\window\window2.cxx @ 411]
vcllo!ImplCursorInvert+0x437 [c:\lo\core\vcl\source\window\cursor.cxx @ 120]
vcllo!Cursor::ImplRestore+0x27 [c:\lo\core\vcl\source\window\cursor.cxx @ 159]
vcllo!Cursor::ImplDoHide+0x40 [c:\lo\core\vcl\source\window\cursor.cxx @ 216]
vcllo!Cursor::ImplHide+0x3c [c:\lo\core\vcl\source\window\cursor.cxx @ 234]
vcllo!Window::ImplGrabFocus+0x4aa [c:\lo\core\vcl\source\window\window.cxx @ 4053]
vcllo!Window::GrabFocus+0x52 [c:\lo\core\vcl\source\window\window.cxx @ 7544]
tklo!StdTabController::ImplActivateControl+0x1fe [c:\lo\core\toolkit\source\controls\stdtabcontroller.cxx @ 152]
tklo!StdTabController::activateFirst+0x45 [c:\lo\core\toolkit\source\controls\stdtabcontroller.cxx @ 354]
msci_uno!`anonymous namespace'::callVirtualMethod+0x8a [c:\lo\core\bridges\source\cpp_uno\msvc_win32_intel\uno2cpp.cxx @ 76]
msci_uno!`anonymous namespace'::cpp_call+0x4b3 [c:\lo\core\bridges\source\cpp_uno\msvc_win32_intel\uno2cpp.cxx @ 257]
msci_uno!bridges::cpp_uno::shared::unoInterfaceProxyDispatch+0x321 [c:\lo\core\bridges\source\cpp_uno\msvc_win32_intel\uno2cpp.cxx @ 438]
binaryurp_uno!binaryurp::IncomingRequest::execute_throw+0xaa8 [c:\lo\core\binaryurp\source\incomingrequest.cxx @ 245]
binaryurp_uno!binaryurp::IncomingRequest::execute+0xe0 [c:\lo\core\binaryurp\source\incomingrequest.cxx @ 74]
binaryurp_uno!request+0x6b [c:\lo\core\binaryurp\source\reader.cxx @ 85]
cppu3!cppu_threadpool::JobQueue::enter+0x28d [c:\lo\core\cppu\source\threadpool\jobqueue.cxx @ 115]
cppu3!cppu_threadpool::ORequestThread::run+0xc6 [c:\lo\core\cppu\source\threadpool\thread.cxx @ 175]
cppu3!threadFunc+0x18 [c:\lo\core\solver\wntmsci12\inc\osl\thread.hxx @ 187]
sal3!oslWorkerWrapperFunction+0x23 [c:\lo\core\sal\osl\w32\thread.c @ 60]

during JunitTest_toolkit_unoapi on Windows (which does not use a headless mode
for those tests).

Whether locking the class instance's GetMutex() is really necessary here I do
not know, but at least be careful to lock the global solar mutex first.

Change-Id: Icbd7936f4bf8433ef6a36912566d43361e911429
2013-03-22 19:17:20 +01:00
Michael Meeks c4008ef546 re-base on ALv2 code. Includes:
tkr41: #117828# office crash fixed . (null pointer) + add unit test
    Patch contributed by Tobias Krause
    http://svn.apache.org/viewvc?view=revision&revision=1172105

    Do not add targets for junit tests when junit is disabled.
    Patch contributed by Andre Fischer
    http://svn.apache.org/viewvc?view=revision&revision=1241508

    remove the OutDev::GetKernPair* stubs completely
    Patch contributed by Herbert Duerr
    http://svn.apache.org/viewvc?view=revision&revision=1179221

    reverting un-necessary OS/2 conditionals.
2012-10-03 16:56:06 +01:00
Arnaud Versini 36a2db3722 Replace usage of rtl_*Memory with equivalent from string.h
Change-Id: I50ffc10f007f03c3252ef0196b59b881429cc159
Reviewed-on: https://gerrit.libreoffice.org/734
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-01 18:48:05 +00:00
Oliver Günther be88027c32 fdo#39468: Translate German comments in toolkit,unotools, & xmloff
Also checked the following with bin/find-german-comments (all
false positives):
- sysui
- xml2cmp
- udm
- ucb

Change-Id: I2c72f973f5cecf56d70b5419e56338170dd55a2e
2012-08-10 21:57:26 +02:00
Norbert Thiebaud 9485f3a6d6 targeted string re-work
Change-Id: If929937d8b1243032983b8b379f067a47d2717a4
2012-05-28 18:09:26 -05:00
Thomas Arnhold 135c63c8f9 fdo#48253 Expand SAL_STATIC_CAST and SAL_CONST_CAST
Change-Id: I50f0887ceb4517d7ef234f970ca2ba679d533382
2012-05-04 15:52:57 +02:00
Caolán McNamara 5daa649c56 disabled for 11 years, not like to get fixed soon 2012-04-05 13:57:22 +01:00
Norbert Thiebaud 6a7d81e7a5 remove include of pch header from toolkit 2011-11-27 13:25:40 -06:00
julien2412 09179e24c4 activation order crashes address database (fdo#41022) 2011-10-24 15:51:28 +02:00
Thomas Arnhold 08be19bcb8 Move DBG_TRACE to OSL_TRACE 2011-03-11 23:41:07 +01:00
Joseph Powers 5bd709c6ab Remove DECLARE_LIST( ComponentEntryList, ComponentEntry* ) 2011-02-10 21:48:39 -08:00
Gert Faller f39607df60 RTL_CONSTASCII_USTRINGPARAM in libs-gui 08 2010-11-22 22:47:26 +01:00
Sebastian Spaeth 4905a19032 Add vim/emacs modelines to all source files
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-14 17:02:15 +02:00
Jens-Heiner Rechtien 8764506704 changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
Rüdiger Timm d7f9b90b84 INTEGRATION: CWS changefileheader (1.11.210); FILE MERGED
2008/04/01 16:00:58 thb 1.11.210.3: #i85898# Stripping all external header guards
2008/04/01 12:56:51 thb 1.11.210.2: #i85898# Stripping all external header guards
2008/03/28 15:40:16 rt 1.11.210.1: #i87441# Change license header to LPGL v3.
2008-04-11 08:26:39 +00:00
Oliver Bolte 0a898ce103 INTEGRATION: CWS pchfix02 (1.10.136); FILE MERGED
2006/09/01 17:54:22 kaib 1.10.136.1: #i68856# Added header markers and pch files
2006-09-16 11:18:17 +00:00
Rüdiger Timm 92cce94167 INTEGRATION: CWS ooo19126 (1.9.138); FILE MERGED
2005/09/05 16:58:13 rt 1.9.138.1: #i54170# Change license header: remove SISSL
2005-09-09 12:18:19 +00:00
Hans-Joachim Lankenau f96807bafd INTEGRATION: CWS dba12 (1.8.2); FILE MERGED
2004/04/26 11:04:06 fs 1.8.2.1: #i22982# more tolerant activateTabOrder
2004-06-28 16:00:55 +00:00
Jens-Heiner Rechtien 0035a0d4cd INTEGRATION: CWS frmcontrols02 (1.7.126); FILE MERGED
2004/01/21 16:24:09 fs 1.7.126.1: wrong tabbing in some cases ...
2004-04-13 10:07:14 +00:00
Vladimir Glazounov 1f47db36c3 INTEGRATION: CWS dba03 (1.5.24.1.20); FILE MERGED
2003/02/26 09:35:26 fs 1.5.24.1.20.1: #107691# assertion corrected
2003-04-01 13:06:38 +00:00
Jens-Heiner Rechtien fd2cf3dc7c MWS_SRX644: migrate branch mws_srx644 -> HEAD 2003-03-27 16:05:12 +00:00
Malte Timmermann b838fac35f #88105# XServiceInfo 2001-09-04 07:06:31 +00:00
Malte Timmermann 4cf626f02d Improvements for the UnoDialogControl... 2001-01-25 12:40:59 +00:00
Malte Timmermann 76b390391d model and control for uno dialogs 2001-01-24 14:00:58 +00:00
Frank Schönheit 93cdfed825 unotools -> comphelper 2000-11-02 10:12:12 +00:00
Jens-Heiner Rechtien 8ab086b6cc initial import 2000-09-18 16:07:07 +00:00