Commit Graph
67 Commits
Author SHA1 Message Date
Stephan Bergmann 697f01e052 SAL_W32 is just an alias for _WIN32
...so consistently use the latter instead of the former

Change-Id: I144d5e7c472632f93b2258461510346bc85892d9
Reviewed-on: https://gerrit.libreoffice.org/48135
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19 08:19:38 +01:00
Andrea Gelmini f0b857310d Fix typos
Change-Id: Ia976371bf52eb1216d8abe728d80bbb87a3c38a2
Reviewed-on: https://gerrit.libreoffice.org/47858
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16 14:23:52 +01:00
Mike Kaganski aaa26a58ba Some more WIN32_LEAN_AND_MEAN
Change-Id: Iadb0ebb66809c192fb817b8c7cf2f8cdb4d0b874
Reviewed-on: https://gerrit.libreoffice.org/42419
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-18 19:24:31 +02:00
Noel Grandin 657f067b91 remove some unnecessary OUStringBuffer usage
Change-Id: Iae9146a3be569107019d9c5af404b94e51e76cd5
Reviewed-on: https://gerrit.libreoffice.org/34469
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-21 06:05:38 +00:00
Stephan Bergmann c68b5c36cd Some simplifications, using UNO_QUERY_THROW
Change-Id: Iaf7b4695e7930b8e7fa5dd3736d19744afb52fa3
Reviewed-on: https://gerrit.libreoffice.org/34254
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-15 14:17:00 +00:00
Christian Lohmaier 8d2f282abe typo: emtpy → empty
Change-Id: I60cdcdc7fc38c175243c071f34295efa8739b717
2016-07-04 12:20:48 +02:00
Rohan Kumar 96e44b3b51 tdf#91794 remove OSL_DEBUG_LEVEL > 1 conditionals
I replaced the OSL_DEBUG_LEVEL > 1 to OSL_DEBUG_LEVEL > 0
conditionals. At some places i removed the logs containing
OSL_DEBUG_LEVEL > 1 as OSL_DEBUG_LEVEL > 0 is compiled in
production code

Change-Id: I4466e7a2025b055f89fc525d7412f10bd4d8a07f
Reviewed-on: https://gerrit.libreoffice.org/23067
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-03-11 12:09:32 +00:00
Chris Sherlock a238b1f8d3 Remove excess newlines
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09 08:18:05 +00:00
Noel Grandin a76f4c6708 com::sun::star->css in testtools/
Change-Id: I9a44e44b2478b007fba7f86eefcf4fa04d77b37b
Reviewed-on: https://gerrit.libreoffice.org/19852
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-09 07:20:51 +00:00
Takeshi Abe ac142d91b6 testtools: tdf#88206 replace cppu::WeakImplHelper*
with the variadic variants.

Change-Id: I6c77b9219c772f38005431fed7cd0f4132fab2b9
Reviewed-on: https://gerrit.libreoffice.org/18395
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-09 08:12:15 +00:00
Caolán McNamara d2275c825d cppcheck: noExplicitConstructor
Change-Id: I955b04396d27e88ce228f180275955071da83ec6
2015-05-26 14:11:12 +01:00
Stephan Bergmann 678196b9a1 Replace remaining getCppuType et al with cppu::UnoType
Change-Id: I02c70b26b82d2d0357111a127aefc57d3be21320
2015-04-01 08:41:50 +02:00
Caolán McNamara fd1372ba8b boost::unordered_map->std::unordered_map
you can get debug stl this way

Change-Id: Ia70a3e7c7c452390e8bee34975d296c9318e4a19
2015-01-02 16:14:36 +00:00
Noel Grandin e7bc3cab01 remove boilerplate in UNO Exception constructor calls
Now that we have default values for Exception constructor params,
remove lots of boilerplate code.

Change-Id: I620bd641eecfed38e6123873b3b94aaf47922e74
2014-05-23 15:06:00 +02:00
Alexander Wilms a9311d6b1a Remove visual noise from testtools
Change-Id: Idbf31a46a9e174b96b3cac76be6a01a6ada0abde
Reviewed-on: https://gerrit.libreoffice.org/8325
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-27 09:44:42 -06:00
Alexander Wilms 0ce0c369aa Remove unneccessary comments
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-23 03:38:49 +00:00
Stephan Bergmann a83b2af9ab Clean-up uno/lbnames.h
Change-Id: I4bd729499aa8be58f04194656e35c1f79d5d4919
2013-12-16 21:43:12 +01:00
Noel Grandin 52bbd9cc00 remove unnecessary RTL_CONSTASCII_STRINGPARAM in appendAscii calls
Convert code like:
    aStrBuf.appendAscii( RTL_CONSTASCII_STRINGPARAM( "ln(x)" ));
to:
    aStrBuf.append( "ln(x)" );
which compiles down to the same code.

Change-Id: I24c7cb45ceb32fd7cd6ec7ed203c2a5d746f1c5c
2013-11-20 10:07:32 +02:00
Noel Grandin 2c35fff7ec remove most use of RTL_CONSTASCII_USTRINGPARAM macro
This is largely unnecessary when working with OUString

Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
2013-11-19 10:29:30 +02:00
Noel Grandin fcd1637d51 convert OUString compareToAscii == 0 to equalsAscii
Convert code like
   aStr.compareToAscii("XXX") == 0
to
  aStr.equalsAscii("XXX")
which is both easier to read and faster.

Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11 12:58:13 +02:00
Noel Grandin e2451bd729 Convert indexOf->startsWith and lastIndexOf->endsWith
This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-31 08:34:21 +02:00
Marcos Paulo de Souza ee5661ecd3 fdo#54938: Adapt supportsService implementations..
to cppu::supportsService

Change-Id: I0b03d3910f094f2183bf9859db9d5bcaf35d1f14
Reviewed-on: https://gerrit.libreoffice.org/6370
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-22 10:28:10 +00:00
Thomas Arnhold ba0a57702c remove OUString wrap for string literals
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-06-29 21:52:54 +00:00
Luboš Luňák 1946794ae0 mass removal of rtl:: prefixes for O(U)String*
Modules sal, salhelper, cppu, cppuhelper, codemaker (selectively) and odk
have kept them, in order not to break external API (the automatic using declaration
is LO-internal).

Change-Id: I588fc9e0c45b914f824f91c0376980621d730f09
2013-04-07 14:23:11 +02:00
Thomas Arnhold 39d45390f4 removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarations
s/(OUString\s+[a-zA-Z_][A-Za-z0-9_]*\s*)\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/$1\($2\)/gms

Change-Id: Iad20f242c80c4bdc69df17e2d7a69d58ea53654b
Reviewed-on: https://gerrit.libreoffice.org/2835
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 10:48:30 +00:00
Thomas Arnhold 8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-03-19 09:00:26 +00:00
Michael Meeks 9d7c1dcbbb re-base on ALv2 code. Includes:
Patches contributed by Ocke Janssen
   converted reportdesign.
   http://svn.apache.org/viewvc?view=revision&revision=1396797
   http://svn.apache.org/viewvc?view=revision&revision=1394326

   Patch contributed by Oliver Rainer-Wittmann
   sw34bf06: #i117783# - Writer's implementation of XPagePrintable -
   apply print settings to new printing routines
   http://svn.apache.org/viewvc?view=revision&revision=1172115
2012-12-06 09:12:57 +00:00
Norbert Thiebaud 750fc20611 replace remaining InterlockedCount() with inlined version
Change-Id: Ifcfa48fc87f905a91470a5b0fd597b02f220784c
Reviewed-on: https://gerrit.libreoffice.org/671
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-09-25 01:55:38 +00:00
Julien Nabet 5bfa5cb86a Fix duplicate branches for if and else
Change-Id: Ic602fd4df63e6807f49c256ce7849ae587eeb82d
2012-09-16 10:24:59 +02:00
Michael Meeks b6db3e3acc re-base on ALv2 code.
Change-Id: Ice06e639213aeb6f7f23cbf4634947dd25613db1
2012-06-21 13:11:06 +01:00
Thomas Arnhold a3bf3451a9 WaE: arrayIndexOutOfBounds 2012-02-21 20:57:06 +01:00
Norbert Thiebaud 3c9d6bdbc6 remove include of pch header from testtools 2011-11-27 13:25:25 -06:00
Tor Lillqvist 469c9ac2f9 Enforce a "lib" prefix for UNO components for Android
This commit for the old build system. (Don't bother for components not
relevant for Android.)

The Android package installer (as invoked through "adb install", from
"ant debug install") silently ignores native libraries in app packages
(.apk files) whose names don't start with "lib" and end with ".so".

The package builder (as invoked through "ant debug") in the SDK gladly
includes also thusly named native libraries in the .apk, though. Yay
for consistency.
2011-11-17 15:22:59 +02:00
Matúš Kukan 50205b9d19 Remove component_getImplementationEnvironment 2011-07-12 12:26:18 +02:00
Julien Nabet a27728407e Easyhack: Add visibility markup to all component_get* functions 2011-04-21 15:28:34 +02:00
Thomas Arnhold d8d6bee713 Move OSL_ENSURE(sal_False,...) to OSL_FAIL(...) 2011-03-19 14:12:11 +01:00
Julien Nabet e62f74cabe Remove "using namespace ::rtl" 2011-03-02 20:52:59 +01:00
Fridrich Štrba 1c4bced7c2 std::hash_map -> boost:unordered_map 2011-02-05 21:58:42 +01:00
Sebastian Spaeth f402b2f5af Add vim/emacs modelines to all source files
Fixes #fdo30794
Based on bin/add-modelines script (originally posted in mail
1286706307.1871.1399280959@webmail.messagingengine.com)

Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
2010-10-13 10:58:05 +02:00
Jens-Heiner Rechtien 7d8d20ca7e changefileheader2: #i109125#: change source file copyright notice from Sun Microsystems to Oracle; remove CVS style keywords (RCSfile, Revision) 2010-02-12 15:01:35 +01:00
Rüdiger Timm 5a5ccec1b6 INTEGRATION: CWS changefileheader (1.7.44); FILE MERGED
2008/04/01 16:00:27 thb 1.7.44.2: #i85898# Stripping all external header guards
2008/03/31 07:26:30 rt 1.7.44.1: #i87441# Change license header to LPGL v3.
2008-04-11 11:35:55 +00:00
Rüdiger Timm e333122c83 INTEGRATION: CWS changefileheader (1.5.44); FILE MERGED
2008/03/31 07:26:29 rt 1.5.44.1: #i87441# Change license header to LPGL v3.
2008-04-11 11:35:38 +00:00
Rüdiger Timm 75715beeda INTEGRATION: CWS changefileheader (1.6.44); FILE MERGED
2008/04/01 16:00:27 thb 1.6.44.2: #i85898# Stripping all external header guards
2008/03/31 07:26:29 rt 1.6.44.1: #i87441# Change license header to LPGL v3.
2008-04-11 11:35:19 +00:00
Rüdiger Timm 78c77205ad INTEGRATION: CWS changefileheader (1.3.88); FILE MERGED
2008/03/31 07:26:29 rt 1.3.88.1: #i87441# Change license header to LPGL v3.
2008-04-11 11:34:43 +00:00
Vladimir Glazounov 1f27bcfe8a INTEGRATION: CWS hr33 (1.4.112); FILE MERGED
2006/11/07 12:49:24 hr 1.4.112.3: RESYNC: (1.4-1.6); FILE MERGED
2006/05/02 16:51:05 hr 1.4.112.2: #i10000#: replace CLK_TCK with POSIX conforming sysconfig(_SC_CLK_TCK); clean up license header, remove log footer
2006/05/02 16:26:04 hr 1.4.112.1: #i55967#: no prefix for STL header please
2006-11-22 09:39:08 +00:00
Vladimir Glazounov ffa47d4705 INTEGRATION: CWS hr33 (1.2.14); FILE MERGED
2006/11/07 12:49:17 hr 1.2.14.2: RESYNC: (1.2-1.4); FILE MERGED
2006/05/02 16:51:30 hr 1.2.14.1: #i10000#: clean up license header, remove log footer
2006-11-22 09:38:55 +00:00
Vladimir Glazounov b9f1e03d8f INTEGRATION: CWS hr33 (1.3.14); FILE MERGED
2006/11/07 12:49:40 hr 1.3.14.2: RESYNC: (1.3-1.5); FILE MERGED
2006/05/02 16:51:30 hr 1.3.14.1: #i10000#: clean up license header, remove log footer
2006-11-22 09:38:38 +00:00
Vladimir Glazounov c01added4c INTEGRATION: CWS hr33 (1.3.112); FILE MERGED
2006/11/07 12:49:32 hr 1.3.112.2: RESYNC: (1.3-1.4); FILE MERGED
2006/05/02 16:54:17 hr 1.3.112.1: #i10000#: clean up license header
2006-11-22 09:38:25 +00:00
Oliver Bolte 27a08bc4e2 INTEGRATION: CWS pchfix02 (1.5.8); FILE MERGED
2006/09/01 17:53:59 kaib 1.5.8.1: #i68856# Added header markers and pch files
2006-09-16 12:38:42 +00:00
Oliver Bolte 1204f4b9f9 INTEGRATION: CWS pchfix02 (1.3.8); FILE MERGED
2006/09/01 17:53:59 kaib 1.3.8.1: #i68856# Added header markers and pch files
2006-09-16 12:38:26 +00:00