Commit Graph
580 Commits
Author SHA1 Message Date
Jens Carl 940f90f3da Add UNO API property tester for common read-only properties.
Add UNO API property tester for read-only properties 'double', 'long',
'short' and 'string'.

Change-Id: I7177e133972058b0272a3cf8493521fbfbcade32
Reviewed-on: https://gerrit.libreoffice.org/52142
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-30 22:37:21 +02:00
Jens Carl 4887640bad Improve documentation
Change-Id: I1c8daa5544806e7d646d7e2c9bbf57d78b7091fb
Reviewed-on: https://gerrit.libreoffice.org/52141
Reviewed-by: Jens Carl <j.carl43@gmx.de>
Tested-by: Jens Carl <j.carl43@gmx.de>
2018-03-30 05:14:22 +02:00
Jens Carl 3fc835b799 tdf#45904 Move _XCalculatable Java test to C++
Change-Id: Ib1fac049d2a135074de45c17fbaa78b0af2bec91
Reviewed-on: https://gerrit.libreoffice.org/51929
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-28 03:28:30 +02:00
Jens Carl 655b9054bc tdf#45904 Move _XDDELink Java test to C++
Change-Id: Ic7a23088ee10f2d92d05354131e3066ec098a7b9
Reviewed-on: https://gerrit.libreoffice.org/51850
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-27 03:14:09 +02:00
Andrea Gelmini 524cf62841 Fix typo
Change-Id: I278098108a8120b1b7a8115d8e5abc6d1ea57321
Reviewed-on: https://gerrit.libreoffice.org/51784
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-03-23 20:22:34 +01:00
Jens Carl b910203239 tdf#45904 Move _SpreadsheetDocumentSettings Java test to C++
Change-Id: Ic6bde95d0d4255e082a60e41a117365422b22aa8
Reviewed-on: https://gerrit.libreoffice.org/51724
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-22 16:56:04 +01:00
Jens Carl 3228251663 Add UNO API property tester for double and read-only boolean.
Change-Id: I85ec413aa34bdc563294dc71520742515849fbca
Reviewed-on: https://gerrit.libreoffice.org/51722
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-22 16:53:15 +01:00
Jens Carl fc3f43b6fe Move UNO API property testers header file
Move the header file form the global include path include/test to the
module-specific path test/inc.

Change-Id: I72c1f3b420bc387f4f5b9ab75f30f0e8462c1b75
Reviewed-on: https://gerrit.libreoffice.org/51682
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-21 17:01:01 +01:00
Jens Carl ea5eb69b65 Fix error with default arguments
Change-Id: Id645d43ad63b7d91d3c47898c22594dc58333cd2
Reviewed-on: https://gerrit.libreoffice.org/51622
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-20 16:46:18 +01:00
Jens Carl d97120c6f3 tdf#45904 Move _Spreadsheet Java tests to C++
Change-Id: Ic540d06899def77313d6dc7e0a5241e1f9eeea54
Reviewed-on: https://gerrit.libreoffice.org/51491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-18 23:32:04 +01:00
Jens Carl c671b27727 Create UNO API property testers for common types
Create UNO API property testers for common, so it's possible to share/use
them between all the UNO API service property tests.
Testers are available for the types 'boolean', 'long', 'short', and
'string'.

Change-Id: Ia36dba98c774695b3ba6ac9d9917af9fb20efdba
Reviewed-on: https://gerrit.libreoffice.org/51259
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-18 05:53:07 +01:00
Jens Carl b8563d46a0 tdf#45904 Move _SheetLink Java tests to C++
Change-Id: I33813be65bcb44c11a35bc97d963057418a28d9e
Reviewed-on: https://gerrit.libreoffice.org/50984
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-09 18:30:31 +01:00
Stephan Bergmann d15ff312ad Normalize computation of directory and file-in-directory URLs
There are occasional failures of Jenkins "Daily Screenshot Build on Windows"
like <https://ci.libreoffice.org/job/lo_tb_master_win_screenshot/324/console>
and <https://ci.libreoffice.org/job/lo_tb_master_win_screenshot/332/console>,
always failing with

> C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_screenshot/test/source/screenshot_test.cxx(84) : error : Assertion
> Test name: ReportdesignDialogsTest::openAnyDialog
> assertion failed
> - Expression: aNew.IsOpen()
> - Failed to open <C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win_screenshot/workdir/screenshots/modules/dbreport/ui/condformatdialog/CondFormat.png>: 796

(where 796 is ERRCODE_IO_NOTEXISTSPATH).  Beats me how that can happen, when
ScreenshotTest::implSaveScreenshot first creates the dir and then the file-in-
dir (and it is rather unlikely that something else deletes the dir in the
meantime, for various builds of that Jenkins bot, always for the same dir
workdir/screenshots/modules/dbreport/ui/condformatdialog/), and why it always
happens for exactly the same file,
workdir/screenshots/modules/dbreport/ui/condformatdialog/CondFormat.png during
CppunitTest_reportdesign_dialogs_test.

However, one curiosity was that the dir's URL was computed with

  m_directories.getURLFromWorkdir(aDirname);

(without a leading slash inserted before aDirname) while the file's pathname was
computed with

  m_directories.getPathFromWorkdir("/" + aDirname + ...)

(with a leading slash inserted before aDirname).  Turns out that SvFileStream
accepts a URL as well as a pathname, so normalize the computation of the dir's
and the file's URL.  Maybe that will give a clue why that Jenkins bot sometimes
fails.

Change-Id: I53b59b51ffc4355c45aa0ca72f6e187cf2010f92
2018-03-06 11:22:08 +01:00
Jens Carl 7b7e0ff7b7 tdf#45904: Move _Shape Java tests to C++
Change-Id: If0bfa9fb465f37e0ccce5b2fa4e909baaac1df50
Reviewed-on: https://gerrit.libreoffice.org/50722
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-04 18:59:22 +01:00
Caolán McNamara ec7f0c0d5a ensure [Message]Dialog dispose order on direct .ui hackery
Change-Id: I31f190a1232331dd2076cdb8583e2036887f4f9f
Reviewed-on: https://gerrit.libreoffice.org/50441
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28 09:40:04 +01:00
Jens Carl 5a0acced89 tdf#45904: Move _SheetFilterDescriptor Java tests to C++
Change-Id: I894b2e2534efeb5369c491053caf56f67dc56618
Reviewed-on: https://gerrit.libreoffice.org/50411
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-02-27 18:18:31 +01:00
Stephan Bergmann 09fcdbd5e0 Fix random range for XFunctionDescriptions::testGetById
...regression introduced with eff7034719
"tdf#45904 Move _XFunctionDescriptions Java test to C++" (where
java.util.Random.nextInt(n) returned a value 0 <= x < n), apparently causing
sporadic failures of CppunitTest_sc_functionlistobj like <https://
ci.libreoffice.org/job/lo_gerrit/27696/Config=linux_clang_dbgutil_64/console>

> ##Failure Location unknown## : Error
> Test name: sc_apitest::ScFunctionListObj::testGetById
> An uncaught exception of type com.sun.star.lang.IndexOutOfBoundsException

Also verify that nCount is not negative, so that the requirements of the
std::uniform_int_distribution ctor are guaranteed to be satisfied.

Change-Id: I90a5dc234fdd07f52fea69ae1d406f0818efb007
2018-02-14 22:36:01 +01:00
Miklos Vajna f8da775795 EPUB export, fixed layout: fix validation error with images
The "xlink" prefix for the "xlink:href" attribute on the "image" element
was not bound.

Change-Id: I473a0b1612b4842cf84a264960bb28a9f19600e5
Reviewed-on: https://gerrit.libreoffice.org/49612
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2018-02-12 21:50:21 +01:00
Jens Carl 4a8856dad8 tdf#45904 Move _SheetCellRanges Java tests to C++
Change-Id: If391071a7e44c2fbeaaa0fa46f6043f30e777cec
Reviewed-on: https://gerrit.libreoffice.org/49125
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-02-02 18:20:35 +01:00
Jens Carl 22f6e25987 tdf#45904 Move _SheetCellRange Java tests to C++
Change-Id: Ia4ebe9d0418e33d245437a49c7ce9551b4a06e82
Reviewed-on: https://gerrit.libreoffice.org/49124
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-02-02 18:19:56 +01:00
Jens Carl 740137d8cc Remove shared mxComponent (test document) in sctablesheetsobj
Change-Id: I3fb21aaebf97a143954f84e5d41415f58ecd9326
Reviewed-on: https://gerrit.libreoffice.org/49062
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-02-01 18:14:33 +01:00
Jens Carl e587def20d Remove shared mxComponent in scdatapilottableobj
Change-Id: I2cf424ecfa2748cfca0f85bab8da820c6286d331
Reviewed-on: https://gerrit.libreoffice.org/49061
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-02-01 03:17:12 +01:00
Jens Carl f0850acf53 Remove shared mxComponent in sccellcursorobj
Change-Id: I24d3641feb34e66959ff2afe4cdb3546e7cd7ca4
Reviewed-on: https://gerrit.libreoffice.org/48732
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-27 18:47:43 +01:00
Andrea Gelmini 32b2a1831d Fix typos
Change-Id: I334f0bd5636940ea8105dcf93b95b3af28894aad
Reviewed-on: https://gerrit.libreoffice.org/48546
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-26 11:39:58 +01:00
Jens Carl 35f6b6f6b9 tdf#45904 Move _SheetCell Java tests to C++
Change-Id: I5d698303a901ee103fdd4ffdea34809142afa0e5
Reviewed-on: https://gerrit.libreoffice.org/48463
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-25 18:18:18 +01:00
Stephan Bergmann 0b87fdcad5 Remove dubious test
...that fails for me on at least one macOS and Windows machine each (with 180
and 230, resp., instead of 116), and where it is unclear why only a value of 116
would be correct (and where that specific check was not present before
95307f2ca7 "tdf#45904 Move
_SpreadsheetViewSettings Java tests to C++", cf. my comment from 2018-01-17 at
<https://gerrit.libreoffice.org/#/c/47625/> "tdf#45904 Move
_SpreadsheetViewSettings Java tests to C++")

Change-Id: I16475ecaa853220ffe9e1d6dcf403302b04f4572
Reviewed-on: https://gerrit.libreoffice.org/48215
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-20 10:45:22 +01:00
Jens Carl 6e31851e72 tdf#45904 Move _GlobalSheetSettings Java tests to C++
Change-Id: Icdc30eb65b10a72b66f26c0d55844b8fb433f090
Reviewed-on: https://gerrit.libreoffice.org/47976
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-16 19:33:06 +01:00
Stephan Bergmann 87e3d60776 More loplugin:cstylecast: test
Change-Id: I5f7cd029e27be24415c075c4589e71eeae5d6ac2
2018-01-15 09:02:18 +01:00
Stephan Bergmann 506856ca50 More loplugin:cstylecast: test
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: Ia0835f0d9fe59bf0cb42210e4a6be1f022259a8d
2018-01-12 20:13:31 +01:00
Jens Carl 95307f2ca7 tdf#45904 Move _SpreadsheetViewSettings Java tests to C++
Change-Id: I68dcabd15b4b318a833a893b4de96c64ffd2a164
Reviewed-on: https://gerrit.libreoffice.org/47625
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-09 06:22:27 +01:00
Jens Carl c29828daa3 tdf#45904 Move _SubTotalDescriptor Java tests to C++
Change-Id: Id4265dd6a8123624bccdfe343655525948cadee7
Reviewed-on: https://gerrit.libreoffice.org/47623
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-09 03:56:31 +01:00
Tomaž Vajngerl e1fb3d95ac Remove XmlWriter in test module and use tools::XmlWriter
Change-Id: I0a0e07a6a71ed95d783d35b7d94b857074ec3450
Reviewed-on: https://gerrit.libreoffice.org/47523
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-01-07 09:34:44 +01:00
Jens Carl 6e21c087fd tdf#45904 Move _DocumentSettings Java tests to C++
Change-Id: Ie00a963c5eb575ae1e96f6e1aa10da1a2ce421e4
Reviewed-on: https://gerrit.libreoffice.org/47485
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-06 20:30:57 +01:00
Miklos Vajna 6007cdaabe CppunitTest_sc_autoformatobj: fix read of value vs content of value
As far as I see the old qadevOOo/runner/lib/MultiPropertyTest.java
didn't assert the content of the property value (only avoided the set of
the property if the value was null or void), the new C++ version asserts
both the type and the value. Asserting the type is probably a good
thing, but asserting the value is problematic, at least the test failed
for me without these tweaks.

Change-Id: I688486025e6118ad4c8907de6cb2629dd008f8fd
Reviewed-on: https://gerrit.libreoffice.org/47475
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-05 20:37:16 +01:00
Jens Carl b673cbeeeb tdf#45904 Move _DatabaseImportDescriptor Java tests to C++
Change-Id: I53e9a449cb18c26187f3b1676f8ab67918128499
Reviewed-on: https://gerrit.libreoffice.org/47447
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-05 02:40:41 +01:00
Jens Carl 5de151f0fd tdf#45904 Move _TableAutoFormat Java tests to C++
Change-Id: Ib26a2d2a05d926a0d031c86812456996cb368792
Reviewed-on: https://gerrit.libreoffice.org/47361
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-04 06:39:00 +01:00
Jens Carl 39f033e548 Remove obsolete header.
Change-Id: I7cd358845a048e6eb6df9bd42d022357e553981c
Reviewed-on: https://gerrit.libreoffice.org/47355
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-04 06:36:08 +01:00
Andrea Gelmini 3a355887ca Fix typos
Change-Id: I3f4ad9eff0730d3deea96b37fa7f36dfd038b214
Reviewed-on: https://gerrit.libreoffice.org/47301
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-03 12:19:33 +01:00
Jens Carl 056575f7ce tdf#45904 Move _TableValidation Java tests to C++
Fixes #i90346.

Change-Id: Iec7e5ebfe28d3d26f5c50950ee2d3f5fc890da65
Reviewed-on: https://gerrit.libreoffice.org/47292
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-03 08:25:56 +01:00
Jens Carl f4bd9029ba Remove unused header.
Change-Id: Ie61537af3dd30e47cc5a9ab925e636686c0325f4
Reviewed-on: https://gerrit.libreoffice.org/47291
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-03 07:44:56 +01:00
Jens Carl 23a1c5429c tdf#45904 Move _Scenario Java tests to C++
Change-Id: I313f3a56fd99e7fb29e6f729cfe13e99adf1fed6
Reviewed-on: https://gerrit.libreoffice.org/47289
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-01-03 03:50:34 +01:00
Jens Carl b92af3c7b4 tdf#45904 Move _XCellRangeAddressable Java test to C++
Change-Id: Ic3c1e6d793d4405c2dc4b8e7d1d7b87ed94fc6c3
Reviewed-on: https://gerrit.libreoffice.org/46579
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-16 01:43:41 +01:00
Jens Carl 96f8861a29 tdf#45904 Move _XCellFormatRangesSupplier Java test to C++
Change-Id: I95c20893878385ef173875956d3d7166b0e9e563
Reviewed-on: https://gerrit.libreoffice.org/46578
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-16 01:18:05 +01:00
Jens Carl acc24edf21 tdf#45904 Move _XConsolidatable Java tests to C++
Change-Id: Id851121d424e88d28f0c941d50ab115eba5cea18
Reviewed-on: https://gerrit.libreoffice.org/46485
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-15 01:55:26 +01:00
Jens Carl 68f7d89cec tdf#45904 Move _XConsolidationDescriptor Java tests to C++
Change-Id: Ib3e3722c1a4799ebb0cbb78f458abd6b967d6ba1
Reviewed-on: https://gerrit.libreoffice.org/46263
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-12 02:32:46 +01:00
Noel Grandin 3af500580b loplugin:salcall fix functions
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11 12:13:46 +01:00
Andrea Gelmini 06e5bd866b Fix typos
Change-Id: I2de8448564c963d3361a828bb96dcdb15eddf717
Reviewed-on: https://gerrit.libreoffice.org/46151
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-10 10:32:11 +01:00
Jens Carl 13ca879fba tdf#45904 Move _XDatabaseRanges Java tests to C++
Change-Id: Iee6753fd60fefc1ecd17ba8fe0acef58f17d64e6
Reviewed-on: https://gerrit.libreoffice.org/46076
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-08 19:30:22 +01:00
Jens Carl 7345bef0f3 tdf#45904 Move _XDataPilotField Java test to C++
Change-Id: I5ba1733a8e675048366651aa5f3affc9c249622c
Reviewed-on: https://gerrit.libreoffice.org/46066
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-08 06:29:45 +01:00
Jens Carl 87d636a14b tdf#45904 Move _XDataPilotTables Java tests to C++
Change-Id: I5a452f10799f78a6f83136bec4e1346c4ec8edf8
Reviewed-on: https://gerrit.libreoffice.org/46063
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-12-08 05:18:43 +01:00