ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
664 Commits
Author SHA1 Message Date
Caolán McNamara 3c8a6b0a18 ofz#7065 Integer-overflow 
Change-Id: Ic8837d21d64dc6fd3623ab5d32bc902e6c34dd21
Reviewed-on: https://gerrit.libreoffice.org/51746
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-23 09:50:49 +01:00
Samuel Mehrbrodt f4394514a1 Typo: SplittTable -> SplitTable 
Change-Id: I6c5947964b3765ea05debe8837bd2f3dc57ae6ed
Reviewed-on: https://gerrit.libreoffice.org/51745
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-03-23 08:24:26 +01:00
Noel Grandin a1b58e93f6 loplugin:constantparam 
Change-Id: I3ce653c0d9e517229dbbe32cc8d3ec3c206e364d
Reviewed-on: https://gerrit.libreoffice.org/51273
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-14 14:30:35 +01:00
Noel Grandin c774ad610e loplugin:constantparam in svtools..unotools 
Change-Id: I6e72fbe44dcb65ee5162448e9a72e6437d56b044
Reviewed-on: https://gerrit.libreoffice.org/50948
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-08 18:23:53 +01:00
Noel Grandin c98d330302 replace Color(COL_*) with COL_* 
using

    git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)"
    | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g"

and then some manual fixup where the resulting expression no longer
compiled

Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4
Reviewed-on: https://gerrit.libreoffice.org/50372
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-27 11:28:29 +01:00
Caolán McNamara 0fad8d3081 convert remaining WarningBox to weld::MessageDialog 
Change-Id: I7e3c156a6ad47ac232636ae274280c1cb7556d4a
 2018-02-27 09:52:32 +00:00
Noel Grandin 08ab1f46b1 loplugin:oncevar extend to tools/gen.hxx types 
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2
Reviewed-on: https://gerrit.libreoffice.org/50283
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-26 07:21:04 +01:00
Noel Grandin 9bc8714308 move MovePoint and MoveRect into Rectangle and Point 
Change-Id: Ie75c7c10288da00aac89479879e0b9fb1a4459b2
Reviewed-on: https://gerrit.libreoffice.org/50247
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-26 07:20:49 +01:00
Noel Grandin 924c0e34fd loplugin:changetoolsgen in svx 
and fix the regex in the plugin for matching += operator

Change-Id: I26b3e3fac1d4ef3e756cc9431b983b5f27ee76d6
Reviewed-on: https://gerrit.libreoffice.org/50037
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-21 06:04:19 +01:00
Noel Grandin 55dd09e3e5 loplugin:useuniqueptr in SdrTableRTFParser 
Change-Id: I3d0657bcfcb9fca0d7f8c27499c159ddc5ccf47d
Reviewed-on: https://gerrit.libreoffice.org/49935
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-19 07:12:30 +01:00
Caolán McNamara 68b1385af6 ofz#5949 Integer-overflow 
Change-Id: Ib1d39e6c80a579752aedd1ca0b41595192cfbbfc
Reviewed-on: https://gerrit.libreoffice.org/49303
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-02-06 21:27:15 +01:00
Caolán McNamara 914a35e846 ofz#4949 Integer-overflow 
Change-Id: Ib8928108c987989ab849e8d7e1a85078f6d93050
Reviewed-on: https://gerrit.libreoffice.org/49216
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-02-05 10:00:17 +01:00
Noel Grandin aa7f880e8a use more TypedWhichId in SdrObject::GetObjectItem 
Change-Id: Iacaffa4bfcca2b594d962985fb9fc93712c4464c
Reviewed-on: https://gerrit.libreoffice.org/49137
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-03 16:03:48 +01:00
Noel Grandin cc45c96770 use TypedWhichId in BaseProperties::GetItem 
Change-Id: Ic359d33d92928f5baa89cd98debe1a6a9d6a52f3
Reviewed-on: https://gerrit.libreoffice.org/49128
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-02 11:12:01 +01:00
Noel Grandin ae5f89fdcc split out SFX_METRIC_ITEM into separate field 
instead of overloading the nMemberId field
and thus fix various places that were effectively setting the METRIC
flag and causing a warning in SvxUnoConvertToMM

And fix bug in
    sw/source/core/unocore/unomap.cxx
where the PropertyAttribute::READONLY was in the wrong place,
ever since
    commit 84a3db80b4
    Date:   Mon Sep 18 23:08:29 2000 +0000
    initial import

Change-Id: Ifc2bf56709f19aea75300b2fda62ce551efc26af
Reviewed-on: https://gerrit.libreoffice.org/48950
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-01 12:34:37 +01:00
Andrea Gelmini 8f9941d5ed Fix typos 
Change-Id: I67ea0d54a06f1280ccdbc1ce65b940d78df701b3
Reviewed-on: https://gerrit.libreoffice.org/48827
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-29 13:24:29 +01:00
Armin Le Grand 75802ae40a BorderlineFix: Corrected wrong indexing in Array initialization 
Change-Id: I4222ef1c82620a05cea9f6db1a0664196cfb3bd4
 2018-01-29 10:16:56 +01:00
Armin Le Grand 753b35b27e BorderlineFix: Use svx::frame::Array tooling in Draw/Impress 
For creating the needed BorderPrimitives for TableCells for the
Tables used in Draw/Impress, adapt the ViewContactOfTableObj doing
this to use svx::frame::Array tooling now. This will correct the
error for not taking the neighboured connects for merged cells
into account and unify one more space to the same tooling.

Change-Id: I2e6f732985e9b963359f156628bd29ddfec1a80c
 2018-01-29 10:16:56 +01:00
Armin Le Grand c4e6f6cfa1 BorderlineFix: Corrected Draw/Impress TableStyle accesses 
In Draw/Impress the indices for accessing the correct
neighbouring TableStyles were wrong and thus created wrong
visualizations, corrected that.

Change-Id: Iebc5f294adb62fa4c6358e2f8c27d29cc3163fbc
 2018-01-29 10:16:56 +01:00
Noel Grandin b2897ae7e1 make SvxTableController constructor take SdrTableObj 
since the only call site already effectively checks that, simplify the
constructor code accordingly

Change-Id: I29e5283d529a988693972d85cfa8196ba2906220
Reviewed-on: https://gerrit.libreoffice.org/48651
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-28 07:32:01 +01:00
Noel Grandin c95d91ee35 improve subtyping when dealing with tools::WeakReference 
tweak the templating to make it easier to declare a WeakReference that
points to a subclass for a weak-capable class.
Which lets us declare some fields with more specific types, and dump a
lot of unnecessary casting.
And make WeakBase be inherited from virtually, so we don't end
up with weird states where two weak refernces could point to two
different parts of the same object.

Change-Id: I3213ea27e087038457b0761b5171c7bce96e71f3
Reviewed-on: https://gerrit.libreoffice.org/48650
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-27 17:19:26 +01:00
Noel Grandin 398bbde823 expand out SdrObjectWeakRef and SdrPageWeakRef typedefs 
Change-Id: Icacc7354df4a927533e6fec072cdd527e4c57b96
Reviewed-on: https://gerrit.libreoffice.org/48566
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-26 08:10:52 +01:00
Stephan Bergmann d9d92d20fd More loplugin:cstylecast: svx 
Change-Id: If370ad12d2885ea9a6348736a3bcab618bc2e6ec
 2018-01-15 09:02:31 +01:00
Stephan Bergmann c049c76fc5 More loplugin:cstylecast: svx 
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: I100e6c14cbf1d780f0e5ebca6b0c9e71ce1caaf7
 2018-01-12 20:13:55 +01:00
Noel Grandin acdba3c2ee loplugin:passstuffbyref more return improvements 
slightly less restrictive check when calling functions

Change-Id: I35e268ac611797b1daa83777cda02288a635aa32
Reviewed-on: https://gerrit.libreoffice.org/47259
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-03 08:07:41 +01:00
Julien Nabet e7fd8ee57c cppcheck: fix prefer ++/-- for non primitive types 
Here, we can just initialize the iterators with the right increment
instead of using while loops to increment them

Change-Id: I08b51ba11398dbb705d3ed83bfbf46df0deb7f21
Reviewed-on: https://gerrit.libreoffice.org/47224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-02 15:55:53 +01:00
Noel Grandin 956dd4a202 TypedWhichId in svx part 2 
Change-Id: Id927679c9f07f1dd820f4fdca9a45eb7aede037c
Reviewed-on: https://gerrit.libreoffice.org/46850
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-21 11:40:19 +01:00
Noel Grandin 882cadaac4 convert EETextFormat to scoped enum 
and drop unused BIN constant

Change-Id: I4ecda96f39147f7e9bceb11ecdb4f0ffe42d2053
Reviewed-on: https://gerrit.libreoffice.org/46589
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-16 10:44:03 +01:00
Caolán McNamara e068d96fec ofz#4581 Integer-overflow 
Change-Id: I7c4e19981c8ef6016f44680657d872102f00f6d3
Reviewed-on: https://gerrit.libreoffice.org/46190
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-12-10 21:03:26 +01:00
Daniel 9b5062a3ee tdf#111773 tdf#111780 Fix selection after merge cells in an Impress table 
Change-Id: I800c4fb8c37c07fb771f4310b207e459119a8e60
Reviewed-on: https://gerrit.libreoffice.org/45451
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-30 14:01:46 +01:00
Caolán McNamara 52869df3f0 ofz#4461 Integer-overflow 
Change-Id: Iae41823164c09352ef8ffa97dc3361476c03add8
Reviewed-on: https://gerrit.libreoffice.org/45396
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-28 15:12:43 +01:00
Caolán McNamara 3d4a0e5cf5 ofz#4422 Integer-overflow 
Change-Id: I1f3a09e34253de7f7a221e2c88d61c293cb69d03
Reviewed-on: https://gerrit.libreoffice.org/45271
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-25 17:55:10 +01:00
Noel Grandin 3fbbd74b7b loplugin:flatten in svx 
Change-Id: Idc4d0186ecc6f0722c2b1358486a2430f037ae29
Reviewed-on: https://gerrit.libreoffice.org/45036
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-22 12:15:38 +01:00
Noel Grandin f1a55c4bfc TypedWhichId for SDRATTR* constants (3) 
Change-Id: Iea72cb3a4bbf693096de46269f58259b5952eedb
Reviewed-on: https://gerrit.libreoffice.org/45024
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-22 08:33:08 +01:00
Noel Grandin ffba2c683a TypedWhichId for SDRATTR* constants (1) 
Change-Id: I29bd18fea4dea531ae84ebc024d2aa87a5c7004d
Reviewed-on: https://gerrit.libreoffice.org/44943
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-20 11:53:47 +01:00
Noel Grandin c690d38b06 TypedWhichId for EE_CHAR* constants 
Change-Id: I261f8a949ddd858dee196118bb42993a101a2a28
Reviewed-on: https://gerrit.libreoffice.org/44829
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-17 11:11:50 +01:00
Caolán McNamara 7719c53b2b silence coverity#1421123 Copy-paste error 
Change-Id: If340824c749dda0668fabba9d417f4a2c2acc3ff
Reviewed-on: https://gerrit.libreoffice.org/44774
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-16 09:57:49 +01:00
Andrea Gelmini 6b56336e23 Fix typos 
Change-Id: I53b47cab5cbc603bf11adcda8ac2a8373eef26a8
Reviewed-on: https://gerrit.libreoffice.org/44695
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-11-14 10:42:08 +01:00
Caolán McNamara 7586246f61 ofz#4146 Integer-overflow 
Change-Id: I380315539f06e790a023b6ac4c4733c136c1c180
Reviewed-on: https://gerrit.libreoffice.org/44544
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-09 17:59:30 +01:00
Caolán McNamara c30e8ba6f1 ofz#4072 Integer-overflow 
Change-Id: Ib4abb390b9846240b663777f0dee126e16e49dcf
Reviewed-on: https://gerrit.libreoffice.org/44452
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-08 14:23:58 +01:00
Caolán McNamara 133cc249c7 ofz#4072 Integer-overflow 
Change-Id: Ib94d4021be86e93e6ed0e836fbab0d8d0ca6f738
Reviewed-on: https://gerrit.libreoffice.org/44346
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-06 22:27:15 +01:00
Caolán McNamara 26211f0456 ofz#4034 Integer-overflow 
Change-Id: I99a4e24e2038387f749051bc268bc74ce808bd96
Reviewed-on: https://gerrit.libreoffice.org/44306
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-04 20:26:35 +01:00
Caolán McNamara bb90e3c283 ofz#4034 Integer-overflow 
Change-Id: Ia126933260ea017f7cfdc8ac2ddc43b16aa37b91
Reviewed-on: https://gerrit.libreoffice.org/44248
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-03 16:08:46 +01:00
Caolán McNamara cc6128d727 ofz#3886 Integer-overflow 
Change-Id: I936f681b835cca62fc14a326b7ae5cb062b3f1df
Reviewed-on: https://gerrit.libreoffice.org/44197
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-02 14:25:27 +01:00
Caolán McNamara 0bc9547ff7 ofz#3886 Integer-overflow 
Change-Id: I5f7ee16e8b05d7bb7e15ca26e0902ad0c1fed2de
Reviewed-on: https://gerrit.libreoffice.org/44164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-11-01 16:55:31 +01:00
Noel Grandin 6f45913394 loplugin:constantparam in svx 
Change-Id: Ifaad1083b1561b2bd908e798e06fbff8bbabbe60
Reviewed-on: https://gerrit.libreoffice.org/44048
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-30 11:58:48 +01:00
Caolán McNamara b154334ad1 ofz#3839 Integer-overflow 
Change-Id: I79c79bc75443f87cf36ec325c9b4d6b513959a76
Reviewed-on: https://gerrit.libreoffice.org/44012
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-10-29 11:02:53 +01:00
Tamás Zolnai 3d872ecc51 tdf#110357: Impress table looses selection when clicking on ... 
... Increase \ decrease font button

Change-Id: I52cf853de01b06c6c9db9779f15174f895789da8
Reviewed-on: https://gerrit.libreoffice.org/43962
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
 2017-10-29 09:36:39 +01:00
Michael Stahl 11d2f3d6e1 vcl: make MapMode constructor explicit 
Insert constructor everywhere, except a couple places that apparently
want to compare GetMapUnit().

Change-Id: I1910deb60562e5e949203435e827057f70a3f988
 2017-10-26 23:17:45 +02:00
Caolán McNamara 438e8b846f ofz Integer-overflow 
Change-Id: If78466f091c55279b21aaa936a4b77e665530aa5
Reviewed-on: https://gerrit.libreoffice.org/43849
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-10-25 21:32:09 +02:00