Commit Graph
408 Commits
Author SHA1 Message Date
Noel Grandin 72593849bb ColorData->Color in sd..svx
Change-Id: I70de56b6bfb1ea4655ec03510fad92bf6645f64e
Reviewed-on: https://gerrit.libreoffice.org/50046
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-21 06:05:41 +01:00
Julien Nabet 0fb4ae8767 Modernize a bit svtools
by using for-range loops
+ use empty() instead of comparing begin and end iterator

Change-Id: I41c3ae0c9032d6349afb113d457cb78862ae9dcf
Reviewed-on: https://gerrit.libreoffice.org/49416
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-08 18:31:34 +01:00
Stephan Bergmann 43b137e140 More loplugin:cstylecast: svtools
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: Ide9e7c53b554f0a36e2078a8823f5ef6fb5cc8fa
2018-01-12 20:14:18 +01:00
Noel Grandin 1ae61b0ac4 loplugin:flatten in svtools
almost completely automatically rewritten, only had to tweak
the indentation on a couple of lines.

Change-Id: Ieec92e5b602d180d7ec556e3421ce3c835c1f646
Reviewed-on: https://gerrit.libreoffice.org/45072
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-22 11:54:12 +01:00
Stephan Bergmann 92236b3eab loplugin:includeform: svtools
Change-Id: I7a25c2db8c097ae4512c8a8b7d8a272905b46e50
2017-10-23 22:45:51 +02:00
Stephan Bergmann 7ca8ff7ff7 loplugin:unnecessaryoverride (dtors) in svtools
Change-Id: I5b0f4b335cd383702324ff6ea04581476309ca70
2016-12-02 11:15:15 +01:00
Stephan Bergmann 91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
Noel Grandin 0b23eec200 teach refcounting clang plugin about uno::Reference
uno::Reference is only allowed to used with classes that have a
::static_type member.
So convert all those places to rtl::Reference.

Maybe we need some LIBO_INTERNAL_ONLY constructors on rtl::Reference and
uno::Reference to make this a little smoother?

Change-Id: Icdcb35d71ca40a87b1dc474096776412adbfc7e3
Reviewed-on: https://gerrit.libreoffice.org/25516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-31 06:25:45 +00:00
Jochen Nitschke 97abbec956 tdf#94306 replace boost::noncopyable in stoc to xmlsec..
Replace with C++11 delete copy-constructur
and copy-assignment.
Remove boost/noncopyable.hpp includes.
Add missing default ctors.

With this commit there should be no users
of boost::noncopyable left.

Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975
Reviewed-on: https://gerrit.libreoffice.org/24051
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-04-13 11:19:04 +00:00
Noel Grandin 4097135413 loplugin:unuseddefaultparam in svtools
Change-Id: I4e9712bea0cc8cf2d48759738806a584dda8268e
2016-03-01 08:30:28 +02:00
Noel Grandin f163745cca convert HighlighterLanguage to scoped enum
Change-Id: Ibf0871601e52ea4fa49e9622176431943c55abdd
2016-02-24 11:48:39 +02:00
Noel Grandin a5e53f9ffd convert TokenTypes to scoped enum
Change-Id: I17c0a616dd6cf48a22896b6cd6b0df157d1f9a9f
2016-02-24 11:48:39 +02:00
Chris Sherlock a238b1f8d3 Remove excess newlines
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09 08:18:05 +00:00
Stephan Bergmann b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Matteo Casalin f845cda89f fix downcast by intermediate function
Change-Id: I8e7909003249a3f86928197bbde29231f84b01c2
2015-09-12 14:18:48 +02:00
Matteo Casalin 6917ebc39f sal_uLong to sal_uInt32
Change-Id: Ifcde090747127680a9e4b810ff062d024663632c
2015-08-16 09:10:21 +02:00
Matteo Casalin 9d0f86326c Rework loops so to have exit condition on correct unsigned value
Change-Id: I91e647d6b1aebe8342f95c88fc81bd2c5a43ce71
2015-08-16 09:10:20 +02:00
Matteo Casalin 7d5f47aff5 This seems to be the original purpose
Change-Id: Ie8c50324fe3d1e836967ba4de24cd740182418a6
2015-08-16 09:10:20 +02:00
Noel Grandin e624c13cf1 loplugin: defaultparams
Change-Id: I9dc3b21e1bf1bccbe9fb69e35b3801814a68e53f
2015-08-11 09:48:18 +02:00
Noel Grandin 2660d24a07 new loplugin: refcounting
This was a feature requested by mmeeks, as a result of
tdf#92611.

It validates that things that extend XInterface are not
directly heap/stack-allocated, but have their lifecycle managed
via css::uno::Reference or rtl::Reference.

Change-Id: I28e3b8b236f6a4a56d0a6d6f26ad54e44b36e692
Reviewed-on: https://gerrit.libreoffice.org/16924
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-08-03 06:37:16 +00:00
Noel Grandin afcf1ecee1 loplugin:loopvartoosmall
Change-Id: I1e9768c08af0bc7caac6a39c13842ee9d8ad962c
2015-05-29 08:48:41 +02:00
Michael Meeks b01554bcda tdf#91052 - more macros for 'make' constructors.
Change-Id: Ic7ff127e2793993f9dcf1018f8d5ed4f2858a2c4
2015-05-11 13:07:45 +01:00
Noel Grandin ce8cfbd3b9 svtools: apply vcl::window refcounting changes
Change-Id: I308f045eaf5c50de26175a2f00f8b0791cdd8ab9

Conflicts:
	svtools/source/control/tabbar.cxx
2015-04-09 20:33:46 +01:00
Tobias Madl 14596452e7 fdo#84938: replace EVENT_ constants with enum
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f
Reviewed-on: https://gerrit.libreoffice.org/13134
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-01 07:43:31 +00:00
Stephan Bergmann 014e7933af svtools: std::auto_ptr -> std::unique_ptr
...changing HTMLOptions to std::vector<std::unique_ptr<...>> because
boost::ptr_vector<...>::push_back only supports auto_ptr, not unique_ptr.

Change-Id: Ie5f92bc40ce5425dc1c634b17addc2b0dd9bbda3
2014-09-29 13:57:17 +02:00
Noel Grandin 827c46e7d7 fdo#82577: Handle Window
Put the VCL Window class in the vcl namespace. Avoids clash with the X11
Window typedef.

Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-23 14:11:39 +03:00
Stephan Bergmann 7af850c896 vcl: sal_Bool -> bool
Change-Id: Iff4da6d6281eb9194db348ebc10fbe7718538401
2014-09-10 08:36:06 +02:00
Caolán McNamara e1683c2d13 callcatcher: update unused code
lots of ResID stuff going away now

Change-Id: Iad8524e201cd3072db71da9e5ee1c244ed337967
2014-08-11 10:22:12 +01:00
Caolán McNamara f630705f09 callcatcher: update unusedcode
Change-Id: I73ff045699113778892db6a534433a70e0e9c8e1
2014-06-02 16:59:56 +01:00
Noel Grandin b7d30cb50e svtools: sal_Bool->bool
Change-Id: Idd9a3ccf0eb6d14cec158daa17a6b2da625f7ffa
2014-05-08 11:48:13 +02:00
Stephan Bergmann 70cc2b191b First batch of adding SAL_OVERRRIDE to overriding function declarations
...mostly done with a rewriting Clang plugin, with just some manual tweaking
necessary to fix poor macro usage.

Change-Id: I71fa20213e86be10de332ece0aa273239df7b61a
2014-03-26 16:39:26 +01:00
Noel Grandin 2d3a1d2a46 svtools: sal_Bool->bool
Change-Id: I6c57a52b4fc3ecb993af4526fefcca352ad269b5
2014-03-25 14:32:55 +02:00
Stephan Bergmann e8f8f24c84 vcl: sal_Bool -> bool
Change-Id: I2a3e3d3e3266ea0f0fafdd91362076a4aa160f0e
2014-02-21 12:53:51 +01:00
Norbert Thiebaud 3cbfcee36d xub_StrLen and tools/string.hxx final straw
Thre is still some 0xffff limit left and possibly some
less than gracefully handled overflow/error cases

Change-Id: I00957ee3a30b02f73918ea49d7353056263dc638
Reviewed-on: https://gerrit.libreoffice.org/7787
Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2014-02-03 07:44:28 +00:00
Stephan Bergmann 602c87b425 Window::PreNotify should return bool
Change-Id: Ic9903fd887f2c3fab2630ebeb20df39392177c8d
2014-01-18 00:37:49 +01:00
Stephan Bergmann 0ee2cddfbd Properly encapsulate svt::TextWindowPeer
Change-Id: Iffa67c345a03852ad7872031b4c5a87e223ffcad
2013-11-27 11:35:24 +01:00
Stephan Bergmann 6812efbb4d Unused include
Change-Id: I3db5994ca2e5f3ce7f0f1dfc2994a07b3cb3d6e0
2013-11-26 17:03:53 +01:00
Stephan Bergmann 62fcdfa34a -Werror,-Wunused-private-field
...fixed more thoroughly than 49c1964b42 "WaE:
private field 'm_bCompoundControlChild' is not used."

Change-Id: Ief1093c054fe272b82da78ab103e8ca3feb72b90
2013-11-26 15:56:33 +01:00
Stephan Bergmann 176ac1e616 Remove unnecessary SyntaxHighlighter::Tokenizer statefulness
...which reveals that SyntaxHighlighter::notifyChange does nothing, so remove it.

Change-Id: I49834af29081ee703d9e62e182e3c1f8ce7e212e
2013-10-28 13:48:14 +01:00
Stephan Bergmann c99267b326 Fold SyntaxHighlighter::initialize into ctor
...which reveals that m_pKeyWords, m_nKeyWordCount members are unused.

Change-Id: I55020e892d463f2e40d5bcf71efba92778b317c1
2013-10-28 13:48:14 +01:00
Stephan Bergmann f5e8be8bb1 Remove unused SimpleTokenizer_Impl::nLine/nCol
...which are never read; remove thereby unused parameters from functions.

Change-Id: I644d2dc1b2d13ae2f932d04243521eef97e67e3e
2013-10-28 13:48:13 +01:00
Stephan Bergmann 9932749854 Use conventional std::vector idioms
Change-Id: I4d26372ea40e7890b76461a764435f8948466ae1
2013-10-22 18:19:18 +02:00
Stephan Bergmann b7f20ef33f Unwind HighlightPortions typedef
Change-Id: I0ecc15f9bfd557d0a70a05536906a4984a46463c
2013-10-22 18:19:18 +02:00
Michael Stahl 593a298dd3 Revert "fdo#63926 - remove extra include paths in svtools/ and sfx2/"
This reverts commit 389bdc1624.

Sadly this was going in the wrong direction...
2013-08-15 17:19:02 +02:00
Noel Grandin 062cf88d8f convert include/svtools/svmedit2.hxx from String to OUString
Change-Id: I313f5d930b744bbd81b3578f7bb77920cfc072c4
2013-08-15 09:11:33 +02:00
Caolán McNamara bfafc8c3a1 callcatcher: update unused code
mostly ResId using ctors left stranded post .ui conversion

Change-Id: I06689eea30ee9146ba05294f52056c0d263695f5
2013-08-10 12:25:10 +01:00
Radu Ioan 389bdc1624 fdo#63926 - remove extra include paths in svtools/ and sfx2/
- removed some paths from include
- more of this kind will follow

Change-Id: Ia5c410a5b9a7a0dfa5610dd50d82c8b23fcf43b2
Reviewed-on: https://gerrit.libreoffice.org/5288
Reviewed-by: Miklos Vajna <vmiklos@suse.cz>
Tested-by: Miklos Vajna <vmiklos@suse.cz>
2013-08-06 09:17:22 +00:00
Caolán McNamara ab29ad8cd5 set some initial sizes for the direct sql dialog textedits
and we can use existing GtkTextView<->VclMultiLineEdit mapping rather than the
svtools MultiLineEdit

Change-Id: I6d20a9ba8731dda1ec9579fc2877b817fea0632f
2013-07-30 14:51:47 +01:00
Csikós Tamás 471e5c1ed1 modern .ui widgetlayout for directsql
Change-Id: I51140fe6abd2d321c5784b923f920ab9183f417e
Reviewed-on: https://gerrit.libreoffice.org/5171
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-07-30 13:48:40 +00:00
Caolán McNamara 5358b9ba4f UniString->OUString
Change-Id: I217944d40ed7cd3a2fca4ad0d61729ff5d94ed96
2013-04-16 13:46:56 +01:00