Commit Graph
142 Commits
Author SHA1 Message Date
Tomaž Vajngerl 7fbb96c2fb Move (and rename) graphic stuff from svtools to vcl
This is preparing to change how GraphicManager works where it
won't base itself around GraphicObject anymore but Graphic. No
functional or cosmetic change was made to the classes, only
changes that were needed because of the move and rename.

The only thing that wasn't moved is the GraphicRenderer as it
is not needed in vcl for now (but makes sense to move it in the
future to keep graphic stuff together).

grfmgr was renamed to GraphicObject as the GraphicManager will be
changed a lot and most likely moved out, so the name grfmgr won't
make any sense anymore.

All the UNO implementations were renamed with a prefix Uno and
used the same name as the class name. This is made to be more
specific which are the Uno objects (for example graphic.cxx
contained the implementation of XGraphic, which is similar to
graph.cxx contains Graphic).

Change-Id: I54a2fa6c7e997469aaa7770db05244adb9f64137
Reviewed-on: https://gerrit.libreoffice.org/51068
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-03-11 13:37:21 +01:00
Miklos Vajna a8ca72cbcd svtools: allow writing characters with HtmlWriter
The sw HTML image export already uses HtmlWriter, so need to extend this
to support XHTML alternate text, writing the character data directly is
not an option.

Change-Id: Iac3f2b9a3828175a5f1d0fb14ab505f8de389e52
Reviewed-on: https://gerrit.libreoffice.org/50965
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2018-03-08 18:53:53 +01:00
Miklos Vajna 9df0ce081e sw HTML export: allow custom XHTML namespace alias
This helps in case the HTML filter expected to produce an XHTML fragment that
has an explicit namespace alias for <http://www.w3.org/1999/xhtml>.

This only has an effect when HtmlWriter is used to write elements,
though.

Change-Id: I161caf4bb6bc6d0c21a7a67433b08bb060b447f1
Reviewed-on: https://gerrit.libreoffice.org/50448
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-28 11:41:50 +01:00
Miklos Vajna fc2d155f42 Fix some IWYU warnings
Change-Id: I4b6e799c1afc2a762a3729ee89f3226c59a6eef8
Reviewed-on: https://gerrit.libreoffice.org/48462
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2018-01-24 10:14:09 +01:00
Andrea Gelmini 624f84c07e Fix typos
Change-Id: I078626eaa3155cc429320cc8c1532003b382b22a
Reviewed-on: https://gerrit.libreoffice.org/47855
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-16 12:40:51 +01:00
Miklos Vajna 3fe64261b5 Related: tdf#114428 svtools HTML import: avoid XML declaration in body text
Just ignore it for now.

Change-Id: Idf82af611370d957c6704cce250941a8a0b90637
Reviewed-on: https://gerrit.libreoffice.org/46388
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-14 09:10:20 +01:00
Stephan Bergmann 92236b3eab loplugin:includeform: svtools
Change-Id: I7a25c2db8c097ae4512c8a8b7d8a272905b46e50
2017-10-23 22:45:51 +02:00
Eike Rathke d80ba7354c Ditch now unused GraphicExportDialog, GraphicExportOptionsDialog
That was a dead end anyway, trying to partly reimplement
SvFilterOptionsDialog ExportDialog, instead of implementing the
necessary bits to use that one which has everything.

Change-Id: Icde7422f2c2d7e26c07dfe921a4abda41e222b09
Reviewed-on: https://gerrit.libreoffice.org/42503
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-22 13:28:31 +02:00
Miklos Vajna b07da72778 vcl pdf import: change test documents to test bitmap fallback
I.e. the test documents now reflect what is created by LO if you insert
a PDF image into a document manually on master.

Change-Id: Ibacce15220a21b159b5e987678c381a98a29fd1a
2017-02-14 13:57:54 +01:00
Miklos Vajna 6657d52417 vcl pdf import: use pdfium instead of draw_pdf_import
Replace creating a full Draw component with direct pdfium library calls.
This also means that the result is now a bitmap, not a metafile for now.

Also decouple HAVE_FEATURE_PDFIMPORT and HAVE_FEATURE_PDFIUM, the first
is the "import PDF into Draw" feature, the second is the "insert PDF as
image" feature.

Change-Id: I72c25642ec84cc831df362e02b1520c6e6d9adcf
Reviewed-on: https://gerrit.libreoffice.org/34217
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-02-13 16:54:04 +00:00
Caolán McNamara 855fbe4edc second arg of deformed copy ctor isn't used
except in the qa test

Change-Id: I84d1a06194e4c11b218c417663f12195c9f76526
Reviewed-on: https://gerrit.libreoffice.org/32890
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-09 20:35:21 +00:00
Stephan Bergmann 9b8fb82150 loplugin:unnecessaryoverride
Change-Id: Iac074bd6f59d2fc890459b45801d0a6143c3eb9e
2016-12-06 10:20:01 +01:00
Samuel Mehrbrodt ec4e48c750 Fix typos
Change-Id: I3e38b1d445c368c28e807202b94c603bd2b2c672
Reviewed-on: https://gerrit.libreoffice.org/30872
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-15 14:51:34 +00:00
Stephan Bergmann 8cfa3f4b52 'make screenshot' use-after-free fixes
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10 22:00:41 +01:00
Stephan Bergmann d543b4df80 'make screenshot' loplugin fixes
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-10 22:00:41 +01:00
Stephan Bergmann 106ea87205 Remove _TYPED suffix from tools/link.hxx macros
...which was introduced with 3ead3ad52f "Gradually
typed Link" to distinguish the new, typed versions from the old, untyped ones,
but is no longer necessary since 382eb1a23c
"remove untyped Link<>" removed the old versions.

Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-10-05 07:56:12 +02:00
Caolán McNamara 88c9133b16 coverity#1371121 Unchecked return value
Change-Id: I1413b62112922af8d6872de413ca7decc0d75875
2016-08-18 21:08:40 +01:00
Armin Le Grand 2a5ac6f634 screenshots: unify dumping of dialog test batch file
Change-Id: Ia1e79216d9537c65f8b7362778a2e1ad3ec6c2c2
2016-08-18 02:39:15 +02:00
Armin Le Grand 89a0328551 screenshots: add dialog test cases for svtools
All *.ui files create a screenshot, but not all look useful

Change-Id: I7a7a6c3ab38e8890404082dd359ff5f4f1ebf9fd
2016-08-18 02:39:14 +02:00
Miklos Vajna 056fbbf93b Fix --disable-pdfimport build
Change-Id: Ida06b892aea92cfe26fd62372e21ca611d8838d3
Reviewed-on: https://gerrit.libreoffice.org/27447
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-07-22 17:50:36 +00:00
Miklos Vajna 71b2dc0de9 vcl: handle PDF data in Read/WriteImpGraphic()
Initially I wrote the test to cover
f7d6f3e4e3 (svtools: survive swapout/in of
graphic with embedded pdf, 2016-06-28), but as it turns out the actual
swapin/out code is in vcl, so extend that as well to support pdf data.

Change-Id: I320ea729dce9440b84a5089607807322ea7b0b04
Reviewed-on: https://gerrit.libreoffice.org/26755
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2016-06-29 10:36:21 +00:00
Noel Grandin 850a8d27ca Convert GRAPHIC to scoped enum
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea
Reviewed-on: https://gerrit.libreoffice.org/25534
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27 12:59:23 +00:00
Stephan Bergmann 60b1c95cc4 Extract Directories from BootstrapFixtureBase
(as some tests derive from the latter only for the Directories part, not for the
setUp/tearDown overrides: those tests will be cleaned up next)

Change-Id: Ib6b78eea868b8bc21d4cc6e8fd9e1d025deca05f
Reviewed-on: https://gerrit.libreoffice.org/23078
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-10 08:04:40 +00:00
Chirag Manwani cc84aaf70a tdf#97703 removed empty setUp/tearDown methods
Change-Id: I244d481bce4723d172e26c0d31aab0a541334604
Reviewed-on: https://gerrit.libreoffice.org/22959
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-07 09:13:53 +00:00
Noel Grandin b14224fe97 loplugin:unusedmethods
using an idea from dtardon:

<dtardon> noelgrandin, hi. could you try to run the unusedmethods clang
plugin with "make build-nocheck"? that would catch functions that are
only used in tests. e.g., i just removed the whole o3tl::range class,
which has not been used in many years, but htere was a test for it...
<noelgrandin> dtardon, interesting idea! Sure, I can do that.

Change-Id: I5653953a426a2186a1e43017212d87ffce520387
Reviewed-on: https://gerrit.libreoffice.org/22041
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-08 06:08:14 +00:00
Stephan Bergmann 28f4bee7bd loplugin:nullptr (automatic rewrite)
Change-Id: I7fc4b4d5c895f241cfb052b009e943e073f3befe
2015-11-10 10:31:48 +01:00
Stephan Bergmann b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Caolán McNamara 498cb0b3a3 unused headers
Change-Id: I59d274951a8b81c091993277f433359834851a0c
2015-09-17 11:00:51 +01:00
Noel Grandin 93157d284e convert Link to Typed
and make it statically allocated, no point in dynamically allocating
such a small object

Change-Id: If476bf5dc1e0d535383d16bc49c8d567776f16cd
2015-08-26 13:52:28 +02:00
Stephan Bergmann 8c8d955998 Clean up C-style casts from pointers to void
Change-Id: If8783896136470a0664f1cbac061e30576ef96a4
2015-03-28 19:09:26 +01:00
Caolán McNamara 6ee80e749a coverity#1272391 Dereference null return value
Change-Id: Id1c5a498ff5c25eefe2573e695f66d8922213f92
2015-03-02 16:18:57 +00:00
Stephan Bergmann c5d488bf8c Missing dispose
Change-Id: If050113552ce331252b3046830a5583c66729531
2015-02-23 14:18:41 +01:00
Zolnai Tamás 908c060cee Test for tdf#88935
Change-Id: I625a59a632c53c77f593268b14e60ab265e5a821
2015-02-22 11:59:21 +01:00
Zolnai Tamás 905d4db48a tdf#88836: UI: in-form navigation bar icons gone
Regression from:
6419c745e5

Revert it and use IsEmpty() instead of operator!().

Change-Id: Icc4f5dbba848a1d4ef807e598f0aa3b940459c82
2015-02-07 11:26:23 +01:00
Caolán McNamara c7258cfccd shared_ptr<T>(new T(args)) -> make_shared<T>(args)
and boost:make_shared->std::make_shared

Change-Id: Ic1e187c52c856a7b27817967b2caa8920f23a98d
2015-02-06 16:45:13 +00:00
Caolán McNamara 4ea1731806 coverity#1255389 Dereference null return value
Change-Id: I3b2a4e69a1c86d9b9ce9f51d6f321bda9e18f8b5
2014-11-21 11:55:10 +00:00
Stephan Bergmann b8689142a9 Dispose document when done
Change-Id: I7b15220568717e159f119e79da0016cbc88873cf
2014-11-20 11:14:44 +01:00
Zolnai Tamás c4706528d4 Missing parentheses
Change-Id: Id6c096d09b984039d54a1d152cf0da594aaf203d
2014-11-18 18:40:26 +01:00
Zolnai Tamás 9a71305950 This test become unreferenced by accident
See:
c454a0cd0c
and
46eb0952f1

Change-Id: I811f1c52f8a9fba28bc4f38fd1ad34826b2bd45e
2014-11-18 18:38:10 +01:00
Zolnai Tamás 89361fcff3 Fix broken GraphicObjectTest
Change-Id: I3f7e0ccd5697a4ca6026bec60210e24af25fb92f
2014-11-18 18:33:54 +01:00
Stephan Bergmann c9518656af loplugin:unreffun
Change-Id: Ifc7377fe1bb68b21e462818248706f53347b39b1
2014-11-17 13:43:56 +01:00
Tor Lillqvist f71aa1adc8 WaE: unused variables
Change-Id: I82570a716a0dba6c466bc754ce66ac53e7c17efa
2014-11-17 14:24:16 +02:00
Tor Lillqvist 46eb0952f1 WaE: Unreferenced function definition [loplugin:unreffun]
Change-Id: I55d6d1d403622e5ec04c29dd407274cf9db20c40
2014-11-17 14:10:45 +02:00
Zolnai Tamás c454a0cd0c Test for size based auto swap out mechanism
Change-Id: Iff0942b9b545f27dd74b73bee3f8ac785539867d
2014-11-16 20:27:32 +01:00
Tomaž Vajngerl d42813db53 Extend HTMLWriter: flush the stack, more values for attribute(..)
Change-Id: I733426ba5f82ee25751387f88942dbc66689821d
2014-09-22 00:31:47 +02:00
David Tardon 19307f65aa it seems that CPPUNIT_PLUGIN_IMPLEMENT can't be in ns
Change-Id: If0d2622b5d64ccd821ff29356d545d59f5017d21
2014-07-24 10:02:08 +02:00
David Tardon 9825e1697d add test for swapping of GraphicObject
Change-Id: I341f52e5dfedb61130545cf30ff61e891abc7e04
2014-07-24 08:19:31 +02:00
Tor Lillqvist 3b6dba357f WaE: overriding virtual function declaration not marked 'override'
Change-Id: I6d38c9b389ce2c5d196e372fd6ae5ad7ac0a03af
2014-04-06 23:40:56 +03:00
Tomaž Vajngerl c7b69624ee Introduce HtmlWriter unit tests.
Change-Id: Icb39dde433124d444c48761e074f6b839a043d4e
2014-04-06 22:02:11 +02:00
Caolán McNamara 8ece1cd6d5 stray test .png left behind
Change-Id: If0a0d61b58ecc46d5ba04951cd278d275fdf25e7
2013-03-14 14:18:45 +00:00