ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
267 Commits
Author SHA1 Message Date
Chris Sherlock fa09d724b4 store: remove unnecessary comments in storpage.hxx 
Change-Id: Ic515c916826d58f89893d2d0d58b65b80c7b83be
Reviewed-on: https://gerrit.libreoffice.org/47196
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2018-01-13 11:08:24 +01:00
Stephan Bergmann 0b0a6e9b4d More loplugin:cstylecast: store 
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: Ie71dbe8077e1467a93fda3c92cce178e53ecb2f4
 2018-01-12 20:15:11 +01:00
Noel Grandin 75c604a4ec loplugin:convertlong in ucb,sot 
Change-Id: I6fa355448834701f11b84584649dfcdecd0f7b2c
Reviewed-on: https://gerrit.libreoffice.org/47596
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-09 07:20:44 +01:00
Noel Grandin 3af500580b loplugin:salcall fix functions 
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-11 12:13:46 +01:00
Noel Grandin 7a1c21e53f loplugin:simplifybool for negation of comparison operator 
Change-Id: Ie56daf560185274754afbc7a09c432b5c2793791
Reviewed-on: https://gerrit.libreoffice.org/45068
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-23 06:59:31 +01:00
Noel Grandin 4f4486c61d look for =() in loplugin:unnecessaryparen 
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0
Reviewed-on: https://gerrit.libreoffice.org/44944
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-20 12:31:32 +01:00
Noel Grandin 455e4011f7 improve constparam loplugin 
lots of little fixes to make the logic less pessimistic

Change-Id: If368822984250b11b98c56f5890177a1402e8660
Reviewed-on: https://gerrit.libreoffice.org/44168
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-02 10:45:01 +01:00
Stephan Bergmann c8ee9e53d2 loplugin:includeform: store 
Change-Id: Ia9134d7f1e9c30b7faef693c3f621cec7ec5a61a
 2017-10-23 22:45:51 +02:00
Noel Grandin 14d4566543 loplugin:constmethod in codemaker,registry,store 
Change-Id: Ie75875974f054ff79bd64b1c261e79e2b78eb7fc
Reviewed-on: https://gerrit.libreoffice.org/43540
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-20 08:50:48 +02:00
Noel Grandin eea6d3951b loplugin:unnecessaryparen 
look for  statements like

    return (function());

Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3
Reviewed-on: https://gerrit.libreoffice.org/41260
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-18 08:49:37 +02:00
Stephan Bergmann b50d6a593d Remove unnecessary user-provided copy functions 
...with the added benefit of the implementation-provided versions being trivial
and so avoiding GCC 8 -Werror=class-memaccess when these classes are subject of
memcpy/memmove in store/source/stortree.cxx and store/source/storpage.cxx.

Change-Id: I684109d8743eb7f1fa57c6925d738b11d934a7cf
Reviewed-on: https://gerrit.libreoffice.org/40977
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-08-15 08:43:21 +02:00
Noel Grandin b09deb0753 loplugin:constparams handle constructors 
had to change the structure of the plugin considerably, was too messy to
structure it to do the calculations on a per-function basis

Change-Id: I4edee7735f726101105c607368124a08dba21086
Reviewed-on: https://gerrit.libreoffice.org/40516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-28 14:51:56 +02:00
Noel Grandin 6f3b39499f loplugin:constparams in store,registry 
Change-Id: I5633203b372a9abd0138a396958c235ea8aaf66d
Reviewed-on: https://gerrit.libreoffice.org/40039
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-17 10:20:19 +02:00
Noel Grandin 4250b25c6a teach unnecessaryparen loplugin about identifiers 
Change-Id: I5710b51e53779c222cec0bf08cd34bda330fec4b
Reviewed-on: https://gerrit.libreoffice.org/39737
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-10 09:57:24 +02:00
Stephan Bergmann df45d21334 loplugin:casttovoid: store 
Change-Id: Idb679a4070202fe7baecab79b69a5a4cf395e7d7
 2017-07-02 22:29:31 +02:00
Noel Grandin 8dca2d5ac7 loplugin:oncevar in starmath..svl 
Change-Id: I20e3796407c7e429a88d2811673929ac1141a41c
Reviewed-on: https://gerrit.libreoffice.org/39280
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-27 08:42:53 +02:00
Noel Grandin 18f5131454 loplugin:unusedfields store..svl 
Change-Id: I6070a683e5128271b84a10caccb548d07c950927
Reviewed-on: https://gerrit.libreoffice.org/39021
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-21 08:43:05 +02:00
Chris Sherlock df65749845 Remove a bunch of comment cruft - esp. "the end." bits 
Change-Id: I5a339a4211ec8eb547459996be69610b9f2b3766
Reviewed-on: https://gerrit.libreoffice.org/38147
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2017-06-16 16:48:50 +02:00
Stephan Bergmann 3631ef8cea Improved loplugin:cstylecast to reference types: store 
Change-Id: I78213cb2b8812ebdd1354c045318d081e4197934
 2017-06-05 21:18:04 +02:00
Noel Grandin 2ccde70d60 teach redundantcast plugin about functional casts 
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0
Reviewed-on: https://gerrit.libreoffice.org/37910
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-30 08:50:31 +02:00
Jochen Nitschke 959496794c cleanup osl/diagnose.h includes 
with command
> git grep -l osl/diagnose.h *.cxx |
  xargs grep -L -w 'OSL_\w*' |
  xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d'

headers need more work

Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab
Reviewed-on: https://gerrit.libreoffice.org/37350
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-05-09 15:41:46 +02:00
Chris Sherlock 97eb00c75e revert OSL_ASSERT changes 
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
 2017-05-07 17:03:35 +10:00
Chris Sherlock b15c5c499e tdf#43157: convert store from OSL_ASSERT to assert 
Change-Id: I7500a0021b33a50ca2e73220b2f8fa2f5ac16e22
 2017-05-07 07:46:47 +10:00
Stephan Bergmann 6cb9e6dad7 Remove redundant 'inline' keyword 
...from function definitions occurring within class definitions.  Done with
a rewriting Clang plugin (to be pushed later).

Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8
Reviewed-on: https://gerrit.libreoffice.org/34874
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-03-03 20:55:50 +00:00
Noel Grandin 2608523b69 loplugin: unnecessary destructor sfx2..store 
Change-Id: Idbf2585e48cd89a43ab68c5c8819880d20461ccf
Reviewed-on: https://gerrit.libreoffice.org/33514
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-25 10:26:05 +00:00
Noel Grandin 4ef9ccea6c OSL_TRACE -> SAL in sfx2..svx 
Change-Id: I78cf8058a5682baa3d7b00a25feeb2d28fb3e66e
Reviewed-on: https://gerrit.libreoffice.org/31799
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-11 18:56:16 +00:00
Noel Grandin faf4bf0c3e loplugin:countusersofdefaultparams in sot..svtools 
Change-Id: Ifce19de3518f3eaf5a1b6439f9053feee4a33c14
 2016-10-14 10:53:30 +02:00
Stephan Bergmann 98323f936b cid#1371195, cide#1371212: Replace PageHolder with shared_ptr 
...removing the need for SharedCount, too

Change-Id: I20c724c940c571aef1c12453da30c3e9fbb46466
 2016-09-30 11:06:19 +02:00
Stephan Bergmann 904959b858 Remove OStorePageData typedef 
Change-Id: I9f4e8fa41a59325fe7036acb66d045a833294bd6
 2016-09-30 11:06:19 +02:00
Stephan Bergmann ba09cda3ef Remove "#if 1 /* EXP */" 
...whatever it was supposed to be good for

Change-Id: I8f2a526aeaa484675e1bd6763fa692f8cbed2a51
 2016-09-30 11:06:19 +02:00
Stephan Bergmann 2950528c51 No need for rtl_cache_* here 
...which shows that m_pCount will never be null

Change-Id: I87c6e4bf5d258c59a8e91cd194c64b1ce85b4445
 2016-09-30 11:06:19 +02:00
Noel Grandin e58324aaca convert storeAccessMode to scoped enum 
Change-Id: I67705cdff0440487019a2992571147d648be1bfc
 2016-09-19 12:47:14 +02:00
Michael Stahl b647996a9b replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos) 
... except in include/rtl, include/sal, include/uno, where sal_Size is
retained for compatibility, and where callers of rtl functions pass in
pointers that are incompatible on MSVC.

Change-Id: I8344453780689f5120ba0870e44965b6d292450c
 2016-09-15 12:01:11 +02:00
Stephan Bergmann 91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround 
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
 2016-09-13 13:19:22 +02:00
Arnaud Versini e53bb6a0f0 store: remove STORE_IMPL_ISP2 and STORE_IMPL_CONCAT. 
Change-Id: Iec6cff8da24515f17a5ad2b9ba6e1f92df124921
Reviewed-on: https://gerrit.libreoffice.org/28508
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-31 07:16:10 +00:00
Arnaud Versini 7173a4edab store : Replace store::swap with std::swap 
Change-Id: I85c1026502dc69b229aaf287858ae76f9391a34d
Reviewed-on: https://gerrit.libreoffice.org/28506
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-08-31 07:14:36 +00:00
Noel Grandin 27319418ed loplugin:countusersofdefaultparams in store..svtools 
Change-Id: I15b4400bddc5a4d0e3de5dfffe18b7e493f97df6
Reviewed-on: https://gerrit.libreoffice.org/27580
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-07-29 07:07:13 +00:00
Noel Grandin 2c8fe2e737 update unusedmethods plugin to deal with constructors 
and fix the operator< implementations in some of the other
plugins too.

Change-Id: Ie5631e0cdc8d2a994ad2af2533cdb558a6cfc035
Reviewed-on: https://gerrit.libreoffice.org/25057
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2016-05-18 10:03:44 +00:00
Stephan Bergmann 14cd5182c5 Replace fallthrough comments with new SAL_FALLTHROUGH macro 
...which (in LIBO_INTERNAL_ONLY) for Clang expands to [[clang::fallthrough]] in
preparation of enabling -Wimplicit-fallthrough.  (This is only relevant for
C++11, as neither C nor old C++ has a way to annotate intended fallthroughs.)

Could use BOOST_FALLTHROUGH instead of introducing our own SAL_FALLTHROUGH, but
that would require adding back in dependencies on boost_headers to many
libraries where we carefully removed any remaining Boost dependencies only
recently.  (At least make SAL_FALLTHROUGH strictly LIBO_INTERNAL_ONLY, so its
future evolution will not have any impact on the stable URE interface.)  C++17
will have a proper [[fallthroug]], eventually removing the need for a macro
altogether.

Change-Id: I342a7610a107db7d7a344ea9cbddfd9714d7e9ca
 2016-05-10 16:42:16 +02:00
Jochen Nitschke 97abbec956 tdf#94306 replace boost::noncopyable in stoc to xmlsec.. 
Replace with C++11 delete copy-constructur
and copy-assignment.
Remove boost/noncopyable.hpp includes.
Add missing default ctors.

With this commit there should be no users
of boost::noncopyable left.

Change-Id: I6b1e47824912a6a80cc3f00f34938ebc048d8975
Reviewed-on: https://gerrit.libreoffice.org/24051
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2016-04-13 11:19:04 +00:00
Noel Grandin e5dd156a44 loplugin:constantparam 
Change-Id: Ie690088d7a7d568703afd22f544628fc8012a7e1
 2016-04-11 08:26:01 +02:00
Stephan Bergmann 5da802b44d Drop __store_ prefix from static entity (avoid reserved identifier) 
Change-Id: Ib03727f6b47d8f013f78a590d36d568ebc405bf3
 2016-03-10 18:32:07 +01:00
Noel Grandin b3483a07bc loplugin:unuseddefaultparam in store 
Change-Id: I825eb075b73daa5bf52e1d41c32cf2100abebe47
 2016-03-01 12:48:49 +02:00
Noel Grandin c45d3badc9 new loplugin: commaoperator 
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
 2016-02-23 08:08:56 +02:00
Noel Grandin de70170ace loplugin:unusedmethods unused return value in store,svl 
Change-Id: I369b3ae84af046242430977cec7d5c5e69fc27e7
 2016-01-14 08:50:43 +02:00
Noel Grandin 3785f82e26 loplugin:unusedfields in store,svtools,svx 
Change-Id: I9577c64e33950899c2e3467c7b481504e021d470
 2015-12-21 13:51:29 +02:00
Stephan Bergmann 4a1edf626a More loplugin:nullptr automatic rewrite (within templates) 
Change-Id: I9bc06cfb5eeb38fd7ae7fb25f876ea9f96e4a65a
 2015-12-10 17:34:31 +01:00
Noel Grandin bc8c158ec6 loplugin:unusedfields in store/ 
Change-Id: I0fae339e3736f98d5d534b8a01a3040c237c6621
 2015-11-23 13:30:54 +02:00
Stephan Bergmann 35b3228609 loplugin:nullptr (automatic rewrite) 
Change-Id: I2a4f84e8c36197a9d39a5bd36cb1e2401a956d87
 2015-11-10 10:31:44 +01:00
Noel Grandin c7e8f21a53 loplugin:unusedmethods 
Change-Id: Id3b5cd75d4357336ed592ef11a3f34d209f8e95f
Reviewed-on: https://gerrit.libreoffice.org/19636
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-30 05:58:41 +00:00