ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
575 Commits
Author SHA1 Message Date
Ashod Nakashian ac6e6753bd pdf: refactor poppler importer 
This paves the way to add pdf
parsing via pdfium.

Change-Id: I384687bcdce3011682ebeec18ee3de44759feb1a
Reviewed-on: https://gerrit.libreoffice.org/51254
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
 2018-03-21 01:57:28 +01:00
Caolán McNamara 2980e65d97 fix crash on pdf import of fdo30892-1 
after
    commit a9ef943769
    Date:   Wed Feb 28 11:09:43 2018 +0200
    loplugin:useuniqueptr in sdext

Change-Id: I964e2319d583455c2c698f895e0b675d69256e38
Reviewed-on: https://gerrit.libreoffice.org/51475
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-18 11:23:24 +01:00
Noel Grandin b0967c69d3 fix crash on pdf import of tdf59883-2 
after
    commit a9ef943769
    Date:   Wed Feb 28 11:09:43 2018 +0200
    loplugin:useuniqueptr in sdext

Change-Id: I3f54002764ee42162279bade49a3e3b21e136917
Reviewed-on: https://gerrit.libreoffice.org/51402
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-16 16:48:40 +01:00
Mohammed Abdul Azeem bf46b46a1d Moving XSAXDocumentBuilder2 to use XFastDocumentHandler: 
This is used in parsing of meta Contexts across different
modules. This also involved moving to XFastParser for
parsing xml filters in sw, sd, starmath.

Change-Id: Ic663aaac6cb20ee8ce5b97cae87c93220f5a2929
Reviewed-on: https://gerrit.libreoffice.org/42989
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-03-14 14:12:08 +01:00
Noel Grandin a9ef943769 loplugin:useuniqueptr in sdext 
Change-Id: I0870d4b1e85465b07e3d9cdb05520fcb37dfc267
Reviewed-on: https://gerrit.libreoffice.org/50659
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-06 10:07:02 +01:00
Stephan Bergmann ba8a70365e New loplugin:nestedunnamed 
Change-Id: Ifb434589ef08428ce609bc7a40b015d4df13224c
Reviewed-on: https://gerrit.libreoffice.org/50048
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-02-21 08:09:46 +01:00
Michael Stahl 20cf158b85 sdext: disable the warnings TWICE because they're sneaky bastards 
Let's hope this will finally work, it was like this before commit
4e102d6a4b

Change-Id: I6337d4f1abc386e71747b2a37e55a3578bcbf340
 2018-02-15 20:58:36 +01:00
Michael Stahl ebbae6a1f5 sdext: MSVC 2015 is trash 
Change-Id: I8549b52417520c0fe52977137fc570d65b0800fc
 2018-02-15 20:25:04 +01:00
Michael Stahl 764e4a4cd3 sdext: if all else fails USE BIGGER HAMMER 
Change-Id: I83803461310580c47886322e20c0949a371a0407
 2018-02-15 17:11:23 +01:00
Michael Stahl 7e241cda12 sdext: suppress another MSVC warning 
Somehow a8ea79b10b caused another warning
to appear in the MSVC 2015 that is used in jenkins builds.  Whyever.

Change-Id: Iba73de5739078972129d0a2de7d8a6437c12b2e0
 2018-02-15 17:00:06 +01:00
Michael Stahl a8ea79b10b sdext: disable MSVC 2017 warnings from boost headers 
Change-Id: I6eb816f155a222ca4299fd425c79d38bf2d464dc
 2018-02-15 15:57:48 +01:00
Julien Nabet aed2107e1d Simplify sortElements in pdfiprocessor (sdext) 
For explanation, see:
http://nabble.documentfoundation.org/About-simplifying-sortElements-in-pdfiprocessor-sdext-tt4231909.html

Change-Id: I53fb732d776d7152279e5fc1440eafac1cfd71fe
Reviewed-on: https://gerrit.libreoffice.org/49127
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2018-02-02 19:49:46 +01:00
Stephan Bergmann 21eba05f5f Blind fix for MSVC warning C4101: 'rError': unreferenced local variable 
...after 4e102d6a4b "sdext: MSVC: pragma warning:
make more specific, remove obsolete"

Change-Id: Ibd198ef24aa67c4c98bc1f504deccb1fdf28d054
 2018-02-02 14:08:45 +01:00
Mike Kaganski 4e102d6a4b sdext: MSVC: pragma warning: make more specific, remove obsolete 
Change-Id: I317b952c27fd052d4f19aa0dfc4ee9ce1e4705ad
Reviewed-on: https://gerrit.libreoffice.org/49046
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2018-02-02 13:10:56 +01:00
Noel Grandin 945a119675 loplugin:constparams 
Change-Id: I7c695073d9a9d3b7a641d6eb9fe01a47d8c3a504
Reviewed-on: https://gerrit.libreoffice.org/48392
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-24 07:56:57 +01:00
Noel Grandin 91b4e45316 new loplugin: pointerbool 
look for possibly bogus implicit conversions to bool when passing
(normally pointer) args to bool params.

this plugin comes in the wake of a couple of bugs caused by refactoring,
where some of the call sites were not currently updated.

Of the changes, the following are real bugs:

desktop/../dp_persmap.cxx

StartInputFieldDlg
    in sw/../fldmgr.cxx
which occurred as a result of
    commit 39d719a80d
    Date:   Tue May 3 11:39:37 2016 +0200
    tdf#99529 sw: don't pop up input field dialog before inserting field

CSerializationURLEncoded::encode_and_append in
    forms/../serialization_urlencoded.cxx

XclExpCFImpl::XclExpCFImpl
    in sc/../xecontent.cxx
I have no idea how to properly fix this, just made a guess.

SwDocTest::test64kPageDescs
    in sw/qa/core/uwriter.cxx
which looks like a simple copy/paste error.

Change-Id: I795ebd5ef485a1d36863dc27fe13832989f5a441
Reviewed-on: https://gerrit.libreoffice.org/48291
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-23 10:41:38 +01:00
Stephan Bergmann 9af8f190ed More loplugin:cstylecast on Windows 
Automatic rewrite (of loplugin:cstylecast and loplugin:unnecessaryparen) after
cab0427cad "Enable loplugin:cstylecast for some
more cases" and a409d32e7f "More
loplugin:cstylecast"

Change-Id: Ib3355159dd08333e1b7a8d091caf2069cdcc7862
Reviewed-on: https://gerrit.libreoffice.org/48317
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-01-23 07:54:51 +01:00
Michael Stahl ea794efe65 tdf#114939 sdext: don't use StarOffice MD5 in PDF import 
Always use real MD5 here, to avoid interop issues.

Change-Id: Id6f43952bace1654ac761aecc77676d933737d1d
 2018-01-16 22:35:14 +01:00
Stephan Bergmann 5cd41952cd More loplugin:cstylecast: sdext 
Change-Id: Ib0b6f3d07c7c596f6eed291587db8bba207c8b7d
 2018-01-15 09:03:30 +01:00
Noel Grandin 7d8e94444d convert a<b?a:b to std::min(a,b) 
with something like

    git grep -nP '(.*)\s*<\s*(.*)\s*\?\s*\g1\s*:\s*\g2' -- *.?xx

Change-Id: Id5078b35961847feb78a66204fdb7598ee63fd23
Note: we also convert a>b?b:a
Reviewed-on: https://gerrit.libreoffice.org/47736
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-15 07:26:17 +01:00
Stephan Bergmann b271fb5ba1 More loplugin:cstylecast: sdext 
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: Ie9eca6a78912a62f5a46ecacb1da052621c79ea4
 2018-01-12 20:16:33 +01:00
Dominique Leuenberger 38368be852 Allow building with poppler-0.62 
Change-Id: Ia627f1628a67dd8ece7d9318639d9ccd06b89765
Reviewed-on: https://gerrit.libreoffice.org/47460
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2018-01-08 16:07:05 +01:00
Ashod Nakashian 653736fb23 pdf: use bimap for GraphicsContext-id map 
In some large PDFs the two maps for
mapping GraphicsContext to ID and finding
GraphicsContext given and ID are huge (over
160 MB in one case). By using a bimap the
footprint went down to 110 MB.

Reviewed-on: https://gerrit.libreoffice.org/45380
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
Tested-by: Ashod Nakashian <ashnakash@gmail.com>
(cherry picked from commit 551543bf359f644f727fd1aa86e2c5ae499f88ce)
(cherry picked from commit ac328157460e9e6a9ca6834e8233a28e845c2806)

Change-Id: I59a444b5efa09fcabc26fa492de723ca063e14a4
Reviewed-on: https://gerrit.libreoffice.org/46988
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
 2017-12-24 17:09:08 +01:00
Noel Grandin 3af500580b loplugin:salcall fix functions 
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-11 12:13:46 +01:00
Julien Nabet 6c42e3961e Modernize code in sdext 
Change-Id: I2257014cf77b14aba263718b4730744960cc1dc2
Reviewed-on: https://gerrit.libreoffice.org/46178
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-12-10 13:57:53 +01:00
Noel Grandin be354a2abd loplugin:constparams 
Change-Id: Ia322ecf8f80b28c58ec33d17ca9607401a92534b
Reviewed-on: https://gerrit.libreoffice.org/45959
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-07 07:21:32 +01:00
Jochen Nitschke e641975076 clang-tidy modernize-use-equals-default in sd 
Change-Id: Ib3d3bb1a0484cb8bb6411444254644252e3614cf
Reviewed-on: https://gerrit.libreoffice.org/45293
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-26 21:15:09 +01:00
Noel Grandin 328cdfd4a7 loplugin:useuniqueptr in PDFContainer 
Change-Id: I25c2a5a078450ed921c7e981f4c9fac242aa7178
Reviewed-on: https://gerrit.libreoffice.org/44863
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-17 14:58:58 +01:00
Noel Grandin 0d50804e1c loplugin:constparams in various(2) 
Change-Id: I533a7eb724b15e168a28dc92cd5962a39bc96e7c
Reviewed-on: https://gerrit.libreoffice.org/44313
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-06 07:13:42 +01:00
Noel Grandin c0cf07d3da loplugin:constantparam in sd 
Change-Id: I1c5e5a26d343ac3aa244d7b053f2ec6922edbb21
Reviewed-on: https://gerrit.libreoffice.org/44085
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-31 12:29:55 +01:00
Stephan Bergmann 2d1de9686e loplugin:includeform: sdext 
Change-Id: Ieb9641b9846ecfed8d1a022a48defe7644405690
 2017-10-23 22:45:54 +02:00
Noel Grandin 87a9979c89 overload std::hash for OUString and OString 
no need to explicitly specify it anymore

Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec
Reviewed-on: https://gerrit.libreoffice.org/43567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-23 08:15:35 +02:00
Stephan Bergmann b8c6a3486b Move sdext/source/pdfimport/tree include files to common include directory 
...that are included from various source directories.  Change done in
preparation of loplugin:includeform.

Change-Id: Ie46f4b940ceeb34fd8883dc17f56a072f625ee3a
Reviewed-on: https://gerrit.libreoffice.org/43442
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-10-17 09:04:56 +02:00
Noel Grandin 2c05d758b2 add << operator for css::uno::Exception 
Change-Id: Ia23dafd07133779144965682df3b7125a3214235
Reviewed-on: https://gerrit.libreoffice.org/43046
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-10-04 15:18:00 +02:00
Tor Lillqvist 8e7897588d Rename the basegfx::tools namespace to basegfx::utils 
Reduce potential confusion with the global tools namespace. Will
hopefully make it possible to remove the annoying initial :: when
referring to the global tools namespace. Unless we have even more
tools subnamespaces somewhere.

Thorsten said it was OK.

Change-Id: Id088dfe8f4244cb79df9aa988995b31a1758c996
Reviewed-on: https://gerrit.libreoffice.org/42644
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
 2017-09-26 14:18:41 +02:00
Noel Grandin a185ea4ec1 clang-tidy modernize-use-emplace in sd 
Change-Id: I2e3000f7bd0f3beed8309e0e3dd18e6ed4b8feee
Reviewed-on: https://gerrit.libreoffice.org/42184
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-12 10:33:27 +02:00
Andrea Gelmini 35974dfc73 Fix typos 
Change-Id: I3f3abc3c6e12536d4bc38f0c676d5fc20532a1e3
Reviewed-on: https://gerrit.libreoffice.org/41370
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
 2017-08-21 08:43:01 +02:00
Noel Grandin 3dcf6dfcee remove unnecessary use of 'this->' 
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4
Reviewed-on: https://gerrit.libreoffice.org/40671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-02 13:45:36 +02:00
Noel Grandin 3964408f7f loplugin:constparams in sdext 
Change-Id: Ia5d2c00b02bf1758f7502065dd109f0f54fda2d3
Reviewed-on: https://gerrit.libreoffice.org/40124
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-18 14:59:47 +02:00
Noel Grandin d7e06e46ac use more OUString::operator== in scaddins..sdext 
Change-Id: I8bc5c925f940283bc54698bbcba77efcca883273
Reviewed-on: https://gerrit.libreoffice.org/39937
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-14 10:12:31 +02:00
Noel Grandin 8c77b5670e use OString::operator== in preference to ::equals 
Change-Id: Ib291521963a791a9c6175964571e9d9895072acf
Reviewed-on: https://gerrit.libreoffice.org/39646
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-06 20:23:09 +02:00
Stephan Bergmann d4ffca1e07 loplugin:unnecessaryparen 
Change-Id: Ifeacfc198c71ae1224ef38a4c8b95b31364f8227
 2017-07-05 22:49:59 +02:00
Noel Grandin 2a1a960339 loplugin:unusedfields in sd 
Change-Id: I42def3dc21ae1a18e1c98d1aeeff4ed4425e941a
Reviewed-on: https://gerrit.libreoffice.org/39479
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-04 08:36:50 +02:00
Stephan Bergmann ec01462141 loplugin:casttovoid: sdext 
Change-Id: I557d59a4bfb9cab17a2cb00c3a80f85a6ef9671b
 2017-07-02 22:30:34 +02:00
Noel Grandin 66efe63e2a loplugin:unusedfields in sdext 
Change-Id: Ib4ce46f370298a0ae86fa95141abb253c2bbfff8
Reviewed-on: https://gerrit.libreoffice.org/39058
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-22 08:45:11 +02:00
Noel Grandin 528632660b convert ErrCode to strong typedef 
would have preferred to re-use o3tl::strong_int, of which this
is a modified copy, but there are lots of convenience accessors
which are nice to define on the class.

Change-Id: I301b807aaf02fbced3bf75de1e1692cde6c0340a
Reviewed-on: https://gerrit.libreoffice.org/38497
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-21 08:42:30 +02:00
Jochen Nitschke febbad7263 cleanup unused css/frame/* includes 
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65
Reviewed-on: https://gerrit.libreoffice.org/38633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-12 13:05:38 +02:00
Noel Grandin 027b25ecd5 use comphelper::InitPropertySequence in more places 
Change-Id: I72d7b13a23ce306b752b39187a0e9fbb7028643a
Reviewed-on: https://gerrit.libreoffice.org/38606
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-09 14:24:00 +02:00
Caolán McNamara 32cb3760a9 Resolves: tdf#107812 add check for -Oblique 
and move checks for -BoldOblique and -LightOblique before -Bold and -Light

Change-Id: I59b59a10c6e92c6a6dc269aad616b9eb9e185ccd
Reviewed-on: https://gerrit.libreoffice.org/37652
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-05-15 17:24:17 +02:00
Noel Grandin 389da66dfc remove unused uno::Reference vars 
found by temporarily marking Reference as SAL_WARN_UNUSED.

Change-Id: I18809b62654467f890016adcc92576980ced393b
Reviewed-on: https://gerrit.libreoffice.org/37511
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-12 09:56:01 +02:00