ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
18450 Commits
Author SHA1 Message Date
Caolán McNamara 374599f8c2 weld SvxCharacterMap dialog 
and SmSymDefineDialog

There's a whole bunch of interrelated stuff which needs to work at the same
time.

add menu support, keyboard support, better mouse support,
a gtk scrollable adaptor to support pseudo scrolling drawing bodge,
plugable uitest support for custom widgets, plugable a11y support
for custom widgets via the existing atk_object_wrapper_new wrapper
for XAccessible

In this specific case, change SvxCharacterMap from something that has an
internal scrollbar to a scrolledwindow where the scrollbar is external, which
drops the need for the a11y impl of SvxCharacterMap to emulate being a scrolled
window and internal table and just needs the table a11y impl

Change-Id: Ia2743d6958021c525a1900154dcbb69ae33fc400
Reviewed-on: https://gerrit.libreoffice.org/52084
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-30 14:32:12 +02:00
Noel Grandin 8e27afa534 loplugin:unnecessaryvirtual 
Change-Id: Ic044a6e4568e707022d87bc5712205fbdf084ba2
Reviewed-on: https://gerrit.libreoffice.org/52067
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-29 18:15:16 +02:00
Noel Grandin 73e6a7975b loplugin:unusedmethods 
Change-Id: I7805ac9bc6f8c0aa5ba4804777e7d7c2c29a78f3
Reviewed-on: https://gerrit.libreoffice.org/52066
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-29 14:45:43 +02:00
Caolán McNamara b83a373586 coverity#1433646 Dereference after null check 
Change-Id: Ie3a352551a82656939c7d25b7f922a03b80d232b
Reviewed-on: https://gerrit.libreoffice.org/52061
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-29 13:29:39 +02:00
Caolán McNamara ce604711da coverity#1433644 silence Dereference after null check 
Change-Id: I699fb3e07d21dc1852c0d50d4a7d478bcf1d1a96
Reviewed-on: https://gerrit.libreoffice.org/52063
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-29 13:07:07 +02:00
Noel Grandin 6a6380b7d6 loplugin:virtualdown in editeng 
Change-Id: Id86a38521fe287a824bdda4b0fd2d68e97ae1b73
Reviewed-on: https://gerrit.libreoffice.org/52036
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-29 08:37:31 +02:00
Noel Grandin 15c9be2bbb loplugin:virtualdown in vcl 
Change-Id: Iea173295b7bc5e7f8a5e0215dc13ab32190c6f8f
Reviewed-on: https://gerrit.libreoffice.org/51999
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-29 08:33:36 +02:00
Johnny_M 4475ccdc3d Translate German variable names 
Akt -> Current in sdiocmpt

Change-Id: I39f05bcf7168fe9fbe6cf90b2499037ec5680cc5
Reviewed-on: https://gerrit.libreoffice.org/51806
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
 2018-03-28 18:11:40 +02:00
Johnny_M cc39342305 Translate German function names 
Akt -> Current in ppt filter

Change-Id: Id32efb885e5e1b04c7fd8f3ce0f21537b2e7576c
Reviewed-on: https://gerrit.libreoffice.org/51800
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
 2018-03-28 18:11:10 +02:00
Noel Grandin 149a4d7566 loplugin:virtualdown in sc..sd 
Change-Id: If93dc12f484839e6d2b44d6568b506f0c15b4735
Reviewed-on: https://gerrit.libreoffice.org/51989
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-28 13:01:12 +02:00
Serge Krot 1c1160967a tdf#115005: New option to prevent adding fallback images 
A new option AddReplacementImages was added to prevent
addition of fallback images that could increase the file
size of the package in several times.

Added unit test.

Change-Id: I50eebba51072d3c93bfe6bed59e9f007568810c0
Reviewed-on: https://gerrit.libreoffice.org/51939
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-03-28 08:56:10 +02:00
himajin100000 e97ab52a83 tdf#116438:Apps should ask if rotation should be applied 
For Calc,Draw,Impress. Writer already does this.

Change-Id: I92512719673fb39a973b8a68378e93f30d82c327
Reviewed-on: https://gerrit.libreoffice.org/51447
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2018-03-27 15:06:09 +02:00
Noel Grandin 862dc17e43 loplugin:expressionalwayszero improvements 
Change-Id: I00bdbc58d2295a0be30b47c85eae6b9abfec17b2
Reviewed-on: https://gerrit.libreoffice.org/51868
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-27 08:22:09 +02:00
Noel Grandin 7574d1865f loplugin:useuniqueptr in OutlineViewShell and ViewShell 
Change-Id: Ia40444b4ba3c8b02d195d979ff6d84cfe4d8b44e
Reviewed-on: https://gerrit.libreoffice.org/51845
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-26 10:57:52 +02:00
Caolán McNamara 1a600d6ed6 tdf#116544 crash on unhandled IllegalArgument exception 
Change-Id: I290ba6097d6d91bf4677e7e92c896bd6359cbc49
Reviewed-on: https://gerrit.libreoffice.org/51833
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-25 21:35:08 +02:00
Noel Grandin 400a70303a loplugin:useuniqueptr in PPTWriter 
Change-Id: I5c099e97d51808d2dcaf6d1385d1e3cab2e2ddf2
Reviewed-on: https://gerrit.libreoffice.org/51762
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-23 11:31:14 +01:00
Noel Grandin e4a839932a loplugin:useuniqueptr in PPTExStyleSheet 
Change-Id: Ib830a1be4f840c06ebda9830351d82ad31706be1
Reviewed-on: https://gerrit.libreoffice.org/51738
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-23 11:05:55 +01:00
Samuel Mehrbrodt a82cdccb0c Typo: GetSelectItemId -> GetSelectedItemId 
Change-Id: Ieebb50b73f1f341c924693f3966f8cd2b09a136b
Reviewed-on: https://gerrit.libreoffice.org/51750
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-03-23 08:26:14 +01:00
Samuel Mehrbrodt c12fc29365 Typo: GetSelectLanguage -> GetSelectedLanguage 
Change-Id: Ia283812d4e9df87d875559af5366c2e36b19eab2
Reviewed-on: https://gerrit.libreoffice.org/51747
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-03-23 08:24:49 +01:00
Noel Grandin 2925ded066 loplugin:useuniqueptr in OutlineView 
Change-Id: I6da98d8634076826cfdbe8d77fa72cb2b99ffe84
Reviewed-on: https://gerrit.libreoffice.org/51672
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-23 07:24:49 +01:00
Noel Grandin fa28a491f5 loplugin:useuniqueptr in DrawDocShell 
Change-Id: I051fb0523622ef2ab93639f0d28b4dc5f4efdbac
Reviewed-on: https://gerrit.libreoffice.org/51671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-22 07:37:35 +01:00
Noel Grandin bf1daa9f4b loplugin:useuniqueptr in SdTransferable 
Change-Id: I7ace5ab37ce6df240d3b7fbe8c0fd12618fa3031
Reviewed-on: https://gerrit.libreoffice.org/51669
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-22 07:36:30 +01:00
Noel Grandin 00635fb32c loplugin:useuniqueptr in DrawViewShell 
Change-Id: I5125e973fbda75b2c7e52e294db74bc3bd5e0bd9
Reviewed-on: https://gerrit.libreoffice.org/51662
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-22 07:33:37 +01:00
Noel Grandin b9ada4bc6f loplugin:useuniqueptr in PresenterTextView::Implementation 
Change-Id: Ie5641d3a4b0791aa4ae4f126afeb3ec6f9760909
Reviewed-on: https://gerrit.libreoffice.org/51661
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-22 07:33:29 +01:00
Mike Kaganski b39cd7d5bd Exclude a redundant variable 
Change-Id: I0a7d6a7068155259313408e8d8e61f72af705cc6
Reviewed-on: https://gerrit.libreoffice.org/51647
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2018-03-20 17:47:55 +01:00
Caolán McNamara 4b785097f1 drop unnecessary includes 
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc
Reviewed-on: https://gerrit.libreoffice.org/51603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-20 13:08:20 +01:00
Mike Kaganski 992a477840 Speed up SdPage comparison 
Move trivial comparisons to front; return early on object comparison

Change-Id: I4db927ac87dbb165e80b70046ff44a260b8a504b
Reviewed-on: https://gerrit.libreoffice.org/51624
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2018-03-20 10:44:04 +01:00
Serge Krot 79b2f1cb36 tdf#115005 Do not remove original vector images from slides 
During calculation of the quality index of the image, we should
take into account also SVM vector image type.
Its mime type is image/x-vclgraphic.

Change-Id: I7c723e99995f73258bb59d976a6c7670c51f7a25
Reviewed-on: https://gerrit.libreoffice.org/51599
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-03-20 07:48:05 +01:00
Caolán McNamara cce17de6e7 coverity#1430077 add assert for 'Division or modulo by zero' 
and

coverity#1430076 Division or modulo by zero
coverity#1430078 Division or modulo by float zero
coverity#1430082 Division or modulo by float zero
coverity#1430083 Division or modulo by zero
coverity#1430085 Division or modulo by zero
coverity#1430102 Division or modulo by zero
coverity#1430103 Division or modulo by zero

Change-Id: I9d7190f95d19a755c681f1f897a8921105ef7c46
Reviewed-on: https://gerrit.libreoffice.org/51568
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-19 21:19:21 +01:00
Xisco Faulí b120932c77 tdf#116364: Revert "tdf#113660: show Master Slide label in handout view" 
This reverts commit 605b01dc59.

Change-Id: I99a2de6a425b1ecd2e9059a9867adac3fc75e619
Reviewed-on: https://gerrit.libreoffice.org/51403
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
 2018-03-19 13:10:06 +01:00
Pranav Kant be8883bcb2 sd: fix incorrect visible center calculation 
Don't call PixelToLogic twice. Thanks Ashod for noticing.

Change-Id: Id280dad7e310ceaf8678f900e6e70214848dd925
Reviewed-on: https://gerrit.libreoffice.org/51529
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
 2018-03-19 08:17:30 +01:00
Jochen Nitschke b2147abdf6 remove unused ucbstreamhelper includes 
and a few vclunohelper includes

Change-Id: I4803605766d155fe5044c2a65c0444631146831c
Reviewed-on: https://gerrit.libreoffice.org/51496
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-19 07:38:49 +01:00
Szymon Kłos e673a47767 tdf#84205 If theme not found, use first 
Not a complete fix, workaround.

Change-Id: If4d765eaeae3419f4f1deb4e1cfbe0113a71da94
Reviewed-on: https://gerrit.libreoffice.org/51440
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
 2018-03-17 08:17:37 +01:00
Pranav Kant 1990fc47bb sd lok: Enable mapmode in case of lok to calculate center 
This reverts the solution in 9fee132c18.

Also, calculate center using the new function for chart, image, and text
shape insertion.

Change-Id: Ie893050b7c875760db0194e7a3f0c2cd3068963b
Reviewed-on: https://gerrit.libreoffice.org/51343
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
 2018-03-17 04:19:18 +01:00
Pranav Kant 21f56ccbd2 sd lok: Set the view size to full page size + fix unit tests 
... such that during insertion of objects when sd calculates the center
of the view to place the object, it is the center of the whole slide,
not the center of the default rectangle of 800x600.

It's also important to hide rulers, scrollbars so that correct center is
calculated; we don't need them anyways in LOK.

Change-Id: I2d1577bc963d324959b272ed3174571ab197d014
Reviewed-on: https://gerrit.libreoffice.org/51416
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: pranavk <pranavk@collabora.co.uk>
 2018-03-17 04:18:55 +01:00
Noel Grandin 92dc87cbac loplugin:useuniqueptr in SvUnoWeakContainer 
just use a std::vector here, these are small objects, no need to
allocate them separately

Change-Id: Ie9f8df88eb7c291e2c99177d0f5e4bfc1c7ab542
Reviewed-on: https://gerrit.libreoffice.org/51415
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-16 19:24:29 +01:00
Caolán McNamara fc86c38e44 weld SvxObjectTitleDescDialog 
Change-Id: Id08c201ee4377fe84618906725e7699d29dc1160
Reviewed-on: https://gerrit.libreoffice.org/51395
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-16 13:18:25 +01:00
Szymon Kłos 064ad89c0e tdf#104789 Export opacity attribute name 
Change-Id: Id47ab6b3cb20fbcebb2d7fa589f3b0d7552e2cce
Reviewed-on: https://gerrit.libreoffice.org/51369
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
 2018-03-16 09:09:14 +01:00
Szymon Kłos 4f90f35c6f tdf#104786 Don't export empty 'to' 
Change-Id: I16b573fd6455813c6be5c2f5a0f0a820360a239f
Reviewed-on: https://gerrit.libreoffice.org/51359
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
 2018-03-16 09:05:09 +01:00
Szymon Kłos 4f1fa172a8 tdf#90627 Don't save empty conditions 
Change-Id: I5a953c1b0fff7bf41a59360a8f52596264ddf266
Reviewed-on: https://gerrit.libreoffice.org/51293
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
 2018-03-16 09:04:22 +01:00
pranavk 32239a1a1a Revert "sd lok: Set the view size to full page size and hide ruler, scrollbars" 
Pushed by mistake. Let's revert until tests passes

This reverts commit 1354bafdc7.

Change-Id: I4a8973f4e22332115143319a264fefa68e343dcc
Reviewed-on: https://gerrit.libreoffice.org/51386
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
 2018-03-16 08:43:24 +01:00
Pranav Kant 1354bafdc7 sd lok: Set the view size to full page size and hide ruler, scrollbars 
... such that during insertion of objects when sd calculates the center
of the view to place the object, it is the center of the whole slide,
not the center of the default rectangle of 800x600.

It's also important to hide rulers, scrollbars so that correct center is
calculated; we don't need them anyways in LOK.

Change-Id: I1180541c1b8c8a35f39112ca0a670c9d96d1320b
Reviewed-on: https://gerrit.libreoffice.org/51347
Reviewed-by: pranavk <pranavk@collabora.co.uk>
Tested-by: pranavk <pranavk@collabora.co.uk>
 2018-03-16 08:29:41 +01:00
Noel Grandin b8512a1cc7 use more TypedWhichId in sfxsids 
Change-Id: I136427319ce2f1117501517efec2f03019bbf71e
Reviewed-on: https://gerrit.libreoffice.org/51339
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-16 08:25:02 +01:00
Caolán McNamara 8f61b382a7 weld SvxObjectNameDialog 
Change-Id: I588bdc61cce9a7b4e709fcac612b229c02e734c0
Reviewed-on: https://gerrit.libreoffice.org/51375
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-16 00:24:52 +01:00
Jan Holesovsky 5372d8022d tdf#115675: Shape selection was breaking when changing pos/size from sidebar. 
Fixes also other potential breakages with the same root cause.

Change-Id: I09b3650189f6edb28ab64652cd411b1dca7dca89
Reviewed-on: https://gerrit.libreoffice.org/51342
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan Holesovsky <kendy@collabora.com>
 2018-03-15 18:40:40 +01:00
Álex Puchades 17b57caf83 tdf#115453 Remove Master Handout tab from Views Tab Bar 
The Views Tab Bar has had five tabs until now (Normal, Outline, Notes, Slide
Sorter and Master Handout). Before this commit, selecting the Master Handout
tab and then going back to the Normal or Notes tab showed the Slide/Notes
Master instead of the expected behaviour.

This commit removes the Master Handout Tab from the Views Tab Bar, with master
views remaining accessible through the View Menu.

Change-Id: I017af5f29d154386e4f0910151c478956aa0985f
Reviewed-on: https://gerrit.libreoffice.org/51320
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-15 16:12:42 +01:00
Noel Grandin a98465920f loplugin:useuniqueptr in SdModule 
Change-Id: I3b79696f06b33703cf61b73867014e4fd86ee9c7
Reviewed-on: https://gerrit.libreoffice.org/51313
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-15 14:21:31 +01:00
Noel Grandin c739573577 loplugin:useuniqueptr in UndoRemovePresObjectImpl 
Change-Id: Ieaaedf6d5815c9dd49dc2f992cfaef7f74c43428
Reviewed-on: https://gerrit.libreoffice.org/51312
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-15 11:58:28 +01:00
Noel Grandin 8f03afa057 loplugin:useuniqueptr in UndoTextAPIChanged 
Change-Id: Id9251ce7e66efe35665619c96e985d5382f0e4a5
Reviewed-on: https://gerrit.libreoffice.org/51311
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-15 10:49:14 +01:00
Xisco Fauli 6a9326803c tdf#115539, tdf#116238: Don't display the notebookbar in presentation mode 
Change-Id: Ifc64d9a3b5c93b83fa238737375e7a58b2ae86db
Reviewed-on: https://gerrit.libreoffice.org/51262
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
 2018-03-14 17:27:23 +01:00