Commit Graph
154 Commits
Author SHA1 Message Date
Tomaž Vajngerl 0d26570365 swarm: don't assert the result in testUnconstrained
It can happen the algorithm doesn't converge the values towards
the solution in the timeframe and number of generations it has
available (slow execution, high cpu load, bad luck) so for now
don't assert the expected value in the test, but still run it
so we know the algorithm does end eventually and doesn't cause
any seg. faults.

Change-Id: Ic889ad1618bf057ac7b281c15bce735f8ec5e13c
Reviewed-on: https://gerrit.libreoffice.org/50500
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-28 14:26:34 +01:00
Noel Grandin 08ab1f46b1 loplugin:oncevar extend to tools/gen.hxx types
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2
Reviewed-on: https://gerrit.libreoffice.org/50283
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26 07:21:04 +01:00
Stephan Bergmann 697f01e052 SAL_W32 is just an alias for _WIN32
...so consistently use the latter instead of the former

Change-Id: I144d5e7c472632f93b2258461510346bc85892d9
Reviewed-on: https://gerrit.libreoffice.org/48135
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-19 08:19:38 +01:00
Jan Holesovsky 101a79cc4d lokdialog: Allow switching language of some of the ResMgr's.
This way, it is possible to have all the strings translated in dialogs even
when different users use different languages.  [It was already possible
to have different languages previously, but not everything in the dialog has
switched - like the buttons at the bottom of the dialogs etc.]

Change-Id: I29a5ae6d31a370eec60397884200b684ec1bf5b9
Reviewed-on: https://gerrit.libreoffice.org/46417
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/46979
Tested-by: Jenkins <ci@libreoffice.org>
2017-12-22 22:39:39 +01:00
Noel Grandin 3af500580b loplugin:salcall fix functions
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-11 12:13:46 +01:00
Michael Stahl 26c14088b0 sccomp: CppunitTest_sccomp_swarmsolvertest fails w/ 32-bit ASAN
Result values look way off, let's just disable it.

Change-Id: Ibc473d238a4f3f4f98de59b5f228948b7b64bebd
2017-12-08 16:21:18 +01:00
Stephan Bergmann 0c3444c9bc Weaken SwarmSolverTest::testUnconstrained even further for now
...after 1fa761af82 "Ridiculously large delta for
SwarmSolverTest::testUnconstrained for now", to accommodate further Jenkins
lo_ubsan failures with actual values of 3.67055466470122
(<https://ci.libreoffice.org/job/lo_ubsan/741/console>) and 3.88389164367578
(<https://ci.libreoffice.org/job/lo_ubsan/743/console>).

Change-Id: Ibacb25ba82c2c279ef8dcd19c5ce7f6d5d8014d5
Reviewed-on: https://gerrit.libreoffice.org/45520
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-30 07:20:41 +01:00
Stephan Bergmann 1fa761af82 Ridiculously large delta for SwarmSolverTest::testUnconstrained for now
At least the Jenkins lo_ubsan build sporadically keeps failing
CppunitTest_sccomp_swarmsolvertest due to rather widely off values here
(3.00064356398118 in <https://ci.libreoffice.org/job/lo_ubsan/736/console> and
2.8639022684852 in <https://ci.libreoffice.org/job/lo_ubsan/738/console>), so
suggestion by Tomaž Vajngerl was: "Let's adapt the delta for now. Generally
anything close to 3 should be acceptable as the algorithm greatly depends on
random values."

Change-Id: Id8f8657e521381decb1c719a1cffdf959ae74ef4
Reviewed-on: https://gerrit.libreoffice.org/45231
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-25 04:20:18 +01:00
Miklos Vajna b3f766154c clang-format fixes
Hopefully the last such commit, now that the in-gerrit verification is
in place and also a warning is printed locally for those who push
directly.

Change-Id: Ib80cbca0b29dc7f71cbb182a38ad6839a659ff41
Reviewed-on: https://gerrit.libreoffice.org/45002
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
2017-11-21 11:16:24 +01:00
Stephan Bergmann 495d25bf65 CppunitTest_swarm_solver_test also consistently fails for UBSan build
...at least for my local one, with

> /data/sbergman/lo-san/core/sccomp/qa/unit/SwarmSolverTest.cxx:387:(anonymous namespace)::SwarmSolverTest::testMultipleVariables
> double equality assertion failed
> - Expected: 0
> - Actual  : 1
> - Delta   : 1e-05

so disable that part unconditionally for now.

Change-Id: Id8c091781baf4381696e2a8f0501df1f3f83724f
Reviewed-on: https://gerrit.libreoffice.org/44977
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-21 02:59:34 +01:00
Stephan Bergmann 42a62d43cc Make CppunitTest name consistent with file name
Change-Id: Ice44f10673d127b1f1c7f701ec2d7905eab7029e
2017-11-20 19:52:39 +01:00
Caolán McNamara fda2ee3d87 WaE: -Werror=unused-function
Change-Id: I773224bd332669c86648578a47612fa6d639c9c5
Reviewed-on: https://gerrit.libreoffice.org/44945
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-20 11:58:51 +01:00
Andrea Gelmini 86b8c063a4 Fix typos
Change-Id: I964528cf4f3b81230c683011e1878b28378b0014
Reviewed-on: https://gerrit.libreoffice.org/44915
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-19 21:57:17 +01:00
jan Iversen f433253f5b iOS reactivated swarmsolver
swarmsolver now compiles after the license issue was corrected, so
no need to have a special case for iOS.

Change-Id: Icae81c2b5769af9c8fd53068d69cbb6e608c7e69
2017-11-19 11:12:21 +01:00
Tomaž Vajngerl 4cc86c8fbf Remove include config_lgpl.h from SwarmSolver, license is MPLv2
Change-Id: I7c29c2e1a6e782dfc24b284f196521a7f7beef61
2017-11-19 01:06:46 +01:00
Caolán McNamara 84cbd415cd we now get a solver lib even without lpsolve or coinmp
Change-Id: I867d9aa37f876532dd67dadff7cd76f6e35868ba
Reviewed-on: https://gerrit.libreoffice.org/44912
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-18 21:59:41 +01:00
jan Iversen 0ee2bd1aeb iOS, swarmsolver workaround
Due to license problems (see mail dev list) disabled swarmsolver

Change-Id: I39889ddab2563a857c3bf0982244f889a402097f
2017-11-18 16:12:05 +01:00
Tomaž Vajngerl 08404bbb90 Swarm based (uses PSO or DE) experimental non-linear solver
This is a new, simple non-linear solver that uses a swarm
(population) to do global optimization. It uses two algoritms -
Particle Swarm Optimization (PSO) or Differential Evolution (DE)
to find a (non-optimal) solution.

It is experimental as not all functions are implemented and it
needs a lot more testing so that it performs well.

Change-Id: If55dad7eda17394851a9d178ad892de771eca7c9
Reviewed-on: https://gerrit.libreoffice.org/44382
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-18 01:16:20 +01:00
Stephan Bergmann 203c989a6c loplugin:includeform: sccomp
Change-Id: I819977bf2c0aff3f98f039f966b7fa6f0fad2728
2017-10-23 22:45:55 +02:00
Rene Engelhard 2651df5a65 sccomp_lpsolver -> sccomp_solver
This test also tests the CoinMP solver, no _lpsolver is misleading

Change-Id: If56de3aa84ec80b1888aadeb940e08e65083c9e9
Reviewed-on: https://gerrit.libreoffice.org/41607
Reviewed-by: Rene Engelhard <rene@debian.org>
Tested-by: Rene Engelhard <rene@debian.org>
2017-08-27 17:33:41 +02:00
Caolán McNamara b1d829e52e move resmgr to unotools
and the vast majority of translations is to the ui language so default
ctor with that arg

and now drop OModuleResourceClient

Change-Id: I3b85a560ffdfe5f019c2271ac56a5fe4a361522b
2017-08-01 13:42:21 +01:00
Caolán McNamara 00657aef09 migrate to boost::gettext
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl
* all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string")
* ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching
  MODULE .mo files
* UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui
  goes from l10n target to normal one, so the res/lang.zips of UI files go away
* translation via Translation::get(hrc-define-key, imbued-std::locale)
* python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there
  to keep finding the .hrc file uniform) so magic numbers can go away there
* java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation
  mechanism
* en-US res files go away, their strings are now the .hrc keys in the source code
* remaining .res files are replaced by .mo files
* in .res/.ui-lang-zip files, the old scheme missing translations of strings
  results in inserting the english original so something can be found, now the
  standard fallback of using the english original from the source key is used, so
  partial translations shrink dramatically in size
* extract .hrc strings with hrcex which backs onto
   xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap
* extract .ui strings with uiex which backs onto
   xgettext --add-comments --no-wrap
* qtz for gettext translations is generated at runtime as ascii-ified crc32 of
   content + "|" + msgid
* [API CHANGE] remove deprecated binary .res resouce loader related uno apis
      com::sun::star::resource::OfficeResourceLoader
      com::sun::star::resource::XResourceBundleLoader
      com::sun::star::resource::XResourceBundle
    when translating strings via uno apis
      com.sun.star.resource.StringResourceWithLocation
    can continue to be used

Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-07-21 08:20:50 +01:00
Chris Sherlock da64d198ec tools: svstream.hxx needs only errcode.hxx & not errinf.hxx
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca
Reviewed-on: https://gerrit.libreoffice.org/36896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25 09:31:31 +02:00
David Ostrovsky de030cd7a2 gbuild: Remove MSVC 2013 legacy code
Uwinapi is discontinued.

Change-Id: I063b4d0d8fab2d60de168e960a63b8181158ac01
Reviewed-on: https://gerrit.libreoffice.org/23198
Reviewed-by: David Ostrovsky <david@ostrovsky.org>
Tested-by: David Ostrovsky <david@ostrovsky.org>
2017-04-21 18:18:44 +02:00
Noel Grandin 7662e92c64 loplugin:redundantcast find cstyle double casts
Change-Id: I5507be190dac781e5cdb545a60acf3d50056c9f8
Reviewed-on: https://gerrit.libreoffice.org/36187
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-06 07:47:30 +00:00
Tomaž Vajngerl b5fb5951c1 change the solver test to explicitly test the available solvers
This changes the lpsolver test to explicitly test the available
linear solvers we have - either CoinMP, LpSolver or both. This
prevents that a newly added solver will be automatically tested
as it can have a different behaviour for the tested input values.

Change-Id: I0c4d2f9c561d1e834ca51196b7b5ecf7d89ba550
Reviewed-on: https://gerrit.libreoffice.org/34813
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-03-02 15:14:30 +00:00
Stephan Bergmann 9a22e96917 Some simplifications, using UNO_QUERY_THROW
Change-Id: Iab702a5ad9697f1c71cc12c7dea954ca620cfdbe
Reviewed-on: https://gerrit.libreoffice.org/34260
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-15 14:17:49 +00:00
Noel Grandin 2489000d3f loplugin:useuniqueptr extend to check local vars
just the simple and obvious case for now, of a local var being allocated
and deleted inside a single local block, and the delete happening at the
end of the block

Change-Id: I3a7a094da543debdcd2374737c2ecff91d644625
Reviewed-on: https://gerrit.libreoffice.org/33749
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-01 12:15:22 +00:00
Stephan Bergmann e57ca02849 Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only).  See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.

Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly).  The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually).  There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).

Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code.  Missing @throws
documentation has not been applied in such manual clean-up.

Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26 12:54:43 +00:00
Stephan Bergmann 2e85ce9692 loplugin:unnecessaryoverride (dtors) in sccomp
Change-Id: Ibfd17710adb0d8cea5046fdf13ca665e7aa549b7
2016-12-05 09:01:01 +01:00
Stephan Bergmann 91dd2db17b loplugin:override: No more need for the "MSVC dtor override" workaround
The issue of 362d4f0cd4 "Explicitly mark
overriding destructors as 'virtual'" appears to no longer be a problem with
MSVC 2013.

(The little change in the rewriting code of compilerplugins/clang/override.cxx
was necessary to prevent an endless loop when adding "override" to

  OOO_DLLPUBLIC_CHARTTOOLS    virtual ~CloseableLifeTimeManager();

in chart2/source/inc/LifeTime.hxx, getting stuck in the leading
OOO_DLLPUBLIC_CHARTTOOLS macro.  Can't remember what that
isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.)

Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13 13:19:22 +02:00
Noel Grandin 6e72f0251b new loplugin unnecessary override
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb
Reviewed-on: https://gerrit.libreoffice.org/27135
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-15 14:05:41 +00:00
Gleb Mishchenko a97b392879 tdf#94698 cleanup Makefiles. Get rid of udkapi and offapi
This patch changes occurences in makefiles
from
$(eval $(call gb_CppunitTest_use_api,comphelper_test_config, \
	udkapi \
	offapi \
))

to
$(eval $(call gb_CppunitTest_use_sdk_api,comphelper_test_config))

(corrected instead of abandon, jani)

Change-Id: Ic96ec65d82d7452e288f05a8b6d576ef543b068e
Reviewed-on: https://gerrit.libreoffice.org/23426
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
Tested-by: jan iversen <jani@documentfoundation.org>
2016-06-09 09:47:11 +00:00
Noel Grandin 96c26b0d9d use initialiser for Sequence<OUString>
using variations of:
git grep -lP 'Sequence.*OUString.*\(\s*1\s*\)' | xargs perl -0777 -pi -e "s/Sequence<OUString> (\w+)\(1\)\;
\s*OUString\* pArray.*;
.*\[0\]\s*=\s*(\S+)\;/Sequence<OUString> \1 { \2 };/g"

Change-Id: I03c64334ff30ee14dce0d17b67f5122a3893bbe3
Reviewed-on: https://gerrit.libreoffice.org/19971
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-15 12:20:39 +00:00
Stephan Bergmann d61d47ad02 loplugin:nullptr (automatic rewrite)
Change-Id: I0fc3144d5791e66d873c36f9a9adf1f3ca152d52
2015-11-10 10:31:37 +01:00
Noel Grandin d95a27f944 com::sun::star->css in scaddins,sccomp,scripting
Change-Id: Id9167341940bac65f055e1e33ff0670f6fa0f6c4
Reviewed-on: https://gerrit.libreoffice.org/19629
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-28 06:31:27 +00:00
Stephan Bergmann b36963c0a6 Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY code
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12 17:52:29 +02:00
Stephan Bergmann bdf9ece338 Actually check the return values of the various Coin* calls
...the code had been like this ever since it got introduced with
6d492447a37ec268fb5924e7fc5631c29c67325d "118160: Use CoinMP as replacement for
lp_solve," but it looks more plausible that the return values should be checked
rather than be ignored.  At least, CppunitTest_sccomp_lpsolver keeps succeeding
after the change (with --enable-coinmp).

Change-Id: If450827ae034079c9ee69b4e49c55b480ac0de06
2015-10-07 15:43:45 +02:00
Takeshi Abe ee7da352b8 Resolves: tdf#88206 replace cppu::WeakImplHelper* etc.
with the variadic variants.

Change-Id: I7154f9472f02fdf47d27ba715db55bb1ec669a8a
Reviewed-on: https://gerrit.libreoffice.org/18580
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-09-15 06:19:28 +00:00
Stephan Bergmann 4f5b03433d Replace remaining getCppuType et al with cppu::UnoType
Change-Id: I7657e83fd1494a199528482d7000940cfa2f60d4
2015-04-01 08:40:44 +02:00
Caolán McNamara 18861c30a6 stdexcept for std::runtime_error
Change-Id: Ic917730ced5ce60036dbab08c1f97ebefb6e86e8
2015-01-04 11:51:58 +00:00
Caolán McNamara 0be5d2b2f6 boost::unordered_map->std::unordered_map
Change-Id: I82f668ef72e916d2ff11df5cda2a02653999f66f
2015-01-04 11:07:58 +00:00
Stephan Bergmann 43c8ca3f99 sccomp: Use appropriate OUString functions on string constants
Change-Id: Ie8495d9da8d3e7c69d12ce3b4d19d3b864cdf818
2014-12-18 14:12:30 +01:00
Caolán McNamara 67b4b34cce coverity#1202902 Uncaught CoinError exception
Change-Id: I93488fa942f1975b9c32be6d37fc76ea955a2067
2014-06-06 14:56:28 +01:00
Stephan Bergmann 369d95931f DeInitVCL at end of tests
This required some changes to the framework:

* Init-/DeInitVCL is no longer done per individual test in BootstrapFixture, but
  once per CppunitTest invocation in a new vclbootstrapprotector (similarly to
  the exisiting unobootstrapprotector).  CppunitTests that need VCL now need to
  declare gb_CppunitTest_use_vcl.

* For things to work properly, the UNO component context needs to be disposed
  from within DeInitVCL (cf. Desktop's Application::DeInit called from
  DeInitVCL).  The easiest solution was to introduce an
  Application::setDeInitHook (where the hook is called from DeInitVCL)
  specifically for vclbootstrapprotector to call.

* PythonTests don't (yet) call DeInitVCL; they still hook into
  BootstrapFixture's original test_init functionality (to call InitVCL), and do
  not make use of the vclbootstrapprotector.

Change-Id: I4f3a3c75db30b58c1cd49d81c51db14902ed68b2
2014-06-04 08:55:12 +02:00
Thomas Arnhold 2bd7767d01 Resolves fdo#70681: fixincludeguards.pl: all that's left
Change-Id: I3e51a62710bb46c8255fd228d41d9300c90a1fb5
Reviewed-on: https://gerrit.libreoffice.org/9360
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
2014-05-15 12:50:46 +00:00
Noel Grandin 65afee03ae sccomp: sal_Bool->bool
Change-Id: I9156ba8671348fd77b93921236827235775e1108
2014-04-24 10:53:16 +02:00
Matúš Kukan 527f5da2f0 sccomp: Fix description of com.sun.star.comp.Calc.CoinMPSolver.
Forgotten in 077bdc73f2

Change-Id: Iddf90f1107f05351754830b49344cb24db1e1089
2014-04-04 15:44:32 +02:00
Stephan Bergmann 9a5a6880c5 loplugin:saloverride
Change-Id: I2f818c865345c9396b3292d9bf0f8520556223e1
2014-04-03 14:20:56 +02:00
Noel Grandin 5babf1b903 remove unnecessary scope qualifier from sal_Bool uses
i.e. convert "::sal_Bool" to "sal_Bool"

Change-Id: Ie5943aee4fee617bf2670655558927ed25b7e067
2014-04-03 13:54:02 +02:00