ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
32101 Commits
Author SHA1 Message Date
Caolán McNamara b16eb0d91f weld SvxZoomDialog 
Change-Id: I9d68fdcc9dc27a5aa4f6ec78542ce7822259233e
Reviewed-on: https://gerrit.libreoffice.org/52157
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-30 21:45:40 +02:00
Caolán McNamara 374599f8c2 weld SvxCharacterMap dialog 
and SmSymDefineDialog

There's a whole bunch of interrelated stuff which needs to work at the same
time.

add menu support, keyboard support, better mouse support,
a gtk scrollable adaptor to support pseudo scrolling drawing bodge,
plugable uitest support for custom widgets, plugable a11y support
for custom widgets via the existing atk_object_wrapper_new wrapper
for XAccessible

In this specific case, change SvxCharacterMap from something that has an
internal scrollbar to a scrolledwindow where the scrollbar is external, which
drops the need for the a11y impl of SvxCharacterMap to emulate being a scrolled
window and internal table and just needs the table a11y impl

Change-Id: Ia2743d6958021c525a1900154dcbb69ae33fc400
Reviewed-on: https://gerrit.libreoffice.org/52084
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-30 14:32:12 +02:00
Winfried Donkers fc121c32ca tdf#97977 make MODE.MULT fully compatible with Excel. 
Also, improve efficiency of function.

Change-Id: Id01542bdd997e0cacfdfd16683d1ac832d22fa35
Reviewed-on: https://gerrit.libreoffice.org/51708
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-03-29 21:46:43 +02:00
Noel Grandin 8e27afa534 loplugin:unnecessaryvirtual 
Change-Id: Ic044a6e4568e707022d87bc5712205fbdf084ba2
Reviewed-on: https://gerrit.libreoffice.org/52067
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-29 18:15:16 +02:00
Caolán McNamara bcf0b17bad coverity#1433648 Unchecked return value 
Change-Id: I11a60e5c6f7728fd47dbb461004622a99f055b16
Reviewed-on: https://gerrit.libreoffice.org/52060
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-29 15:09:27 +02:00
Noel Grandin 73e6a7975b loplugin:unusedmethods 
Change-Id: I7805ac9bc6f8c0aa5ba4804777e7d7c2c29a78f3
Reviewed-on: https://gerrit.libreoffice.org/52066
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-29 14:45:43 +02:00
Noel Grandin 47ccda36fc loplugin:virtualdown in sfx2 
Change-Id: I51e79a4a3d2c799e69bc13c66b5b84056bee6206
Reviewed-on: https://gerrit.libreoffice.org/52034
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-29 08:37:19 +02:00
Noel Grandin bc8b3a8d45 loplugin:useuniqueptr in ScInterpreter 
Change-Id: I682fa97a567ecf952214aa050a0ec981b4897ef5
Reviewed-on: https://gerrit.libreoffice.org/52028
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-29 08:35:43 +02:00
Noel Grandin 15c9be2bbb loplugin:virtualdown in vcl 
Change-Id: Iea173295b7bc5e7f8a5e0215dc13ab32190c6f8f
Reviewed-on: https://gerrit.libreoffice.org/51999
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-29 08:33:36 +02:00
Noel Grandin 149a4d7566 loplugin:virtualdown in sc..sd 
Change-Id: If93dc12f484839e6d2b44d6568b506f0c15b4735
Reviewed-on: https://gerrit.libreoffice.org/51989
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-28 13:01:12 +02:00
Noel Grandin 1a43481a1d loplugin:useuniqueptr in ScSortInfoArray 
ScSortInfo is rather small POD object, so rather than using the heap,
and doing lots of pointer chasing, just allocate them in nice big cache-
friendly arrays.

Change-Id: Ice7b6afc73c7f6e2af51855d38184640ef440e46
Reviewed-on: https://gerrit.libreoffice.org/51914
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-28 08:39:55 +02:00
Noel Grandin e32c56855b use boost::optional in sc and svgio 
instead of using std:unique_ptr to allocate small objects on the heap

Change-Id: Ifd309a9bf331910354406b827b89a0363f3b7eda
Reviewed-on: https://gerrit.libreoffice.org/51945
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-28 08:39:35 +02:00
Noel Grandin b2e8bbeafa loplugin:useuniqueptr in ScColumn 
Change-Id: Iff6c68a29b9e7660132cbe4e556802b0f63706f0
Reviewed-on: https://gerrit.libreoffice.org/51904
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-28 08:39:21 +02:00
Noel Grandin f4f1654c07 tdf#106667 Hang when trying to open a dialog and the whole sheet is selected 
regression from

    commit 8d54796bf1 (patch)
    enhance pass-by-ref plugin to detect large arguments

which converted this peice of code into an O(n^2) loop

Change-Id: I0473a084518c0d10411615e1b3901b9b90144bc9
Reviewed-on: https://gerrit.libreoffice.org/51956
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-03-27 21:22:31 +02:00
himajin100000 8100a41597 tdf#116470:Apply BOLD to CJK/CTL pivot table style 
by changing ATTR_CJK_FONT_WEIGHT and ATTR_CTL_FONT_WEIGHT
(carelessly forgotten in Change 51511)

Change-Id: Idd7fce6b20f8e1f5b8d70bdc74ba06833cd0a1d9
Reviewed-on: https://gerrit.libreoffice.org/51727
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
 2018-03-27 16:35:37 +02:00
himajin100000 e97ab52a83 tdf#116438:Apps should ask if rotation should be applied 
For Calc,Draw,Impress. Writer already does this.

Change-Id: I92512719673fb39a973b8a68378e93f30d82c327
Reviewed-on: https://gerrit.libreoffice.org/51447
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
 2018-03-27 15:06:09 +02:00
Caolán McNamara edfa056261 ofz#7121 NamedDBs::insert takes ownership of its argument 
at one point this was based on std::auto_ptr and didn't
free its arg on failure

Change-Id: I8aeed6876d80b7ebe4ebb5e2cfd12e00420bd207
Reviewed-on: https://gerrit.libreoffice.org/51932
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-27 13:30:40 +02:00
Noel Grandin 3acc5a2383 tdf#69977 improve creation of large charts 
this patch only tweaks a few things around the edges. The bulk of the
cost is down in the chart2 module where it creates ticks and labels.

Change-Id: If73a16d2f0a7511f07eff379a9b5c1b38ef96786
Reviewed-on: https://gerrit.libreoffice.org/51931
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-27 13:26:30 +02:00
Noel Grandin 0f87f89538 loplugin:useuniqueptr in ScMultipleReadHeader 
Change-Id: I517593a910ed5783f256722bad915be2232f290e
Reviewed-on: https://gerrit.libreoffice.org/51913
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-27 09:54:37 +02:00
Noel Grandin 50af4bf5c6 loplugin:useuniqueptr in ScDrawLayer 
Change-Id: I684e391b738be23ba7769b7c5b0a354f43a9226e
Reviewed-on: https://gerrit.libreoffice.org/51903
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-27 08:21:44 +02:00
Noel Grandin 26ebaae4f1 loplugin:useuniqueptr in ScPrintSaverTab 
Change-Id: I51ef59e97e9b46cf9496dbefaabcc15471e9cdae
Reviewed-on: https://gerrit.libreoffice.org/51902
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-27 08:21:33 +02:00
Caolán McNamara 0869602fdf forcepoint #31 check validity of another group range 
Change-Id: I82ff3e47a033c91581b108e1685b1ff4d5865895
Reviewed-on: https://gerrit.libreoffice.org/51881
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-27 00:36:49 +02:00
Szymon Kłos 030c30b33b tdf#116241 Customizing value highlighting colors 
Available in: Tools->Options->Application colors

Change-Id: I6e4f7a0dcad9a6ee222275019596853f0cbd3ab0
Reviewed-on: https://gerrit.libreoffice.org/51791
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
 2018-03-26 23:24:08 +02:00
Caolán McNamara c2a4061e3e forcepoint #34 survive missing autostyles 
Change-Id: I742816297659d614e836a8d5e8965b1c55154719
Reviewed-on: https://gerrit.libreoffice.org/51890
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-26 22:31:19 +02:00
Caolán McNamara 424f54c3cc forcepoint #32 survive missing value range 
Change-Id: I90315f0481bf73c4d9071959bf5408f4a2690257
Reviewed-on: https://gerrit.libreoffice.org/51884
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-26 20:31:05 +02:00
Noel Grandin 4f26869578 loplugin:useuniqueptr in ScDPSource 
Change-Id: Iea0795b0c48ec8ad50af15beb0d27cc335b15660
Reviewed-on: https://gerrit.libreoffice.org/51846
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-26 15:34:55 +02:00
Caolán McNamara 01582612fe forcepoint #29 detect illegal self series add 
Change-Id: I3bba0f942780c54951a3a810c05cc3b56ca18a5e
Reviewed-on: https://gerrit.libreoffice.org/51854
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-26 14:58:08 +02:00
Caolán McNamara 6215deb5d2 forcepoint #30 check validity of group range 
Change-Id: Ie0611f36809b051ce46030e44c137b4e1f8d2fe0
Reviewed-on: https://gerrit.libreoffice.org/51856
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-26 12:18:33 +02:00
Noel Grandin 7e1fbb3cdb loplugin:useuniqueptr in ScAddInAsync 
Change-Id: Ic9b0964dd5c3d7188ec857fa52d20d030edacd5a
Reviewed-on: https://gerrit.libreoffice.org/51847
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-26 11:55:02 +02:00
Noel Grandin 939b90f126 loplugin:useuniqueptr in ScChartListener 
Change-Id: Ib178b1cbe518088af7b3120c5188dd03ae4cf6c2
Reviewed-on: https://gerrit.libreoffice.org/51848
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-26 11:16:01 +02:00
Noel Grandin d312ff2b52 tdf#112997 multiple animated gif only one frame 
Not sure what the problem is, but using a vector and just making sure
we insert into the right spot for the sorting fixes it.

Change-Id: I11c08e08a14c98ba7eb6a5d925c75bab891ecf63
Reviewed-on: https://gerrit.libreoffice.org/51829
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-26 09:30:25 +02:00
Szymon Kłos 154496aefe Revert "tdf#116241 Customizing value highlighting colors" 
This reverts commit fb29b82624.

Change-Id: I338af7c108bb6386193550ef0603b406c4f7bd99
Reaseon: I will move this to more suitable place "application colors" and extend with protected cell backround.
Reviewed-on: https://gerrit.libreoffice.org/51789
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
 2018-03-23 20:48:41 +01:00
Eike Rathke c53235ba9a Enable binary search for numeric values again 
... as used in LOOKUP and VLOOKUP.

This was disabled as a fallout from

    commit bad266fa06
    CommitDate: Mon Feb 22 21:30:28 2016 +0100

        ScQueryEntry::GetSearchTextPtr() with SearchType, tdf#72196

that changed the !bRegExp condition (which includes numeric) to
bLiteral (which covers only text string) searches.

Change-Id: I265286ffe75bc7cd9e660ab82b0e647d82865eb9
 2018-03-23 13:14:51 +01:00
Samuel Mehrbrodt a82cdccb0c Typo: GetSelectItemId -> GetSelectedItemId 
Change-Id: Ieebb50b73f1f341c924693f3966f8cd2b09a136b
Reviewed-on: https://gerrit.libreoffice.org/51750
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-03-23 08:26:14 +01:00
Samuel Mehrbrodt c12fc29365 Typo: GetSelectLanguage -> GetSelectedLanguage 
Change-Id: Ia283812d4e9df87d875559af5366c2e36b19eab2
Reviewed-on: https://gerrit.libreoffice.org/51747
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-03-23 08:24:49 +01:00
Noel Grandin 503c93275e loplugin:useuniqueptr in ScPoolHelper 
Change-Id: I12bb470b3c0af78aa713e7b28d59235b55507d24
Reviewed-on: https://gerrit.libreoffice.org/51737
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-23 08:17:58 +01:00
Samuel Mehrbrodt d8b7119859 tdf#116510 Copy cell anchored images too when copying cells 
Change-Id: Ia64100a00e65b7871c44a9b4700ca86782897a8e
Reviewed-on: https://gerrit.libreoffice.org/51725
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2018-03-22 16:45:50 +01:00
Noel Grandin b7654432bf loplugin:useuniqueptr in ScDocument 
and fix bug where we were deleting a pointer to an object
we did not own via pFormatExchangeList

Change-Id: I488c679734c48bd21bc6be04837e037e97550647
Reviewed-on: https://gerrit.libreoffice.org/51668
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-22 09:53:45 +01:00
Noel Grandin c0a76a9460 loplugin:useuniqueptr in ScColumn 
Change-Id: If2f8e1f730fabaf124e515dbe58ec5d755d1e57b
Reviewed-on: https://gerrit.libreoffice.org/51667
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-22 07:36:12 +01:00
Noel Grandin cc2c1d9525 loplugin:useuniqueptr in ScDPResultMember 
Change-Id: Icf8a52bcf233994bc49a5d9094196154f20602ea
Reviewed-on: https://gerrit.libreoffice.org/51663
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-22 07:33:56 +01:00
Szymon Kłos fb29b82624 tdf#116241 Customizing value highlighting colors 
Change-Id: I5d77e6207d1e29326282d7184c9348e59292977a
Reviewed-on: https://gerrit.libreoffice.org/51653
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
 2018-03-21 17:54:47 +01:00
tagezi 3b3e203461 tdf#68290 cursor moves with Enter in protected sheet 
Change-Id: I2ac848f1799d94f521628480664cdb579417772a
Reviewed-on: https://gerrit.libreoffice.org/49085
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-03-21 01:08:03 +01:00
himajin100000 82aab78ccd tdf#116470:Convert between ProgName/DisplayName for pivot table style 
to avoid styles in different languages to be unnecessarily registered

Change-Id: I450909d798749f751b1c59cda28865f6c3ea76c3
Reviewed-on: https://gerrit.libreoffice.org/51511
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
 2018-03-20 21:13:28 +01:00
Caolán McNamara 4b785097f1 drop unnecessary includes 
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc
Reviewed-on: https://gerrit.libreoffice.org/51603
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-20 13:08:20 +01:00
Caolán McNamara 14244769eb coverity#1430097 Dereference null return value 
Change-Id: I1cba6a67c2b94b5906c017960e5636d5e7b87dd2
Reviewed-on: https://gerrit.libreoffice.org/51565
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-19 21:20:02 +01:00
Caolán McNamara cce17de6e7 coverity#1430077 add assert for 'Division or modulo by zero' 
and

coverity#1430076 Division or modulo by zero
coverity#1430078 Division or modulo by float zero
coverity#1430082 Division or modulo by float zero
coverity#1430083 Division or modulo by zero
coverity#1430085 Division or modulo by zero
coverity#1430102 Division or modulo by zero
coverity#1430103 Division or modulo by zero

Change-Id: I9d7190f95d19a755c681f1f897a8921105ef7c46
Reviewed-on: https://gerrit.libreoffice.org/51568
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-19 21:19:21 +01:00
Caolán McNamara a80d9d61b8 coverity#1430075 Dereference after null check 
Change-Id: Id4c9cc1463ba8b38a7b115d574fec8c9b1d55384
Reviewed-on: https://gerrit.libreoffice.org/51556
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2018-03-19 16:59:13 +01:00
Noel Grandin 2ec02d7ea1 tdf#116421 autosum is not working 
regression from
   commit 6529cd54c2
   don't use heap for elements in ScRangeList

The change in lcl_MoveRanges is not part of the fix, just something else
I noticed when reviewing the problematic commit

Change-Id: I958937f92a84f6e8e7bec607705c3a958d70ad3c
Reviewed-on: https://gerrit.libreoffice.org/51547
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-19 14:51:01 +01:00
Jochen Nitschke b2147abdf6 remove unused ucbstreamhelper includes 
and a few vclunohelper includes

Change-Id: I4803605766d155fe5044c2a65c0444631146831c
Reviewed-on: https://gerrit.libreoffice.org/51496
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-19 07:38:49 +01:00
Julien Nabet b37f81f298 cppcheck: arrayIndexThenCheck 
Change-Id: If30664066e3f3f99c02244e248e72406380069aa
Reviewed-on: https://gerrit.libreoffice.org/51513
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-03-18 21:10:46 +01:00