Commit Graph
891 Commits
Author SHA1 Message Date
Noel Grandin c91f8e55fa loplugin:useuniqueptr in MergeDataHashMap
Change-Id: I263c187bab997b6ab929ca04788214d7418cb449
Reviewed-on: https://gerrit.libreoffice.org/51928
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-27 09:54:44 +02:00
Julien Nabet f365b17bf1 Use for-range loops in some modules
jvmaccess, jvmfwk, l10ntools, libreofficekit and linguistic

Change-Id: I9d290d1098b25ccb3aee19d2df18c18f4aa65105
Reviewed-on: https://gerrit.libreoffice.org/51495
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-25 15:14:44 +02:00
Stephan Bergmann bcbb3c4f5b Remove dead Executable_genlang
...originally introduce with 999c68f12f "genLang
project (awareness)", but apparently never took off.

Change-Id: I6f61271a75d96750dea63de596b7745c2f589b83
Reviewed-on: https://gerrit.libreoffice.org/49389
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-09 08:51:05 +01:00
Stephan Bergmann 95adb247b6 More loplugin:cstylecast: l10ntools
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: I062bc41d2feb8b50371da345edac0e65e0d187b2
2018-01-12 20:20:59 +01:00
Noel Grandin 96d9bd2262 loplugin:useuniqueptr in l10ntools
update plugin to find all places where we are unconditionally deleting
stuff in a destructor

Change-Id: Ia0fedc2420c7717ed2bdd8d3bb00262d2a63e0bc
Reviewed-on: https://gerrit.libreoffice.org/47724
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-11 07:36:26 +01:00
Noel Grandin a5be07d6b6 inline use-once typedefs
Change-Id: I5c3ffc03c26b3428f1f336e6ecba7838a1cf1157
Reviewed-on: https://gerrit.libreoffice.org/46764
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-19 11:57:57 +01:00
Julien Nabet 2ec698b433 cppcheck: fix some reports
variableScope reports in comphelper/drawinglayer/editeng
+filter/framework/l10ntools

Change-Id: I4575428773e8b9b3efedabb44fdcd6d8175ac46a
Reviewed-on: https://gerrit.libreoffice.org/46116
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-08 23:14:49 +01:00
Julien Nabet 96829f75aa Replace list by vector in pocheck (l10ntools)
+ use for range loops which included std::list while at it.

Change-Id: If80e63e54f6ba39b38f5de92f97642737727e60a
Reviewed-on: https://gerrit.libreoffice.org/46039
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-07 22:23:01 +01:00
Noel Grandin 4f4486c61d look for =() in loplugin:unnecessaryparen
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0
Reviewed-on: https://gerrit.libreoffice.org/44944
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-20 12:31:32 +01:00
Stephan Bergmann fc8e95600a loplugin:includeform: l10ntools
Change-Id: I73eed5cbaaa1a0668f0dfa89a1a26883f64b3107
2017-10-23 22:46:03 +02:00
Eike Rathke d80ba7354c Ditch now unused GraphicExportDialog, GraphicExportOptionsDialog
That was a dead end anyway, trying to partly reimplement
SvFilterOptionsDialog ExportDialog, instead of implementing the
necessary bits to use that one which has everything.

Change-Id: Icde7422f2c2d7e26c07dfe921a4abda41e222b09
Reviewed-on: https://gerrit.libreoffice.org/42503
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-22 13:28:31 +02:00
Mike Kaganski afeff9102c Use even more WIN32_LEAN_AND_MEAN
Change-Id: I538fe5b41156366e0e87b3a93e58a3947afd18f5
Reviewed-on: https://gerrit.libreoffice.org/42398
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-09-18 01:13:30 +02:00
Jan Holesovsky a0f51dc3a4 Use "en-US" as the default for XHP's xml-lang attribute.
Change-Id: I765e1cc25ac79d2cebf54f7a247a200647c984da
Reviewed-on: https://gerrit.libreoffice.org/32296
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-13 01:53:47 +02:00
Andrea Gelmini 8f5e385242 sdstring.src no more exists
Change-Id: I9cc937daa135ad35c1abca66a926d2fe40040dc4
Reviewed-on: https://gerrit.libreoffice.org/41315
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-08-19 11:59:16 +02:00
Julien Nabet 92507dd3dc Remove refs to deleted src files
following https://cgit.freedesktop.org/libreoffice/core/commit/?id=00657aef09d854c74fb426a935a3e8b1fc390bb0

Change-Id: I34a119676257eb3b3caa318eb788f16e7fd1bd4b
Reviewed-on: https://gerrit.libreoffice.org/41307
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-18 22:50:20 +02:00
Andrea Gelmini b44f30f0c9 Removed reference to deleted file
cui/source/dialogs/cuires.src has been deleted on commit
00657aef09

Change-Id: I2030a352a9538cf46e3ce078c21d30d3af979284
Reviewed-on: https://gerrit.libreoffice.org/41191
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-16 18:55:15 +02:00
Andrea Gelmini 90eed41147 Deleted referenced file
svtools/source/contnr/svcontnr.src has been deleted on commit
00657aef09

Change-Id: I0b8a470f141ec64b1a3d410606f52bad1a926cbc
Reviewed-on: https://gerrit.libreoffice.org/41193
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-16 18:53:35 +02:00
Andrea Gelmini 06aaedb292 Removed reference to deleted file
extensions/source/propctrlr/formres.src deleted on commit
00657aef09

Change-Id: I54853e383be936623299ae6a36fe1809add28e2a
Reviewed-on: https://gerrit.libreoffice.org/41192
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-16 18:52:51 +02:00
Noel Grandin d347c24036 convert std::map::insert to std::map::emplace
which is considerably less verbose

Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b
Reviewed-on: https://gerrit.libreoffice.org/40978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11 12:38:32 +02:00
Noel Grandin a209172669 loplugin:constantparam
Change-Id: Ib92aba17c46a4ada75c2a0630f281759d995f32e
Reviewed-on: https://gerrit.libreoffice.org/40843
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-08 08:08:35 +02:00
Mike Kaganski 765398294b tdf#110448: Remove "Memory" page from Options dialog
The relevant caches settings are still available under Expert
Configuration:

/org.openoffice.Office.Common/Cache/GraphicManager/TotalCacheSize
/org.openoffice.Office.Common/Cache/GraphicManager/ObjectCacheSize
/org.openoffice.Office.Common/Cache/GraphicManager/ObjectReleaseTime
/org.openoffice.Office.Common/Cache/DrawingEngine/OLE_Objects
/org.openoffice.Office.Common/Cache/Writer/OLE_Objects

Change-Id: I7692fd94a873ba7220a21d51ff8a943598c6a9fc
Reviewed-on: https://gerrit.libreoffice.org/40640
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-02 10:36:38 +02:00
Noel Grandin 3e4b0bde62 loplugin:unusedfields some untouched fields
which lead to a whole bunch of dead code in vcl/.../i18n_status.cxx

Change-Id: Id8eeadeb9cbc6107e1a0dac5801ce20b2b9ae6dc
Reviewed-on: https://gerrit.libreoffice.org/40355
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-24 11:02:19 +02:00
Noel Grandin ec340697d6 loplugin:constparams in soltools and various
Change-Id: I5e8e4a9a31aa7c3ff54cc7ce137d08770ea297e1
Reviewed-on: https://gerrit.libreoffice.org/40279
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-21 17:11:15 +02:00
Caolán McNamara 00657aef09 migrate to boost::gettext
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl
* all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string")
* ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching
  MODULE .mo files
* UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui
  goes from l10n target to normal one, so the res/lang.zips of UI files go away
* translation via Translation::get(hrc-define-key, imbued-std::locale)
* python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there
  to keep finding the .hrc file uniform) so magic numbers can go away there
* java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation
  mechanism
* en-US res files go away, their strings are now the .hrc keys in the source code
* remaining .res files are replaced by .mo files
* in .res/.ui-lang-zip files, the old scheme missing translations of strings
  results in inserting the english original so something can be found, now the
  standard fallback of using the english original from the source key is used, so
  partial translations shrink dramatically in size
* extract .hrc strings with hrcex which backs onto
   xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap
* extract .ui strings with uiex which backs onto
   xgettext --add-comments --no-wrap
* qtz for gettext translations is generated at runtime as ascii-ified crc32 of
   content + "|" + msgid
* [API CHANGE] remove deprecated binary .res resouce loader related uno apis
      com::sun::star::resource::OfficeResourceLoader
      com::sun::star::resource::XResourceBundleLoader
      com::sun::star::resource::XResourceBundle
    when translating strings via uno apis
      com.sun.star.resource.StringResourceWithLocation
    can continue to be used

Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-07-21 08:20:50 +01:00
Noel Grandin 65e4a776e8 simplify some OUString::copy calls
Change-Id: Ifa228ca02ea79a1309e1875414028aade7e5f12d
Reviewed-on: https://gerrit.libreoffice.org/39801
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-11 13:55:30 +02:00
Noel Grandin 8c77b5670e use OString::operator== in preference to ::equals
Change-Id: Ib291521963a791a9c6175964571e9d9895072acf
Reviewed-on: https://gerrit.libreoffice.org/39646
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-06 20:23:09 +02:00
Stephan Bergmann 0c4d4f268f loplugin:unnecessaryparen
Change-Id: I38f1462c97c6a8fc5777f0db4555c11d8201b49b
2017-07-05 15:05:10 +02:00
Noel Grandin 469076317d loplugin:unusedfields l10ntools..rsc
Change-Id: I78785eeab436910c9e8733924a7c43fa998ba36f
Reviewed-on: https://gerrit.libreoffice.org/39491
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-04 11:26:09 +02:00
Stephan Bergmann 5c2002d0d2 loplugin:casttovoid: l10ntools
Change-Id: I9f21497e821632936074272b52879507f60afe65
2017-07-02 22:31:43 +02:00
Noel Grandin 93d42c1b23 loplugin:oncevar in l10ntools..mysqlc
Change-Id: Ifd4826f8ba4e10f2e012172fa693794d68bb6b4d
Reviewed-on: https://gerrit.libreoffice.org/39188
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-25 17:19:48 +02:00
Gabor Kelemen c9b9224018 Remove support for the oldref attribute in l10ntools
Now that oldref and l10n attributes were removed from
helpcontent in commit eb9ec1c794a0d3b8522375c7a87ac3ee999c8a66
we can as well drop support of these from l10ntools and xmlhelp

Change-Id: Ib6fe30e93f0d7e976bb675beee9395ab543af99c
Reviewed-on: https://gerrit.libreoffice.org/38715
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
2017-06-23 21:09:41 +02:00
Andrea Gelmini a3a40ba2a6 Fix typos: uniform registered
We have in the same files "registered" and "registred".

Change-Id: I604a8fdb7d5c40fe208fc11e9120333b3eaef3da
Reviewed-on: https://gerrit.libreoffice.org/39097
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-06-23 11:52:25 +02:00
Noel Grandin cb37c5f0f3 loplugin:unusedfields in jvmfwk..mysqlc
Change-Id: If9c7a3239fceba9a2db3a5905ccaa7fa9adadb08
Reviewed-on: https://gerrit.libreoffice.org/39099
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-23 08:59:20 +02:00
Gabor Kelemen 6721e35f5a tdf#106175 Support <sub> tag in localized help text as well
Change-Id: If038daf4350bfcd2e7146809f63ee4f062a0dc81
Reviewed-on: https://gerrit.libreoffice.org/38670
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-19 11:13:49 +02:00
Jochen Nitschke a5dba7dbec remove unused osl/mutex.hxx includes
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-18 13:38:25 +02:00
Michael Stahl 4ffdb6750f remove TDE integration (vclplug, address book, config backend)
It has ~no users, can't even be built on modern Linuxes, and it annoys
folks who want to refactor VCL.

Per ESC decision from 2017-06-08, remove --enable-tde and --enable-tdeab.

Change-Id: I51ce4786f29f8fcac2e2bb2a654c41fbfbbd8afd
Reviewed-on: https://gerrit.libreoffice.org/38718
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-06-13 10:41:24 +02:00
Juergen Funk 6ca3b3648e tdf#106942 Wrong message when lock file is empty or corrupt
1. Erase empty or corrupt lockfile, when reading it fails and
   skip "Locked Document Dialog" in that case
2. Show Dialog (use LockFileIgnoreRequest -> LockFailedQueryBox)
   when create lock file is not possible.
   Two Dialogs:  "lock file create error" and
                 "empty lockfile is present"
   Set the document to read-only when creating lockfile is not
   possible. If lockfile is corrupt or empty, inform the user.
   They can interrupt loading the document or open it read-only,
   which also erases the corrupt lock file after closing
   the document
3. Handling for the two Dialogs
   Use LockFileIgnoreRequst for create lockfile error and
   add a new LockFileCorruptRequest, (lock file is corrupt).
   Change and generate new messages for both dialogs in english

Change-Id: I35c377f85b5113e8ffb89d83b9544b8ebc81d89f
Reviewed-on: https://gerrit.libreoffice.org/36658
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-06-06 15:58:02 +02:00
Arnaud Versini f2d40b8ba1 Remove all allocation of VCLExternalSolarLock.
This patch is graciously offered by Arnaud Versini.

Change-Id: I3ed5e1758d09542a2ca0533e3f4a6ceb2dbb6346
Reviewed-on: https://gerrit.libreoffice.org/38404
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-05 13:41:38 +02:00
Noel Grandin 146033f5da spelling instanciate -> instantiate
Change-Id: Ic1393da64328c0dc7e2860334b204139bf537d81
Reviewed-on: https://gerrit.libreoffice.org/38401
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-05 10:11:33 +02:00
Arnaud Versini c4ac732d81 Remove usage of OString("")
Change-Id: I0874f81c35573048d05b3842806daa0db67f7887
Reviewed-on: https://gerrit.libreoffice.org/38386
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-04 15:13:17 +02:00
Noel Grandin ca145c7364 remove some unnecessary OString constructor calls
Change-Id: I11358f17770cacb2a33011797f4be82dc02340b7
Reviewed-on: https://gerrit.libreoffice.org/38130
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-29 12:56:28 +02:00
Noel Grandin ef513fd4b0 remove unnecessary use of OString::getStr
Change-Id: I0490efedf459190521f4339854b3394d57765fdb
Reviewed-on: https://gerrit.libreoffice.org/38058
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-28 19:44:08 +02:00
Christian Lohmaier 826f1bca40 rdm#2247 enable Upper Sorbian for languagepack/UI
Change-Id: Id497d8032668823c6db07eb179ad4484241b7285
2017-05-28 18:24:47 +02:00
Caolán McNamara 8119d0ceb7 writerperfect translations missing
persumably because there were never extracted to be available
for translation

Change-Id: Ib9d37105a41c19898577ba8acec121b87e3af9e5
2017-05-26 13:23:57 +01:00
Andrea Gelmini fbd4147411 Fix typos
To complete commit 076758857a

Change-Id: I6424109e3aee8a3236e40168bdd98c725a7afafb
Reviewed-on: https://gerrit.libreoffice.org/37306
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-05-07 12:45:36 +02:00
Stephan Bergmann b75968c8c3 loplugin:salunicodeliteral: l10ntools
Change-Id: Id291a2242a2ec0d19cf7a679825fb4a1ec468d07
2017-04-28 18:26:58 +02:00
Christian Lohmaier 11468ea907 allow itemlist-method's multi-line msgid strings in msgctxt
otherwise pocheck will file on strings like like e.g.

 #: analysis.src
 msgctxt ""
 "analysis.src\n"
 "ANALYSIS_Weeknum\n"
 "Returns the number of the calendar week in which the specified date occurs.\n"
 "This function exists for interoperability with older Microsoft Excel documents, for new documents use WEEKNUM instead.\n"
 "itemlist.text"
 msgid ""
 "Returns the number of the calendar week in which the specified date occurs.\n"
 "This function exists for interoperability with older Microsoft Excel documents, for new documents use WEEKNUM instead."
 msgstr ""

Change-Id: Ib64a989933ca42c5119b0ecf2339f693793d4e96
2017-04-28 16:46:00 +02:00
Chris Sherlock da64d198ec tools: svstream.hxx needs only errcode.hxx & not errinf.hxx
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca
Reviewed-on: https://gerrit.libreoffice.org/36896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-25 09:31:31 +02:00
Noel Grandin e0097fea5a loplugin:checkunusedparams in i18nlangtag and l10ntools
Change-Id: If7c7404b1cc1cf9445a2af8106f7326b76524388
Reviewed-on: https://gerrit.libreoffice.org/36883
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-24 15:45:22 +02:00
Noel Grandin 8c8f2a5285 remove unnecessary explicit linefeeds from end of SAL and OSL log calls
Change-Id: I3fa363c8e76e6cfb297f4ec346e3f031c09d6fbf
Reviewed-on: https://gerrit.libreoffice.org/36727
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-21 09:15:11 +02:00