ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
121 Commits
Author SHA1 Message Date
Andrea Gelmini 34fe67be47 Fix typos 
Change-Id: I359c5aff8c90359783588d189de4e5b94224fa9c
Reviewed-on: https://gerrit.libreoffice.org/48232
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2018-01-24 21:03:32 +01:00
Stephan Bergmann 697f01e052 SAL_W32 is just an alias for _WIN32 
...so consistently use the latter instead of the former

Change-Id: I144d5e7c472632f93b2258461510346bc85892d9
Reviewed-on: https://gerrit.libreoffice.org/48135
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2018-01-19 08:19:38 +01:00
Jochen Nitschke a5dba7dbec remove unused osl/mutex.hxx includes 
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-06-18 13:38:25 +02:00
Jochen Nitschke 959496794c cleanup osl/diagnose.h includes 
with command
> git grep -l osl/diagnose.h *.cxx |
  xargs grep -L -w 'OSL_\w*' |
  xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d'

headers need more work

Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab
Reviewed-on: https://gerrit.libreoffice.org/37350
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-05-09 15:41:46 +02:00
Chris Sherlock 97eb00c75e revert OSL_ASSERT changes 
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
 2017-05-07 17:03:35 +10:00
Chris Sherlock 9a274915a1 tdf#43157: convert cppuhelper and io from OSL_ASSERT to assert 
Change-Id: I56d49e1ce9f1c070fedcabb8f1637d17dee1083b
 2017-05-07 08:11:12 +10:00
Chris Sherlock a238b1f8d3 Remove excess newlines 
A ridiculously fast way of doing this is:

for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \
  --exclude-dir=workdir --exclude-dir=instdir '^
{3,}' .)
do
    perl -0777 -i -pe 's/^
{3,}/

/gm' $i
done

Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c
Reviewed-on: https://gerrit.libreoffice.org/22224
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2016-02-09 08:18:05 +00:00
Andrea Gelmini 64d624b651 Fix typos 
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86
Reviewed-on: https://gerrit.libreoffice.org/21209
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
 2016-01-10 14:17:20 +00:00
Caolán McNamara 70b09d9322 cppcheck: noExplicitConstructor 
Change-Id: I1934441858baeeb41a46f694dbcef2d846b308b7
 2015-11-24 10:35:44 +00:00
Noel Grandin 8569c6d0ad use initialiser list for Sequence<OUString> 
Change-Id: Ia5e47261d1fc6fac2d046656c05a1c5eedb07e02
Reviewed-on: https://gerrit.libreoffice.org/19978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-16 08:35:42 +00:00
Noel Grandin 54d22957bc use initialiser for Sequence<OUString> 
performed using:
git grep -lP 'Sequence.*OUString.*\(1\)'
| xargs perl -0777 -pi -e
  "s/Sequence<OUString> (\w+)\(1\);
.*\[0\] = (\S+);/Sequence<OUString> \1 { \2 };/g"

Change-Id: I4da56c80fa09bfc1e8f868794001e9921431e09f
Reviewed-on: https://gerrit.libreoffice.org/19968
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-15 11:31:23 +00:00
Noel Grandin fcb8df3bcf use uno::Reference::set method instead of assignment 
Change-Id: I11822c50fa66d038a3d6f38054ab35c2e613f077
 2015-11-04 14:20:51 +02:00
Noel Grandin b5db48ada1 no need to use OUString constructor in call to createInstance 
Change-Id: Iaf3d83ba1490cb1d97a5bd4d1f7cd6943d4a7296
Reviewed-on: https://gerrit.libreoffice.org/19704
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
 2015-11-01 15:25:43 +00:00
Noel Grandin 3bc5df7f32 UNO: no need to use OUString constructor when calling createInstance 
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526
Reviewed-on: https://gerrit.libreoffice.org/19682
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-10-30 08:59:59 +00:00
Noel Grandin 63cec254e7 com::sun::star->css in io 
Change-Id: I4a0cd4b29db91584c23148d659846c71b90b0d65
 2015-10-23 12:55:52 +02:00
Andrea Gelmini 9956b99e68 Fix typos 
Change-Id: I44bdb63bef76e9686e995661a24a3bef7cd50ab7
Reviewed-on: https://gerrit.libreoffice.org/18959
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
 2015-09-30 11:03:11 +00:00
Takeshi Abe e00d41f76d io: tdf#88206 replace cppu::WeakImplHelper* etc. 
with the variadic variants.

Change-Id: Iad03db6b729a785ab8b29a69943fa45f5a36b21b
Reviewed-on: https://gerrit.libreoffice.org/17849
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2015-08-19 07:48:50 +00:00
Noel Grandin 38ecca9b30 inline a bunch of use-once macros 
no point in having a macro unless it's actually going to reduce the
number of lines of code

Change-Id: Ic8760d6506cf272d7bd088f7b3b4dcbf288099fc
 2015-07-27 08:18:16 +02:00
Noel Grandin 71b809959b remove unnecessary use of void in function declarations 
ie.
    void f(void);
becomes
    void f();

I used the following command to make the changes:

  git grep -lP '\(\s*void\s*\)' -- *.cxx \
    | xargs perl -pi -w -e 's/(\w+)\s*\(\s*void\s*\)/$1\(\)/g;'

and ran it for both .cxx and .hxx files.

Change-Id: I314a1b56e9c14d10726e32841736b0ad5eef8ddd
 2015-04-15 11:47:12 +02:00
Stephan Bergmann 2fc4a8c811 Add support for cppu::UnoType<void> 
Change-Id: I88259ffaffc73979c240721d2db166c79d3085f1
 2015-04-01 12:48:44 +02:00
Stephan Bergmann abf2ad6dae Replace remaining getCppuType et al with cppu::UnoType 
Change-Id: I736518e38a9badf9ee24564952a135bd5019d110
 2015-04-01 08:39:47 +02:00
Noel Grandin 0371a63365 remove unnecessary 'using namespace rtl' declarations 
It turns out that almost none of them were necessary.

Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83
Reviewed-on: https://gerrit.libreoffice.org/12133
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
 2014-10-29 11:28:54 +00:00
Jens Carl 8e115c6008 fdo#68849: Add header guards to all include files 
added header guards for directories basebmp/, chart2/, cppuhelper/,
include/test/, io/test/, sax/test, shell/, writerfilter/, and xmlhelp/

Change-Id: I0e29a9b75c26d71f58aa98986b52f6d3b46015a6
Reviewed-on: https://gerrit.libreoffice.org/9615
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2014-06-02 08:46:30 +00:00
Julien Nabet ac76cc7e60 Prefer cppu::UnoType<T>::get() to ::getCppuType((T*)0) part20 
Change-Id: If87cdfb2c605254f6d69baa4ca5aec09091caa68
 2014-05-23 22:11:52 +02:00
Stephan Bergmann f73af1733e second test should be DataOutputStream 
...as <https://gerrit.libreoffice.org/#/c/9007/> "cppcheck: multiCondition,
second test should be DataOutputStream" found out for an effective duplicate of
this code that got removed with the previous commit "Remove dead test code."

Change-Id: Ib7b088f065def2d5e954837d22178521f85c49fe
 2014-04-22 09:11:29 +02:00
Alexander Wilms 043e378521 Remove visual noise from io 
Change-Id: I46f8c4f793596b0e6feb2db7b9302b9b6eb9644b
Reviewed-on: https://gerrit.libreoffice.org/8273
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-26 09:25:43 -06:00
Alexander Wilms 0ce0c369aa Remove unneccessary comments 
Change-Id: I939160ae72fecbe3d4a60ce755730bd4c38497fb
Reviewed-on: https://gerrit.libreoffice.org/8182
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2014-02-23 03:38:49 +00:00
Noel Grandin 610b2b94b3 remove unnecessary use of OUString constructor when assigning 
change code like
   aStr = OUString("xxxx");
to
   aStr = "xxxx";

Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
 2013-11-19 10:29:31 +02:00
Noel Grandin 2c35fff7ec remove most use of RTL_CONSTASCII_USTRINGPARAM macro 
This is largely unnecessary when working with OUString

Change-Id: I3cf4d68357a43665d01162ef4a2d5346a45da9be
 2013-11-19 10:29:30 +02:00
Noel Grandin 0a9ef5a18e convert OUString 0==compareToAscii to equalsAscii 
Convert code like:
   0 == aStr.compareToAscii("XXX")
to
   aStr.equalsAscii("XXX")
which is both clearer and faster.

Change-Id: I2e906d7d38494db38eb292702fadb781b1251e07
 2013-11-11 12:58:12 +02:00
Noel Grandin e52779d2f8 remove unnecessary use of OUString constructor 
Change-Id: Ifb220af71857ddacd64e8204fb6d3e4aad8eef71
 2013-11-11 11:21:26 +02:00
Noel Grandin 5285beeaa4 remove redundant calls to OUString constructor in if expression 
Convert code like:
  if( aStr == OUString("xxxx") )
to this:
  if( aStr == "xxxx" )

Change-Id: I8d201f048477731eff590fb988259ef0935c080c
 2013-11-04 10:11:08 +02:00
Tor Lillqvist a7724966ab Bin comments that claim to say why some header is included 
They are practically always useless, often misleading or obsolete.

Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
 2013-10-22 16:56:28 +03:00
Thomas Arnhold f762dad2e7 fdo#46374 replace stardiv in comments where applicable 
Change-Id: Icd07fba84735325408741ad10864c63ea32a6481
 2013-10-04 15:06:23 +02:00
Thomas Arnhold ba0a57702c remove OUString wrap for string literals 
For some functions and all kinds of Exceptions.

CannotConvertException
CloseVetoException
DisposedException
EmptyUndoStackException
ErrorCodeIOException
Exception
GridInvalidDataException
GridInvalidModelException
IOException
IllegalAccessException
IllegalArgumentException
IllegalTypeException
IndexOutOfBoundsException
NoMasterException
NoSuchElementException
NoSupportException
PropertyVetoException
RuntimeException
SAXException
ScannerException
StorageWrappedTargetException
UnsupportedFlavorException
VetoException
WrappedTargetException
ZipIOException
throwGenericSQLException
throwIllegallArgumentException

createInstance
createInstanceWithContext
forName
getByName
getPackageManager
getPropertyValue
getUnpackedValueOrDefault
getValueByName
hasPropertyByName
openKey
setName
setPropertyValue
supportsService

bash command:

for i in `cat list`; do git grep "$i\s*(\s*OUString(\s*\"" -- '*.[hc]xx'
	| cut -d ':' -f1 | sort -u
	| xargs sed -i
		-e "s/\(\<$i\s*(\)\s*OUString(\s*\(\"[^\")\\]*\"\)\s*)\s*/\1\2/g"
		-e "s/\($i.*\)\"+ /\1\" + /g";
done

Change-Id: Iaf8e641b0abf28c082906014f87a183517630535
Reviewed-on: https://gerrit.libreoffice.org/4624
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-06-29 21:52:54 +00:00
Thomas Arnhold 5bb4a2ba1d further OUString cleanup 
Change-Id: I19954ee5976cb881a5fe73a889c8e04a19b14eb6
 2013-03-19 14:18:10 +01:00
Thomas Arnhold 8b27d78b4a automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings 
Done with a perl regex:

s/OUString\s*\(\s*RTL_CONSTASCII_USTRINGPARAM\s*\((\s*"[^")]*?"\s*)\)\s*\)/OUString\($1\)/gms

Change-Id: Idf28320817cdcbea6d0f7ec06a9bf51bd2c3b3ec
Reviewed-on: https://gerrit.libreoffice.org/2832
Reviewed-by: Thomas Arnhold <thomas@arnhold.org>
Tested-by: Thomas Arnhold <thomas@arnhold.org>
 2013-03-19 09:00:26 +00:00
Michael Meeks 00c9394baf re-base on ALv2 code. 2012-07-04 12:14:59 +01:00
Michael Meeks b9042fad7c re-base on ALv2 code. 
Change-Id: I6c145e984c885c7e06caa1c27bfb354ea49ad9ce
 2012-06-21 15:00:05 +01:00
Michael Meeks b6db3e3acc re-base on ALv2 code. 
Change-Id: Ice06e639213aeb6f7f23cbf4634947dd25613db1
 2012-06-21 13:11:06 +01:00
Norbert Thiebaud acb7bd175a targeted string re-work 
Change-Id: I145731d9f28faf0065f5960f2c5a32f27d8c8620
 2012-06-02 16:48:34 -05:00
Norbert Thiebaud 9601b63509 targeted string re-work 
Change-Id: Ibe5c739c3066f3e706a44b64d4ad775abde9662c
 2012-06-01 09:41:49 -05:00
Thomas Arnhold 135c63c8f9 fdo#48253 Expand SAL_STATIC_CAST and SAL_CONST_CAST 
Change-Id: I50f0887ceb4517d7ef234f970ca2ba679d533382
 2012-05-04 15:52:57 +02:00
Elton Chung 23af031b09 Fix typos in comments 2012-02-18 09:35:43 +00:00
Mariusz Dykierek b8f007d052 remove extraneous qualifiers that break some compilers 2012-02-17 15:22:46 +00:00
Takeshi Abe 0f44079ce2 catch exception by constant reference 2011-12-15 13:52:23 +09:00
Tor Lillqvist 7904a8cc56 I don't see NO_BSYMBOLIC being used anywhere 2011-12-11 02:57:59 +02:00
Norbert Thiebaud 902b94875c remove include of pch header from io 2011-11-27 13:13:17 -06:00
Matúš Kukan 15f10fc946 Remove component_getImplementationEnvironment 2011-07-12 16:30:06 +02:00
Christina Rossmanith d5124274ae __cdecl -> SAL_CALL 2011-06-05 21:34:04 +02:00