ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
478 Commits
Author SHA1 Message Date
Noel Grandin f657ab7bbb loplugin:virtualdown in various 
Change-Id: I4db71fda953ea1d20712ae8033f6fc09b3b2855d
Reviewed-on: https://gerrit.libreoffice.org/52068
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-30 12:55:56 +02:00
Julien Nabet 1e3a5bb9e9 Use for-range loops in hwpfilter, i18n*, idl* and io 
Change-Id: I980464162b73ed9ee0a09acbca1b9050af8d1027
Reviewed-on: https://gerrit.libreoffice.org/51492
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-03-18 11:33:16 +01:00
Mike Kaganski 6ab9f0cfcd SDI: don't #define/#undef names of actual classes for slot headers 
Visual Studio 2015/2017 cannot handle that correctly, and emits a lot
of intellisense errors. So, just prepend the define with "ShellClass_"

Change-Id: I473ceb7e0a88e114b92e6342fd4ae63015cafd3e
Reviewed-on: https://gerrit.libreoffice.org/51135
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
 2018-03-13 14:14:12 +01:00
Shubham Verma 0b49701fa5 tdf#114441 sal_uLong to better integer types 
Change-Id: I55b45821cf67a99f97ba067a3d4923d76c19696e
Reviewed-on: https://gerrit.libreoffice.org/50204
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2018-02-27 17:51:42 +01:00
Noel Grandin be8c414567 loplugin:unusedmethods also check for functions returning bool 
we were previously excluding them

Change-Id: I48a68799b0de60b4995fae541eb363e043d4dd11
Reviewed-on: https://gerrit.libreoffice.org/48167
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-19 13:26:27 +01:00
Noel Grandin 61bfcf16dc loplugin:useuniqueptr in idl 
Change-Id: I3681d119dda85400dbb33c96fab736c262f7ce8a
 2018-01-19 08:58:46 +02:00
Stephan Bergmann e297bbdc45 More loplugin:cstylecast: idl 
auto-rewrite with <https://gerrit.libreoffice.org/#/c/47798/> "Enable
loplugin:cstylecast for some more cases" plus
solenv/clang-format/reformat-formatted-files

Change-Id: Ic4fb1f34902fc637989a348aaea5539ddc006e38
 2018-01-12 20:22:40 +01:00
Noel Grandin 24158311c1 TypedWhichId in svx part 1 
and teach the idl compiler how to ignore the TypeWhichId<T1> part
of the define

Change-Id: I030f54080924d51e9f0ac09b19e14106648024db
Reviewed-on: https://gerrit.libreoffice.org/46849
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-21 06:09:01 +01:00
Andrea Gelmini 0d4cc84cca Fix typos 
Change-Id: Ifd95ada4477d7d21ffbadd355226f91f2a2371e1
Reviewed-on: https://gerrit.libreoffice.org/45004
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jens Carl <j.carl43@gmx.de>
 2017-11-21 06:04:52 +01:00
Noel Grandin 9ee60319c6 loplugin:constmethod in idl,helpcompiler 
Change-Id: I9b328fc0a3ebdd15a646ee6dab800ffbadb1aaef
Reviewed-on: https://gerrit.libreoffice.org/44050
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-30 13:06:54 +01:00
Andrea Gelmini e07606fdd0 Fix typos 
Change-Id: Ia30f466d08a9366b527225bbc0965f85881c7431
Reviewed-on: https://gerrit.libreoffice.org/43714
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2017-10-23 15:17:01 +02:00
Noel Grandin 3dcf6dfcee remove unnecessary use of 'this->' 
Change-Id: I5c115389af7d24c18ddaf5fbec8c00f35017a5b4
Reviewed-on: https://gerrit.libreoffice.org/40671
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-02 13:45:36 +02:00
Noel Grandin b09deb0753 loplugin:constparams handle constructors 
had to change the structure of the plugin considerably, was too messy to
structure it to do the calculations on a per-function basis

Change-Id: I4edee7735f726101105c607368124a08dba21086
Reviewed-on: https://gerrit.libreoffice.org/40516
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-28 14:51:56 +02:00
Noel Grandin f2964b9cdb convert SfxGroupId to scoped enum 
in the process I had to teach the idl compiler to cope with identifiers
like SfxGroupID::Math, which has the side effect of requiring a space
before a ':' in some of the .sdi files.

Change-Id: If256599cb8aa1dfc0a33642c5070c5560702f3ba
Reviewed-on: https://gerrit.libreoffice.org/40441
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-26 11:42:49 +02:00
Noel Grandin 41dc56df37 loplugin:constparams codemaker,idl,idlc 
Change-Id: Ic72b7525cfbfbd3c5afb12fe9ea814176e6c8c9d
Reviewed-on: https://gerrit.libreoffice.org/40126
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-18 13:27:45 +02:00
Noel Grandin 8c77b5670e use OString::operator== in preference to ::equals 
Change-Id: Ib291521963a791a9c6175964571e9d9895072acf
Reviewed-on: https://gerrit.libreoffice.org/39646
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-06 20:23:09 +02:00
Johnny_M c6f4fd1942 tdf#39468 Translate German comments and dbg strings (leftovers in h.. to i..) 
Translates all (leftovers) found using a custom regex, in directories not shown by
/bin/find-german-comments and beginning with "h" to "i".

Additionally:
- Fixed a few spellings

Change-Id: I54ea06f8e0cf1bd4bd6c84b171bec1bd342a8df8
Reviewed-on: https://gerrit.libreoffice.org/38390
Reviewed-by: Michael Stahl <mstahl@redhat.com>
Tested-by: Michael Stahl <mstahl@redhat.com>
 2017-06-06 13:51:55 +02:00
Johnny_M 7f79316671 tdf#39674 Translate some German variable/function names 
No functional change is intended.

Change-Id: Ib693d5f15bb279e8fe6771e3a64a976b53c6d13d
Reviewed-on: https://gerrit.libreoffice.org/38391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Eike Rathke <erack@redhat.com>
 2017-06-06 13:48:24 +02:00
Noel Grandin de8caac6be replace SVSTREAM_OK with ERRCODE_NONE 
since the first is #define'd to the second, and offers no extra value

Change-Id: I2c67e09ea3aa5361b8e7dfe7a20858c6ae054450
Reviewed-on: https://gerrit.libreoffice.org/38406
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-06 08:15:57 +02:00
Noel Grandin ef513fd4b0 remove unnecessary use of OString::getStr 
Change-Id: I0490efedf459190521f4339854b3394d57765fdb
Reviewed-on: https://gerrit.libreoffice.org/38058
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-28 19:44:08 +02:00
Caolán McNamara fd24dd469d coverity#1403731 Explicit null dereferenced 
Change-Id: Ia8d183fbf1c80964eabc10f1e363333133a4181c
 2017-05-12 09:28:12 +01:00
Jochen Nitschke 959496794c cleanup osl/diagnose.h includes 
with command
> git grep -l osl/diagnose.h *.cxx |
  xargs grep -L -w 'OSL_\w*' |
  xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d'

headers need more work

Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab
Reviewed-on: https://gerrit.libreoffice.org/37350
Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-05-09 15:41:46 +02:00
Jochen Nitschke b3eb843766 cleanup tools/debug.hxx includes 
with command
> git grep -l tools/debug.hxx |
  xargs grep -L DBG_ |
  xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d'

don't change files in includes/ and */pch

Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08
Reviewed-on: https://gerrit.libreoffice.org/37349
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-08 08:33:01 +02:00
Noel Grandin a12dfa3531 create SfxGroupId based on o3tl::strong_int 
Change-Id: Iaccf16f29b6f4b1a2c712d1e5e2bd0fa4fdb5e71
Reviewed-on: https://gerrit.libreoffice.org/37108
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-02 08:18:14 +02:00
Maxim Monastirsky c2f7c567b7 svidl: Adapt to SlotType removal 
No diff in workdir/SdiTarget.

BEWARE: If you're going to revert this for whatever
reason, you should also revert the previous commit
that removed the SlotType property from sdi files!

Change-Id: I78cc391a6b47f4672157926eba1b55e786f48f2d
 2017-05-01 01:30:44 +03:00
Maxim Monastirsky 20f33eb7c5 svidl: Remove nested method support 
No diff in workdir/SdiTarget.

Change-Id: I53e974c8ccafbbc3675f67b87a0e1b8ff19b6790
 2017-05-01 01:28:02 +03:00
Noel Grandin 3a36cf434f loplugin:checkunusedparams in configmgr and vcl 
Change-Id: I7226d01f38e6edaf3868d7267d9b02dbdbc9e5ba
Reviewed-on: https://gerrit.libreoffice.org/36975
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-28 08:32:56 +02:00
Chris Sherlock da64d198ec tools: svstream.hxx needs only errcode.hxx & not errinf.hxx 
Change-Id: Ia28e35ae5af4f601e9a586a3deffbcd61702b0ca
Reviewed-on: https://gerrit.libreoffice.org/36896
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
 2017-04-25 09:31:31 +02:00
Caolán McNamara aa434253d2 coverity#1403731 Explicit null dereferenced 
Change-Id: I6025e6d4307aa8a6e4b6338d62bc597dace0ac9e
 2017-04-03 10:18:44 +01:00
Caolán McNamara da1d5307c3 use weak attribute for Linux too 
Change-Id: If6bad5be57c984930061629077b07eee287202f0
 2017-04-01 14:54:22 +01:00
Jens Carl ad3681df0a tdf#39468 Translate German comments 
Translate German comments and terms in dbaccess/, forms/, fpicker/, framework/,
and idl/

Change-Id: I08b3db9492f16fc1c457e8f5eff838c13561c945
Reviewed-on: https://gerrit.libreoffice.org/35888
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Michael Stahl <mstahl@redhat.com>
 2017-03-30 10:27:35 +00:00
Noel Grandin 7097037d5a remove enum slot code from sfx2 
since we only used it for the pseudo-slot stuff, which is now gone

Change-Id: I72146090e7741d5b71d581fa0b5c6d43c154445a
Reviewed-on: https://gerrit.libreoffice.org/35759
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-28 08:25:18 +00:00
Noel Grandin 71403558cb remove PseudoSlot support from idl compiler 
Since we have removed the last usage with
commit 12c6caa84a
"Kill remaining PseudoSlots usage"

And remove corresponding support from the list-dispatch-commands script.

Also remove the now unused SFX_NEW_SLOT_ENUM macro

Change-Id: Id07c431de4404acf61a8bdd3507e390e5249879a
Reviewed-on: https://gerrit.libreoffice.org/35754
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-28 08:24:51 +00:00
Noel Grandin 2fc5ef74c5 remove unhandled SID commands from sfx2 
Change-Id: I5473dbb1fdc2c3779892610ab4ea5f6146291921
Reviewed-on: https://gerrit.libreoffice.org/35742
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-28 06:41:25 +00:00
Stephan Bergmann 6291574d94 Remove unused #include <ctype.h> 
Change-Id: I8bf3e30687e20151a9e1936e69362abfe9b3a99d
 2017-03-23 17:55:31 +01:00
Stephan Bergmann 254c13265f Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char) 
Change-Id: I94b4cd3860b1b8740965373ee0b254a0415c8b4c
 2017-03-23 07:35:01 +01:00
Stephan Bergmann 0ab2f39e45 Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char) 
Change-Id: Ie37f15379b0e10912ef2e0ac94249da11040eede
 2017-03-23 07:32:58 +01:00
Stephan Bergmann 0a92c29e47 This code trades in 'char' entities disguised as 'int' 
(with EOF represented as 0), so better actually use 'char'.

Change-Id: Id9c684c833b0d46f8a51a34aa2c4b78a75e2d3a5
 2017-03-23 07:29:17 +01:00
Stephan Bergmann a2201cba9f Use rtl::isAscii* instead of ctype.h is* (and fix passing plain char) 
Change-Id: Ic0e1c7f4e0899fd976a00b5ea8ba8b130657bac9
 2017-03-23 07:20:44 +01:00
Noel Grandin e9c7d259e8 create SfxDisableFlags enum 
Change-Id: Ib59c7886017247977b916a8e140853fb8310582f
Reviewed-on: https://gerrit.libreoffice.org/35514
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-22 06:46:10 +00:00
Noel Grandin 4978328534 convert method names in tools::SvRef to be more like our other.. 
reference classes, uno::Reference and rtl::Reference.

Specifically rename Is()->is() and Clear()->clear().

Change-Id: Icb7e05e2d09cb9977121508b837ba0961dabb4ae
Reviewed-on: https://gerrit.libreoffice.org/33576
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-02 08:02:54 +00:00
Noel Grandin 7a60e90ef0 new loplugin: useuniqueptr: helpcompiler..io 
Change-Id: I6b394163c144e6b5540cb160abb613d56fe327de
Reviewed-on: https://gerrit.libreoffice.org/33165
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-01-17 08:34:42 +00:00
Stephan Bergmann 9c5494bfd7 New loplugin:externvar: idl 
Change-Id: I67d0c0f7c7aa6d4a81e46ef6afca2d7a762eb813
 2017-01-09 15:43:11 +01:00
Noel Grandin f9a97a5d5a drop custom hashtable implementation in idl 
Change-Id: I2cdb79022e77cdcc03962d392d0d87626a090ac5
Reviewed-on: https://gerrit.libreoffice.org/32043
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-12-19 06:05:47 +00:00
Noel Grandin 1a743fd8a2 loplugin:expandablemethods in hwpfilter..linguistic 
Change-Id: I62ae20ab4a47b3b7e2b0d503cedcad3319cc9c85
Reviewed-on: https://gerrit.libreoffice.org/30683
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-11-08 08:41:38 +00:00
Noel Grandin 88ec5de1c9 expand SvMetaType::ReadNamesSvIdl 
it just forwards to ReadNameSvIdl

Change-Id: I803edb7a5977cf309e2cedaa3b4764bcbd933597
 2016-10-26 11:56:21 +02:00
Noel Grandin 877774c057 loplugin:expandablemethodds in hwpfilter..linguistic 
Change-Id: If20fd4a6cf8a8e005804dbb7caf41cce73d587a5
Reviewed-on: https://gerrit.libreoffice.org/30016
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-19 08:07:18 +00:00
Noel Grandin 62223f9a8a loplugin:unnecessaryoverride 
Change-Id: I08c55a3023ec2e8990098eeb60e91cd18556e7ae
Reviewed-on: https://gerrit.libreoffice.org/29656
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2016-10-13 06:47:44 +00:00
Stephan Bergmann 802f2a4208 Don't allow O[U]StringBuffer in string concatenation 
...as

  OStringBuffer b("foo"); b = "bar" + b;

doesn't work as one might expect (see the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2016-October/075464.html>
"concat of OUStringBuffer".  That feature was LIBO_INTERNAL_ONLY, anyway.  And
of the affected places, MethodDescriptor::getSignature
(codemaker/source/javamaker/javatype.cxx) was the only one that would actually
have benefitted.

Change-Id: Ib84266f43e40c42c2e428f0c0616db8cfa90adff
 2016-10-12 16:05:32 +02:00
Jacek Fraczek f004aa9951 tdf#89307: Removed SvRef::operator T*() 
Conditional statements are using SvRef::Is() method.
Changed static_cast<T*>(svRef<T>) occurances to svRef.get().
Added operator == and != to SvRef.

SbxObject::Execute is using SbxVariableRef internally.
SbxObject::FindQualified is using SbxVariableRef internally.

Change-Id: I45b553e35d8fca9bf71163e6eefc60802a066395
Reviewed-on: https://gerrit.libreoffice.org/29621
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2016-10-10 08:48:30 +00:00