ODFstudio/odfstudio
2
0
Fork 0
Code Issues Packages Activity
421,396 Commits 3 Branches 3 Tags
940f90f3da170b62379e9d1d33d4e6d690997026
Commit Graph
429 Commits
Author SHA1 Message Date
Noel Grandin 70d2fd4823 loplugin:useuniqueptr in ImplImageList 
and fix leak in RemoveImage in the process

Change-Id: I20e395178f92f7127e99011aebbe97246f255d1d
Reviewed-on: https://gerrit.libreoffice.org/51550
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-20 07:45:28 +01:00
Jochen Nitschke b2147abdf6 remove unused ucbstreamhelper includes 
and a few vclunohelper includes

Change-Id: I4803605766d155fe5044c2a65c0444631146831c
Reviewed-on: https://gerrit.libreoffice.org/51496
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-03-19 07:38:49 +01:00
Julien Nabet 823ef9ef32 Use for-range loops in framework 
Change-Id: I72ea832848fd7c76863bcee70a3303de488c0b0f
Reviewed-on: https://gerrit.libreoffice.org/51471
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-03-17 23:08:48 +01:00
Noel Grandin 1a4fcb7fea simplify ImageList::GetAsHorizontalStrip 
no need to repeat logic the BitmapEx constructor already implements

Change-Id: Ic958b3a3baafe9911b8461e1fc512e36616db89c
Reviewed-on: https://gerrit.libreoffice.org/51401
Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
 2018-03-16 15:15:15 +01:00
Noel Grandin bf8a6cacd0 loplugin:changetoolsgen in filter..framework 
Change-Id: I622da8a0c096c74efd97326451c4576b230f0483
Reviewed-on: https://gerrit.libreoffice.org/49701
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-02-14 11:38:00 +01:00
Julien Nabet 1e47afd9b8 Unused include pngread/write (framework) 
Change-Id: I14358ba06a4a7eb7ad01b0e7cc73455daec917a2
Reviewed-on: https://gerrit.libreoffice.org/49293
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
 2018-02-06 18:58:10 +01:00
Noel Grandin cfb598178b loplugin:useuniqueptr in ImageListsDescriptor 
Change-Id: I165af348b6d8863a4b1e5dd164d92c29f49d09c0
Reviewed-on: https://gerrit.libreoffice.org/48423
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-24 07:58:23 +01:00
Noel Grandin be8c414567 loplugin:unusedmethods also check for functions returning bool 
we were previously excluding them

Change-Id: I48a68799b0de60b4995fae541eb363e043d4dd11
Reviewed-on: https://gerrit.libreoffice.org/48167
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-19 13:26:27 +01:00
Stephan Bergmann e1c753da32 More loplugin:cstylecast: framework 
Change-Id: Iffd183cb21b43aaa66dd55cc6c453ebeae36a3e1
 2018-01-15 09:05:14 +01:00
Noel Grandin 5328bf4021 drop CmdToXGraphicNameAccess typedef 
Change-Id: I76dc73c5a6c62b0ec0fff274ae57f084ccdb8c70
Reviewed-on: https://gerrit.libreoffice.org/47347
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2018-01-04 07:25:41 +01:00
Noel Grandin 3af500580b loplugin:salcall fix functions 
since cdecl is the default calling convention on Windows for
such functions, the annotation is redundant.

Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d
Reviewed-on: https://gerrit.libreoffice.org/46164
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-12-11 12:13:46 +01:00
Stephan Bergmann 19f9a7e298 Remove unused #include <vcl/metaact.hxx> from vcl/outdev.hxx 
...and fix the fallout

Change-Id: Ie514bd95d5a9f990a887566619031e9844c40b92
Reviewed-on: https://gerrit.libreoffice.org/45195
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
 2017-12-06 20:25:51 +01:00
Stephan Bergmann 2a4727f2d8 loplugin:unnecessaryparen 
Change-Id: Ie87cb60e2340a0bc21163b0b6c02ed0d2c6c3765
 2017-12-03 19:33:51 +01:00
Noel Grandin 4f4486c61d look for =() in loplugin:unnecessaryparen 
Change-Id: I4f9b71ff7767e90987bb40358fc46ed5d1d571d0
Reviewed-on: https://gerrit.libreoffice.org/44944
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-11-20 12:31:32 +01:00
Stephan Bergmann 084f454e8c More loplugin:unnecessaryparen 
81892b2037 "loplugin:unnecessaryparen when
compiling as C++17, so the ParenExpr is no longer hidden behind
ExprWithCleanups/CXXConstructExpr/MaterializedTemporaryExpr wrappers" gave me
the idea to generally look though IgnoreImplicit instead of IngoreImpCasts in
loplugin:unnecessaryparen.  However, that would still not look through implicit
CXXConstructExpr, so would still not have found the occurrences in
81892b2037 when compiling in pre-C++17 mode.
Therefore, let ignoreAllImplicit also look through CXXConstructExpr.  (I am not
entirely sure in which situations non-implicit CXXConstructExpr---that should
thus not be ignored---would occur, but assume they would be underneath something
like a CXXFunctionalCastExpr, which is not ignored.)

Change-Id: I947d08742e1809150ecc34a7abe84cca5e0ce843
 2017-10-26 10:27:48 +02:00
Stephan Bergmann a457c7c6b0 loplugin:includeform: framework 
Change-Id: Ib5eaab06ff0cc1b44db9e4057ab349a0990af14d
 2017-10-23 22:46:07 +02:00
Noel Grandin 87a9979c89 overload std::hash for OUString and OString 
no need to explicitly specify it anymore

Change-Id: I6ad9259cce77201fdd75152533f5151aae83e9ec
Reviewed-on: https://gerrit.libreoffice.org/43567
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-10-23 08:15:35 +02:00
Noel Grandin 1ffba0e356 loplugin:flatten check for throw in then clause 
also make the plugin ignore the case where we have var decl's in the
clause we want to flatten, which could lead to problematic extension of
variable lifetime

Change-Id: I3061f7104e8c6a460bf74f5eac325a516ec50c59
Reviewed-on: https://gerrit.libreoffice.org/42889
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-29 08:51:48 +02:00
Noel Grandin cc1ed7fbce loplugin:flatten in various 
Change-Id: I42dca691ffadbddad38a7e8f978b1da9d5d9a7b0
Reviewed-on: https://gerrit.libreoffice.org/42842
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-27 11:02:56 +02:00
Noel Grandin 4af6c0948b loplugin:flatten in filter..i18npool 
Change-Id: I9024b8b614a4de83a4d927e1918f6d4904a7fccb
Reviewed-on: https://gerrit.libreoffice.org/42592
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-09-22 08:29:29 +02:00
Noel Grandin b92068bbe2 unused m_aModuleIdentifier in UIConfigurationManager 
Change-Id: Idd4ced156201e81ee818d4b6b69e6c4d254f3387
 2017-09-20 08:42:30 +02:00
Stephan Bergmann cb25507503 Drop lazywrite property, which is silently ignored by configmgr anyway 
...at least ever since the "new" configmgr reimplementation,
6b849a6aee "#i101955# initial work in progress of
a configmgr reimplementation (for now in an extra module 'configmgr2')" et al

Change-Id: I43430d991647fb2e26762463d51175247db0604b
 2017-09-05 17:57:18 +02:00
Noel Grandin f9acc8649d loplugin:useuniqueptr in framework 
Change-Id: I89bcfaa605251912bd1f979b38f12e983dcaf76e
Reviewed-on: https://gerrit.libreoffice.org/41512
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-24 14:33:45 +02:00
Muhammet Kara 3976f115ef Add some exception messages to the removeSettings method 
in UIConfigurationManager and ModuleUIConfigurationManager

Change-Id: I82c5369dc43dc8ccd9be62acaf327a39f3b4d68f
Reviewed-on: https://gerrit.libreoffice.org/41403
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-22 13:14:33 +02:00
Noel Grandin eea6d3951b loplugin:unnecessaryparen 
look for  statements like

    return (function());

Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3
Reviewed-on: https://gerrit.libreoffice.org/41260
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-18 08:49:37 +02:00
Noel Grandin d347c24036 convert std::map::insert to std::map::emplace 
which is considerably less verbose

Change-Id: Ifa373e8eb09e39bd6c8d3578641610a6055a187b
Reviewed-on: https://gerrit.libreoffice.org/40978
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-08-11 12:38:32 +02:00
Caolán McNamara b1d829e52e move resmgr to unotools 
and the vast majority of translations is to the ui language so default
ctor with that arg

and now drop OModuleResourceClient

Change-Id: I3b85a560ffdfe5f019c2271ac56a5fe4a361522b
 2017-08-01 13:42:21 +01:00
Noel Grandin 18f80da7a6 loplugin:checkunusedparams more part2 
Change-Id: Ibb940c2a7098313dfa282734894b1abc1ac40bc2
Reviewed-on: https://gerrit.libreoffice.org/40489
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-28 07:18:23 +02:00
Noel Grandin f74da1315a use more comphelper::InitAnyPropertySequence 
Found with:
  git grep -n -A10 'Sequence.*Any' -- *.cxx | grep -B5 -w PropertyValueProvider
and:
  git grep -n 'Sequence.*Any.*( *&'

Change-Id: Icb18c98bdd3f8352817e443ff78de5df042859ad
Reviewed-on: https://gerrit.libreoffice.org/40389
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-25 12:03:17 +02:00
Noel Grandin 039d9b97b7 loplugin:constparams in framework 
Change-Id: Iecd19a0cbb3cc78158c17bfa064cc23bafc44b18
Reviewed-on: https://gerrit.libreoffice.org/40206
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-20 09:19:54 +02:00
Noel Grandin 3697b87b70 use more OUString::operator== in forms..sal 
Change-Id: I70d7e50f8c1e019524ccad915f0cca912c5035dc
Reviewed-on: https://gerrit.libreoffice.org/39899
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-13 15:20:58 +02:00
Noel Grandin 2b24fba09c loplugin:unusedfields in framework 
Change-Id: Ibb602e037bcee518c31dfe9734a5c5773cff23ab
Reviewed-on: https://gerrit.libreoffice.org/39492
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-07-04 10:51:46 +02:00
Jochen Nitschke a5dba7dbec remove unused osl/mutex.hxx includes 
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb
Reviewed-on: https://gerrit.libreoffice.org/38905
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-06-18 13:38:25 +02:00
Jochen Nitschke febbad7263 cleanup unused css/frame/* includes 
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65
Reviewed-on: https://gerrit.libreoffice.org/38633
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-12 13:05:38 +02:00
Jochen Nitschke 442211903b framework: cleanup xserviceinfo.hxx includes 
Change-Id: Ie5addc277fd47663726199dd7b94fb7299aa4d9c
Reviewed-on: https://gerrit.libreoffice.org/38539
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-06-08 01:10:32 +02:00
Jochen Nitschke f95cb2841a framework: cleanup xinterface.hxx includes 
Change-Id: I66b27e623e411c9ba9c5ba17c46c052336d031b8
Reviewed-on: https://gerrit.libreoffice.org/38503
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
 2017-06-08 01:10:13 +02:00
Jochen Nitschke a83740ebcf framework: cleanup xtypeprovider.hxx includes 
LayoutManager uses macro impl from comphelper, so use declarations
from comphelper too.

Change-Id: I638492849742782d48c3bb5439c2255e72f9f694
Reviewed-on: https://gerrit.libreoffice.org/38496
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-06-07 14:00:27 +02:00
Noel Grandin 2ccde70d60 teach redundantcast plugin about functional casts 
Change-Id: Iac8ccd17d9e46ebb2cb55db7adb06c469bbd4ea0
Reviewed-on: https://gerrit.libreoffice.org/37910
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-30 08:50:31 +02:00
Jochen Nitschke 0d1a3593c2 cleanup unused css/uri/ includes 
Change-Id: I08c7981ecce45e343ff9e98277dd3aea4ed68ab9
Reviewed-on: https://gerrit.libreoffice.org/37860
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-20 18:00:23 +02:00
Noel Grandin 389da66dfc remove unused uno::Reference vars 
found by temporarily marking Reference as SAL_WARN_UNUSED.

Change-Id: I18809b62654467f890016adcc92576980ced393b
Reviewed-on: https://gerrit.libreoffice.org/37511
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-12 09:56:01 +02:00
Jochen Nitschke b3eb843766 cleanup tools/debug.hxx includes 
with command
> git grep -l tools/debug.hxx |
  xargs grep -L DBG_ |
  xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d'

don't change files in includes/ and */pch

Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08
Reviewed-on: https://gerrit.libreoffice.org/37349
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-05-08 08:33:01 +02:00
Noel Grandin 1c5cae479b loplugin:unusedmethods 
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672
Reviewed-on: https://gerrit.libreoffice.org/36718
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-04-20 10:07:10 +02:00
Caolán McNamara 2b83e73fd7 remove freshly unused menu support from src files 
Change-Id: I038711a0c4d440d452d5b2ae1bfcba5c9305815b
Reviewed-on: https://gerrit.libreoffice.org/36646
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
 2017-04-19 13:42:07 +02:00
Julien Nabet 4c16651356 Replace OSL_FAIL by SAL_WARN_IF 
+ simplify message and code to create it

Change-Id: I40cc0c1bf62a974ad5a5c5f27c4ed78c822390fa
Reviewed-on: https://gerrit.libreoffice.org/35984
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
 2017-04-01 08:06:58 +00:00
Miklos Vajna a5a571307f tdf#82580 tools: rename Rectangle to tools::Rectangle 
Mostly generated using

make check COMPILER_EXTERNAL_TOOL=1 CCACHE_PREFIX=clang-rename-wrapper RENAME_ARGS="-qualified-name=Rectangle -new-name=tools::Rectangle"

Except some modules have their own foo::tools namespace, so there have
to use ::tools::Rectangle. This commit just moves the class from the
global namespace, it does not update pre/postwin.h yet.

Change-Id: I42b2de3c6f769fcf28cfe086f98eb31e42a305f2
Reviewed-on: https://gerrit.libreoffice.org/35923
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins <ci@libreoffice.org>
 2017-03-31 06:27:11 +00:00
Noel Grandin 9bfd742d8c loplugin:unusedmethods 
Change-Id: Ib008613fb06c82791c63d5b074a3e2ff1c3607a0
Reviewed-on: https://gerrit.libreoffice.org/35834
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-03-29 11:43:40 +00:00
Noel Grandin 198c41c4fe new loplugin unoany 
Change-Id: I5d6c4a67cb2a09e7cd5bd620c6b262d188701b89
Reviewed-on: https://gerrit.libreoffice.org/34714
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
 2017-02-28 10:17:47 +00:00
Stephan Bergmann f058cedb5f loplugin:loopvartoosmall 
Change-Id: I05874c22883a98f09c9231c0e0ff0dff93e2d643
 2017-02-27 12:55:25 +01:00
Maxim Monastirsky 7e559e5495 Revert "Resolves: #i120029# Unregister on dispose." 
This reverts commit 11f8e53d6c.

At the time this commit was imported from AOO, we had the
original problem fixed already with
dd8fa7c25a ("fix more lifecycle
problems").

Change-Id: Id8288d30c1cb908b68e5b9ef0279237412aae357
 2017-02-21 01:39:53 +02:00
Noel Grandin d5c3e8004b drop enum framework::GlobalSettings::UIElementType 
since we only ever use the one enumerator.
Consequently renaming some methods

Change-Id: Ia8c022135df6661b8f300e037ea3e7cf610b63ac
 2017-02-16 12:42:04 +02:00